Re: [llvm-commits] CVS: llvm/lib/Transforms/Scalar/IndVarSimplify.cpp

2007-07-03 Thread Zhou Sheng
Hi Chris, > The condition "IterationCount->getType() != LargestType" doesn't > mean the IterationCount->getType's bitwidth < LargestType's > so, sometimes, (like in this testcase), it need a trunc not ext. > This patch is to fix it. Ah, I see. Thank you for checking in the testcase. The re

Re: [llvm-commits] CVS: llvm/lib/Transforms/Scalar/IndVarSimplify.cpp

2007-07-03 Thread Chris Lattner
On Jun 27, 2007, at 7:00 PM, Sheng Zhou wrote: > Chris, > > Attached is the testcase, which will get: > > opt: /developer/home2/zsth/llvm-gcc-dev/HEAD/llvm/llvm/lib/VMCore/ > Constants.cpp:1559: static llvm::Constant* > llvm::ConstantExpr::getZExt(llvm::Constant*, const llvm::Type*): > Asse

Re: [llvm-commits] CVS: llvm/lib/Transforms/Scalar/IndVarSimplify.cpp

2007-06-29 Thread Tanya Lattner
Should this be added as a regression test? -Tanya On Jun 27, 2007, at 7:00 PM, Sheng Zhou wrote: > Chris, > > Attached is the testcase, which will get: > > opt: /developer/home2/zsth/llvm-gcc-dev/HEAD/llvm/llvm/lib/VMCore/ > Constants.cpp:1559: static llvm::Constant* > llvm::ConstantExpr::get

Re: [llvm-commits] CVS: llvm/lib/Transforms/Scalar/IndVarSimplify.cpp

2007-06-27 Thread Sheng Zhou
Chris, Attached is the testcase, which will get: opt: /developer/home2/zsth/llvm-gcc-dev/HEAD/llvm/llvm/lib/VMCore/Constants.cpp:1559: static llvm::Constant* llvm::ConstantExpr::getZExt(llvm::Constant*, const llvm::Type*): Assertion `C->getType()->getPrimitiveSizeInBits() < Ty->getPrimitiveS

Re: [llvm-commits] CVS: llvm/lib/Transforms/Scalar/IndVarSimplify.cpp

2007-06-27 Thread Chris Lattner
On Jun 27, 2007, at 2:50 AM, Zhou Sheng wrote: > Fix a bug. Testcase plz! What does this do, it seems wrong. -Chris > --- > Diffs of the changes: (+4 -1) > > IndVarSimplify.cpp |5 - > 1 files changed, 4 insertions(+), 1 deletion(-) > > > Index: llvm/lib/Transforms/Scalar/IndVarSimpli

Re: [llvm-commits] CVS: llvm/lib/Transforms/Scalar/IndVarSimplify.cpp LoopStrengthReduce.cpp

2007-06-15 Thread Chris Lattner
On Jun 15, 2007, at 7:38 AM, Dan Gohman wrote: > > > Changes in directory llvm/lib/Transforms/Scalar: > > IndVarSimplify.cpp updated: 1.120 -> 1.121 > LoopStrengthReduce.cpp updated: 1.140 -> 1.141 > --- > Log message: > > Add a SCEV class and supporting code for sign-extend expressions. > > This