Re: [llvm-commits] RFC: patch for PR1782 (BasicAliasAnalyis)

2007-12-13 Thread Chris Lattner
>>> I guess, such a large positive index in GEP as seen above can be >>> introduced by -instcombine pass. >> >> Ok. This is somewhat dubious though, as it is wrapping around the >> end >> of the address space which is undefined in C. > > I've found one place in instcombine, where something like

Re: [llvm-commits] RFC: patch for PR1782 (BasicAliasAnalyis)

2007-12-13 Thread Wojciech Matyjewicz
Chris Lattner wrote: >> Suppose, we have a target with 32-bit pointers and the following >> instructions: >> >> %p = getelementptr i32* %x, i32 -1 >> %q = getelementptr i32* %x, i32 1073741823 ;(1073741823 == 2^30 - 1) >> >> TargetData::getIndexedOffset() uses 64-bit arithmetic to perform >> off

Re: [llvm-commits] RFC: patch for PR1782 (BasicAliasAnalyis)

2007-12-11 Thread Chris Lattner
On Dec 9, 2007, at 2:57 PM, Wojciech Matyjewicz wrote: > Chris Lattner wrote: > >> Yep, it looks Gordon was right :). Thanks again Wojtek, I applied >> the >> patch. Please close the PR, > > Before I close the PR, I would like to discuss one more issue > discovered > while working on it. >

Re: [llvm-commits] RFC: patch for PR1782 (BasicAliasAnalyis)

2007-12-09 Thread Wojciech Matyjewicz
Chris Lattner wrote: > Yep, it looks Gordon was right :). Thanks again Wojtek, I applied the > patch. Please close the PR, Before I close the PR, I would like to discuss one more issue discovered while working on it. Suppose, we have a target with 32-bit pointers and the following instructio

Re: [llvm-commits] RFC: patch for PR1782 (BasicAliasAnalyis)

2007-12-08 Thread Chris Lattner
On Dec 8, 2007, at 5:52 PM, Wojciech Matyjewicz wrote: > Gordon Henriksen wrote: > >> Wojtek, you might try /(a.)/ using ".patch" in the hopes of eliciting >> Content-Type: application/octet-stream which will always appear as an >> attachment, /(b.)/ compressing the attachment, or /(c.)/ looking

Re: [llvm-commits] RFC: patch for PR1782 (BasicAliasAnalyis)

2007-12-08 Thread Wojciech Matyjewicz
Gordon Henriksen wrote: > Wojtek, you might try /(a.)/ using ".patch" in the hopes of eliciting > Content-Type: application/octet-stream which will always appear as an > attachment, /(b.)/ compressing the attachment, or /(c.)/ looking for a > setting in Thunderbird to use Content-Disposition: atta

Re: [llvm-commits] RFC: patch for PR1782 (BasicAliasAnalyis)

2007-12-08 Thread Gordon Henriksen
On 2007-12-08, at 19:58, Wojciech Matyjewicz wrote: Chris Lattner wrote: Unfortunately though, the patch does not apply. Can you please attach it instead of including it inline in the email? Chris, could you check my previous post one more time, please. The patch should be attached to

Re: [llvm-commits] RFC: patch for PR1782 (BasicAliasAnalyis)

2007-12-08 Thread Wojciech Matyjewicz
Chris Lattner wrote: > > Unfortunately though, the patch > does not apply. Can you please attach it instead of including it > inline in the email? Chris, could you check my previous post one more time, please. The patch should be attached to it. At least, I have received this post with an at

Re: [llvm-commits] RFC: patch for PR1782 (BasicAliasAnalyis)

2007-12-08 Thread Chris Lattner
On Dec 8, 2007, at 2:35 PM, Wojciech Matyjewicz wrote: > Hi, > > It seems that this problem is caused by a copy-paste bug in > BasicAliasAnalysis.cpp. The first part of the diff is of a cosmetic > nature. The second fixes the bug. This patch looks excellent, thanks! Unfortunately though, the pa

[llvm-commits] RFC: patch for PR1782 (BasicAliasAnalyis)

2007-12-08 Thread Wojciech Matyjewicz
Hi, It seems that this problem is caused by a copy-paste bug in BasicAliasAnalysis.cpp. The first part of the diff is of a cosmetic nature. The second fixes the bug. -Wojtek Index: lib/Analysis/BasicAliasAnalysis.cpp === --- lib/Anal