Re: [llvm-commits] PCH fix

2007-05-17 Thread Devang Patel
On May 17, 2007, at 11:08 AM, Tanya M. Lattner wrote: > >> This patch is good. I installed this patch in mainline sources. I >> agree, this should also go in 2.0 release branch. > > Devang - Can you please apply this patch to the release-2.0 branch? Done. > Also, it would be great if we could

Re: [llvm-commits] PCH fix

2007-05-17 Thread Tanya M. Lattner
> This patch is good. I installed this patch in mainline sources. I agree, this > should also go in 2.0 release branch. Devang - Can you please apply this patch to the release-2.0 branch? Also, it would be great if we could push this to the mirror ASAP, so I can begin making new tarballs tonig

Re: [llvm-commits] PCH fix

2007-05-17 Thread Devang Patel
Anton, This patch is good. I installed this patch in mainline sources. I agree, this should also go in 2.0 release branch. Thanks Anton for taking care of this bug. - Devang On May 17, 2007, at 2:53 AM, Anton Korobeynikov wrote: > Hello, Everyone. > > Attached patch fixes PCHs for both TOT an

[llvm-commits] PCH fix

2007-05-17 Thread Anton Korobeynikov
Hello, Everyone. Attached patch fixes PCHs for both TOT and 2.0 release. There were 2 problems: 1. flush() method of oFILEstream doesn't actually flush the file. This can lead to incorrect offsets calculations in the PCH handling code and junk output. This problem seems to be highly platform-dep