Re: [llvm-commits] CVS: llvm/lib/VMCore/Globals.cpp

2007-05-05 Thread Chris Lattner
On May 5, 2007, at 11:48 PM, Duncan Sands wrote: > Hi Chris, > >> + (CE->getOpcode() == Instruction::BitCast || >> + CE->getOpcode() == Instruction::GetElementPtr)) >> +return dyn_cast(CE->getOperand(0)); > > isn't this only correct if all the GEP indices are zero? > By t

Re: [llvm-commits] CVS: llvm/lib/VMCore/Globals.cpp

2007-05-05 Thread Duncan Sands
Hi Chris, > + (CE->getOpcode() == Instruction::BitCast || > + CE->getOpcode() == Instruction::GetElementPtr)) > +return dyn_cast(CE->getOperand(0)); isn't this only correct if all the GEP indices are zero? By the way, ExtractGlobalVariable in SelectionDAGISel does the

[llvm-commits] CVS: llvm/lib/VMCore/Globals.cpp

2007-05-05 Thread Chris Lattner
Changes in directory llvm/lib/VMCore: Globals.cpp updated: 1.24 -> 1.25 --- Log message: handle gep aliasee --- Diffs of the changes: (+4 -3) Globals.cpp |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) Index: llvm/lib/VMCore/Globals.cpp diff -u llvm/lib/VMCore/Globals.cp

[llvm-commits] CVS: llvm/lib/VMCore/Globals.cpp

2007-05-03 Thread Jeff Cohen
Changes in directory llvm/lib/VMCore: Globals.cpp updated: 1.23 -> 1.24 --- Log message: Unbreak VC++ build. --- Diffs of the changes: (+2 -2) Globals.cpp |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Index: llvm/lib/VMCore/Globals.cpp diff -u llvm/lib/VMCore/Globals.cpp:1

[llvm-commits] CVS: llvm/lib/VMCore/Globals.cpp

2007-04-30 Thread Anton Korobeynikov
Changes in directory llvm/lib/VMCore: Globals.cpp updated: 1.22 -> 1.23 --- Log message: Fix typo. Interesting, but old variant worked too :) --- Diffs of the changes: (+1 -1) Globals.cpp |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) Index: llvm/lib/VMCore/Globals.cpp diff -u

[llvm-commits] CVS: llvm/lib/VMCore/Globals.cpp

2007-02-25 Thread Chris Lattner
Changes in directory llvm/lib/VMCore: Globals.cpp updated: 1.17 -> 1.18 --- Log message: reapply my previous patch with a bugfix. --- Diffs of the changes: (+31 -21) Globals.cpp | 52 +++- 1 files changed, 31 insertions(+), 21 deletions(-)

[llvm-commits] CVS: llvm/lib/VMCore/Globals.cpp

2007-02-25 Thread Chris Lattner
Changes in directory llvm/lib/VMCore: Globals.cpp updated: 1.16 -> 1.17 --- Log message: revert my previous change, something strange is happening. --- Diffs of the changes: (+21 -29) Globals.cpp | 50 +- 1 files changed, 21 insertions(+),

[llvm-commits] CVS: llvm/lib/VMCore/Globals.cpp

2007-02-25 Thread Chris Lattner
Changes in directory llvm/lib/VMCore: Globals.cpp updated: 1.15 -> 1.16 --- Log message: Rework GlobalValue::removeDeadConstantUsers to always remove dead constant exprs hanging off a global, even if the global is not otherwise dead. This requires some tricky iterator gymnastics. This impleme

[llvm-commits] CVS: llvm/lib/VMCore/Globals.cpp

2006-09-30 Thread Chris Lattner
Changes in directory llvm/lib/VMCore: Globals.cpp updated: 1.13 -> 1.14 --- Log message: Add a version of the globalvariable ctor that inserts at a specific location. --- Diffs of the changes: (+21 -0) Globals.cpp | 21 + 1 files changed, 21 insertions(+) Index: llv