Hello, Chris.
> Ok, but the call can be used to dig the global out from under the
> constantexprs etc.
Yes. Commited.
> I must be missing something: isn't it *always* safe to RAUW uses of
> an alias with uses of its aliasee?
No, that's me missing some bits :) It's always safe to do RAUW of an
On Apr 29, 2007, at 3:38 AM, Anton Korobeynikov wrote:
> Chris,
>
>> This can use the new getAliaseeGlobal() method.
> Not here. We should distinguish, whether we have variable, function ot
> bitcast here and print them differently.
Ok, but the call can be used to dig the global out from under t
Changes in directory llvm/lib/VMCore:
AsmWriter.cpp updated: 1.277 -> 1.278
Globals.cpp updated: 1.21 -> 1.22
Verifier.cpp updated: 1.208 -> 1.209
---
Log message:
Implement review feedback
---
Diffs of the changes: (+30 -9)
AsmWriter.cpp |3 +--
Globals.cpp | 33 ++
Chris,
> This can use the new getAliaseeGlobal() method.
Not here. We should distinguish, whether we have variable, function ot
bitcast here and print them differently.
> What does it mean for an alias to be a declaration? I'd be fine with
> them always returning true or false. What code call
> +++ llvm/lib/VMCore/AsmWriter.cpp Sat Apr 28 08:44:59 2007
> @@ -926,7 +926,7 @@
> assert(0 && "Invalid alias linkage");
>}
>
> - const GlobalValue *Aliasee = GA->getAliasee();
> + const Constant *Aliasee = dyn_cast_or_null(GA-
> >getAliasee());
>assert(Aliasee && "Aliasee cann
Changes in directory llvm/lib/VMCore:
AsmWriter.cpp updated: 1.276 -> 1.277
Globals.cpp updated: 1.20 -> 1.21
Module.cpp updated: 1.81 -> 1.82
Verifier.cpp updated: 1.206 -> 1.207
---
Log message:
Implement review feedback. Aliasees can be either GlobalValue's or
bitcasts of them.
---
Diffs
On Apr 25, 2007, at 7:28 AM, Anton Korobeynikov wrote:
> +void GlobalAlias::setAliasee(const GlobalValue *GV)
> +{
> + // FIXME: Some checks?
> + Aliasee = GV;
> +}
> +
This should assert that GV type matches the alias type.
> @@ -277,7 +282,9 @@
>Assert1(!GV.isDeclaration() ||
>
Changes in directory llvm/lib/VMCore:
AsmWriter.cpp updated: 1.274 -> 1.275
Globals.cpp updated: 1.19 -> 1.20
Module.cpp updated: 1.80 -> 1.81
Verifier.cpp updated: 1.205 -> 1.206
---
Log message:
Implement aliases. This fixes PR1017: http://llvm.org/PR1017 and it's
dependent bugs. CFE part
Changes in directory llvm/lib/VMCore:
AsmWriter.cpp updated: 1.268 -> 1.269
Globals.cpp updated: 1.18 -> 1.19
---
Log message:
Implement the "thread_local" keyword.
---
Diffs of the changes: (+8 -7)
AsmWriter.cpp |3 ++-
Globals.cpp | 12 ++--
2 files changed, 8 insertions(
