Re: [llvm-commits] CVS: llvm/include/llvm/Function.h GlobalValue.h GlobalVariable.h Module.h Value.h ValueSymbolTable.h

2007-04-25 Thread Chris Lattner
On Apr 25, 2007, at 1:53 PM, Anton Korobeynikov wrote: > Hello, Chris. > >> Why do these all need to be virtual and accessible from GlobalValue? > For llvm-gcc patch. Or, it's better to insert three-way cast there? I'd prefer to do the three way compare here, -Chris ___

Re: [llvm-commits] CVS: llvm/include/llvm/Function.h GlobalValue.h GlobalVariable.h Module.h Value.h ValueSymbolTable.h

2007-04-25 Thread Anton Korobeynikov
Hello, Chris. > Why do these all need to be virtual and accessible from GlobalValue? For llvm-gcc patch. Or, it's better to insert three-way cast there? -- With best regards, Anton Korobeynikov. Faculty of Mathematics & Mechanics, Saint Petersburg State University. ___

Re: [llvm-commits] CVS: llvm/include/llvm/Function.h GlobalValue.h GlobalVariable.h Module.h Value.h ValueSymbolTable.h

2007-04-25 Thread Chris Lattner
> @@ -121,6 +121,16 @@ >/// value is outside of the current translation unit... >virtual bool isDeclaration() const = 0; > > + /// removeFromParent - This method unlinks 'this' from the > containing module, > + /// but does not delete it. > + /// > + virtual void removeFromParent() =

Re: [llvm-commits] CVS: llvm/include/llvm/Function.h GlobalValue.h GlobalVariable.h Module.h Value.h ValueSymbolTable.h

2007-04-25 Thread Evan Cheng
Hi Anton, You forgot to check in GlobalAlias.h. Evan On Apr 25, 2007, at 7:28 AM, Anton Korobeynikov wrote: > > > Changes in directory llvm/include/llvm: > > Function.h updated: 1.81 -> 1.82 > GlobalValue.h updated: 1.38 -> 1.39 > GlobalVariable.h updated: 1.44 -> 1.45 > Module.h updated: 1.88

[llvm-commits] CVS: llvm/include/llvm/Function.h GlobalValue.h GlobalVariable.h Module.h Value.h ValueSymbolTable.h

2007-04-25 Thread Anton Korobeynikov
Changes in directory llvm/include/llvm: Function.h updated: 1.81 -> 1.82 GlobalValue.h updated: 1.38 -> 1.39 GlobalVariable.h updated: 1.44 -> 1.45 Module.h updated: 1.88 -> 1.89 Value.h updated: 1.100 -> 1.101 ValueSymbolTable.h updated: 1.12 -> 1.13 --- Log message: Implement aliases. This fi

[llvm-commits] CVS: llvm/include/llvm/Function.h GlobalValue.h GlobalVariable.h

2007-01-30 Thread Reid Spencer
Changes in directory llvm/include/llvm: Function.h updated: 1.70 -> 1.71 GlobalValue.h updated: 1.31 -> 1.32 GlobalVariable.h updated: 1.38 -> 1.39 --- Log message: For PR1136: http://llvm.org/PR1136 : Rename GlobalVariable::isExternal as isDeclaration to avoid confusion with external linkage