Re: [llvm-commits] CAST Patch Update [1/4] first third of the patch.

On Nov 12, 2006, at 8:25 PM, Reid Spencer wrote: > I have a meta-comment on your review. The ConvertInst::getCast and > ConstantExpr::getCast methods work. Many of your review comments > claim > they don't. I should have primed you for this but didn't have time. > Here's why it works: > > 1. Th

Re: [llvm-commits] CAST Patch Update [1/4] first third of the patch.

On Sun, 2006-11-12 at 17:51 -0800, Chris Lattner wrote: > > Attached is the latest CAST patch. This passes all llvm/test and > > llvm-test test cases with the exception of > > MultiSource/Applications/hbd. > > I'm hoping that fresh eyes on this patch can help discover the > > problem > > because it

Re: [llvm-commits] [llvmgcc] CAST Patch [2/4] llvm-gcc part

On Nov 12, 2006, at 6:48 PM, Reid Spencer wrote:Attached is the llvm-gcc4 patch to correspond with the new CASTinstructions in LLVM.For Review Only.  PLEASE DO NOT COMMIT THIS!This patch looks fine: the uses of getCast are safe, because the CFE never has types that disagree with what the FE thinks

Re: [llvm-commits] CAST Patch Update [1/4] first third of the patch.

Chris, I have a meta-comment on your review. The ConvertInst::getCast and ConstantExpr::getCast methods work. Many of your review comments claim they don't. I should have primed you for this but didn't have time. Here's why it works: 1. These two methods are temporary. They were introduced to mi

[llvm-commits] [llvmgcc] CAST Patch (For Review Only)

Attached is the llvm-gcc4 patch to correspond with the new CAST instructions in LLVM. For Review Only. PLEASE DO NOT COMMIT THIS! Reid. Index: gcc/llvm-convert.cpp === --- gcc/llvm-convert.cpp (revision 204) +++ gcc/llvm-convert.cpp

Re: [llvm-commits] CVS: llvm/lib/Target/README.txt

He's been looking at the demo script. I was trying that code out... Andrew On 11/12/06, Nick Lewycky <[EMAIL PROTECTED]> wrote: > > > Changes in directory llvm/lib/Target: > > README.txt updated: 1.47 -> 1.48 > --- > Log message: > > Cute example from Chris Lattner. > > > --- > Diffs of the chan

[llvm-commits] CVS: llvm/lib/Analysis/BasicAliasAnalysis.cpp

Changes in directory llvm/lib/Analysis: BasicAliasAnalysis.cpp updated: 1.89 -> 1.90 --- Log message: remove redundant code --- Diffs of the changes: (+0 -2) BasicAliasAnalysis.cpp |2 -- 1 files changed, 2 deletions(-) Index: llvm/lib/Analysis/BasicAliasAnalysis.cpp diff -u llvm/lib

[llvm-commits] CVS: llvm/lib/Target/README.txt

Changes in directory llvm/lib/Target: README.txt updated: 1.47 -> 1.48 --- Log message: Cute example from Chris Lattner. --- Diffs of the changes: (+40 -0) README.txt | 40 1 files changed, 40 insertions(+) Index: llvm/lib/Target/README.txt diff

[llvm-commits] CVS: llvm-test/MultiSource/Applications/hbd/d6-arith.cpp decomp.cpp

Changes in directory llvm-test/MultiSource/Applications/hbd: d6-arith.cpp updated: 1.2 -> 1.3 decomp.cpp updated: 1.2 -> 1.3 --- Log message: Fix array delete instances. This shuts up about 1300 errors from valgrind. --- Diffs of the changes: (+5 -5) d6-arith.cpp |2 +- decomp.cpp |

Re: [llvm-commits] CAST Patch Update (Review Only)

Second Update: I ran findmisopt one more time and this time it found something: -mem2reg -instcombine. I'm currently tracking down the misoptimization. It seems to be a little too aggressive in eliminating setcc: 136,139c129,131 < %tmp71 = load ubyte* %tmp70 ; [#uses=1] <

[llvm-commits] CVS: llvm/lib/AsmParser/llvmAsmParser.y

Changes in directory llvm/lib/AsmParser: llvmAsmParser.y updated: 1.274 -> 1.275 --- Log message: Initialize some pointers to quiet the compiler (when doing build_gcc builds). --- Diffs of the changes: (+2 -2) llvmAsmParser.y |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)