[llvm-branch-commits] [libcxx] [libc++][spaceship] Implements X::iterator container requirements. (#… (PR #100440)

2024-07-24 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-libcxx Author: Mark de Wever (mordante) Changes …99343) This implements the requirements for the container iterator requirements for array, deque, vector, and `vector`. Implements: - LWG3352 strong_equality isn't a thing Implements parts of: -

[llvm-branch-commits] [clang] release/19.x: [ExprConstant] Handle shift overflow the same way as other kinds of overflow (#99579) (PR #100452)

2024-07-24 Thread via llvm-branch-commits
https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/100452 Backport 20eff68 Requested by: @efriedma-quic >From 741124ccac5a6daee7c2295066f9f90a63b1b3d4 Mon Sep 17 00:00:00 2001 From: Eli Friedman Date: Wed, 24 Jul 2024 12:36:08 -0700 Subject: [PATCH] [ExprConstant] Ha

[llvm-branch-commits] [clang] release/19.x: [ExprConstant] Handle shift overflow the same way as other kinds of overflow (#99579) (PR #100452)

2024-07-24 Thread via llvm-branch-commits
https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/100452 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/19.x: [ExprConstant] Handle shift overflow the same way as other kinds of overflow (#99579) (PR #100452)

2024-07-24 Thread via llvm-branch-commits
llvmbot wrote: @AaronBallman What do you think about merging this PR to the release branch? https://github.com/llvm/llvm-project/pull/100452 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[llvm-branch-commits] [clang] release/19.x: [ExprConstant] Handle shift overflow the same way as other kinds of overflow (#99579) (PR #100452)

2024-07-24 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (llvmbot) Changes Backport 20eff68 Requested by: @efriedma-quic --- Full diff: https://github.com/llvm/llvm-project/pull/100452.diff 8 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+2) - (modified) clang/lib/AST/ExprC

[llvm-branch-commits] [llvm] [BOLT] Match blocks with pseudo probes (PR #99891)

2024-07-24 Thread via llvm-branch-commits
@@ -478,10 +605,31 @@ matchWeightsByHashes(BinaryContext &BC, Blocks.push_back(&Func.Blocks[I + 1]); BlendedBlockHash BlendedHash(BB->getHash()); BlendedHashes.push_back(BlendedHash); +// Collects pseudo probes attached to the BB for use in the StaleMatcher. +

[llvm-branch-commits] [llvm] [BOLT] Match blocks with pseudo probes (PR #99891)

2024-07-24 Thread via llvm-branch-commits
@@ -478,10 +605,31 @@ matchWeightsByHashes(BinaryContext &BC, Blocks.push_back(&Func.Blocks[I + 1]); BlendedBlockHash BlendedHash(BB->getHash()); BlendedHashes.push_back(BlendedHash); +// Collects pseudo probes attached to the BB for use in the StaleMatcher. +

[llvm-branch-commits] [llvm] [BOLT] Match blocks with pseudo probes (PR #99891)

2024-07-24 Thread via llvm-branch-commits
@@ -208,11 +212,33 @@ class StaleMatcher { } } - /// Find the most similar block for a given hash. - const FlowBlock *matchBlock(BlendedBlockHash BlendedHash, - uint64_t CallHash) const { + /// Creates a mapping from a pseudo probe index t

[llvm-branch-commits] [llvm] [BOLT] Match blocks with pseudo probes (PR #99891)

2024-07-24 Thread via llvm-branch-commits
@@ -45,6 +45,8 @@ namespace opts { extern cl::opt TimeRewrite; extern cl::OptionCategory BoltOptCategory; +extern cl::opt Verbosity; +extern cl::opt ProfileUsePseudoProbes; WenleiHe wrote: IIUC `ProfileUsePseudoProbes` controls whether we extract probe from b

[llvm-branch-commits] [compiler-rt] [flang] [llvm] release/19.x: [Flang][Docs] Update information about AArch64 trampolines (#100391) (PR #100471)

2024-07-24 Thread via llvm-branch-commits
https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/100471 Backport c4b66bf4d065d3bbc2e2fac8512a6df8e013c704 c6e69b041a7e6d18463f6cf684b10fd46a62c496 Requested by: @ceseo >From b770811dfe94c4ae5e4eadd56f4e38cc9b8f2b29 Mon Sep 17 00:00:00 2001 From: Carlos Seo Date: W

[llvm-branch-commits] [compiler-rt] [flang] [llvm] release/19.x: [Flang][Docs] Update information about AArch64 trampolines (#100391) (PR #100471)

2024-07-24 Thread via llvm-branch-commits
https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/100471 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [flang] [llvm] release/19.x: [Flang][Docs] Update information about AArch64 trampolines (#100391) (PR #100471)

2024-07-24 Thread via llvm-branch-commits
llvmbot wrote: @ceseo @ceseo What do you think about merging this PR to the release branch? https://github.com/llvm/llvm-project/pull/100471 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[llvm-branch-commits] [compiler-rt] [flang] [llvm] release/19.x: [Flang][Docs] Update information about AArch64 trampolines (#100391) (PR #100471)

2024-07-24 Thread via llvm-branch-commits
https://github.com/llvmbot updated https://github.com/llvm/llvm-project/pull/100471 >From 6217df16aa9552fd6504dac6535d2753095daa47 Mon Sep 17 00:00:00 2001 From: Carlos Seo Date: Wed, 24 Jul 2024 11:18:08 -0300 Subject: [PATCH 1/2] [AArch64] Implement INIT/ADJUST_TRAMPOLINE (#70267) Add suppor

[llvm-branch-commits] [compiler-rt] [flang] [llvm] release/19.x: [Flang][Docs] Update information about AArch64 trampolines (#100391) (PR #100471)

2024-07-24 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Author: None (llvmbot) Changes Backport c4b66bf4d065d3bbc2e2fac8512a6df8e013c704 c6e69b041a7e6d18463f6cf684b10fd46a62c496 Requested by: @ceseo --- Full diff: https://github.com/llvm/llvm-project/pull/100471.diff 7 Files Affected: -

[llvm-branch-commits] [llvm] [BOLT] Match blocks with pseudo probes (PR #99891)

2024-07-24 Thread via llvm-branch-commits
@@ -45,6 +45,8 @@ namespace opts { extern cl::opt TimeRewrite; extern cl::OptionCategory BoltOptCategory; +extern cl::opt Verbosity; +extern cl::opt ProfileUsePseudoProbes; WenleiHe wrote: Ok, I think we need a dedicated flag to control matching strategy, oth

[llvm-branch-commits] [llvm] [BOLT] Match blocks with pseudo probes (PR #99891)

2024-07-24 Thread via llvm-branch-commits
@@ -208,11 +212,33 @@ class StaleMatcher { } } - /// Find the most similar block for a given hash. - const FlowBlock *matchBlock(BlendedBlockHash BlendedHash, - uint64_t CallHash) const { + /// Creates a mapping from a pseudo probe index t

[llvm-branch-commits] [llvm] [BOLT] Match blocks with pseudo probes (PR #99891)

2024-07-24 Thread via llvm-branch-commits
@@ -45,6 +45,8 @@ namespace opts { extern cl::opt TimeRewrite; extern cl::OptionCategory BoltOptCategory; +extern cl::opt Verbosity; +extern cl::opt ProfileUsePseudoProbes; WenleiHe wrote: > If the profile contains probe information, but ProfileUsePseudoProbe

[llvm-branch-commits] [flang] 8f950d0 - Revert "[flang][OpenMP] Fix copyprivate semantic checks (#95799)"

2024-07-24 Thread via llvm-branch-commits
Author: Leandro Lupori Date: 2024-07-24T19:11:57-03:00 New Revision: 8f950d0499fc797e89919eb4dcc264a845dcec77 URL: https://github.com/llvm/llvm-project/commit/8f950d0499fc797e89919eb4dcc264a845dcec77 DIFF: https://github.com/llvm/llvm-project/commit/8f950d0499fc797e89919eb4dcc264a845dcec77.diff

[llvm-branch-commits] [clang] release/19.x: [PAC][clang] Enable `-fptrauth-indirect-gotos` as part of pauthtest ABI (#100480) (PR #100484)

2024-07-24 Thread via llvm-branch-commits
https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/100484 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/19.x: [PAC][clang] Enable `-fptrauth-indirect-gotos` as part of pauthtest ABI (#100480) (PR #100484)

2024-07-24 Thread via llvm-branch-commits
llvmbot wrote: @asl What do you think about merging this PR to the release branch? https://github.com/llvm/llvm-project/pull/100484 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[llvm-branch-commits] [clang] release/19.x: [PAC][clang] Enable `-fptrauth-indirect-gotos` as part of pauthtest ABI (#100480) (PR #100484)

2024-07-24 Thread via llvm-branch-commits
https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/100484 Backport 3f6eb13abf643afec17a73448ede380606531226 Requested by: @asl >From 145ad8b3b5800db2ed777b4fe44fdd050e9a12c5 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Thu, 25 Jul 2024 02:13:30 +0300 Subject:

[llvm-branch-commits] [clang] release/19.x: [PAC][clang] Enable `-fptrauth-indirect-gotos` as part of pauthtest ABI (#100480) (PR #100484)

2024-07-24 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: None (llvmbot) Changes Backport 3f6eb13abf643afec17a73448ede380606531226 Requested by: @asl --- Full diff: https://github.com/llvm/llvm-project/pull/100484.diff 2 Files Affected: - (modified) clang/lib/Driver/ToolChains/Clang.cp

[llvm-branch-commits] [llvm] [BOLT] Match blocks with pseudo probes (PR #99891)

2024-07-24 Thread via llvm-branch-commits
@@ -45,6 +45,8 @@ namespace opts { extern cl::opt TimeRewrite; extern cl::OptionCategory BoltOptCategory; +extern cl::opt Verbosity; +extern cl::opt ProfileUsePseudoProbes; WenleiHe wrote: > There's no use of probes outside stale matching. True, but you do

[llvm-branch-commits] [llvm] [BOLT] Match blocks with pseudo probes (PR #99891)

2024-07-24 Thread via llvm-branch-commits
@@ -223,10 +249,31 @@ class StaleMatcher { return Hash1.InstrHash == Hash2.InstrHash; } + /// Returns true if a profiled block was matched with its pseudo probe. + bool isPseudoProbeMatch(BlendedBlockHash YamlBBHash) { +return MatchedWithPseudoProbes.find(YamlBBHas

[llvm-branch-commits] [libc] release/19.x: [libc] Only add '-fno-builtin-*' on the entrypoints that use them (#100481) (PR #100496)

2024-07-24 Thread via llvm-branch-commits
https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/100496 Backport 8e43acbfedf53ded43ec693ddaaf518cb7416c1c Requested by: @jhuber6 >From e8d69fb1610912c265f7a64471ce372e83a7a014 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Wed, 24 Jul 2024 21:06:19 -0500 Subject

[llvm-branch-commits] [libc] release/19.x: [libc] Only add '-fno-builtin-*' on the entrypoints that use them (#100481) (PR #100496)

2024-07-24 Thread via llvm-branch-commits
https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/100496 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libc] release/19.x: [libc] Only add '-fno-builtin-*' on the entrypoints that use them (#100481) (PR #100496)

2024-07-24 Thread via llvm-branch-commits
llvmbot wrote: @lntue What do you think about merging this PR to the release branch? https://github.com/llvm/llvm-project/pull/100496 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[llvm-branch-commits] [libc] release/19.x: [libc] Only add '-fno-builtin-*' on the entrypoints that use them (#100481) (PR #100496)

2024-07-24 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-libc Author: None (llvmbot) Changes Backport 8e43acbfedf53ded43ec693ddaaf518cb7416c1c Requested by: @jhuber6 --- Full diff: https://github.com/llvm/llvm-project/pull/100496.diff 2 Files Affected: - (modified) libc/cmake/modules/LLVMLibCCompileOption

[llvm-branch-commits] [libc] release/19.x: [libc] Only add '-fno-builtin-*' on the entrypoints that use them (#100481) (PR #100496)

2024-07-24 Thread via llvm-branch-commits
https://github.com/lntue approved this pull request. https://github.com/llvm/llvm-project/pull/100496 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/19.x: Revert "[clang-format] Fix a bug in annotating `*` in `#define`s (#99433)" (PR #100499)

2024-07-24 Thread via llvm-branch-commits
https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/100499 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/19.x: Revert "[clang-format] Fix a bug in annotating `*` in `#define`s (#99433)" (PR #100499)

2024-07-24 Thread via llvm-branch-commits
https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/100499 Backport 7e7a9069d4240d2ae619cb50eba09f948c537ce3 Requested by: @owenca >From d65a9335367749a62ef924400b24a2c66574c92d Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Wed, 24 Jul 2024 19:22:18 -0700 Subject: [PA

[llvm-branch-commits] [clang] release/19.x: Revert "[clang-format] Fix a bug in annotating `*` in `#define`s (#99433)" (PR #100499)

2024-07-24 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: None (llvmbot) Changes Backport 7e7a9069d4240d2ae619cb50eba09f948c537ce3 Requested by: @owenca --- Full diff: https://github.com/llvm/llvm-project/pull/100499.diff 2 Files Affected: - (modified) clang/lib/Format/TokenAnnotator.c

[llvm-branch-commits] [mlir] 055852b - Revert "[mlir] Fix block merging (#97697)"

2024-07-24 Thread via llvm-branch-commits
Author: Christian Ulmann Date: 2024-07-25T07:42:56+02:00 New Revision: 055852b37047d8a550c4900ec94bdc4ee4256e3d URL: https://github.com/llvm/llvm-project/commit/055852b37047d8a550c4900ec94bdc4ee4256e3d DIFF: https://github.com/llvm/llvm-project/commit/055852b37047d8a550c4900ec94bdc4ee4256e3d.di

[llvm-branch-commits] [llvm] AMDGPU: Add baseline test for vectorize of integer min/max (PR #100513)

2024-07-24 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-analysis @llvm/pr-subscribers-llvm-transforms Author: Matt Arsenault (arsenm) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/100513.diff 1 Files Affected: - (added) llvm/test/Transforms/SLPVectorizer/AMDGPU/min_max.ll (+366)

[llvm-branch-commits] [llvm] TTI: Check legalization cost of min/max ISD nodes (PR #100514)

2024-07-24 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Matt Arsenault (arsenm) Changes TTI: Check legalization cost of min/max ISD nodes Instead of counting the cost of the assumed expansion. The AMDGPU costs for the i64 case look too high to me. Preserve default expansion logic --

[llvm-branch-commits] [llvm] TTI: Check legalization cost of min/max ISD nodes (PR #100514)

2024-07-24 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-transforms Author: Matt Arsenault (arsenm) Changes TTI: Check legalization cost of min/max ISD nodes Instead of counting the cost of the assumed expansion. The AMDGPU costs for the i64 case look too high to me. Preserve default expansion logic -

[llvm-branch-commits] [llvm] TTI: Check legalization cost of mul overflow ISD nodes (PR #100519)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-analysis Author: Matt Arsenault (arsenm) Changes --- Patch is 40.56 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/100519.diff 3 Files Affected: - (modified) llvm/include/llvm/CodeGen/BasicTTIImpl.h

[llvm-branch-commits] [llvm] TTI: Check legalization cost of mulfix ISD nodes (PR #100520)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-transforms Author: Matt Arsenault (arsenm) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/100520.diff 1 Files Affected: - (modified) llvm/include/llvm/CodeGen/BasicTTIImpl.h (+29-24) ``diff diff --git a/llvm/include

[llvm-branch-commits] [llvm] TTI: Check legalization cost of fptosi_sat/fptoui_sat nodes (PR #100521)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu @llvm/pr-subscribers-llvm-analysis Author: Matt Arsenault (arsenm) Changes --- Patch is 127.35 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/100521.diff 6 Files Affected: - (modified) llv

[llvm-branch-commits] [llvm] TTI: Check legalization cost of add/sub overflow ISD nodes (PR #100518)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Matt Arsenault (arsenm) Changes --- Patch is 245.20 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/100518.diff 8 Files Affected: - (modified) llvm/include/llvm/CodeGen/BasicTTIImpl

[llvm-branch-commits] [llvm] TTI: Check legalization cost of add/sub overflow ISD nodes (PR #100518)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-analysis Author: Matt Arsenault (arsenm) Changes --- Patch is 245.20 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/100518.diff 8 Files Affected: - (modified) llvm/include/llvm/CodeGen/BasicTTIImpl.

[llvm-branch-commits] [llvm] AMDGPU: Add baseline test for cost of abs intrinsics (PR #100522)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Matt Arsenault (arsenm) Changes --- Patch is 36.04 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/100522.diff 1 Files Affected: - (added) llvm/test/Analysis/CostModel/AMDGPU/abs.ll

[llvm-branch-commits] [llvm] TTI: Check legalization cost of abs nodes (PR #100523)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Matt Arsenault (arsenm) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/100523.diff 2 Files Affected: - (modified) llvm/include/llvm/CodeGen/BasicTTIImpl.h (+18-14) - (modified) llvm/test/Analysis/CostModel/A

[llvm-branch-commits] [llvm] TTI: Check legalization cost of abs nodes (PR #100523)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-analysis Author: Matt Arsenault (arsenm) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/100523.diff 2 Files Affected: - (modified) llvm/include/llvm/CodeGen/BasicTTIImpl.h (+18-14) - (modified) llvm/test/Analysis/CostModel/AM

[llvm-branch-commits] [compiler-rt] release/19.x: [AArch64][SME] Rewrite __arm_get_current_vg to preserve required registers (#100143) (PR #100546)

2024-07-25 Thread via llvm-branch-commits
https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/100546 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] release/19.x: [AArch64][SME] Rewrite __arm_get_current_vg to preserve required registers (#100143) (PR #100546)

2024-07-25 Thread via llvm-branch-commits
https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/100546 Backport 6da6772bf0a33131aa8540c9d4f60d5db75c32b5 Requested by: @kmclaughlin-arm >From 6271d3d03846216502487711f330227a4a6d3022 Mon Sep 17 00:00:00 2001 From: Kerry McLaughlin Date: Wed, 24 Jul 2024 14:30:25 +

[llvm-branch-commits] [compiler-rt] release/19.x: [AArch64][SME] Rewrite __arm_get_current_vg to preserve required registers (#100143) (PR #100546)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @sdesmalen-arm What do you think about merging this PR to the release branch? https://github.com/llvm/llvm-project/pull/100546 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[llvm-branch-commits] [llvm] cf55425 - Revert "MTM: fix issues after cursory reading (#100404)"

2024-07-25 Thread via llvm-branch-commits
Author: Mehdi Amini Date: 2024-07-25T14:06:44+02:00 New Revision: cf55425639c201d8b3a80541bc222934485d5eda URL: https://github.com/llvm/llvm-project/commit/cf55425639c201d8b3a80541bc222934485d5eda DIFF: https://github.com/llvm/llvm-project/commit/cf55425639c201d8b3a80541bc222934485d5eda.diff L

[llvm-branch-commits] [lldb] b851520 - Revert "[lldb] Fix incorrect uses of logical operator in 'if' condition check…"

2024-07-25 Thread via llvm-branch-commits
Author: David Spickett Date: 2024-07-25T13:16:55+01:00 New Revision: b85152008f41e8136f5e21db875a63b464f8c10f URL: https://github.com/llvm/llvm-project/commit/b85152008f41e8136f5e21db875a63b464f8c10f DIFF: https://github.com/llvm/llvm-project/commit/b85152008f41e8136f5e21db875a63b464f8c10f.diff

[llvm-branch-commits] [flang] release/19.x: [flang][OpenMP] Initialize privatised derived type variables (#100417) (PR #100587)

2024-07-25 Thread via llvm-branch-commits
https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/100587 Backport 98e733e Requested by: @tblah >From 6867a167f40aacd653e56a3fab08bc52797f46cd Mon Sep 17 00:00:00 2001 From: Tom Eccles Date: Thu, 25 Jul 2024 16:53:27 +0100 Subject: [PATCH] [flang][OpenMP] Initialize

[llvm-branch-commits] [flang] release/19.x: [flang][OpenMP] Initialize privatised derived type variables (#100417) (PR #100587)

2024-07-25 Thread via llvm-branch-commits
https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/100587 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] release/19.x: [flang][OpenMP] Initialize privatised derived type variables (#100417) (PR #100587)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @jeanPerier What do you think about merging this PR to the release branch? https://github.com/llvm/llvm-project/pull/100587 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[llvm-branch-commits] [flang] release/19.x: [flang][OpenMP] Initialize privatised derived type variables (#100417) (PR #100587)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-flang-openmp Author: None (llvmbot) Changes Backport 98e733e Requested by: @tblah --- Full diff: https://github.com/llvm/llvm-project/pull/100587.diff 4 Files Affected: - (modified) flang/include/flang/Lower/ConvertVariable.h (+8) - (modified) flan

[llvm-branch-commits] [clang] release/19.x: [clang] Remove `__is_layout_compatible` from revertible type traits list (#100572) (PR #100590)

2024-07-25 Thread via llvm-branch-commits
https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/100590 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/19.x: [clang] Remove `__is_layout_compatible` from revertible type traits list (#100572) (PR #100590)

2024-07-25 Thread via llvm-branch-commits
https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/100590 Backport 3295d377f37a60597321f502d164b5d6b1948e28 Requested by: @Endilll >From 3c7695ec2681c3ca531b5ce2a2fd20b8301df0b5 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Thu, 25 Jul 2024 20:15:14 +0400 S

[llvm-branch-commits] [clang] release/19.x: [clang] Remove `__is_layout_compatible` from revertible type traits list (#100572) (PR #100590)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @cor3ntin What do you think about merging this PR to the release branch? https://github.com/llvm/llvm-project/pull/100590 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[llvm-branch-commits] [clang] release/19.x: [clang] Remove `__is_layout_compatible` from revertible type traits list (#100572) (PR #100590)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (llvmbot) Changes Backport 3295d377f37a60597321f502d164b5d6b1948e28 Requested by: @Endilll --- Full diff: https://github.com/llvm/llvm-project/pull/100590.diff 1 Files Affected: - (modified) clang/lib/Parse/ParseExpr.cpp (+3-1)

[llvm-branch-commits] [clang] release/19.x: [clang] Remove `__is_layout_compatible` from revertible type traits list (#100572) (PR #100590)

2024-07-25 Thread via llvm-branch-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/100590 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/19.x: [libc++] Add missing xlocale.h include on Apple and FreeBSD (#99689) (PR #100604)

2024-07-25 Thread via llvm-branch-commits
https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/100604 Backport a55df237375e98cfc2520d5eb1a23b302ef02ba0 Requested by: @ldionne >From 342755c855bbc6873b4677a74812759c6a80cdae Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Thu, 25 Jul 2024 12:16:48 -0500 Subject

[llvm-branch-commits] [libcxx] release/19.x: [libc++] Add missing xlocale.h include on Apple and FreeBSD (#99689) (PR #100604)

2024-07-25 Thread via llvm-branch-commits
https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/100604 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/19.x: [libc++] Add missing xlocale.h include on Apple and FreeBSD (#99689) (PR #100604)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @philnik777 What do you think about merging this PR to the release branch? https://github.com/llvm/llvm-project/pull/100604 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[llvm-branch-commits] [libcxx] release/19.x: [libc++] Add missing xlocale.h include on Apple and FreeBSD (#99689) (PR #100604)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-libcxx Author: None (llvmbot) Changes Backport a55df237375e98cfc2520d5eb1a23b302ef02ba0 Requested by: @ldionne --- Full diff: https://github.com/llvm/llvm-project/pull/100604.diff 1 Files Affected: - (modified) libcxx/include/locale (+4)

[llvm-branch-commits] [DXIL][Analysis] Replace #include with forward declaration. NFC (PR #100622)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-analysis Author: Justin Bogner (bogner) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/100622.diff 2 Files Affected: - (modified) llvm/include/llvm/Analysis/DXILResource.h (+2-1) - (modified) llvm/lib/Analysis/DXILResource.cp

[llvm-branch-commits] [DXIL][Analysis] Make the DXILResource binding optional. NFC (PR #100623)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-analysis Author: Justin Bogner (bogner) Changes This makes the binding structure in a DXILResource default to empty and need a separate call to set up, and also moves the unique ID into it since bindings are the only place where those are actually u

[llvm-branch-commits] [DXIL][Analysis] Make the DXILResource binding optional. NFC (PR #100623)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-backend-directx Author: Justin Bogner (bogner) Changes This makes the binding structure in a DXILResource default to empty and need a separate call to set up, and also moves the unique ID into it since bindings are the only place where those are actually

[llvm-branch-commits] [compiler-rt] release/19.x: Normalize ptrauth handling in sanitizer runtime (#100483) (PR #100634)

2024-07-25 Thread via llvm-branch-commits
https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/100634 Backport cc4f98979b079b517edd8a71f56a8975f436e63d Requested by: @asl >From 018a8c72cc75b9bb4dcb88a07bdda31454c78ca1 Mon Sep 17 00:00:00 2001 From: Anton Korobeynikov Date: Thu, 25 Jul 2024 11:57:46 -0700 Subje

[llvm-branch-commits] [compiler-rt] release/19.x: Normalize ptrauth handling in sanitizer runtime (#100483) (PR #100634)

2024-07-25 Thread via llvm-branch-commits
https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/100634 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] release/19.x: Normalize ptrauth handling in sanitizer runtime (#100483) (PR #100634)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @DanielKristofKiss What do you think about merging this PR to the release branch? https://github.com/llvm/llvm-project/pull/100634 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[llvm-branch-commits] [compiler-rt] release/19.x: Normalize ptrauth handling in sanitizer runtime (#100483) (PR #100634)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-compiler-rt-sanitizer Author: None (llvmbot) Changes Backport cc4f98979b079b517edd8a71f56a8975f436e63d Requested by: @asl --- Full diff: https://github.com/llvm/llvm-project/pull/100634.diff 1 Files Affected: - (modified) compiler-rt/lib/sanitizer_c

[llvm-branch-commits] [NFC][ubsan] Add mixed filter test case (PR #100679)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-transforms Author: Vitaly Buka (vitalybuka) Changes Currently "random" overrides "hotness", we need to make them work together. --- Full diff: https://github.com/llvm/llvm-project/pull/100679.diff 1 Files Affected: - (modified) llvm/test/Transf

[llvm-branch-commits] [ubsan][hwasan] Let mixing filters (PR #100680)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-transforms Author: Vitaly Buka (vitalybuka) Changes Now the check will be enabled only if each filter is satisfied. --- Full diff: https://github.com/llvm/llvm-project/pull/100680.diff 4 Files Affected: - (modified) llvm/lib/Transforms/Instrume

[llvm-branch-commits] [DXIL][Analysis] Make alignment on StructuredBuffer optional (PR #100697)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-analysis @llvm/pr-subscribers-backend-directx Author: Justin Bogner (bogner) Changes HLSL allows StructuredBuffer<> to be defined with scalar or up-to-4-element vectors as well as with structs, but when doing so `dxc` doesn't set the alignment. Emul

[llvm-branch-commits] [DirectX] Remove new-pm versions of DXILResource passes. NFC (PR #100698)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-backend-directx Author: Justin Bogner (bogner) Changes This is a bit of a hack, but these aren't actually used at the moment and they'll cause naming conflicts with DXIL resource passes that I'm adding to llvm/Analysis for replacing all of this with the

[llvm-branch-commits] [DXIL][Analysis] Implement enough of DXILResourceAnalysis for buffers (PR #100699)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-backend-directx Author: Justin Bogner (bogner) Changes This implements the DXILResourceAnalysis pass for `dx.TypedBuffer` and `dx.RawBuffer` types. This should be sufficient to lower `dx.handle.fromBinding` for this set of types, but it leaves a number o

[llvm-branch-commits] [DXIL][Analysis] Boilerplate for DXILResourceAnalysis pass (PR #100700)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-backend-directx Author: Justin Bogner (bogner) Changes Broke this out into its own commit to make the next one easier to review. --- Full diff: https://github.com/llvm/llvm-project/pull/100700.diff 5 Files Affected: - (modified) llvm/include/llvm/An

[llvm-branch-commits] [DXIL][Analysis] Boilerplate for DXILResourceAnalysis pass (PR #100700)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-analysis Author: Justin Bogner (bogner) Changes Broke this out into its own commit to make the next one easier to review. --- Full diff: https://github.com/llvm/llvm-project/pull/100700.diff 5 Files Affected: - (modified) llvm/include/llvm/Anal

[llvm-branch-commits] [clang] release/19.x: [clang][Sema] Add support for OpenBSD's syslog format attribute (#97366) (PR #100703)

2024-07-25 Thread via llvm-branch-commits
https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/100703 Backport e788788c42fcbed5077b13f8bb88a81a832ab6eb Requested by: @brad0 >From 89fc77d4185d1b624b8456ae36a088d42a2f62ed Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Thu, 25 Jul 2024 18:57:14 -0400 Subject: [P

[llvm-branch-commits] [clang] release/19.x: [clang][Sema] Add support for OpenBSD's syslog format attribute (#97366) (PR #100703)

2024-07-25 Thread via llvm-branch-commits
https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/100703 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/19.x: [clang][Sema] Add support for OpenBSD's syslog format attribute (#97366) (PR #100703)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @Sirraide What do you think about merging this PR to the release branch? https://github.com/llvm/llvm-project/pull/100703 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[llvm-branch-commits] [clang] release/19.x: [clang][Sema] Add support for OpenBSD's syslog format attribute (#97366) (PR #100703)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (llvmbot) Changes Backport e788788c42fcbed5077b13f8bb88a81a832ab6eb Requested by: @brad0 --- Full diff: https://github.com/llvm/llvm-project/pull/100703.diff 5 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+2) - (modi

[llvm-branch-commits] [llvm] [lld][ELF][LoongArch] Support R_LARCH_TLS_{LD, GD, DESC}_PCREL_S2 (PR #100105)

2024-07-25 Thread via llvm-branch-commits
https://github.com/wangleiat updated https://github.com/llvm/llvm-project/pull/100105 >From c50d8a3dba1e9ac8712659bbafcc184da6e86533 Mon Sep 17 00:00:00 2001 From: wanglei Date: Tue, 23 Jul 2024 19:13:41 +0800 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20change?= =?UTF-8

[llvm-branch-commits] [llvm] release/19.x: [LoongArch][MC] Support %[ld_/gd_/desc_]pcrel_20 (PR #100704)

2024-07-25 Thread via llvm-branch-commits
https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/100704 Backport e27358c8ed7abac200546e808ea30a86aa9aa580 Requested by: @wangleiat >From 77642a3646e1cd86f51198f715b2ff68bf92c4c3 Mon Sep 17 00:00:00 2001 From: wanglei Date: Fri, 26 Jul 2024 14:36:54 +0800 Subject: [

[llvm-branch-commits] [llvm] release/19.x: [LoongArch][MC] Support %[ld_/gd_/desc_]pcrel_20 (PR #100704)

2024-07-25 Thread via llvm-branch-commits
https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/100704 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/19.x: [LoongArch][MC] Support %[ld_/gd_/desc_]pcrel_20 (PR #100704)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @MaskRay What do you think about merging this PR to the release branch? https://github.com/llvm/llvm-project/pull/100704 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[llvm-branch-commits] [llvm] release/19.x: [LoongArch][MC] Support %[ld_/gd_/desc_]pcrel_20 (PR #100704)

2024-07-25 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-backend-loongarch Author: None (llvmbot) Changes Backport e27358c8ed7abac200546e808ea30a86aa9aa580 Requested by: @wangleiat --- Full diff: https://github.com/llvm/llvm-project/pull/100704.diff 8 Files Affected: - (modified) llvm/lib/Target/LoongArch

[llvm-branch-commits] [libcxx] [libc++][doc] Update the release notes for LLVM 19. (PR #100167)

2024-07-26 Thread via llvm-branch-commits
github-actions[bot] wrote: @mordante (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR.

[llvm-branch-commits] [clang] release/19.x: [clang][headers] Including stddef.h always redefines NULL (#99727) (PR #100191)

2024-07-26 Thread via llvm-branch-commits
github-actions[bot] wrote: @ian-twilightcoder (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to th

[llvm-branch-commits] [llvm] release/19.x: [LLVM] [MC] Update frame layout & CFI generation to handle frames larger than 2gb (#99263) (PR #100195)

2024-07-26 Thread via llvm-branch-commits
github-actions[bot] wrote: @MaskRay (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR. h

[llvm-branch-commits] [clang] release/19.x: [Clang] Fix an assertion failure introduced by #93430 (#100313) (PR #100407)

2024-07-26 Thread via llvm-branch-commits
github-actions[bot] wrote: @cor3ntin (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR.

[llvm-branch-commits] [clang] release/19.x: [Clang][NFC] Simplify initialization of `OverloadCandidate` objects. (#100318) (PR #100410)

2024-07-26 Thread via llvm-branch-commits
github-actions[bot] wrote: @cor3ntin (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR.

[llvm-branch-commits] [libcxx] release/19.x: [libc++] Improve behavior when using relative path for LIBCXX_ASSERTION_HANDLER_FILE (#100157) (PR #100411)

2024-07-26 Thread via llvm-branch-commits
github-actions[bot] wrote: @ldionne (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR. h

[llvm-branch-commits] [libcxx] [libc++][spaceship] Implements X::iterator container requirements. (#99343) (PR #100440)

2024-07-26 Thread via llvm-branch-commits
github-actions[bot] wrote: @mordante (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR.

[llvm-branch-commits] [clang] release/19.x: [ExprConstant] Handle shift overflow the same way as other kinds of overflow (#99579) (PR #100452)

2024-07-26 Thread via llvm-branch-commits
github-actions[bot] wrote: @efriedma-quic (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this P

[llvm-branch-commits] [compiler-rt] [flang] [llvm] release/19.x: [Flang][Docs] Update information about AArch64 trampolines (#100391) (PR #100471)

2024-07-26 Thread via llvm-branch-commits
github-actions[bot] wrote: @ceseo (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR. htt

[llvm-branch-commits] [clang] release/19.x: [PAC][clang] Enable `-fptrauth-indirect-gotos` as part of pauthtest ABI (#100480) (PR #100484)

2024-07-26 Thread via llvm-branch-commits
github-actions[bot] wrote: @asl (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR. https

[llvm-branch-commits] [libc] release/19.x: [libc] Only add '-fno-builtin-*' on the entrypoints that use them (#100481) (PR #100496)

2024-07-26 Thread via llvm-branch-commits
github-actions[bot] wrote: @jhuber6 (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR. h

[llvm-branch-commits] [clang] [flang] release/19.x: [Flang][Driver] Enable config file options (#100343) (PR #100541)

2024-07-26 Thread via llvm-branch-commits
github-actions[bot] wrote: @kiranchandramohan (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to th

[llvm-branch-commits] [compiler-rt] release/19.x: [AArch64][SME] Rewrite __arm_get_current_vg to preserve required registers (#100143) (PR #100546)

2024-07-26 Thread via llvm-branch-commits
github-actions[bot] wrote: @kmclaughlin-arm (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this

[llvm-branch-commits] [flang] release/19.x: [flang][OpenMP] Initialize privatised derived type variables (#100417) (PR #100587)

2024-07-26 Thread via llvm-branch-commits
github-actions[bot] wrote: @tblah (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR. htt

[llvm-branch-commits] [compiler-rt] release/19.x: [compiler-rt][ubsan][nfc-ish] Fix a type conversion bug (#100665) (PR #100713)

2024-07-26 Thread via llvm-branch-commits
github-actions[bot] wrote: @asl (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR. https

<    2   3   4   5   6   7   8   9   10   11   >