tahonermann wrote:
I recommend extending testing via additional `RUN` lines to all of the
following tests:
- `clang/test/CodeGen/attr-cpuspecific.c`
- `clang/test/CodeGen/attr-target-clones.c`
- `clang/test/CodeGen/attr-target-mv-func-ptrs.c`
- `clang/test/CodeGen/attr-target-mv-va-args.c` (alre
tahonermann wrote:
Added @erichkeane as a reviewer as well.
Will this cause an ABI compatibility issue for any existing use of the function
multiversioning attributes on Darwin? I think it might, but I haven't tried to
confirm.
https://github.com/llvm/llvm-project/pull/73688
_
tahonermann wrote:
Added @erichkeane as a reviewer.
I recommend extending test coverage to all of the following tests:
- `clang/test/CodeGenCXX/externc-ifunc-resolver.cpp`
- `clang/test/SemaCXX/externc-ifunc-resolver.cpp`
- `clang/test/CodeGen/ifunc.c` (already done)
- `clang/test/CodeGen/attr-i