[llvm-branch-commits] [compiler-rt] release/19.x: [builtins] Fix divtc3.c etc. compilation on Solaris/SPARC with gcc (#101662) (PR #101847)

2024-09-03 Thread Sean Perry via llvm-branch-commits
perry-ca wrote: I have concerns about this change just thinking about this from the Solaris point of view. A couple questions: - from what I've learnt from Rainer, the Sparc 32-bit mode doesn't support long double. In that case they should change the CMakefile file so none of the TF function

[llvm-branch-commits] [clang] clang: Remove requires system-linux from some driver tests (PR #111976)

2024-10-11 Thread Sean Perry via llvm-branch-commits
@@ -1,4 +1,3 @@ -// REQUIRES: system-linux perry-ca wrote: I'm looking into that question. The first thing I noticed was the temp file is being created and read as a binary file. I also noticed that the output of the script is not being redirected into the te

[llvm-branch-commits] [clang] clang: Remove requires system-linux from some driver tests (PR #111976)

2024-10-11 Thread Sean Perry via llvm-branch-commits
https://github.com/perry-ca commented: Three of these tests will fail on z/OS when the requires is removed. It would be great if they can be fixed so they work on z/OS. None of these are available or supported on z/OS so marking them as unsupported on system-zos is also an option. @daltenty

[llvm-branch-commits] [clang] clang: Remove requires system-linux from some driver tests (PR #111976)

2024-10-11 Thread Sean Perry via llvm-branch-commits
https://github.com/perry-ca edited https://github.com/llvm/llvm-project/pull/111976 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] clang: Remove requires system-linux from some driver tests (PR #111976)

2024-10-11 Thread Sean Perry via llvm-branch-commits
@@ -1,4 +1,3 @@ -// REQUIRES: system-linux perry-ca wrote: This is failing on z/OS on line 33 with the error: ``` clang: error: failed to deduce triple for target architecture 'native'; specify the triple using '-fopenmp-targets' and '-Xopenmp-target' instead ``

[llvm-branch-commits] [clang] clang: Remove requires system-linux from some driver tests (PR #111976)

2024-10-11 Thread Sean Perry via llvm-branch-commits
@@ -1,4 +1,3 @@ -// REQUIRES: system-linux perry-ca wrote: The compile & test on line 47 is failing on z/OS with the following message: ``` clang: error: cannot determine amdgcn architecture: No AMD GPU detected in the system; consider passing it via '--offload-

[llvm-branch-commits] [clang] clang: Remove requires system-linux from some driver tests (PR #111976)

2024-10-11 Thread Sean Perry via llvm-branch-commits
@@ -1,4 +1,3 @@ -// REQUIRES: system-linux perry-ca wrote: This is failing on z/OS on line 28 (ARCH_sm70 check). The actual cc1 line is: ``` clang: warning: CUDA version is newer than the latest partially supported version 12.5 [-Wunknown-cuda-version] clang: e

[llvm-branch-commits] [clang] clang: Remove requires system-linux from some driver tests (PR #111976)

2024-10-11 Thread Sean Perry via llvm-branch-commits
@@ -1,4 +1,3 @@ -// REQUIRES: system-linux perry-ca wrote: I agree. By fixing it, I was referring to the code in clang that determines this value. If it's easy to make the test pass on z/OS great. If not marking it as unsupported works too. This applies to