[llvm-branch-commits] [llvm] release/19.x: [RemoveDIs] Fix spliceDebugInfo splice-to-end edge case (#105671) (PR #106691)

OCHyams wrote: Edge-case `BasicBlock::end()` iterator dereference, depends on https://github.com/llvm/llvm-project/pull/106690 https://github.com/llvm/llvm-project/pull/106691 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org htt

[llvm-branch-commits] [llvm] release/19.x: [RemoveDIs] Fix spliceDebugInfo splice-to-end edge case (#105671) (PR #106691)

OCHyams wrote: Thanks for the report, I'll look at that now https://github.com/llvm/llvm-project/pull/106691 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/19.x: [RemoveDIs] Fix spliceDebugInfo splice-to-end edge case (#105671, #106723) (PR #106952)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/106952 Please can we backport 43661a1214353ea1773a711f403f8d1118e9ca0f (and 7ffe67c17c524c2d3056c0721a33c7012dce3061) into the next dot release. Replaces #106691 - this one includes a follow-up fix in 7ffe67c17c524c2

[llvm-branch-commits] [llvm] release/19.x: [RemoveDIs] Fix spliceDebugInfo splice-to-end edge case (#105671) (PR #106691)

OCHyams wrote: Re-opened backport request with the fix too - #106952 https://github.com/llvm/llvm-project/pull/106691 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-c

[llvm-branch-commits] [llvm] release/19.x: [RemoveDIs] Fix spliceDebugInfo splice-to-end edge case (#105671) (PR #106691)

https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/106691 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/19.x: [RemoveDIs] Fix spliceDebugInfo splice-to-end edge case (#105671, #106723) (PR #106952)

https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/106952 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/19.x: [DebugInfo][RemoveDIs] Find types hidden in DbgRecords (#106547) (PR #107060)

https://github.com/OCHyams approved this pull request. > @OCHyams What do you think about merging this PR to the release branch? LGTM, this fixes a bug where valid IR gets rejected by the parser, so getting it backported sounds good. For peace of mind: we don't need a null check in the `DVI->l

[llvm-branch-commits] [llvm] release/19.x: [DebugInfo][RemoveDIs] Find types hidden in DbgRecords (#106547) (PR #107060)

https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/107060 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/19.x: [RemoveDIs] Fix spliceDebugInfo splice-to-end edge case (#105671, #106723) (PR #106952)

https://github.com/OCHyams commented: Hi @tru, > Is this PR a fix for a regression or a critical issue? Neither > What is the risk of accepting this into the release branch? If I've made a mistake in the patch we could get incorrect debug-info in an edge case. I've added some comments inline

[llvm-branch-commits] [llvm] release/19.x: [RemoveDIs] Fix spliceDebugInfo splice-to-end edge case (#105671, #106723) (PR #106952)

https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/106952 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/19.x: [RemoveDIs] Fix spliceDebugInfo splice-to-end edge case (#105671, #106723) (PR #106952)

@@ -975,8 +975,16 @@ void BasicBlock::spliceDebugInfoImpl(BasicBlock::iterator Dest, BasicBlock *Src, if (ReadFromTail && Src->getMarker(Last)) { DbgMarker *FromLast = Src->getMarker(Last); if (LastIsEnd) { - Dest->adoptDbgRecords(Src, Last, true); - // ado

[llvm-branch-commits] [llvm] release/19.x: [RemoveDIs] Fix spliceDebugInfo splice-to-end edge case (#105671, #106723) (PR #106952)

@@ -975,8 +975,16 @@ void BasicBlock::spliceDebugInfoImpl(BasicBlock::iterator Dest, BasicBlock *Src, if (ReadFromTail && Src->getMarker(Last)) { DbgMarker *FromLast = Src->getMarker(Last); if (LastIsEnd) { - Dest->adoptDbgRecords(Src, Last, true); - // ado

[llvm-branch-commits] [llvm] release/19.x: [RemoveDIs] Fix spliceDebugInfo splice-to-end edge case (#105671, #106723) (PR #106952)

@@ -975,8 +975,16 @@ void BasicBlock::spliceDebugInfoImpl(BasicBlock::iterator Dest, BasicBlock *Src, if (ReadFromTail && Src->getMarker(Last)) { DbgMarker *FromLast = Src->getMarker(Last); if (LastIsEnd) { - Dest->adoptDbgRecords(Src, Last, true); - // ado

[llvm-branch-commits] [llvm] release/19.x: [RemoveDIs] Fix spliceDebugInfo splice-to-end edge case (#105671, #106723) (PR #106952)

@@ -975,8 +975,16 @@ void BasicBlock::spliceDebugInfoImpl(BasicBlock::iterator Dest, BasicBlock *Src, if (ReadFromTail && Src->getMarker(Last)) { DbgMarker *FromLast = Src->getMarker(Last); if (LastIsEnd) { - Dest->adoptDbgRecords(Src, Last, true); - // ado

[llvm-branch-commits] [llvm] release/19.x: [RemoveDIs] Fix spliceDebugInfo splice-to-end edge case (#105671, #106723) (PR #106952)

https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/106952 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/19.x: [RemoveDIs] Fix spliceDebugInfo splice-to-end edge case (#105671, #106723) (PR #106952)

OCHyams wrote: @tru just a note, I got confused about the release timelines and I mistakenly said this wasn't a regression (it is a regression from LLVM 18 as it is in in LLVM 19 that we turned on the feature that triggers the issue this patch fixes). I've updated my initial reply. https://gi

[llvm-branch-commits] [llvm] [NFC][KeyInstr] Add Atom Group (re)mapping (PR #133479)

https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/133479 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [KeyInstr][Inline] Don't propagate atoms to inlined nodebug instructions (PR #133485)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/133485?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [llvm] [KeyInstr][SimplifyCFG] Remap atoms when folding br to common succ into pred (PR #133482)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/133482?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [llvm] [KeyInstr][LoopRotate] Remap atoms of duplicated instructions (PR #133490)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/133490 None >From 20a853373f9105f54a973b6d933a8010edaf316a Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Wed, 26 Mar 2025 16:03:41 + Subject: [PATCH] [KeyInstr][LoopRotate] Remap atoms of duplicated i

[llvm-branch-commits] [llvm] [KeyInstr][DwarfDebug] Add is_stmt emission support (PR #133495)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/133495?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [clang] [Clang][NFC] Move some static functions into CodeGenFunction (PR #134634)

OCHyams wrote: Thanks for the review. Landed in https://github.com/llvm/llvm-project/commit/308654608cb8bc5bbd5d4b3779cb7d92920dd6b7 (sorry for the additional noise, I'm still getting to grips with Graphite, plus this patch isn't actually dependant on its parent in the stack). https://github.

[llvm-branch-commits] [clang] [Clang][NFC] Move some static functions into CodeGenFunction (PR #134634)

https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/134634 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [KeyInstr] Add Atom Group waterline to LLVMContext (PR #133478)

OCHyams wrote: > Possibly part of the design here is to simply not care, if it's only about > internal consistency within a Function (does that hold after inlining too). > Apologies if this is all explained in a later patch. It is indeed the goal not to care; an instruction is only considered

[llvm-branch-commits] [llvm] [KeyInstr] Merge atoms in DILocation::getMergedLocation (PR #133480)

@@ -226,8 +230,44 @@ DILocation *DILocation::getMergedLocation(DILocation *LocA, DILocation *LocB) { bool SameCol = L1->getColumn() == L2->getColumn(); unsigned Line = SameLine ? L1->getLine() : 0; unsigned Col = SameLine && SameCol ? L1->getColumn() : 0; - -re

[llvm-branch-commits] [llvm] [KeyInstr] Add Atom Group waterline to LLVMContext (PR #133478)

@@ -67,6 +67,9 @@ DILocation::DILocation(LLVMContext &C, StorageType Storage, unsigned Line, #ifdef EXPERIMENTAL_KEY_INSTRUCTIONS assert(AtomRank <= 7 && "AtomRank number should fit in 3 bits"); #endif + if (AtomRank) OCHyams wrote: note to self: should be

[llvm-branch-commits] [llvm] [KeyInstr][debugify] Add --debugify-atoms to add key instructions metadata (PR #133483)

https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/133483 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [KeyInstr][SimplifyCFG] Remap atoms after duplication for threading (PR #133484)

https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/133484 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [KeyInstr][JumpThreading] Remap atoms duping bb with cond br on phi into pred (PR #133488)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/133488?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [llvm] [KeyInstr][LoopUnroll] Remap atoms while unrolling (PR #133489)

https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/133489 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [KeyInstr][JumpThreading] Remap atoms after threading (PR #133487)

https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/133487 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [KeyInstr][debugify] Add --debugify-atoms to add key instructions metadata (PR #133483)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/133483 None >From b848c421338a93c1d031f3038f81b538eac33aab Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Mon, 24 Mar 2025 15:53:27 + Subject: [PATCH] [KeyInstr][debugify] Add --debugify-atoms to add k

[llvm-branch-commits] [llvm] Propagate DebugLocs on phis in BreakCriticalEdges (PR #133492)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/133492?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [llvm] Propagate DebugLocs on phis in BreakCriticalEdges (PR #133492)

https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/133492 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [KeyInstr] Add Atom Group waterline to LLVMContext (PR #133478)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/133478 The waterline is managed through DILocation creation, LLVMContext::incNextAtomGroup, and LLVMContext::updateAtomGroupWaterline. Add unittest. >From d12e993d5e22cae5c6eeb7088eedbf8e3ec2cb98 Mon Sep 17 00:00:00 2

[llvm-branch-commits] [llvm] [KeyInstr][SimplifyCFG] Remap atoms after duplication for threading (PR #133484)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/133484 Given the same branch condition in `a` and `c` SimplifyCFG converts: +> b -+ | v --> a --> c --> e --> | ^ +> d -+ into: +--> bcd ---+ | v

[llvm-branch-commits] [llvm] [KeyInstr][JumpThreading] Remap atoms in blocks duplicated for threading (PR #133486)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/133486?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [llvm] [KeyInstr][LoopUnswitch] Remap cloned instructions' atoms (PR #133491)

https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/133491 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [KeyInstr][JumpThreading] Remap atoms after threading (PR #133487)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/133487 None >From 272f806606513125115f0a81db25159d16f83de8 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Tue, 25 Mar 2025 11:56:08 + Subject: [PATCH] [KeyInstr][JumpThreading] Remap atoms after thread

[llvm-branch-commits] [llvm] [KeyInstr][SimplifyCFG] Remap atoms after duplication for threading (PR #133484)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/133484?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [llvm] [KeyInstr] Merge atoms in DILocation::getMergedLocation (PR #133480)

https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/133480 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [KeyInstr][DwarfDebug] Add is_stmt emission support (PR #133495)

https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/133495 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [KeyInstr] Add MIR parser support (PR #133494)

https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/133494 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [KeyInstr] Inline atom info (PR #133481)

https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/133481 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [KeyInstr][JumpThreading] Remap atoms duping bb with cond br on phi into pred (PR #133488)

https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/133488 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [KeyInstr][JumpThreading] Remap atoms in blocks duplicated for threading (PR #133486)

https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/133486 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [KeyInstr] Add Atom Group waterline to LLVMContext (PR #133478)

https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/133478 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [KeyInstr][JumpThreading] Remap atoms in blocks duplicated for threading (PR #133486)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/133486 None >From 3cc84e5c3d83c804332d4b7f9ad8057ddf906902 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Tue, 25 Mar 2025 09:51:43 + Subject: [PATCH] [KeyInstr][JumpThreading] Remap atoms in blocks du

[llvm-branch-commits] [llvm] [KeyInstr][SimplifyCFG] Remap atoms when folding br to common succ into pred (PR #133482)

https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/133482 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [KeyInstr][Clang] While stmt atom (PR #134645)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/134645 See test comment for possible future improvement. This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "q

[llvm-branch-commits] [clang] [KeyInstr][Clang] Add ApplyAtomGroup (PR #134632)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134632?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [clang] [KeyInstr] Complex assignment atoms (PR #134638)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/134638 This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "quick summary" section at the top which adds context

[llvm-branch-commits] [clang] [KeyInstr][Clang] Assignment atom group (PR #134637)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/134637 [KeyInstr][Clang] Assignment atom group This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "quick summa

[llvm-branch-commits] [clang] [KeyInstr][Clang] Scalar init atom (PR #134633)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/134633 This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "quick summary" section at the top which adds context

[llvm-branch-commits] [clang] [KeyInstr][Clang] Assign vector element atom (PR #134649)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/134649 This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "quick summary" section at the top which adds context

[llvm-branch-commits] [clang] [KeyInstr][Clang] Member initalization atom (PR #134640)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134640?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [clang] [KeyInstr][Clang] Assign matrix element atom (PR #134650)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/134650 This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "quick summary" section at the top which adds context

[llvm-branch-commits] [clang] [KeyInstr][Clang] If stmt atom (PR #134642)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134642?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [clang] [KeyInstr][Clang] Scalar init atom (PR #134633)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134633?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [clang] [Clang][NFC] Move some static functions into CodeGenFunction (PR #134634)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134634?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [clang] [KeyInstr][Clang] Coerced store atoms (PR #134653)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/134653 [KeyInstr][Clang] Coerced store atoms This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "quick summary

[llvm-branch-commits] [clang] [Clang][NFC] Move some static functions into CodeGenFunction (PR #134634)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/134634 The next patch in the stack needs to access CGF in these functions. 2 CGF fields are passed to these functions already; at this point it felt natural to promote them to CGF methods. >From a644c795b12da626627c1d4

[llvm-branch-commits] [clang] [KeyInstr][Clang] Add ApplyAtomGroup (PR #134632)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/134632 This is a scoped helper similar to ApplyDebugLocation that creates a new source atom group which instructions can be added to. A source atom is a source construct that is "interesting" for debug stepping purpose

[llvm-branch-commits] [clang] [KeyInstr][Clang] Aggregate init + copy (PR #134639)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/134639 [KeyInstr][Clang] Aggregate init + copy This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "quick summa

[llvm-branch-commits] [clang] [KeyInstr][Clang] Agg init atom (PR #134635)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134635?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [clang] [KeyInstr][Clang] Aggregate init + copy (PR #134639)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134639?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [clang] [KeyInstr][Clang] Agg init atom (PR #134635)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/134635 [KeyInstr][Clang] Agg init atom This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "quick summary" sect

[llvm-branch-commits] [clang] [KeyInstr][Clang] Member initalization atom (PR #134640)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/134640 This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "quick summary" section at the top which adds context

[llvm-branch-commits] [clang] [KeyInstr][Clang] Static variable init atom (PR #134636)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/134636 This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "quick summary" section at the top which adds context

[llvm-branch-commits] [clang] [KeyInstr][Clang] Switch stmt atom (PR #134643)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/134643 This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "quick summary" section at the top which adds context

[llvm-branch-commits] [clang] [KeyInstr][Clang] If stmt atom (PR #134642)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/134642 This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "quick summary" section at the top which adds context

[llvm-branch-commits] [clang] [KeyInstr][Clang] Do stmt atom (PR #134644)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/134644 See test comment for possible future improvement. This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "q

[llvm-branch-commits] [clang] [KeyInstr][Clang] Bitfield atom (PR #134648)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/134648 This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "quick summary" section at the top which adds context

[llvm-branch-commits] [clang] [KeyInstr][Clang] Catch variable init atom (PR #134641)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/134641 This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "quick summary" section at the top which adds context

[llvm-branch-commits] [clang] [KeyInstr][Clang] Ret atom (PR #134652)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/134652 [KeyInstr][Clang] Ret atom This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "quick summary" section a

[llvm-branch-commits] [clang] [KeyInstr][Clang] For stmt atom (PR #134646)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/134646 This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "quick summary" section at the top which adds context

[llvm-branch-commits] [clang] [KeyInstr][Clang] For stmt atom (PR #134646)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134646?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [clang] [KeyInstr][Clang] Bitfield atom (PR #134648)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134648?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [clang] [KeyIntsr][Clang] Builtins alloca auto-init atom (PR #134651)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134651?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [clang] [KeyInstr][Clang] Assignment atom group (PR #134637)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134637?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [clang] [NFC][KeyInstr][Clang] Add some additional tests (PR #134654)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/134654 This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "quick summary" section at the top which adds context

[llvm-branch-commits] [clang] [KeyInstr][Clang] Assign vector element atom (PR #134649)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134649?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [clang] [KeyInstr][Clang] Assign matrix element atom (PR #134650)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134650?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [clang] [KeyInstr][Clang] Switch stmt atom (PR #134643)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134643?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [clang] [KeyInstr][Clang] Catch variable init atom (PR #134641)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134641?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [clang] [KeyInstr][Clang] Coerced store atoms (PR #134653)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134653?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [clang] [KeyInstr][Clang] Do stmt atom (PR #134644)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134644?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [clang] [NFC][KeyInstr][Clang] Add some additional tests (PR #134654)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134654?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [clang] [KeyInstr][Clang] Ret atom (PR #134652)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134652?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [clang] [KeyInstr] Complex assignment atoms (PR #134638)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134638?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [clang] [KeyInstr][Clang] Static variable init atom (PR #134636)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134636?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [clang] [KeyInstr][Clang] For range stmt atoms (PR #134647)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134647?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [clang] [KeyInstr][Clang] While stmt atom (PR #134645)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134645?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [clang] [KeyInstr][Clang] Add Clang option -g[no-]key-instructions (PR #134627)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/134627 This needs to be driver level to pass an -mllvm flag to LLVM. Keep the flag help-hidden as the feature is under development. --- This patch is part of a stack that teaches Clang to generate Key Instructions me

[llvm-branch-commits] [clang] [KeyInstr][Clang] Add Clang option -g[no-]key-instructions (PR #134627)

OCHyams wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134627?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [clang] [KeyInstr][Clang] Add Clang option -g[no-]key-instructions (PR #134627)

https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/134627 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [KeyInstr][SimplifyCFG] Remap atoms when folding br to common succ into pred (PR #133482)

https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/133482 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [KeyInstr][SimplifyCFG] Remap atoms when folding br to common succ into pred (PR #133482)

@@ -1129,13 +1130,17 @@ static void cloneInstructionsIntoPredecessorBlockAndUpdateSSAUses( Instruction *NewBonusInst = BonusInst.clone(); -if (!isa(BonusInst) && -PTI->getDebugLoc() != NewBonusInst->getDebugLoc()) { - // Unless the instruction has the sa

[llvm-branch-commits] [clang] [KeyInstr][Clang] For range stmt atoms (PR #134647)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/134647 This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "quick summary" section at the top which adds context

[llvm-branch-commits] [clang] [KeyIntsr][Clang] Builtins alloca auto-init atom (PR #134651)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/134651 [KeyIntsr][Clang] Builtins alloca auto-init atom This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "qu

  1   2   3   >