Meinersbur wrote:
Moving this PR out of the chain causes merge conflicts further down, making
maintaining consistency of the series even more difficult. At least the change
`std::optional` to `optional.h` is needed or I cannot compile it with nvcc (I
am not sure how you do). I understand that
jeanPerier wrote:
@Meinersbur, is it possible to move this patch outside of the chain for the
runtime change?
While your patch has a rational and relates to the runtime, I do not think it
is needed functionally for the runtime cmake/project change and could be
discussed later so that you can
Meinersbur wrote:
`FortranSupport` has just been introduced in #122894.
https://github.com/llvm/llvm-project/pull/122069
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch
https://github.com/jplehr approved this pull request.
I did not find issues when running this through a couple of configurations I
typically use.
https://github.com/llvm/llvm-project/pull/122069
___
llvm-branch-commits mailing list
llvm-branch-commits
Meinersbur wrote:
Source compiled for the runtime has different requirements than the source
compiled into the compiler. Any source that is not not used in the runtime yet
will probably be incompatible with the runtime requirements. Even if it does,
there is no reason to enforce runtime requir
klausler wrote:
There's an implicit assumption here that either future runtime work won't
occur, or won't need anything from Common that you're moving away into the new
compiler-only directory.
Is this change required for your work that restructures the runtime builds?
https://github.com/llvm
https://github.com/jhuber6 approved this pull request.
Seems reasonable to me
https://github.com/llvm/llvm-project/pull/122069
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-
https://github.com/Meinersbur ready_for_review
https://github.com/llvm/llvm-project/pull/122069
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff a08aa48fb4955f9d16c6172580505c100076b5d4
2023940bffc9c717e44266134b4f63f04f65f762 --e
