https://github.com/yxsamliu approved this pull request.
https://github.com/llvm/llvm-project/pull/122138
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/yxsamliu approved this pull request.
The intention was to make the interface more flexible in cases that a target
may want to do some arithmetic directly based on target address space instead
of an addrspacecast inst. However, so many years have passed and no target was
doin
https://github.com/yxsamliu approved this pull request.
LGTM.
Does this mean device library have no code depending on option
`-cl-denorms-are-zero`?
https://github.com/llvm/llvm-project/pull/134805
___
llvm-branch-commits mailing list
llvm-branch-com
yxsamliu wrote:
> > Clang adds !amdgpu.no.fine.grained.memory and !amdgpu.no.remote.memory to
> > any atomic instructions by default. I think this behavior is expected to
> > keep ISA unchanged compared to the ISA before these metatadat were
> > introduced. Did I miss anything?
>
> All of the
yxsamliu wrote:
> @yxsamliu (or anyone else). If you would like to add a note about this fix in
> the release notes (completely optional). Please reply to this comment with a
> one or two sentence description of the fix. When you are done, please add the
> release:note label to this PR.
Fixed
https://github.com/yxsamliu updated
https://github.com/llvm/llvm-project/pull/130126
>From 64ecdf75962cb0e849ee2d39eca900329d3cc745 Mon Sep 17 00:00:00 2001
From: "Yaxun (Sam) Liu"
Date: Fri, 28 Feb 2025 09:58:19 -0500
Subject: [PATCH] [CUDA][HIP] fix virtual dtor host/device attr (#128926)
Wh
yxsamliu wrote:
@tstellar Is this PR the right procedure for c-p a fix to LLVM release branch?
Thanks.
https://github.com/llvm/llvm-project/pull/130126
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-
https://github.com/yxsamliu created
https://github.com/llvm/llvm-project/pull/130126
When inferring host device attr of virtual dtor of explicit template class
instantiation, clang should be conservative. This guarantees dtors that may
call host functions not to have implicit device attr, ther
https://github.com/yxsamliu edited
https://github.com/llvm/llvm-project/pull/130126
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
yxsamliu wrote:
how about assuming the strict triple format first, this will make the generic
GPU arch work with strict triple.
If the first assumption fails, then fall back to the legacy parsing, that is,
assuming no '-' in GPU arch and split at the right most '-'. This way, the old
target I
yxsamliu wrote:
> > > Still, I think it is possible to make it generic with minor assumption.
> > > Let's say you are now about to parsing the final part of the target ID
> > > string which may be either "env-cpu" or "cpu" without env.
> >
> >
> > This is not actually the issue. The issue is
yxsamliu wrote:
> > Still, I think it is possible to make it generic with minor assumption.
> > Let's say you are now about to parsing the final part of the target ID
> > string which may be either "env-cpu" or "cpu" without env.
>
> This is not actually the issue. The issue is when the cpu is
yxsamliu wrote:
> First of all, I don't think it can fix the issue in a robust way. Second,
> `generic` is already a valid target/cpu/offload target.
>
> Unless we do something like, if the last part is `generic`, we keep looking
> forward until we can construct a valid target. That has no dif
yxsamliu wrote:
> Somewhere for the linker wrapper I just checked if the triple was recognized,
> you could probably just take strings after the `-` until it stops working.
+1
It would be bad user experience to break existing app. It would be low risk to
have env+cpu to be a valid cpu. So you
=?utf-8?q?Micha=C5=82_G=C3=B3rny?=
Message-ID:
In-Reply-To:
https://github.com/yxsamliu approved this pull request.
https://github.com/llvm/llvm-project/pull/121755
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://list
https://github.com/yxsamliu approved this pull request.
https://github.com/llvm/llvm-project/pull/112411
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/yxsamliu approved this pull request.
https://github.com/llvm/llvm-project/pull/97050
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/yxsamliu approved this pull request.
https://github.com/llvm/llvm-project/pull/96876
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/yxsamliu approved this pull request.
https://github.com/llvm/llvm-project/pull/101698
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -106,106 +100,6 @@ define <2 x half> @flat_atomic_fadd_v2f16_rtn(ptr %ptr,
<2 x half> %data) {
ret <2 x half> %ret
}
-define amdgpu_kernel void @flat_atomic_fadd_v2bf16_noret(ptr %ptr, <2 x i16>
%data) {
-; GFX940-LABEL: flat_atomic_fadd_v2bf16_noret:
-; GFX940: ;
yxsamliu wrote:
I thought this PR will merge to main branch, but it only merges to my own
branch. I have to open another PR to merge it to main branch.
https://github.com/llvm/llvm-project/pull/98544
___
llvm-branch-commits mailing list
llvm-branch-co
https://github.com/yxsamliu closed
https://github.com/llvm/llvm-project/pull/98544
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
yxsamliu wrote:
> Looks like this patch includes #98543. You may want to exclude it from the
> pull request.
done
https://github.com/llvm/llvm-project/pull/98544
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.ll
https://github.com/yxsamliu edited
https://github.com/llvm/llvm-project/pull/98544
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -49,7 +49,7 @@ void test_s_wait_event_export_ready() {
}
// CHECK-LABEL: @test_global_add_f32
-// CHECK: {{.*}}call{{.*}} float
@llvm.amdgcn.global.atomic.fadd.f32.p1.f32(ptr addrspace(1) %{{.*}}, float
%{{.*}})
+// CHECK: = atomicrmw fadd ptr addrspace(1) %addr, float %x
@@ -788,6 +788,14 @@ def FeatureFlatAtomicFaddF32Inst
"Has flat_atomic_add_f32 instruction"
>;
+def FeatureAgentScopeFineGrainedRemoteMemoryAtomics
+ : SubtargetFeature<"agent-scope-fine-grained-remote-memory-atomics",
+ "HasAgentScopeFineGrainedRemoteMemoryAtomics",
+ "t
yxsamliu wrote:
need some tests
https://github.com/llvm/llvm-project/pull/96442
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
yxsamliu wrote:
If a sub target does not have this feature, does none of the atomic
instructions work for fine-grained remote memory, including integer atomic
add/xchg/cmpxchg?
https://github.com/llvm/llvm-project/pull/96442
___
llvm-branch-commits m
@@ -117,13 +117,44 @@ void test_update_dpp(global int* out, int arg1, int arg2)
}
// CHECK-LABEL: @test_ds_fadd
-// CHECK: {{.*}}call{{.*}} float @llvm.amdgcn.ds.fadd.f32(ptr addrspace(3)
%out, float %src, i32 0, i32 0, i1 false)
+// CHECK: atomicrmw fadd ptr addrspace(3) %ou
https://github.com/yxsamliu approved this pull request.
https://github.com/llvm/llvm-project/pull/80716
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
Author: Yaxun (Sam) Liu
Date: 2023-11-22T21:20:53-05:00
New Revision: 6b3470b4b83195aeeda60b101e8d3bf8800c321c
URL:
https://github.com/llvm/llvm-project/commit/6b3470b4b83195aeeda60b101e8d3bf8800c321c
DIFF:
https://github.com/llvm/llvm-project/commit/6b3470b4b83195aeeda60b101e8d3bf8800c321c.dif
Author: Yaxun (Sam) Liu
Date: 2023-11-22T21:04:55-05:00
New Revision: 22078bd9f6842411aac2b75196975d68a817a358
URL:
https://github.com/llvm/llvm-project/commit/22078bd9f6842411aac2b75196975d68a817a358
DIFF:
https://github.com/llvm/llvm-project/commit/22078bd9f6842411aac2b75196975d68a817a358.dif
Author: Yaxun (Sam) Liu
Date: 2023-11-22T21:20:53-05:00
New Revision: 6b3470b4b83195aeeda60b101e8d3bf8800c321c
URL:
https://github.com/llvm/llvm-project/commit/6b3470b4b83195aeeda60b101e8d3bf8800c321c
DIFF:
https://github.com/llvm/llvm-project/commit/6b3470b4b83195aeeda60b101e8d3bf8800c321c.dif
Author: Yaxun (Sam) Liu
Date: 2023-11-22T21:04:55-05:00
New Revision: 22078bd9f6842411aac2b75196975d68a817a358
URL:
https://github.com/llvm/llvm-project/commit/22078bd9f6842411aac2b75196975d68a817a358
DIFF:
https://github.com/llvm/llvm-project/commit/22078bd9f6842411aac2b75196975d68a817a358.dif
Author: Yaxun (Sam) Liu
Date: 2023-11-22T21:20:53-05:00
New Revision: 6b3470b4b83195aeeda60b101e8d3bf8800c321c
URL:
https://github.com/llvm/llvm-project/commit/6b3470b4b83195aeeda60b101e8d3bf8800c321c
DIFF:
https://github.com/llvm/llvm-project/commit/6b3470b4b83195aeeda60b101e8d3bf8800c321c.dif
Author: Yaxun (Sam) Liu
Date: 2023-11-22T21:04:55-05:00
New Revision: 22078bd9f6842411aac2b75196975d68a817a358
URL:
https://github.com/llvm/llvm-project/commit/22078bd9f6842411aac2b75196975d68a817a358
DIFF:
https://github.com/llvm/llvm-project/commit/22078bd9f6842411aac2b75196975d68a817a358.dif
Author: Yaxun (Sam) Liu
Date: 2022-02-07T10:00:54-05:00
New Revision: 02d5b112138e7e9f30dec685afb380c1b9593a84
URL:
https://github.com/llvm/llvm-project/commit/02d5b112138e7e9f30dec685afb380c1b9593a84
DIFF:
https://github.com/llvm/llvm-project/commit/02d5b112138e7e9f30dec685afb380c1b9593a84.dif
Author: Yaxun (Sam) Liu
Date: 2021-01-22T11:43:58-05:00
New Revision: 622eaa4a4cea17c2cec6942d9702b010deae392b
URL:
https://github.com/llvm/llvm-project/commit/622eaa4a4cea17c2cec6942d9702b010deae392b
DIFF:
https://github.com/llvm/llvm-project/commit/622eaa4a4cea17c2cec6942d9702b010deae392b.dif
Author: Yaxun (Sam) Liu
Date: 2021-01-06T16:23:01-05:00
New Revision: 90bf3ecef4bb1e214a718aebcee730c24199c8ba
URL:
https://github.com/llvm/llvm-project/commit/90bf3ecef4bb1e214a718aebcee730c24199c8ba
DIFF:
https://github.com/llvm/llvm-project/commit/90bf3ecef4bb1e214a718aebcee730c24199c8ba.dif
Author: Yaxun (Sam) Liu
Date: 2020-12-16T14:52:39-05:00
New Revision: b9fb063e63c7959e8bc9b424bd34b266ca826826
URL:
https://github.com/llvm/llvm-project/commit/b9fb063e63c7959e8bc9b424bd34b266ca826826
DIFF:
https://github.com/llvm/llvm-project/commit/b9fb063e63c7959e8bc9b424bd34b266ca826826.dif
Author: Yaxun (Sam) Liu
Date: 2020-12-15T22:14:18-05:00
New Revision: 4f14b80803a458209b6b11daa3ec05076b8c4973
URL:
https://github.com/llvm/llvm-project/commit/4f14b80803a458209b6b11daa3ec05076b8c4973
DIFF:
https://github.com/llvm/llvm-project/commit/4f14b80803a458209b6b11daa3ec05076b8c4973.dif
Author: Yaxun (Sam) Liu
Date: 2020-12-07T19:50:21-05:00
New Revision: efc063b621ea0c4d1e452bcade62f7fc7e1cc937
URL:
https://github.com/llvm/llvm-project/commit/efc063b621ea0c4d1e452bcade62f7fc7e1cc937
DIFF:
https://github.com/llvm/llvm-project/commit/efc063b621ea0c4d1e452bcade62f7fc7e1cc937.dif
Author: Yaxun (Sam) Liu
Date: 2020-12-07T18:08:37-05:00
New Revision: 0b81d9a992579ef55b0781c9bc678aa1f3133e9e
URL:
https://github.com/llvm/llvm-project/commit/0b81d9a992579ef55b0781c9bc678aa1f3133e9e
DIFF:
https://github.com/llvm/llvm-project/commit/0b81d9a992579ef55b0781c9bc678aa1f3133e9e.dif
Author: Yaxun (Sam) Liu
Date: 2020-12-07T18:08:37-05:00
New Revision: 5cae70800266119bbf319675a175cba9a7f315b1
URL:
https://github.com/llvm/llvm-project/commit/5cae70800266119bbf319675a175cba9a7f315b1
DIFF:
https://github.com/llvm/llvm-project/commit/5cae70800266119bbf319675a175cba9a7f315b1.dif
Author: Yaxun (Sam) Liu
Date: 2020-12-07T18:08:37-05:00
New Revision: 4bed1d9b32b19f786aed17865e08c966962513cd
URL:
https://github.com/llvm/llvm-project/commit/4bed1d9b32b19f786aed17865e08c966962513cd
DIFF:
https://github.com/llvm/llvm-project/commit/4bed1d9b32b19f786aed17865e08c966962513cd.dif
Author: Yaxun (Sam) Liu
Date: 2020-12-07T18:05:47-05:00
New Revision: 40ad476a32445ec98666adcf24d2b33fd887ccc6
URL:
https://github.com/llvm/llvm-project/commit/40ad476a32445ec98666adcf24d2b33fd887ccc6
DIFF:
https://github.com/llvm/llvm-project/commit/40ad476a32445ec98666adcf24d2b33fd887ccc6.dif
Author: Yaxun (Sam) Liu
Date: 2020-12-04T08:36:52-05:00
New Revision: 0519e1ddb3885d070f054ca30a7487f915f6f795
URL:
https://github.com/llvm/llvm-project/commit/0519e1ddb3885d070f054ca30a7487f915f6f795
DIFF:
https://github.com/llvm/llvm-project/commit/0519e1ddb3885d070f054ca30a7487f915f6f795.dif
Author: Yaxun (Sam) Liu
Date: 2020-12-02T19:10:01-05:00
New Revision: 3a781b912fc7b492a21fe52cc8ce6c9e5854a9ab
URL:
https://github.com/llvm/llvm-project/commit/3a781b912fc7b492a21fe52cc8ce6c9e5854a9ab
DIFF:
https://github.com/llvm/llvm-project/commit/3a781b912fc7b492a21fe52cc8ce6c9e5854a9ab.dif
Author: Yaxun (Sam) Liu
Date: 2020-12-02T16:33:33-05:00
New Revision: acb6f80d96b74af3ec515bb9811d213abb406c31
URL:
https://github.com/llvm/llvm-project/commit/acb6f80d96b74af3ec515bb9811d213abb406c31
DIFF:
https://github.com/llvm/llvm-project/commit/acb6f80d96b74af3ec515bb9811d213abb406c31.dif
Author: Yaxun (Sam) Liu
Date: 2020-12-02T10:15:56-05:00
New Revision: 5c8911d0ba3862119d2507aa55b94766263be13b
URL:
https://github.com/llvm/llvm-project/commit/5c8911d0ba3862119d2507aa55b94766263be13b
DIFF:
https://github.com/llvm/llvm-project/commit/5c8911d0ba3862119d2507aa55b94766263be13b.dif
Author: Yaxun (Sam) Liu
Date: 2020-12-02T10:14:46-05:00
New Revision: cd95338ee3022bffd658e52cd3eb9419b4c218ca
URL:
https://github.com/llvm/llvm-project/commit/cd95338ee3022bffd658e52cd3eb9419b4c218ca
DIFF:
https://github.com/llvm/llvm-project/commit/cd95338ee3022bffd658e52cd3eb9419b4c218ca.dif
Author: Yaxun (Sam) Liu
Date: 2020-11-30T22:31:16-05:00
New Revision: 011bf4f55630858111e5f0504b3f7390eaf41e09
URL:
https://github.com/llvm/llvm-project/commit/011bf4f55630858111e5f0504b3f7390eaf41e09
DIFF:
https://github.com/llvm/llvm-project/commit/011bf4f55630858111e5f0504b3f7390eaf41e09.dif
52 matches
Mail list logo
