[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

2023-12-26 Thread Will Hawkins via llvm-branch-commits
hawkinsw wrote: > > > > If you are okay with the suggestions that I made for some typos in the > > > > documentation, I will preemptively incorporate it into my documentation > > > > PR. > > > > > > > > > Thanks for the suggestions! Please do no incorporate these in your PR. > > > Other revi

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

2023-12-23 Thread Will Hawkins via llvm-branch-commits
hawkinsw wrote: > > If you are okay with the suggestions that I made for some typos in the > > documentation, I will preemptively incorporate it into my documentation PR. > > Thanks for the suggestions! Please do no incorporate these in your PR. Other > reviewers may have other suggestions whi

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

2023-12-22 Thread Will Hawkins via llvm-branch-commits
https://github.com/hawkinsw commented: If you are okay with the suggestions that I made for some typos in the documentation, I will preemptively incorporate it into my documentation PR. I really like how you integrated module testing so nicely. I hope my comments are helpful! https://github.

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

2023-12-22 Thread Will Hawkins via llvm-branch-commits
@@ -131,13 +138,62 @@ def parseScript(test, preamble): script += preamble script += scriptInTest +has_std_module = False +has_std_compat_module = False +for module in modules: +if module == "std": +has_std_module = True +elif mod

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

2023-12-22 Thread Will Hawkins via llvm-branch-commits
https://github.com/hawkinsw edited https://github.com/llvm/llvm-project/pull/76246 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

2023-12-22 Thread Will Hawkins via llvm-branch-commits
@@ -131,13 +138,62 @@ def parseScript(test, preamble): script += preamble script += scriptInTest +has_std_module = False +has_std_compat_module = False +for module in modules: +if module == "std": +has_std_module = True +elif mod

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

2023-12-22 Thread Will Hawkins via llvm-branch-commits
@@ -223,6 +280,12 @@ class CxxStandardLibraryTest(lit.formats.FileBasedTest): allows adding special compilation flags without having to use a .sh.cpp test, which would be more powerful but perhaps overkill. +// MODULE: std std.compat + +

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

2023-12-22 Thread Will Hawkins via llvm-branch-commits
@@ -223,6 +280,12 @@ class CxxStandardLibraryTest(lit.formats.FileBasedTest): allows adding special compilation flags without having to use a .sh.cpp test, which would be more powerful but perhaps overkill. +// MODULE: std std.compat + +