[llvm-branch-commits] [CI] Use Github Native Groups in monolithic-* scripts (PR #143481)

https://github.com/Endilll approved this pull request. It would be nice to give them properly formatted names (e.g. `Ninja Runtimes (Clang modules)`), because when I wrote them, the context I expected them to be seen was local editor with lengthy log file opened. Now it's going to be in UI. ht

[llvm-branch-commits] [llvm] [CI] Migrate to runtimes build (PR #142696)

@@ -49,8 +49,7 @@ }, "lld": {"bolt", "cross-project-tests"}, # TODO(issues/132795): LLDB should be enabled on clang changes. -"clang": {"clang-tools-extra", "compiler-rt", "cross-project-tests"}, -"clang-tools-extra": {"libc"}, Endilll wrote

[llvm-branch-commits] [CI] Use LLVM_ENABLE_RUNTIMES for runtimes builds on Linux (PR #142694)

https://github.com/Endilll approved this pull request. https://github.com/llvm/llvm-project/pull/142694 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [CI] Migrate to runtimes build (PR #142696)

Endilll wrote: > > It doesn't relate to multilib, I understand that, but does it mean we're > > going to test more than one runtime or that we'll test the same runtime > > multiple ways? > > It's runtimes that we test in multiple ways (`-std=c++26` and > `enable_modules=clang` currently). I f

[llvm-branch-commits] [CI] Use LLVM_ENABLE_RUNTIMES for runtimes builds on Linux (PR #142694)

https://github.com/Endilll commented: > We're using LLVM_ENABLE_RUNTIMES. It uses the just built clang to build the > runtimes specified. That explains it, thank you. There's still an outstanding question of unrelated changes to libc++ tests that are included in this PR. https://github.com/ll

[llvm-branch-commits] [CI] Use LLVM_ENABLE_RUNTIMES for runtimes builds on Linux (PR #142694)

Endilll wrote: I just opened 9e3490b51f85d1aff3978dc32aadde4531363774 in my local git, and yes, all libc++ changes are there alongside changes to `monolithic-linux.sh` that we're interested in https://github.com/llvm/llvm-project/pull/142694 ___ llvm

[llvm-branch-commits] [CI] Use LLVM_ENABLE_RUNTIMES for runtimes builds on Linux (PR #142694)

Endilll wrote: > I'm not sure how you're seeing this.   https://github.com/llvm/llvm-project/pull/142694 ___

[llvm-branch-commits] [CI] Use LLVM_ENABLE_RUNTIMES for runtimes builds on Linux (PR #142694)

https://github.com/Endilll commented: Something feels wrong with this PR: 1) There's a "full changes here" button on the Files Changed tab, which shows me a bunch of changes to libc++ tests adding `#include ` 2) In the new version, I don't see `LLVM_ENABLE_RUTIMES` passed to cmake. Not even `CM

[llvm-branch-commits] [clang] [clang-tools-extra] [clang] improve class type sugar preservation in pointers to members (PR #130537)

https://github.com/Endilll commented: Changes to C++ DR tests look good. > FIXME: why diagnostic says just `Y` and not `cwg794::Y`, like `cwg794::X`? This FIXME resolved in the opposite direction I anticipated back when I wrote it, but that's fine, as long as we print both types in a consistent

[llvm-branch-commits] [clang] [clang] Implement instantiation context note for checking template parameters (PR #126088)

@@ -1018,9 +1019,9 @@ namespace cwg62 { // cwg62: 2.9 struct A { struct { int n; } b; }; - template struct X {}; - template T get() { return get(); } - template int take(T) { return 0; } + template struct X {}; // cxx98-note 6{{template parameter is declared here}}

[llvm-branch-commits] [clang] [clang] Implement instantiation context note for checking template parameters (PR #126088)

@@ -1018,9 +1019,9 @@ namespace cwg62 { // cwg62: 2.9 struct A { struct { int n; } b; }; - template struct X {}; - template T get() { return get(); } - template int take(T) { return 0; } + template struct X {}; // cxx98-note 6{{template parameter is declared here}}

[llvm-branch-commits] [clang] release/20.x: [clang] Handle f(no-)strict-overflow, f(no-)wrapv, f(no-)wrapv-pointer like gcc (#126524) (PR #126535)

Endilll wrote: @nico I think that the release note from #122486 doesn't cover changes in this PR. Can you expand existing release notes or add another one, which explains how we handle combination of those driver arguments? https://github.com/llvm/llvm-project/pull/126535 _

[llvm-branch-commits] [clang] [clang] Implement instantiation context note for checking template parameters (PR #126088)

@@ -637,6 +641,8 @@ namespace cwg431 { // cwg431: 2.8 namespace cwg432 { // cwg432: 3.0 template struct A {}; + // expected-note@-1{{template parameter is declared here}} + // since-cxx11-note@-2 {{template parameter is declared here}} Endilll wrote:

[llvm-branch-commits] [clang] [clang] Implement instantiation context note for checking template parameters (PR #126088)

@@ -1018,9 +1019,9 @@ namespace cwg62 { // cwg62: 2.9 struct A { struct { int n; } b; }; - template struct X {}; - template T get() { return get(); } - template int take(T) { return 0; } + template struct X {}; // cxx98-note 6{{template parameter is declared here}}

[llvm-branch-commits] [clang] [clang] Implement instantiation context note for checking template parameters (PR #126088)

@@ -318,6 +318,7 @@ namespace cwg319 { // cwg319: no pa parr; // ok, type has linkage despite using 'n1' template struct X {}; + // cxx98-note@-1 2{{template parameter is declared here}} Endilll wrote: Those two notes should go to their respective errors

[llvm-branch-commits] [clang] [clang] Implement instantiation context note for checking template parameters (PR #126088)

https://github.com/Endilll commented: Good job following the way expected directives are written in C++ DR tests, but I have to ask you to fix the remaining discrepancies to keep them consistent. I also spotted the same note emitted twice for the same line. That seems unfortunate. https://git

[llvm-branch-commits] [clang] [clang] Implement instantiation context note for checking template parameters (PR #126088)

@@ -637,6 +641,8 @@ namespace cwg431 { // cwg431: 2.8 namespace cwg432 { // cwg432: 3.0 template struct A {}; + // expected-note@-1{{template parameter is declared here}} + // since-cxx11-note@-2 {{template parameter is declared here}} Endilll wrote:

[llvm-branch-commits] [clang] [clang] Implement instantiation context note for checking template parameters (PR #126088)

@@ -1503,6 +1505,7 @@ namespace cwg389 { // cwg389: no typedef enum {} const D; // #cwg389-D }; template struct T {}; + // cxx98-note@-1 5{{template parameter is declared here}} Endilll wrote: Those, too, should go to their respective errors https://

[llvm-branch-commits] [clang] [clang] Implement instantiation context note for checking template parameters (PR #126088)

@@ -637,6 +641,8 @@ namespace cwg431 { // cwg431: 2.8 namespace cwg432 { // cwg432: 3.0 template struct A {}; + // expected-note@-1{{template parameter is declared here}} + // since-cxx11-note@-2 {{template parameter is declared here}} Endilll wrote:

[llvm-branch-commits] [clang] [clang] Implement instantiation context note for checking template parameters (PR #126088)

https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/126088 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang] Implement instantiation context note for checking template parameters (PR #126088)

@@ -83,6 +83,7 @@ namespace cwg603 { // cwg603: 3.1 typedef S<'\001'> S1; typedef S<(1ul << __CHAR_BIT__) + 1> S1; // since-cxx11-error@-1 {{non-type template argument evaluates to 257, which cannot be narrowed to type 'unsigned char'}} + // since-cxx11-note@-4 {{temp

[llvm-branch-commits] [clang] release/19.x: [libclang] Fix symbol version of `getBinaryOpcode` functions (#101820) (PR #101824)

https://github.com/Endilll approved this pull request. I don't consider this critical, but I can see this becoming a source of confusion for a long time. https://github.com/llvm/llvm-project/pull/101824 ___ llvm-branch-commits mailing list llvm-branch

[llvm-branch-commits] [clang] [llvm] release/19.x: [clang] Fix definition of layout-compatible to ignore empty classes (PR #101491)

Endilll wrote: This should only affect `__builtin_is_layout_compatible` introduced in Clang 19, so we don't have an ABI we need to be compatible with. https://github.com/llvm/llvm-project/pull/101491 ___ llvm-branch-commits mailing list llvm-branch-co

[llvm-branch-commits] [clang] [Clang] Add a release note deprecating __is_nullptr (PR #101638)

https://github.com/Endilll approved this pull request. https://github.com/llvm/llvm-project/pull/101638 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [Clang] Add a release note deprecating __is_nullptr (PR #101638)

https://github.com/Endilll milestoned https://github.com/llvm/llvm-project/pull/101638 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [llvm] release/19.x: [clang] Fix definition of layout-compatible to ignore empty classes (PR #101491)

https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/101491 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [llvm] release/19.x: [clang] Fix definition of layout-compatible to ignore empty classes (PR #101491)

https://github.com/Endilll milestoned https://github.com/llvm/llvm-project/pull/101491 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [llvm] release/19.x: [clang] Fix definition of layout-compatible to ignore empty classes (PR #101491)

https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/101491 Backport of #92103, as suggested by me and Aaron Ballman in https://github.com/llvm/llvm-project/pull/92103#discussion_r1699172578 and https://github.com/llvm/llvm-project/pull/92103#discussion_r1699982348 res

[llvm-branch-commits] [clang] release/19.x: [clang][Sema] Add support for OpenBSD's syslog format attribute (#97366) (PR #100703)

Endilll wrote: I'm not sure we want to backport a feature this late. I also don't see any discussion of this being critical for 19 in #97366 https://github.com/llvm/llvm-project/pull/100703 ___ llvm-branch-commits mailing list llvm-branch-commits@lists

[llvm-branch-commits] [clang] release/19.x: [clang] Remove `__is_layout_compatible` from revertible type traits list (#100572) (PR #100590)

Endilll wrote: Release note for `__is_layout_compatible` is already present. This change in particular is not worth a release note. https://github.com/llvm/llvm-project/pull/100590 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.or

[llvm-branch-commits] [clang] [clang] Finish implementation of P0522 (PR #96023)

https://github.com/Endilll commented: `Sema.h` changes look good. https://github.com/llvm/llvm-project/pull/96023 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commit

[llvm-branch-commits] [clang] [clang] Implement pointer authentication for C++ virtual functions, v-tables, and VTTs (PR #94056)

Endilll wrote: @asl It would be nice if you submit the next round of review as a single review, instead of 29 individual comments. https://github.com/llvm/llvm-project/pull/94056 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [clang] [clang] Implement pointer authentication for C++ virtual functions, v-tables, and VTTs (PR #94056)

https://github.com/Endilll commented: `Sema.h` changes look good. https://github.com/llvm/llvm-project/pull/94056 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commit

[llvm-branch-commits] [clang] [libcxx] [clang] fix printing of canonical template template parameters take 2 (PR #93448)

https://github.com/Endilll commented: Changes to `Sema.h` and DR test suite look good. https://github.com/llvm/llvm-project/pull/93448 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[llvm-branch-commits] [clang] [libcxx] [clang] Preserve Qualifiers and type sugar in TemplateNames (PR #93433)

https://github.com/Endilll commented: `Sema.h` changes look good to me. https://github.com/llvm/llvm-project/pull/93433 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-

[llvm-branch-commits] [clang] [libcxx] [clang] Preserve Qualifiers and type sugar in TemplateNames (PR #93433)

https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/93433 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang-tools-extra] [clang] NFCI: use TemplateArgumentLoc for type-param DefaultArgument (PR #92854)

https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/92854 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang-tools-extra] [clang] NFCI: use TemplateArgumentLoc for type-param DefaultArgument (PR #92854)

https://github.com/Endilll commented: LGTM, but you should wait for someone with more knowledge of our templates. https://github.com/llvm/llvm-project/pull/92854 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm

[llvm-branch-commits] [clang] [clang-tools-extra] [clang] NFCI: use TemplateArgumentLoc for type-param DefaultArgument (PR #92854)

@@ -10082,7 +10082,9 @@ class Sema final : public SemaBase { bool SubstTemplateArgument(const TemplateArgumentLoc &Input, const MultiLevelTemplateArgumentList &TemplateArgs, - TemplateArgumentLoc &Output); +

[llvm-branch-commits] [clang] [clang-tools-extra] [clang] NFCI: use TemplateArgumentLoc for type-param DefaultArgument (PR #92854)

https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/92854 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang-tools-extra] [clang] NFCI: use TemplateArgumentLoc for type-param DefaultArgument (PR #92854)

https://github.com/Endilll commented: It looks like you have two sets of changes here: 1) the ones related to `TemplateTypeParmDecl::getDefaultArgument()` 2) the ones related to `Sema::SubstTemplateArgument()` You don't seem to touch the latter in PR description. It would be nice if you can expl

[llvm-branch-commits] [clang] [clang-tools-extra] [clang] NFCI: use TemplateArgumentLoc for type-param DefaultArgument (PR #92854)

@@ -10082,7 +10082,9 @@ class Sema final : public SemaBase { bool SubstTemplateArgument(const TemplateArgumentLoc &Input, const MultiLevelTemplateArgumentList &TemplateArgs, - TemplateArgumentLoc &Output); +

[llvm-branch-commits] [clang] [clang-tools-extra] [clang] NFCI: use TemplateArgumentLoc for type-param DefaultArgument (PR #92854)

https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/92854 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang] Revise IDE folder structure (PR #89743)

Endilll wrote: CC @AaronBallman https://github.com/llvm/llvm-project/pull/89743 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [clang] PR for llvm/llvm-project#79762 (PR #79763)

https://github.com/Endilll approved this pull request. Changes to DR tests look good to me. https://github.com/llvm/llvm-project/pull/79763 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l