[llvm-branch-commits] [clang] Add documentation for Multilib custom flags (PR #114998)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/114998 >From 7fd397e918ba2663c7342bc1653c9ccbc5be9d96 Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Tue, 5 Nov 2024 14:22:06 + Subject: [PATCH 1/4] Add documentation for Multilib custom flags --- clang/doc

[llvm-branch-commits] [clang] [Multilib] Custom flags processing for library selection (PR #110659)

https://github.com/vhscampos edited https://github.com/llvm/llvm-project/pull/110659 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [Multilib] Custom flags processing for library selection (PR #110659)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/110659 >From 2fe418964fff9e03861650afb89a81ac80f1413d Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Thu, 26 Sep 2024 14:44:33 +0100 Subject: [PATCH 1/6] [Multilib] Custom flags processing for library selection

[llvm-branch-commits] [clang] [Multilib] Custom flags processing for library selection (PR #110659)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/110659 >From 2fe418964fff9e03861650afb89a81ac80f1413d Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Thu, 26 Sep 2024 14:44:33 +0100 Subject: [PATCH 1/5] [Multilib] Custom flags processing for library selection

[llvm-branch-commits] [clang] [Multilib] Custom flags processing for library selection (PR #110659)

@@ -92,12 +93,141 @@ MultilibSet &MultilibSet::FilterOut(FilterCallback F) { void MultilibSet::push_back(const Multilib &M) { Multilibs.push_back(M); } -bool MultilibSet::select(const Driver &D, const Multilib::flags_list &Flags, - llvm::SmallVectorImp

[llvm-branch-commits] [clang] Add documentation for Multilib custom flags (PR #114998)

@@ -122,6 +122,76 @@ subclass and a suitable base multilib variant is present then the It is the responsibility of layered multilib authors to ensure that headers and libraries in each layer are complete enough to mask any incompatibilities. +Multilib custom flags +==

[llvm-branch-commits] [clang] Add documentation for Multilib custom flags (PR #114998)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/114998 >From 9fcdd1760ea664a618a2c05a18e777940a9d49b6 Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Tue, 5 Nov 2024 14:22:06 + Subject: [PATCH 1/4] Add documentation for Multilib custom flags --- clang/doc

[llvm-branch-commits] [clang] Add documentation for Multilib custom flags (PR #114998)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/114998 >From 9fcdd1760ea664a618a2c05a18e777940a9d49b6 Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Tue, 5 Nov 2024 14:22:06 + Subject: [PATCH 1/3] Add documentation for Multilib custom flags --- clang/doc

[llvm-branch-commits] [clang] [Multilib] Custom flags processing for library selection (PR #110659)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/110659 >From 2fe418964fff9e03861650afb89a81ac80f1413d Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Thu, 26 Sep 2024 14:44:33 +0100 Subject: [PATCH 1/4] [Multilib] Custom flags processing for library selection

[llvm-branch-commits] [clang] [Multilib] Add -fmultilib-flag command-line option (PR #110658)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/110658 >From 17265b1f8b175acda38e225b044cadcc845666ff Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Thu, 26 Sep 2024 14:44:01 +0100 Subject: [PATCH] [Multilib] Add -fmultilib-flag command-line option This optio

[llvm-branch-commits] [clang] [Multilib] Custom flags processing for library selection (PR #110659)

https://github.com/vhscampos edited https://github.com/llvm/llvm-project/pull/110659 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [Multilib] Custom flags processing for library selection (PR #110659)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/110659 >From 96e089e5b075cf5376109cae6eadea9b4b9a054d Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Mon, 9 Dec 2024 09:36:52 + Subject: [PATCH 1/6] Change in specification: DriverArgs now MacroDefines We've

[llvm-branch-commits] [clang] Add documentation for Multilib custom flags (PR #114998)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/114998 >From 6f607d96dfc02223ab22fa743796a5af6c14e3f1 Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Tue, 5 Nov 2024 14:22:06 + Subject: [PATCH 1/3] Add documentation for Multilib custom flags --- clang/doc

[llvm-branch-commits] [clang] [Multilib] Add -fmultilib-flag command-line option (PR #110658)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/110658 >From c0bb75d7ba6292a0267d71026324164a11910ce8 Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Thu, 26 Sep 2024 14:44:01 +0100 Subject: [PATCH] [Multilib] Add -fmultilib-flag command-line option This optio

[llvm-branch-commits] [clang] Add documentation for Multilib custom flags (PR #114998)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/114998 >From be0d5d6ee15e22b78a6fe671dc4f665680fd2aa5 Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Tue, 5 Nov 2024 14:22:06 + Subject: [PATCH 1/2] Add documentation for Multilib custom flags --- clang/doc

[llvm-branch-commits] [clang] [Multilib] Custom flags processing for library selection (PR #110659)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/110659 >From b2de2588d108fa19a957a1525a63d522dee93769 Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Thu, 26 Sep 2024 14:44:33 +0100 Subject: [PATCH 1/3] [Multilib] Custom flags processing for library selection

[llvm-branch-commits] [clang] Add documentation for Multilib custom flags (PR #114998)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/114998 >From 1e4516b64005507d4e778847c7a3d5ec0b4b0fe1 Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Tue, 5 Nov 2024 14:22:06 + Subject: [PATCH 1/2] Add documentation for Multilib custom flags --- clang/doc

[llvm-branch-commits] [clang] [Multilib] Custom flags processing for library selection (PR #110659)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/110659 >From b2de2588d108fa19a957a1525a63d522dee93769 Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Thu, 26 Sep 2024 14:44:33 +0100 Subject: [PATCH 1/2] [Multilib] Custom flags processing for library selection

[llvm-branch-commits] [clang] [Multilib] Add -fmultilib-flag command-line option (PR #110658)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/110658 >From 7b8f0d9a968eba4d85cf1d6a4ebc93f5e6dfbd2b Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Thu, 26 Sep 2024 14:44:01 +0100 Subject: [PATCH] [Multilib] Add -fmultilib-flag command-line option This optio

[llvm-branch-commits] [clang] Add documentation for Multilib custom flags (PR #114998)

https://github.com/vhscampos edited https://github.com/llvm/llvm-project/pull/114998 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [Multilib] Custom flags processing for library selection (PR #110659)

https://github.com/vhscampos edited https://github.com/llvm/llvm-project/pull/110659 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [Multilib] Custom flags processing for library selection (PR #110659)

https://github.com/vhscampos edited https://github.com/llvm/llvm-project/pull/110659 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [Multilib] Add -fmultilib-flag command-line option (PR #110658)

https://github.com/vhscampos edited https://github.com/llvm/llvm-project/pull/110658 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [Multilib] Custom flags processing for library selection (PR #110659)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/110659 >From b2de2588d108fa19a957a1525a63d522dee93769 Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Thu, 26 Sep 2024 14:44:33 +0100 Subject: [PATCH] [Multilib] Custom flags processing for library selection Sele

[llvm-branch-commits] [clang] Add documentation for Multilib custom flags (PR #114998)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/114998 >From 391e7c9a0236b71caaa7db699ee8becaefec5cfd Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Tue, 5 Nov 2024 14:22:06 + Subject: [PATCH] Add documentation for Multilib custom flags --- clang/docs/Mu

[llvm-branch-commits] [clang] [Multilib] Custom flags processing for library selection (PR #110659)

vhscampos wrote: FYI I added a test for `-print-multi-lib` and its interaction with `ExtraBuildArgs`. https://github.com/llvm/llvm-project/pull/110659 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[llvm-branch-commits] [clang] [Multilib] Custom flags processing for library selection (PR #110659)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/110659 >From f2525efdd1f70c59923220b787be005903bdced5 Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Thu, 26 Sep 2024 14:44:33 +0100 Subject: [PATCH 1/3] [Multilib] Custom flags processing for library selection

[llvm-branch-commits] [clang] Add documentation for Multilib custom flags (PR #114998)

https://github.com/vhscampos created https://github.com/llvm/llvm-project/pull/114998 None >From 02161c1c4754b15450ae81538c22b77501a809ca Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Tue, 5 Nov 2024 14:22:06 + Subject: [PATCH] Add documentation for Multilib custom flags --- clang/d

[llvm-branch-commits] [clang] [Multilib] Custom flags processing for library selection (PR #110659)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/110659 >From f2525efdd1f70c59923220b787be005903bdced5 Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Thu, 26 Sep 2024 14:44:33 +0100 Subject: [PATCH 1/2] [Multilib] Custom flags processing for library selection

[llvm-branch-commits] [clang] [Multilib] Custom flags processing for library selection (PR #110659)

@@ -95,9 +96,113 @@ MultilibSet &MultilibSet::FilterOut(FilterCallback F) { void MultilibSet::push_back(const Multilib &M) { Multilibs.push_back(M); } +static void WarnUnclaimedMultilibCustomFlags( +const Driver &D, const SmallVector &UnclaimedCustomFlagValues, +const

[llvm-branch-commits] [clang] [Multilib] Custom flags processing for library selection (PR #110659)

@@ -14,6 +14,12 @@ def err_drv_no_such_file_with_suggestion : Error< def err_drv_unsupported_opt : Error<"unsupported option '%0'">; def err_drv_unsupported_opt_with_suggestion : Error< "unsupported option '%0'; did you mean '%1'?">; +def warn_drv_unsupported_opt : Warning< +

[llvm-branch-commits] [clang] [Multilib] Custom flags processing for library selection (PR #110659)

https://github.com/vhscampos edited https://github.com/llvm/llvm-project/pull/110659 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [Multilib] Custom flags processing for library selection (PR #110659)

@@ -95,9 +96,113 @@ MultilibSet &MultilibSet::FilterOut(FilterCallback F) { void MultilibSet::push_back(const Multilib &M) { Multilibs.push_back(M); } +static void WarnUnclaimedMultilibCustomFlags( +const Driver &D, const SmallVector &UnclaimedCustomFlagValues, +const

[llvm-branch-commits] [clang] [Multilib] Add -fmultilib-flag command-line option (PR #110658)

@@ -196,6 +196,16 @@ bool ToolChain::defaultToIEEELongDouble() const { return PPC_LINUX_DEFAULT_IEEELONGDOUBLE && getTriple().isOSLinux(); } +static void +processARMAArch64MultilibCustomFlags(Multilib::flags_list &List, vhscampos wrote: Fixed https://githu

[llvm-branch-commits] [clang] [Multilib] Add -fmultilib-flag command-line option (PR #110658)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/110658 >From 4f85ea57b021362f2a1bff12f720c8991093 Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Thu, 26 Sep 2024 14:44:01 +0100 Subject: [PATCH 1/2] [Multilib] Add -fmultilib-flag command-line option This o

[llvm-branch-commits] [clang] [Multilib] Add -fmultilib-flag command-line option (PR #110658)

https://github.com/vhscampos ready_for_review https://github.com/llvm/llvm-project/pull/110658 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [Multilib] Custom flags processing for library selection (PR #110659)

https://github.com/vhscampos ready_for_review https://github.com/llvm/llvm-project/pull/110659 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [Multilib] Add -fmultilib-flag command-line option (PR #110658)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/110658 >From 829fad54c1b1ee204633e4c1d7dcef3657c179cd Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Thu, 26 Sep 2024 14:44:01 +0100 Subject: [PATCH] [Multilib] Add -fmultilib-flag command-line option This optio

[llvm-branch-commits] [clang] [Multilib] Custom flags processing for library selection (PR #110659)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/110659 >From 838993d1fa75688a91a5734ed7a6bd379da9f6e3 Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Thu, 26 Sep 2024 14:44:33 +0100 Subject: [PATCH] [Multilib] Custom flags processing for library selection Sele

[llvm-branch-commits] [clang] [Multilib] Add -fmultilib-flag command-line option (PR #110658)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/110658 >From 002079817c4d849973941795bb4d19bd822112d5 Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Thu, 26 Sep 2024 14:44:01 +0100 Subject: [PATCH] [Multilib] Add -fmultilib-flag command-line option This optio

[llvm-branch-commits] [clang] [Multilib] Custom flags processing for library selection (PR #110659)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/110659 >From 1d394d0cbfb4a47d77f466b265671d0c13ebbb3b Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Thu, 26 Sep 2024 14:44:33 +0100 Subject: [PATCH] [Multilib] Custom flags processing for library selection Sele

[llvm-branch-commits] [llvm] [ADT] Add more useful methods to SmallSet API (PR #108601)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/108601 >From 12b657a4761351d52fccb93ce52e64c3c1b1e91f Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Fri, 9 Aug 2024 14:00:32 +0100 Subject: [PATCH 1/3] [ADT] Add more useful methods to SmallSet API This patch a

[llvm-branch-commits] [llvm] [ADT] Add more useful methods to SmallSet API (PR #108601)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/108601 >From 12b657a4761351d52fccb93ce52e64c3c1b1e91f Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Fri, 9 Aug 2024 14:00:32 +0100 Subject: [PATCH 1/2] [ADT] Add more useful methods to SmallSet API This patch a

[llvm-branch-commits] [llvm] [ADT] Add more useful methods to SmallSet API (PR #108601)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/108601 >From 12b657a4761351d52fccb93ce52e64c3c1b1e91f Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Fri, 9 Aug 2024 14:00:32 +0100 Subject: [PATCH] [ADT] Add more useful methods to SmallSet API This patch adds

[llvm-branch-commits] [llvm] [ADT] Use perfect forwarding in SmallSet::insert() (PR #108590)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/108590 >From 964abdd8e2c5d9089b831ad242452cb83605db3a Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Fri, 9 Aug 2024 13:57:42 +0100 Subject: [PATCH 1/3] [ADT] Use perfect forwarding in SmallSet::insert() Previou

[llvm-branch-commits] [llvm] [ADT] Add more useful methods to SmallSet API (PR #108601)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/108601 >From d05069198321f3bab9de7db65f48f3c2b15b34bc Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Fri, 9 Aug 2024 14:00:32 +0100 Subject: [PATCH 1/2] [ADT] Add more useful methods to SmallSet API This patch a

[llvm-branch-commits] [llvm] [ADT] Use range-based helper functions in SmallSet (PR #108585)

vhscampos wrote: New PR: https://github.com/llvm/llvm-project/pull/109412 https://github.com/llvm/llvm-project/pull/108585 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bran

[llvm-branch-commits] [llvm] [ADT] Use perfect forwarding in SmallSet::insert() (PR #108590)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/108590 >From a2438ce9a61d8e80aa32fa58ca5368a64deacd52 Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Fri, 9 Aug 2024 13:56:31 +0100 Subject: [PATCH 1/4] [ADT] Use range-based helper functions in SmallSet Replace

[llvm-branch-commits] [llvm] [ADT] Use perfect forwarding in SmallSet::insert() (PR #108590)

https://github.com/vhscampos edited https://github.com/llvm/llvm-project/pull/108590 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [llvm] [ADT] Simplify SmallSet (PR #109412)

https://github.com/vhscampos created https://github.com/llvm/llvm-project/pull/109412 - Remove dependence on `STLExtras.h`. - Remove unused header inclusions. - Make `count` use `contains` for deduplication. - Replace hand-written linear scans on Vector by `std::find`. >From 3d83c5456c35f891aef

[llvm-branch-commits] [llvm] [ADT] Use range-based helper functions in SmallSet (PR #108585)

vhscampos wrote: Given that this change isn't exactly agreeable, I plan to change it to a PR to make SmallSet not use `STLExtras.h` at all. https://github.com/llvm/llvm-project/pull/108585 ___ llvm-branch-commits mailing list llvm-branch-commits@lists

[llvm-branch-commits] [llvm] [ADT] Use perfect forwarding in SmallSet::insert() (PR #108590)

https://github.com/vhscampos updated https://github.com/llvm/llvm-project/pull/108590 >From e0295a14694c5bba65a873914eb700b201e94b6a Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Fri, 9 Aug 2024 13:57:42 +0100 Subject: [PATCH 1/3] [ADT] Use perfect forwarding in SmallSet::insert() Previou

[llvm-branch-commits] [llvm] [ADT] Use range-based helper functions in SmallSet (PR #108585)

@@ -234,19 +225,12 @@ class SmallSet { /// Check if the SmallSet contains the given element. bool contains(const T &V) const { if (isSmall()) - return vfind(V) != Vector.end(); -return Set.find(V) != Set.end(); + return llvm::is_contained(Vector, V); +

[llvm-branch-commits] [llvm] [ADT] Use range-based helper functions in SmallSet (PR #108585)

@@ -234,19 +225,12 @@ class SmallSet { /// Check if the SmallSet contains the given element. bool contains(const T &V) const { if (isSmall()) - return vfind(V) != Vector.end(); -return Set.find(V) != Set.end(); + return llvm::is_contained(Vector, V); +

[llvm-branch-commits] [llvm] [ADT] Use range-based helper functions in SmallSet (PR #108585)

vhscampos wrote: > I'm slightly opposed to this change because it pulls in STLExtras.h. Yes, it > is already included, but it would be better to avoid including it. Why is including `STLExtras.h` a problem? https://github.com/llvm/llvm-project/pull/108585 __

[llvm-branch-commits] [llvm] [ADT] Add more useful methods to SmallSet API (PR #108601)

https://github.com/vhscampos created https://github.com/llvm/llvm-project/pull/108601 This patch adds useful methods to the SmallSet API: - Constructor that takes pair of iterators. - Constructor that takes a range. - Constructor that takes an initializer list. - Copy constructor. - Move c

[llvm-branch-commits] [llvm] [ADT] Use range-based helper functions in SmallSet (PR #108585)

https://github.com/vhscampos created https://github.com/llvm/llvm-project/pull/108585 Replace code that relies on iterators by LLVM helper functions that take ranges. This makes the code simpler and more readable. >From a2438ce9a61d8e80aa32fa58ca5368a64deacd52 Mon Sep 17 00:00:00 2001 From: Vi

[llvm-branch-commits] [llvm] 7996b49 - Revert "[ARM] Improve codegen of volatile load/store of i64"

Author: Victor Campos Date: 2020-02-08T13:36:47Z New Revision: 7996b49053f0508717f4a081d197ddc3073f4b5f URL: https://github.com/llvm/llvm-project/commit/7996b49053f0508717f4a081d197ddc3073f4b5f DIFF: https://github.com/llvm/llvm-project/commit/7996b49053f0508717f4a081d197ddc3073f4b5f.diff LOG: