https://github.com/shafik approved this pull request.
IIUC correctly this will just be backporting what the new behavior will be to
help downstream. I think it makes sense to me. Thank you for explaining.
https://github.com/llvm/llvm-project/pull/137806
_
https://github.com/shafik commented:
The summary should also explain the problem being fixed and how exactly this
fixes the problem. The motivation for backporting is not clear to me from what
is provided.
https://github.com/llvm/llvm-project/pull/137806
___
shafik wrote:
> This is great, @hahnjo. We need this to unbreak llvm20 for downstream
> clients. LGTM!
Is there a bug report for this, I would like to understand how this is breaking
someone? IF there is not one, can we please file one.
Thank you
https://github.com/llvm/llvm-project/pull/13
@@ -265,14 +265,14 @@ int k9 = f9(V9());
// CHECK-ELIDE-TREE: S9<
// CHECK-ELIDE-TREE: [2 * ...],
// CHECK-ELIDE-TREE: U9<
-// CHECK-ELIDE-TREE: [(no qualifiers) != const] double>>
shafik wrote:
It is not obvious why this changed, can you expla
@@ -315,9 +315,9 @@ std::vector
HeuristicResolverImpl::resolveMemberExpr(
std::vector
HeuristicResolverImpl::resolveDeclRefExpr(const DependentScopeDeclRefExpr *RE)
{
- return resolveDependentMember(
- resolveNestedNameSpecifierToType(RE->getQualifier()), RE->getDeclNa
@@ -80,7 +80,7 @@ void test2() {
// CHECK-ELIDE-TREE: candidate function not viable: no known conversion from
argument type to parameter type for 1st argument
// CHECK-ELIDE-TREE: I2<
// CHECK-ELIDE-TREE: [double != int],
-// CHECK-ELIDE-TREE: [...],
---
https://github.com/shafik approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/131853
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/shafik commented:
Thank you for backporting these changes!
https://github.com/llvm/llvm-project/pull/130658
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-
Author: Shafik Yaghmour
Date: 2021-01-22T10:05:24-08:00
New Revision: dc057e87f6c18c24d17c7cae97ebe95f78b6d934
URL:
https://github.com/llvm/llvm-project/commit/dc057e87f6c18c24d17c7cae97ebe95f78b6d934
DIFF:
https://github.com/llvm/llvm-project/commit/dc057e87f6c18c24d17c7cae97ebe95f78b6d934.dif