[llvm-branch-commits] [llvm] [AMDGPU] Remove dead function metadata after amdgpu-lower-kernel-arguments (PR #126147)

2025-02-10 Thread Scott Linder via llvm-branch-commits
https://github.com/slinder1 updated https://github.com/llvm/llvm-project/pull/126147 >From de86a2987ca66eafe5767e149ebc561c0c70158d Mon Sep 17 00:00:00 2001 From: Scott Linder Date: Wed, 5 Feb 2025 22:56:55 + Subject: [PATCH 1/2] [AMDGPU] Remove dead function metadata after amdgpu-lower-ke

[llvm-branch-commits] [llvm] [AMDGPU] Push amdgpu-preload-kern-arg-prolog after livedebugvalues (PR #126148)

2025-02-10 Thread Scott Linder via llvm-branch-commits
https://github.com/slinder1 updated https://github.com/llvm/llvm-project/pull/126148 >From 5862e3249531359f66ae911fa42c7a69514a82ac Mon Sep 17 00:00:00 2001 From: Scott Linder Date: Thu, 6 Feb 2025 00:01:07 + Subject: [PATCH] [AMDGPU] Push amdgpu-preload-kern-arg-prolog after livedebugvalu

[llvm-branch-commits] [llvm] [AMDGPU] Remove dead function metadata after amdgpu-lower-kernel-arguments (PR #126147)

2025-02-07 Thread Scott Linder via llvm-branch-commits
@@ -1,7 +1,7 @@ -; RUN: not --crash opt -mtriple=amdgcn-amd-amdhsa -mcpu=gfx940 -passes='amdgpu-attributor,function(amdgpu-lower-kernel-arguments)' -amdgpu-kernarg-preload-count=16 -S < %s 2>&1 | FileCheck %s +; RUN: opt -mtriple=amdgcn-amd-amdhsa -mcpu=gfx940 -passes='amdgpu-a

[llvm-branch-commits] [llvm] [AMDGPU] Remove dead function metadata after amdgpu-lower-kernel-arguments (PR #126147)

2025-02-07 Thread Scott Linder via llvm-branch-commits
@@ -1,7 +1,7 @@ -; RUN: not --crash opt -mtriple=amdgcn-amd-amdhsa -mcpu=gfx940 -passes='amdgpu-attributor,function(amdgpu-lower-kernel-arguments)' -amdgpu-kernarg-preload-count=16 -S < %s 2>&1 | FileCheck %s +; RUN: opt -mtriple=amdgcn-amd-amdhsa -mcpu=gfx940 -passes='amdgpu-a

[llvm-branch-commits] [llvm] [AMDGPU] Remove dead function metadata after amdgpu-lower-kernel-arguments (PR #126147)

2025-02-07 Thread Scott Linder via llvm-branch-commits
@@ -132,6 +132,7 @@ class PreloadKernelArgInfo { NF->setAttributes(AL); F.replaceAllUsesWith(NF); F.setCallingConv(CallingConv::C); +F.clearMetadata(); slinder1 wrote: I'm a bit lost, isn't any useful metadata already poached by the new functio

[llvm-branch-commits] [llvm] [AMDGPU] Push amdgpu-preload-kern-arg-prolog after livedebugvalues (PR #126148)

2025-02-06 Thread Scott Linder via llvm-branch-commits
https://github.com/slinder1 updated https://github.com/llvm/llvm-project/pull/126148 >From 87d26ba446362f1f50dea05339f5a46c08312f7a Mon Sep 17 00:00:00 2001 From: Scott Linder Date: Thu, 6 Feb 2025 00:01:07 + Subject: [PATCH] [AMDGPU] Push amdgpu-preload-kern-arg-prolog after livedebugvalu

[llvm-branch-commits] [llvm] [AMDGPU] Remove dead function metadata after amdgpu-lower-kernel-arguments (PR #126147)

2025-02-06 Thread Scott Linder via llvm-branch-commits
https://github.com/slinder1 ready_for_review https://github.com/llvm/llvm-project/pull/126147 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [AMDGPU] Push amdgpu-preload-kern-arg-prolog after livedebugvalues (PR #126148)

2025-02-06 Thread Scott Linder via llvm-branch-commits
https://github.com/slinder1 ready_for_review https://github.com/llvm/llvm-project/pull/126148 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [AMDGPU] Remove dead function metadata after amdgpu-lower-kernel-arguments (PR #126147)

2025-02-06 Thread Scott Linder via llvm-branch-commits
slinder1 wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/126147?utm_source=stack-comment-downstack-mergeability-warning"

[llvm-branch-commits] [llvm] [AMDGPU] Push amdgpu-preload-kern-arg-prolog after livedebugvalues (PR #126148)

2025-02-06 Thread Scott Linder via llvm-branch-commits
https://github.com/slinder1 created https://github.com/llvm/llvm-project/pull/126148 This is effectively a workaround for a bug in livedebugvalues, but seems to potentially be a general improvement, as BB sections seems like it could ruin the special 256-byte prelude scheme that amdgpu-preload-k

[llvm-branch-commits] [llvm] [AMDGPU] Push amdgpu-preload-kern-arg-prolog after livedebugvalues (PR #126148)

2025-02-06 Thread Scott Linder via llvm-branch-commits
slinder1 wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/126148?utm_source=stack-comment-downstack-mergeability-warning"

[llvm-branch-commits] [llvm] [AMDGPU] Remove dead function metadata after amdgpu-lower-kernel-arguments (PR #126147)

2025-02-06 Thread Scott Linder via llvm-branch-commits
https://github.com/slinder1 created https://github.com/llvm/llvm-project/pull/126147 The verifier ensures function !dbg metadata is unique across the module, so ensure the old nameless function we leave behind doesn't violate this invariant. Removing the function via e.g. eraseFromParent seems

[llvm-branch-commits] [llvm] [YAMLParser] Unfold multi-line scalar values (PR #70898)

2023-11-09 Thread Scott Linder via llvm-branch-commits
https://github.com/slinder1 approved this pull request. Thank you for breaking out the NFC test changes, and for adding even more unittests! I am again not being meticulous and exhaustive in looking for spec compliance, but in every case I did examine you were fixing a clear issue. I also ran

[llvm-branch-commits] [llvm] [YAMLParser] Fix handling escaped line breaks in double-quoted scalars (PR #71775)

2023-11-09 Thread Scott Linder via llvm-branch-commits
https://github.com/slinder1 approved this pull request. I am not certain I'm reviewing the spec-compliance particularly rigorously, in that I am not certain I have followed every path and confirmed there are tests for every possibility. But clearly what we have now is not compliant in these te

[llvm-branch-commits] [llvm] [NFC][AsmPrinter] Clarify handleNewDebugValue cache of TrackedRegs (PR #71737)

2023-11-08 Thread Scott Linder via llvm-branch-commits
https://github.com/slinder1 created https://github.com/llvm/llvm-project/pull/71737 None ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] 28e8baf - [𝘀𝗽𝗿] initial version

2023-11-08 Thread Scott Linder via llvm-branch-commits
Author: Scott Linder Date: 2023-11-08T21:05:40Z New Revision: 28e8baf03efd7ba43a2af4afb3831caa511880ca URL: https://github.com/llvm/llvm-project/commit/28e8baf03efd7ba43a2af4afb3831caa511880ca DIFF: https://github.com/llvm/llvm-project/commit/28e8baf03efd7ba43a2af4afb3831caa511880ca.diff LOG:

[llvm-branch-commits] [llvm] 30fbba9 - [𝘀𝗽𝗿] initial version

2023-11-08 Thread Scott Linder via llvm-branch-commits
Author: Scott Linder Date: 2023-11-08T21:05:35Z New Revision: 30fbba91ce82b68395b0b527ff0f34d349e6a010 URL: https://github.com/llvm/llvm-project/commit/30fbba91ce82b68395b0b527ff0f34d349e6a010 DIFF: https://github.com/llvm/llvm-project/commit/30fbba91ce82b68395b0b527ff0f34d349e6a010.diff LOG:

[llvm-branch-commits] [clang] c15b0e2 - [Clang][Docs] Fix ambiguity in clang-offload-bundler docs

2021-01-11 Thread Scott Linder via llvm-branch-commits
Author: Scott Linder Date: 2021-01-11T17:23:24Z New Revision: c15b0e2229ea04d1c36fafaa1f717f433a995e9a URL: https://github.com/llvm/llvm-project/commit/c15b0e2229ea04d1c36fafaa1f717f433a995e9a DIFF: https://github.com/llvm/llvm-project/commit/c15b0e2229ea04d1c36fafaa1f717f433a995e9a.diff LOG:

[llvm-branch-commits] [clang] ffba47d - Revert "[AMDGPU][HIP] Switch default DWARF version to 5"

2020-12-21 Thread Scott Linder via llvm-branch-commits
Author: Scott Linder Date: 2020-12-21T21:43:51Z New Revision: ffba47df76460905965df4b54cf6ba945d2eb1ce URL: https://github.com/llvm/llvm-project/commit/ffba47df76460905965df4b54cf6ba945d2eb1ce DIFF: https://github.com/llvm/llvm-project/commit/ffba47df76460905965df4b54cf6ba945d2eb1ce.diff LOG:

[llvm-branch-commits] [llvm] 32910f7 - [SmallVector][NFC] Link to ProgrammersManual from SmallVector docs

2020-12-11 Thread Scott Linder via llvm-branch-commits
Author: Scott Linder Date: 2020-12-11T19:34:10Z New Revision: 32910f780df4f5add290f176459648f2326674f5 URL: https://github.com/llvm/llvm-project/commit/32910f780df4f5add290f176459648f2326674f5 DIFF: https://github.com/llvm/llvm-project/commit/32910f780df4f5add290f176459648f2326674f5.diff LOG:

[llvm-branch-commits] [llvm] 10b5eae - [SmallVector] Copy new docs into Doxygen comment

2020-12-10 Thread Scott Linder via llvm-branch-commits
Author: Scott Linder Date: 2020-12-10T22:20:37Z New Revision: 10b5eaed917d6f91aa2d416c08c93697bd1d446f URL: https://github.com/llvm/llvm-project/commit/10b5eaed917d6f91aa2d416c08c93697bd1d446f DIFF: https://github.com/llvm/llvm-project/commit/10b5eaed917d6f91aa2d416c08c93697bd1d446f.diff LOG:

[llvm-branch-commits] [llvm] 19c56e1 - [MC] Fix ICE with non-newline terminated input

2020-12-09 Thread Scott Linder via llvm-branch-commits
Author: Scott Linder Date: 2020-12-09T23:39:32Z New Revision: 19c56e11fa489cfc461b9ea10faa68e5a1f3eca1 URL: https://github.com/llvm/llvm-project/commit/19c56e11fa489cfc461b9ea10faa68e5a1f3eca1 DIFF: https://github.com/llvm/llvm-project/commit/19c56e11fa489cfc461b9ea10faa68e5a1f3eca1.diff LOG:

[llvm-branch-commits] [llvm] 9260a99 - [MC][AMDGPU] Consume EndOfStatement in asm parser

2020-12-09 Thread Scott Linder via llvm-branch-commits
Author: Scott Linder Date: 2020-12-09T21:45:55Z New Revision: 9260a90cd8ee877e1cb9b517166579eca4f3 URL: https://github.com/llvm/llvm-project/commit/9260a90cd8ee877e1cb9b517166579eca4f3 DIFF: https://github.com/llvm/llvm-project/commit/9260a90cd8ee877e1cb9b517166579eca4f3.diff LOG:

[llvm-branch-commits] [llvm] f5f4b8b - [AMDGPU][MC] Restore old error position for "too few operands"

2020-12-09 Thread Scott Linder via llvm-branch-commits
Author: Scott Linder Date: 2020-12-09T21:09:47Z New Revision: f5f4b8b60fc0931440c4f2549fbff0965c868d2c URL: https://github.com/llvm/llvm-project/commit/f5f4b8b60fc0931440c4f2549fbff0965c868d2c DIFF: https://github.com/llvm/llvm-project/commit/f5f4b8b60fc0931440c4f2549fbff0965c868d2c.diff LOG:

[llvm-branch-commits] [llvm] d55d680 - [MC] Consume EndOfStatement in .cfi_{sections, endproc}

2020-12-04 Thread Scott Linder via llvm-branch-commits
Author: Scott Linder Date: 2020-12-04T22:30:29Z New Revision: d55d6806ad728f76c8721d3fee294545f5833fac URL: https://github.com/llvm/llvm-project/commit/d55d6806ad728f76c8721d3fee294545f5833fac DIFF: https://github.com/llvm/llvm-project/commit/d55d6806ad728f76c8721d3fee294545f5833fac.diff LOG: