owenca wrote:
> So far this is the only slated fix for 19.1.8 - I don't think it's important
> enough to do a release. Let me know if you disagree.
+1.
https://github.com/llvm/llvm-project/pull/123439
___
llvm-branch-commits mailing list
llvm-branch-
owenca wrote:
> can we get a review on this?
I already approved it.
https://github.com/llvm/llvm-project/pull/119503
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-co
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/119503
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/111958
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca edited
https://github.com/llvm/llvm-project/pull/111245
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca edited
https://github.com/llvm/llvm-project/pull/111245
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca milestoned
https://github.com/llvm/llvm-project/pull/111245
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/111245
…110408)
Fixes #109925.
>From 8f516b15b30f7d17f82f958e758e448929c6e9a1 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Wed, 2 Oct 2024 19:06:56 -0700
Subject: [PATCH] [clang-format] Handle template closer followe
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/109170
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
owenca wrote:
> Hi, since we are wrapping up LLVM 19.1.0 we are very strict with the fixes we
> pick at this point. Can you please respond to the following questions to help
> me understand if this has to be included in the final release or not.
>
> Is this PR a fix for a regression or a criti
https://github.com/owenca milestoned
https://github.com/llvm/llvm-project/pull/107531
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
owenca wrote:
@tru, I've created #107531 which reverts
2d90e8f7402b0a8114978b6f014cfe76c96c94a1 and backports #107352.
https://github.com/llvm/llvm-project/pull/107058
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lis
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/107531
This reverts commit 2d90e8f7402b0a8114978b6f014cfe76c96c94a1 and backports
commit 616a8ce6203d8c7569266bfaf163e74df1f440ad.
>From 4d8827c9b63ecbc9de984e19621cafad025e4380 Mon Sep 17 00:00:00 2001
From: Owen Pan
owenca wrote:
Alternatively, we can backport #107352.
https://github.com/llvm/llvm-project/pull/107058
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
owenca wrote:
> @tru, this introduced what looks like a (confirmed) regression, see [#107096
> (comment)](https://github.com/llvm/llvm-project/issues/107096#issuecomment-2326830100).
> Could this be reverted?
I've reverted 0fa78b6c7bd43c2498700a98c47a02cf4fd06388 with
3449ed8dece600f387357b71
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/107058
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/106897
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca milestoned
https://github.com/llvm/llvm-project/pull/106897
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
owenca wrote:
See https://github.com/llvm/llvm-project/pull/106484#issuecomment-2319705402.
https://github.com/llvm/llvm-project/pull/106897
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/106897
See https://github.com/llvm/llvm-project/pull/89706#issuecomment-2315549955.
>From 0b75d0dd80d712c83d6188f931ad18eb6b6c8071 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Sun, 1 Sep 2024 02:46:38 -0700
Subject: [
owenca wrote:
Will do. Sorry about that!
https://github.com/llvm/llvm-project/pull/106482
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
owenca wrote:
@HazardyKnusperkeks @mydeveloperday @rymiel please see
https://github.com/llvm/llvm-project/pull/105923#issuecomment-2316563384.
https://github.com/llvm/llvm-project/pull/106482
___
llvm-branch-commits mailing list
llvm-branch-commits@li
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/106819
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca milestoned
https://github.com/llvm/llvm-project/pull/106482
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/106482
…… (#105923)
…519)"
This reverts commit e00d32afb9d33a1eca48e2b041c9688436706c5b and adds a test
for lambda arrow SplitPenalty.
Fixes #105480.
>From 386f54403a6b38fd14d8e3126fcc46b7e579f575 Mon Sep 17 00:00:0
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/106390
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/106326
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/105971
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/105967
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/105773
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/100499
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
owenca wrote:
> @owenca Do you have a release note we can put in the release announcement?
Release note:
Fixes a clang-format regression (since 17.0.6) on formatting `goto` labels in
macro definitions.
https://github.com/llvm/llvm-project/pull/93494
owenca wrote:
@tstellar thanks!
> @owenca Do you have a release note we can put in the release announcement?
Release note:
Fixes clang-format (since 18.1.1) regressions on breaking before a stream
insertion operator (<<) when both operands are string literals.
https://github.com/llvm/llvm-pro
owenca wrote:
@tstellar strictly speaking, this is a regression fix. (It's a churn within
18.x release cycle.)
1. Risk level: low IMO. (The other code owner @mydeveloperday approved it to be
included in 18.1.7.)
2. Last known working version: 18.1.4
https://github.com/llvm/llvm-project/pull/9
owenca wrote:
@tstellar
> 1. How risky is this fix?
Very low IMO. (@mydeveloperday @HazardyKnusperkeks @rymiel can chime in if
anyone thinks otherwise.)
> 2. When was the last known working version of clang-format?
17.0.6 (regressed since 18.1.1).
https://github.com/llvm/llvm-project/pull/9
owenca wrote:
@tstellar this is a regression fix as labeled by the issue the original
pr/commit fixed. :)
https://github.com/llvm/llvm-project/pull/93494
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cg
owenca wrote:
@tstellar can we also get this one into 18.1.7?
https://github.com/llvm/llvm-project/pull/94091
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca milestoned
https://github.com/llvm/llvm-project/pull/94091
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/94091
…ing literals (#92214)
>From 88711473d2affcb21703e7b4f78420c512192acf Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 31 May 2024 20:13:27 -0700
Subject: [PATCH] release/18.x: [clang-format] Don't always break
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/93494
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
owenca wrote:
@tstellar can we get this one in if we are doing another point release?
https://github.com/llvm/llvm-project/pull/93494
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
owenca wrote:
@HazardyKnusperkeks can you approve it too?
https://github.com/llvm/llvm-project/pull/91049
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/91049
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
owenca wrote:
@tstellar below is the release notes for clang-format 18.1.5.
- Restores clang-format behavior that always breaks before a stream insertion
operator (`<<`) when both operands are string literals.
- Fixes clang-format regressions in annotating initialization list braces and
trailin
Author: Owen Pan
Date: 2024-04-25T08:31:16-07:00
New Revision: 35fea1032741526f76d7fea49794061bf3a1d3ee
URL:
https://github.com/llvm/llvm-project/commit/35fea1032741526f76d7fea49794061bf3a1d3ee
DIFF:
https://github.com/llvm/llvm-project/commit/35fea1032741526f76d7fea49794061bf3a1d3ee.diff
LOG:
owenca wrote:
@tstellar is this still waiting for @HazardyKnusperkeks?
https://github.com/llvm/llvm-project/pull/89415
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-c
owenca wrote:
@tstellar is this waiting for @HazardyKnusperkeks?
https://github.com/llvm/llvm-project/pull/89412
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/89491
>From 35fea1032741526f76d7fea49794061bf3a1d3ee Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 19 Apr 2024 23:20:47 -0700
Subject: [PATCH] release/18.x: [clang-format] Correctly annotate braces in
macros (#879
Author: Owen Pan
Date: 2024-04-24T21:29:46-07:00
New Revision: c0b48372d82aa0adaef671788ee1a37a650ee4fd
URL:
https://github.com/llvm/llvm-project/commit/c0b48372d82aa0adaef671788ee1a37a650ee4fd
DIFF:
https://github.com/llvm/llvm-project/commit/c0b48372d82aa0adaef671788ee1a37a650ee4fd.diff
LOG:
owenca wrote:
> @owenca Can you rebase this branch?
@tstellar I've rebased it.
https://github.com/llvm/llvm-project/pull/89492
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/89492
>From c0b48372d82aa0adaef671788ee1a37a650ee4fd Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 19 Apr 2024 23:58:35 -0700
Subject: [PATCH] release/18.x: [clang-format] Revert breaking stream operators
to previ
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/89415
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/89412
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/89492
…ious default (#89016)
Backport 29ecd6d50f14
>From 7fd5c11287f10fa94f58b4c7aee293d7df17b498 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 19 Apr 2024 23:58:35 -0700
Subject: [PATCH] release/18.x: [clang-for
https://github.com/owenca milestoned
https://github.com/llvm/llvm-project/pull/89492
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca milestoned
https://github.com/llvm/llvm-project/pull/89491
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/89491
…953)
Backport 58323de2e5ed
>From 042f92bcdaed5b4ba1fceddb0c2187df76b51006 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 19 Apr 2024 23:20:47 -0700
Subject: [PATCH] release/18.x: [clang-format] Correctly an
https://github.com/owenca milestoned
https://github.com/llvm/llvm-project/pull/89489
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/89489
…Init (#87450)
Backport 7c9c38eaa9b7
>From 497357a593a65534691091ef155e80d43d51d9c9 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 19 Apr 2024 21:59:29 -0700
Subject: [PATCH] release/18.x: [clang-format] Fix
owenca wrote:
The only bug fix for clang-format is in the change log section of 18.1.4
release notes, so I'm not sure if it's useful to repeat it at the top of the
release notes. For 18.1.5, there will be a reversion of behavior from 18.1.1.
I'll definitely add that to the release notes.
http
owenca wrote:
This is just a bug fix
[requested](https://github.com/llvm/llvm-project/issues/79834#issuecomment-2030179647)
to be cherry picked, so I don't think we need to add a note about it in the
release note.
https://github.com/llvm/llvm-project/pull/87735
___
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/81096
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/81106
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/80593
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
owenca wrote:
> As stated in the discussion, it is an absolutely must to merge it in the
> release. In my opinion we can't just drop an option, for the next release.
Yep! See
https://github.com/llvm/llvm-project/issues/78892#issuecomment-1926009360.
https://github.com/llvm/llvm-project/pull/8
owenca wrote:
@tstellar can you move this PR to Needs Merge? Thanks!
https://github.com/llvm/llvm-project/pull/80259
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-com
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/80259
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/80591
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
owenca wrote:
Replaced with #80593.
https://github.com/llvm/llvm-project/pull/80591
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
69 matches
Mail list logo
