https://github.com/HighCommander4 approved this pull request.
https://github.com/llvm/llvm-project/pull/143344
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/HighCommander4 created
https://github.com/llvm/llvm-project/pull/135927
Backport
https://github.com/llvm/llvm-project/commit/289baf1f42c8b5773271b611cd235d4ab94bb4e8
Fixes https://github.com/llvm/llvm-project/issues/135922
>From a9ea5de20db3ff08d691856e7da5b185d438e228 Mon
https://github.com/HighCommander4 milestoned
https://github.com/llvm/llvm-project/pull/135927
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/HighCommander4 updated
https://github.com/llvm/llvm-project/pull/131074
>From 556926d2644160405958a5d01963714f97ab522e Mon Sep 17 00:00:00 2001
From: Nathan Ridge
Date: Thu, 13 Mar 2025 01:23:03 -0400
Subject: [PATCH] [clang][HeuristicResolver] Default argument heuristic for
@@ -125,6 +126,20 @@ TagDecl
*HeuristicResolverImpl::resolveTypeToTagDecl(QualType QT) {
if (!T)
return nullptr;
+ // If T is the type of a template parameter, we can't get a useful TagDecl
+ // out of it. However, if the template parameter has a default argument,
+
https://github.com/HighCommander4 edited
https://github.com/llvm/llvm-project/pull/132576
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
HighCommander4 wrote:
This is a follow-up to https://github.com/llvm/llvm-project/pull/131074. After
moving the default argument heuristic to `simplifyType` as per [this
discussion](https://github.com/llvm/llvm-project/pull/131074#discussion_r2006918564),
I realized that this made it no longer
https://github.com/HighCommander4 created
https://github.com/llvm/llvm-project/pull/132576
None
>From ea949861a4b03123d7784fe5ef3bc1fe2f3cf2cd Mon Sep 17 00:00:00 2001
From: Nathan Ridge
Date: Sat, 22 Mar 2025 20:54:02 -0400
Subject: [PATCH] [clang][HeuristicResolver] Apply default argument he
HighCommander4 wrote:
(Rebased)
https://github.com/llvm/llvm-project/pull/132576
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/HighCommander4 updated
https://github.com/llvm/llvm-project/pull/132576
>From 2c9fc17bf2ef28c42df472598e4b7d09297cb668 Mon Sep 17 00:00:00 2001
From: Nathan Ridge
Date: Sat, 22 Mar 2025 20:54:02 -0400
Subject: [PATCH] [clang][HeuristicResolver] Apply default argument heuristi
HighCommander4 wrote:
Resubmitted at https://github.com/llvm/llvm-project/pull/132465
https://github.com/llvm/llvm-project/pull/131074
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
HighCommander4 wrote:
> @HighCommander4 did you merge it into a wrong branch?
Oops. I forgot that the patch was stacked on top of another patch for
https://github.com/llvm/llvm-project/issues/130468.
I will resubmit and reland.
https://github.com/llvm/llvm-project/pull/131074
https://github.com/HighCommander4 closed
https://github.com/llvm/llvm-project/pull/131074
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/HighCommander4 updated
https://github.com/llvm/llvm-project/pull/131074
>From 9530a2186f46fa852021a67c17d06085360d5b9c Mon Sep 17 00:00:00 2001
From: Nathan Ridge
Date: Thu, 13 Mar 2025 01:23:03 -0400
Subject: [PATCH] [clang][HeuristicResolver] Default argument heuristic for
https://github.com/HighCommander4 created
https://github.com/llvm/llvm-project/pull/131074
Fixes https://github.com/clangd/clangd/discussions/1056
>From 32ca27b5daa8cd1a0a9ad7b60c0ceecebaf9e8b6 Mon Sep 17 00:00:00 2001
From: Nathan Ridge
Date: Thu, 13 Mar 2025 01:23:03 -0400
Subject: [PATCH] [
https://github.com/HighCommander4 ready_for_review
https://github.com/llvm/llvm-project/pull/131074
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/HighCommander4 updated
https://github.com/llvm/llvm-project/pull/131074
>From aeeb8f20927850b11c66110021fe404576ff084f Mon Sep 17 00:00:00 2001
From: Nathan Ridge
Date: Thu, 13 Mar 2025 01:23:03 -0400
Subject: [PATCH] [clang][HeuristicResolver] Default argument heuristic for
HighCommander4 wrote:
> LGTM in general, but my concern would be that we're less clear about the
> number of uses of this function out-of-tree (and how hard it could be to
> migrate them to HeuristicResolver), so as an alternative, can we turn the
> implementation to use HeuristicResolver and
HighCommander4 wrote:
For reference, the callers of `CXXRecordDecl::lookupDependentName()` have been
ported over to `HeuristicResolver` over the following series of patches:
https://github.com/llvm/llvm-project/pull/124888
https://github.com/llvm/llvm-project/pull/125153
https://github.com/llvm
https://github.com/HighCommander4 created
https://github.com/llvm/llvm-project/pull/128392
This function has been superseded by HeuristicResolver::lookupDependentName(),
which implements the same heuristics and more.
Porting note for any out-of-tree callers:
```
RD->lookupDependentName(Name,
HighCommander4 wrote:
Thanks all for the reviews!
Adding @tstellar to request merging this to the llvm 20 branch.
https://github.com/llvm/llvm-project/pull/127358
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.ll
https://github.com/HighCommander4 updated
https://github.com/llvm/llvm-project/pull/127358
>From 8359f75adaacd9d2b7247e8887151cce59e7c086 Mon Sep 17 00:00:00 2001
From: Nathan Ridge
Date: Sat, 15 Feb 2025 01:30:48 -0500
Subject: [PATCH] [clangd] Add clangd 20 release notes
---
clang-tools-ext
@@ -67,35 +68,84 @@ Semantic Highlighting
Compile flags
^
+- Fixed a bug where clangd would unnecessarily reparse open files whose
+ compile command did not change when receiving a new compile command
+ via an LSP `workspace/configuration` request (#GH115438)
+
@@ -67,35 +68,84 @@ Semantic Highlighting
Compile flags
^
+- Fixed a bug where clangd would unnecessarily reparse open files whose
+ compile command did not change when receiving a new compile command
+ via an LSP `workspace/configuration` request (#GH115438)
+
https://github.com/HighCommander4 created
https://github.com/llvm/llvm-project/pull/127358
None
>From 77080f896293c948d9c87c8ce47df38ca81c2090 Mon Sep 17 00:00:00 2001
From: Nathan Ridge
Date: Sat, 15 Feb 2025 01:30:48 -0500
Subject: [PATCH] [clangd] Add clangd 20 release notes
---
clang-too
HighCommander4 wrote:
> @HighCommander4 (or anyone else). If you would like to add a note about this
> fix in the release notes (completely optional). Please reply to this comment
> with a one or two sentence description of the fix. When you are done, please
> add the release:note label to thi
HighCommander4 wrote:
> and cherry picking it into the 20 release
The regressing change, which introduced the `simplifyType()` function, isn't
present on the llvm 20 branch (it landed a bit after the branch cut). So there
should not be a need to cherry-pick the fix onto the llvm 20 branch eith
HighCommander4 wrote:
This is not needed to fix https://github.com/llvm/llvm-project/issues/126536
(https://github.com/llvm/llvm-project/pull/126689 does that), it's a hedge
against additional bugs that may be lurking that cause infinite loops.
I'm open to suggestions as to whether this is a g
https://github.com/HighCommander4 created
https://github.com/llvm/llvm-project/pull/126690
None
>From 28630abecc42c23527687b84be8cb4dbcd2ca5d9 Mon Sep 17 00:00:00 2001
From: Nathan Ridge
Date: Tue, 11 Feb 2025 02:06:32 -0500
Subject: [PATCH] [clang][HeuristicResolver] Additional hardening agai
https://github.com/HighCommander4 edited
https://github.com/llvm/llvm-project/pull/123818
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/HighCommander4 created
https://github.com/llvm/llvm-project/pull/123818
Fixes https://github.com/clangd/clangd/issues/1249
>From 58029449d63af7f452820dd02aba0d10134f588c Mon Sep 17 00:00:00 2001
From: Nathan Ridge
Date: Tue, 21 Jan 2025 15:56:27 -0500
Subject: [PATCH] [clang
HighCommander4 wrote:
The buildkite run shows the test `Clang.Index/complete-memfunc-cvquals.cpp`
failing.
This made me realize that `HeuristicResolver::getPointeeType()` actually has a
deficiency where it incorrectly discards the cv-qualifiers of the returned
pointee type. I'll fix that in a
HighCommander4 wrote:
Depends on https://github.com/llvm/llvm-project/pull/121314
https://github.com/llvm/llvm-project/pull/121315
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
https://github.com/HighCommander4 created
https://github.com/llvm/llvm-project/pull/121315
Fixes https://github.com/clangd/clangd/issues/810
>From 5165ce906cb5ec9ecd913f69fc376b049ab803d6 Mon Sep 17 00:00:00 2001
From: Nathan Ridge
Date: Thu, 26 Dec 2024 20:59:06 -0500
Subject: [PATCH] [clang]
HighCommander4 wrote:
Depends on https://github.com/llvm/llvm-project/pull/121313
https://github.com/llvm/llvm-project/pull/121314
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
https://github.com/HighCommander4 created
https://github.com/llvm/llvm-project/pull/121314
Fixes https://github.com/llvm/llvm-project/issues/121310
>From 4a1f5a145dac353f2060e6d1d4b2eb2d231e3a5a Mon Sep 17 00:00:00 2001
From: Nathan Ridge
Date: Thu, 26 Dec 2024 00:40:48 -0500
Subject: [PATCH]
https://github.com/HighCommander4 approved this pull request.
+1 from me
https://github.com/llvm/llvm-project/pull/106989
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branc
HighCommander4 wrote:
Thanks for the review.
@tstellar could you merge these release notes for us please?
https://github.com/llvm/llvm-project/pull/105975
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/c
https://github.com/HighCommander4 milestoned
https://github.com/llvm/llvm-project/pull/105975
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
HighCommander4 wrote:
> Should we mention the module support, even though it’s still in the initial
> stages?
It is [already
mentioned](https://github.com/llvm/llvm-project/blob/5f744ee5c770d7332740bb6247f961e7d99ee359/clang-tools-extra/docs/ReleaseNotes.rst#L51-L53).
(It was added to the rel
https://github.com/HighCommander4 created
https://github.com/llvm/llvm-project/pull/105975
None
>From 210ac24c486f144967598a6abcb7fdc829113ffe Mon Sep 17 00:00:00 2001
From: Nathan Ridge
Date: Sun, 25 Aug 2024 02:10:45 -0400
Subject: [PATCH] [clangd] Add clangd 19 release notes
---
clang-too
HighCommander4 wrote:
> that sounds a bit unclear. :)
I'm happy to take suggestions for better wording!
https://github.com/llvm/llvm-project/pull/84117
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-
HighCommander4 wrote:
> Do you think this needs a release note?
There is an umbrella entry in the release notes for "Various stability
improvements, e.g. crash fixes". I don't think it adds much value to list the
crash fixes individually (unless maybe it's a particularly widely reported one
l
HighCommander4 wrote:
(Does the backport need to be reviewed separately? Not sure what is the process
these days.)
https://github.com/llvm/llvm-project/pull/84117
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.ll
HighCommander4 wrote:
@kadircet do you know what is the process for getting this approved and merged?
As this is targeting the `release/18.x` branch, I do not have permissions to
merge it myself like a regular PR.
https://github.com/llvm/llvm-project/pull/84436
@@ -51,21 +51,40 @@ Improvements to clangd
Inlay hints
^^^
+- Type hints
+* Improved heuristics for showing sugared vs. desguared types
+* Some hints which provide no information (e.g. ) are
now omitted
+- Parameter hints
+* Parameter hints are now sho
https://github.com/HighCommander4 updated
https://github.com/llvm/llvm-project/pull/84436
>From f3c3e2d29abaf07ec2d84092c29bc01cc7201fda Mon Sep 17 00:00:00 2001
From: Nathan Ridge
Date: Fri, 8 Mar 2024 02:00:08 -0500
Subject: [PATCH] [clangd] [include-cleaner] Add release notes for LLVM 18
--
HighCommander4 wrote:
To prepare these, I went through the clangd commits in clangd 18 and made note
of what seemed notable to me.
In some areas of the code that I'm less familiar with, I was somewhat vague
(e.g. under "Diagnostics" I added "Improved quality of include-cleaner
diagnostics (mi
https://github.com/HighCommander4 created
https://github.com/llvm/llvm-project/pull/84436
None
>From 41cdc4a095d3082a3d6764c8950e626156c7bb07 Mon Sep 17 00:00:00 2001
From: Nathan Ridge
Date: Fri, 8 Mar 2024 02:00:08 -0500
Subject: [PATCH] [clangd] Add clangd 18 release notes
---
clang-tools
Author: Nathan Ridge
Date: 2021-01-12T13:57:54-05:00
New Revision: 4718ec01669b01373180f4cd1256c6e2dd6f3999
URL:
https://github.com/llvm/llvm-project/commit/4718ec01669b01373180f4cd1256c6e2dd6f3999
DIFF:
https://github.com/llvm/llvm-project/commit/4718ec01669b01373180f4cd1256c6e2dd6f3999.diff
Author: Nathan Ridge
Date: 2020-12-13T18:33:33-05:00
New Revision: fef242c32e833b84e8b46bd56a28c01c5f9aa65d
URL:
https://github.com/llvm/llvm-project/commit/fef242c32e833b84e8b46bd56a28c01c5f9aa65d
DIFF:
https://github.com/llvm/llvm-project/commit/fef242c32e833b84e8b46bd56a28c01c5f9aa65d.diff
Author: Nathan Ridge
Date: 2020-11-29T18:32:23-05:00
New Revision: f15b7869e5afbd6c24ef440b0b62593e80fbd24f
URL:
https://github.com/llvm/llvm-project/commit/f15b7869e5afbd6c24ef440b0b62593e80fbd24f
DIFF:
https://github.com/llvm/llvm-project/commit/f15b7869e5afbd6c24ef440b0b62593e80fbd24f.diff
Author: Nathan Ridge
Date: 2020-11-26T03:42:42-05:00
New Revision: d1fd91ddaf9de95428a25d001606c23703e14b31
URL:
https://github.com/llvm/llvm-project/commit/d1fd91ddaf9de95428a25d001606c23703e14b31
DIFF:
https://github.com/llvm/llvm-project/commit/d1fd91ddaf9de95428a25d001606c23703e14b31.diff
Author: Nathan Ridge
Date: 2020-11-25T20:33:57-05:00
New Revision: c6cb47b640ffafda113581c488a73fb62b6ea38a
URL:
https://github.com/llvm/llvm-project/commit/c6cb47b640ffafda113581c488a73fb62b6ea38a
DIFF:
https://github.com/llvm/llvm-project/commit/c6cb47b640ffafda113581c488a73fb62b6ea38a.diff
Author: Nathan Ridge
Date: 2020-11-25T03:45:00-05:00
New Revision: 3d2c681f2835261599654c1b82dacdae05c9b4c4
URL:
https://github.com/llvm/llvm-project/commit/3d2c681f2835261599654c1b82dacdae05c9b4c4
DIFF:
https://github.com/llvm/llvm-project/commit/3d2c681f2835261599654c1b82dacdae05c9b4c4.diff
Author: Nathan Ridge
Date: 2020-11-23T20:44:14-05:00
New Revision: dced150375d09df6266448342fbb066d638b59ef
URL:
https://github.com/llvm/llvm-project/commit/dced150375d09df6266448342fbb066d638b59ef
DIFF:
https://github.com/llvm/llvm-project/commit/dced150375d09df6266448342fbb066d638b59ef.diff
Author: Nathan Ridge
Date: 2020-11-23T20:44:07-05:00
New Revision: 0a4f99c494d007a21652b1b3939bde4753042c33
URL:
https://github.com/llvm/llvm-project/commit/0a4f99c494d007a21652b1b3939bde4753042c33
DIFF:
https://github.com/llvm/llvm-project/commit/0a4f99c494d007a21652b1b3939bde4753042c33.diff
Author: Nathan Ridge
Date: 2020-11-23T20:43:41-05:00
New Revision: 4cb976e014db80efd20dfca45ba218c3a69aac42
URL:
https://github.com/llvm/llvm-project/commit/4cb976e014db80efd20dfca45ba218c3a69aac42
DIFF:
https://github.com/llvm/llvm-project/commit/4cb976e014db80efd20dfca45ba218c3a69aac42.diff
Author: Nathan Ridge
Date: 2020-11-23T20:43:38-05:00
New Revision: 3e6e6a2db674cd85b33c06b75685c6bce5acb154
URL:
https://github.com/llvm/llvm-project/commit/3e6e6a2db674cd85b33c06b75685c6bce5acb154
DIFF:
https://github.com/llvm/llvm-project/commit/3e6e6a2db674cd85b33c06b75685c6bce5acb154.diff
59 matches
Mail list logo
