[llvm-branch-commits] [libcxx] [libc++] Add accessor functions to __tree_node_base (PR #147679)

https://github.com/ldionne commented: I think this could be rebased onto `main` -- it doesn't depend on `__pointer_int_pair` in itself. https://github.com/llvm/llvm-project/pull/147679 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llv

[llvm-branch-commits] [libcxx] [libc++] Add ABI flag to make __tree nodes more compact (PR #147681)

@@ -593,6 +594,43 @@ public: __tree_node_base& operator=(__tree_node_base const&) = delete; }; +#ifdef _LIBCPP_ABI_TREE_POINTER_INT_PAIR +template <> +class __tree_node_base : public __tree_end_node<__tree_node_base*> { +public: + using pointer=

[llvm-branch-commits] [libcxx] [libc++] Add ABI flag to make __tree nodes more compact (PR #147681)

@@ -593,6 +594,43 @@ public: __tree_node_base& operator=(__tree_node_base const&) = delete; }; +#ifdef _LIBCPP_ABI_TREE_POINTER_INT_PAIR +template <> +class __tree_node_base : public __tree_end_node<__tree_node_base*> { ldionne wrote: We should add a `stat

[llvm-branch-commits] [libcxx] release/20.x: [libc++] Fix std::make_exception_ptr interaction with ObjC (#135386) (PR #147554)

ldionne wrote: The CI failures are not legitimate, they are caused by changes in the infrastructure that make all patches on the release branch fail. This is something we should have fixed for upcoming releases, but it's always tricky to keep everything working on both branches. About the pat

[llvm-branch-commits] [libcxx] [libc++][C++03] Fix tests which only fail due to incorrect includes (PR #144110)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/144110 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][C++03] Fix a bunch of random tests (PR #144117)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/144117 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][C++03] Remove XFAILs from the non-frozen libc++-specific tests (PR #144101)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/144101 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][C++03] Remove tests from libcxx-03 which aren't run in C++03 mode (PR #144094)

https://github.com/ldionne approved this pull request. LGTM with CI passing. https://github.com/llvm/llvm-project/pull/144094 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-b

[llvm-branch-commits] [CI] Use LLVM_ENABLE_RUNTIMES for runtimes builds on Linux (PR #142694)

@@ -102,51 +102,25 @@ if [[ "${runtimes}" != "" ]]; then exit 1 fi - echo "--- ninja install-clang" - - ninja -C ${BUILD_DIR} install-clang install-clang-resource-headers - - RUNTIMES_BUILD_DIR="${MONOREPO_ROOT}/build-runtimes" - INSTALL_DIR="${BUILD_DIR}/install" -

[llvm-branch-commits] [libcxx] release/20.x: [libcxx] Provide locale conversions to tests through lit substitution (#105651) (PR #136449)

https://github.com/ldionne approved this pull request. I am fine with this backport. I looked at the failure on macOS and they look like the ones we had after the unfortunate OS update on Github runners, so I think this patch is clean. Also this patch only touches the tests. https://github.com

[llvm-branch-commits] [libcxx] [libc++] Implements the new FTM documentation generator. (PR #139774)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/139774 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Implements the new FTM documentation generator. (PR #139774)

https://github.com/ldionne approved this pull request. I am really excited for this change! This looks really good, with a few comments. https://github.com/llvm/llvm-project/pull/139774 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.ll

[llvm-branch-commits] [libcxx] [libc++] Implements the new FTM documentation generator. (PR #139774)

@@ -0,0 +1,187 @@ +# ===--===## +# +# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +# See https://llvm.org/LICENSE.txt for license information. +# SPDX-License-Identifier: Apache-

[llvm-branch-commits] [libcxx] [libc++] Implements the new FTM documentation generator. (PR #139774)

@@ -2555,6 +2645,72 @@ def generate_header_test_directory(self, path: os.path) -> None: f.write(self.generate_header_test_file(header)) +@functools.cached_property +def status_list_table(self) -> str: +"""Creates the rst status table using a l

[llvm-branch-commits] [libcxx] release/20.x: [libc++] Add _LIBCPP_NO_UNIQUE_ADDRESS to flat_{, multi}map::value_compare (#137594) (PR #138880)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/138880 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/20.x: [libc++] Re-introduce _LIBCPP_DISABLE_AVAILABILITY (#134158) (PR #138674)

ldionne wrote: The CI failures are caused by an automatic update of the Xcode version and can be ignored. https://github.com/llvm/llvm-project/pull/138674 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/c

[llvm-branch-commits] [libcxx] release/20.x: [libcxx] Provide locale conversions to tests through lit substitution (#105651) (PR #136449)

ldionne wrote: @mstorsjo Is there a reason to want to backport this, since this is only fixing the test suite? I wouldn't oppose it, but it looks like this needs work to pass CI on the release branch and I'm not sure it's worth the trouble. https://github.com/llvm/llvm-project/pull/136449

[llvm-branch-commits] [libcxx] [NFC][libc++][test] Minor updates to generated header version test. (PR #134543)

@@ -1830,28 +1830,28 @@ def produce_tests(): // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // //===--===// -// -// WARNING: This test was generated by {script_name} + +// WARNING: This test was ge

[llvm-branch-commits] [libcxx] [NFC][libc++][test] Minor updates to generated header version test. (PR #134543)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/134543 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Adds is_implemented function for new ftm generator. (PR #134538)

https://github.com/ldionne approved this pull request. LGTM with comment rewording. https://github.com/llvm/llvm-project/pull/134538 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[llvm-branch-commits] [libcxx] [libc++] Adds is_implemented function for new ftm generator. (PR #134538)

@@ -2208,6 +2209,20 @@ def implemented_ftms(self) -> Dict[Ftm, Dict[Std, Optional[Value]]]: return get_ftms(self.__data, self.std_dialects, True) +def is_implemented(self, ftm: Ftm, std: Std) -> bool: +"""Has the FTM `ftm` been implemented in the dialect

[llvm-branch-commits] [libcxx] [libc++] Adds is_implemented function for new ftm generator. (PR #134538)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/134538 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxxabi] [release/18.x][backport][libc++abi] Use __has_feature check to enable usage of thread_local for exception storage (PR #132241)

ldionne wrote: The LLVM 18 release has been done for a long time, we're working on LLVM 20 now. https://github.com/llvm/llvm-project/pull/132241 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[llvm-branch-commits] [libcxxabi] [release/18.x][backport][libc++abi] Use __has_feature check to enable usage of thread_local for exception storage (PR #132241)

ldionne wrote: (I'm going to tentatively close this since as I said we're not cherry-picking stuff back to LLVM 18 anymore, please reopen for more discussion) https://github.com/llvm/llvm-project/pull/132241 ___ llvm-branch-commits mailing list llvm-b

[llvm-branch-commits] [libcxx] release/20.x: [libcxx] Add a missing include for __bit_iterator (#127015) (PR #131382)

https://github.com/ldionne approved this pull request. Now that we have a better understanding that this is a workaround for an issue, how to reproduce the issue, etc, I am comfortable with cherry-picking this to LLVM 20. I don't think this is necessarily the workaround we'll want to keep fore

[llvm-branch-commits] [libcxx] [libc++] Guard additional headers with _LIBCPP_HAS_LOCALIZATION (#131921) (PR #134406)

https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/134406 >From abb3af9e0f26cae7583efe2591fe870da7b87fa7 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 4 Apr 2025 11:48:46 -0400 Subject: [PATCH] [libc++] Guard additional headers with _LIBCPP_HAS_LOCALIZATION (

[llvm-branch-commits] [libcxx] [libc++] Guard additional headers with _LIBCPP_HAS_LOCALIZATION (#131921) (PR #134406)

https://github.com/ldionne milestoned https://github.com/llvm/llvm-project/pull/134406 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Guard additional headers with _LIBCPP_HAS_LOCALIZATION (#131921) (PR #134406)

https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/134406 There were some remaining headers that were not guarded with _LIBCPP_HAS_LOCALIZATION, leading to errors when trying to use modules on platforms that don't support localization (since all the headers get pulled

[llvm-branch-commits] [libcxx] [libc++][C++03] Remove macros that expand to nothing (PR #134046)

https://github.com/ldionne approved this pull request. Same comment about commit message, please make it self-standing. https://github.com/llvm/llvm-project/pull/134046 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lis

[llvm-branch-commits] [libcxx] [libc++][C++03] Remove code that is not used in C++03 (PR #134045)

https://github.com/ldionne approved this pull request. LGTM, please update the commit message to explain what's being done and this is part of the frozen header RFC. Thanks! https://github.com/llvm/llvm-project/pull/134045 ___ llvm-branch-commits mail

[llvm-branch-commits] [libcxx] [libc++] Remove the need for _LIBCPP_TEMPLATE_VIS (PR #133010)

ldionne wrote: The commit message should make it clear that this is a no-op on Clang. https://github.com/llvm/llvm-project/pull/133010 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://li

[llvm-branch-commits] [libcxx] [libc++] Remove the need for _LIBCPP_TEMPLATE_VIS (PR #133010)

@@ -64,25 +64,13 @@ Visibility Macros ABI, we should create a new _LIBCPP_HIDE_FROM_ABI_AFTER_XXX macro, and we can ldionne wrote: Not attached to this line: you should update the `Overview` at the beginning of this file to reflect the latest state of things.

[llvm-branch-commits] [libcxx] [libc++] Remove the need for _LIBCPP_TEMPLATE_VIS (PR #133010)

https://github.com/ldionne requested changes to this pull request. I am fine with the spirit of this patch. I think it needs a release note though since we're making library-wide changes. We don't think those changes are going to affect anyone, but I think it's a nice courtesy to give our users

[llvm-branch-commits] [libcxx] [libc++] Remove the need for _LIBCPP_TEMPLATE_VIS (PR #133010)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/133010 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxxabi] [release/18.x][backport][libc++abi] Use __has_feature check to enable usage of thread_local for exception storage (PR #132241)

https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/132241 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/20.x: [libcxx] Add a missing include for __bit_iterator (#127015) (PR #131382)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/131382 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Clang-tidy operator& hijacker. (PR #128366)

@@ -0,0 +1,47 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[llvm-branch-commits] [libcxx] [NFC][libc++] Guard against operator& hijacking. (PR #129453)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/129453 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/20.x: [libcxx] Add a missing include for __bit_iterator (#127015) (PR #131382)

ldionne wrote: I'd like us to validate that this is the right fix on `main` first. I've asked for a reproducer in #127015. https://github.com/llvm/llvm-project/pull/131382 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https:/

[llvm-branch-commits] [libcxx] release/20.x: [libc++][test] Backport test skipping for Apple Clang 17 (PR #131506)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/131506 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Clang-tidy operator& hijacker. (PR #128366)

@@ -0,0 +1,24 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[llvm-branch-commits] [libcxx] [NFC][libc++] Guard against operator& hijacking. (PR #128351)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/128351 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [NFC][libc++] Guard against operator& hijacking. (PR #128351)

https://github.com/ldionne approved this pull request. LGTM with minor comment https://github.com/llvm/llvm-project/pull/128351 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm

[llvm-branch-commits] [libcxx] [NFC][libc++] Guard against operator& hijacking. (PR #128351)

@@ -353,9 +354,9 @@ _LIBCPP_HIDE_FROM_ABI basic_ostream<_CharT, _Traits>& operator<<(basic_ostream<_ typedef ostreambuf_iterator<_CharT, _Traits> _Ip; if (std::__pad_and_output( _Ip(__os), - &__c, - (__os.flags() & ios_base::

[llvm-branch-commits] [flang] release/20.x: flang: Fix build with latest libc++ (#127362) (PR #127805)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/127805 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/20.x: [libc++] Avoid including on arbitrary platforms (#125587) (PR #127310)

ldionne wrote: @tstellar Can we merge this one? I have another fix I want to cherry-pick which depends on this one. https://github.com/llvm/llvm-project/pull/127310 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.

[llvm-branch-commits] [libcxx] release/20.x: [libc++][TZDB] Fixes mapping of nonexisting time. (#127330) (PR #127531)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/127531 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/20.x: Revert "[libc++] Reduce std::conjunction overhead (#124259)" (PR #127677)

https://github.com/ldionne approved this pull request. LGTM but we need CI to be green https://github.com/llvm/llvm-project/pull/127677 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[llvm-branch-commits] [libcxx] release/20.x: [libc++] Avoid including on arbitrary platforms (#125587) (PR #127310)

ldionne wrote: Thanks for the heads up. I think we should merge this but also cherry-pick https://github.com/llvm/llvm-project/pull/127691 into LLVM 20 to fix that issue. https://github.com/llvm/llvm-project/pull/127310 ___ llvm-branch-commits mailing

[llvm-branch-commits] [libcxx] release/20.x: [libc++] Fixes (|multi)_set spaceship operator. (#127326) (PR #127342)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/127342 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/20.x: [libc++][format] Disables the FTM on older MacOS versions. (#126547) (PR #127232)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/127232 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Make benchmarks dry-run by default on the release branch (PR #126441)

https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/126441 As reported in #125510, doing a full run of the benchmarks during release testing breaks for some of the testers, and it also takes a long time. The proper fix would be for the release testing process to call `

[llvm-branch-commits] [libcxx] release/20.x: [libc++][TZDB] Fixes %z escaping. (#125399) (PR #125730)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/125730 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [llvm] Bump version to 20.1.0git (PR #125067)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/125067 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/18.x: [libcxx] Align `__recommend() + 1` by __endian_factor (#90292) (PR #95264)

ldionne wrote: Approved per discussion in https://github.com/llvm/llvm-project/pull/90292. @vitalybuka It would be amazing if you could run this PR through the same tests that made you find the bug that you fixed with https://github.com/llvm/llvm-project/pull/90292 https://github.com/llvm/llv

[llvm-branch-commits] [libcxx] [libcxx] Workaround for build error after #108999 (PR #110783)

ldionne wrote: The patch has since then been reverted, but I guess this is something that @philnik777 should have a look into before it is re-landed. https://github.com/llvm/llvm-project/pull/110783 ___ llvm-branch-commits mailing list llvm-branch-com

[llvm-branch-commits] [libcxx] release/18.x: [libcxx] Align `__recommend() + 1` by __endian_factor (#90292) (PR #95264)

ldionne wrote: @tickerguy Thanks for the heads up. @tstellar I read the thread in the linked FreeBSD tracker up to `2024-07-02 18:59:18 UTC`, and based on what I am seeing they are still investigating the cause of the issue. I don't think we have grounds to do anything at this point: we know

[llvm-branch-commits] [libcxx] release/18.x: [libcxx] Align `__recommend() + 1` by __endian_factor (#90292) (PR #95264)

ldionne wrote: > Could someone write a release note for this? https://github.com/llvm/llvm-project/pull/96116 https://github.com/llvm/llvm-project/pull/95264 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.or

[llvm-branch-commits] [libcxx] release/18.x: [libcxx] Align `__recommend() + 1` by __endian_factor (#90292) (PR #95264)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/95264 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [libcxx] [libcxxabi] [Fuchsia][cmake] Allow using FatLTO when building runtimes (PR #112277)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/112277 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [libcxx] [libcxxabi] [Fuchsia][cmake] Allow using FatLTO when building runtimes (PR #112277)

@@ -1285,7 +1285,7 @@ elseif(LLVM_ENABLE_LTO) endif() endif() -if(LLVM_ENABLE_FATLTO AND UNIX AND NOT APPLE) +if(LLVM_ENABLE_FATLTO AND ((UNIX AND NOT APPLE) OR FUCHSIA)) ldionne wrote: Sorry, I think I initially read `if (LLVM_ENABLE_FATLTO OR ((UNIX AND N

[llvm-branch-commits] [libcxx] [llvm] [libc++][C++03] Use `__cxx03/` headers in C++03 mode (PR #109002)

@@ -79,42 +79,46 @@ namespace std { } // namespace std */ - -#include <__config> -#include <__memory/allocator.h> -#include <__memory/allocator_destructor.h> -#include <__memory/allocator_traits.h> -#include <__memory/unique_ptr.h> -#include <__type_traits/add_cv_quals.h> -#in

[llvm-branch-commits] [libcxx] [llvm] [libc++][C++03] Use `__cxx03/` headers in C++03 mode (PR #109002)

@@ -11,10 +11,6 @@ #include <__config> -#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) ldionne wrote: Merge conflict? https://github.com/llvm/llvm-project/pull/109002 ___ llvm-branch-commits mailing list llvm-b

[llvm-branch-commits] [libcxx] [llvm] [libc++][C++03] Use `__cxx03/` headers in C++03 mode (PR #109002)

@@ -152,11 +152,6 @@ _LIBCPP_HARDENING_MODE_DEBUG # define _LIBCPP_TOSTRING2(x) #x # define _LIBCPP_TOSTRING(x) _LIBCPP_TOSTRING2(x) -// NOLINTNEXTLINE(libcpp-cpp-version-check) -# if __cplusplus < 201103L -#define _LIBCPP_CXX03_LANG -# endif ldionne w

[llvm-branch-commits] [libcxx] [llvm] [libc++][C++03] Use `__cxx03/` headers in C++03 mode (PR #109002)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/109002 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [llvm] [libc++][C++03] Use `__cxx03/` headers in C++03 mode (PR #109002)

https://github.com/ldionne commented: Let's write down the order for landing this in smaller pieces: 1. Land the `#if 0` change which addresses the formatting issues. 2. Land the CMake changes that start installing the C++03 headers. 3. Switch to `#if __cplusplus < C++11 && USE_FROZEN_HEADERS` (

[llvm-branch-commits] [clang] [libcxx] [libcxxabi] [Fuchsia][cmake] Allow using FatLTO when building runtimes (PR #112277)

@@ -1285,7 +1285,7 @@ elseif(LLVM_ENABLE_LTO) endif() endif() -if(LLVM_ENABLE_FATLTO AND UNIX AND NOT APPLE) +if(LLVM_ENABLE_FATLTO AND ((UNIX AND NOT APPLE) OR FUCHSIA)) ldionne wrote: I don't understand why that diff is required since you're setting it pr

[llvm-branch-commits] [clang] [libcxx] [libcxxabi] [Fuchsia][cmake] Allow using FatLTO when building runtimes (PR #112277)

https://github.com/ldionne requested changes to this pull request. https://github.com/llvm/llvm-project/pull/112277 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-comm

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=flang-rt (PR #110217)

https://github.com/ldionne dismissed https://github.com/llvm/llvm-project/pull/110217 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libcxxabi] release/19.x: [libc++] Fix broken configuration system-libcxxabi on Apple (#110920) (PR #115892)

https://github.com/ldionne approved this pull request. I think this is reasonable to cherry-pick. It's fixing a somewhat more niche use case, but if that's useful to @mgorny I think it makes sense to backport. https://github.com/llvm/llvm-project/pull/115892

[llvm-branch-commits] [libcxx] [libc++] Stop copying headers to the build directory (PR #115380)

@@ -1021,17 +1021,8 @@ set(files configure_file("__config_site.in" "${LIBCXX_GENERATED_INCLUDE_TARGET_DIR}/__config_site" @ONLY) ldionne wrote: @philnik777 Should be be modifying the C++03 `CMakeLists.txt` at all? https://github.com/llvm/llvm-project/pull/1153

[llvm-branch-commits] [libcxx] [libc++] Stop copying headers to the build directory (PR #115380)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/115380 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Stop copying headers to the build directory (PR #115380)

https://github.com/ldionne approved this pull request. This looks great, this is a really nice cleanup. Thank you! Let's just wait until we know what to do with the C++03 CMakeLists but I'm OK with merging this once that's settled, if CI is green. https://github.com/llvm/llvm-project/pull/1153

[llvm-branch-commits] [libcxx] [libc++] Stop copying headers to the build directory (PR #115380)

@@ -1043,17 +1043,8 @@ set(files configure_file("__config_site.in" "${LIBCXX_GENERATED_INCLUDE_TARGET_DIR}/__config_site" @ONLY) configure_file("${LIBCXX_ASSERTION_HANDLER_FILE}" "${LIBCXX_GENERATED_INCLUDE_DIR}/__assertion_handler" COPYONLY) -set(_all_includes "${LIBCXX_GEN

[llvm-branch-commits] [libc++abi] Stop copying headers to the build directory (PR #115086)

https://github.com/ldionne approved this pull request. LGTM, thanks for the cleanup! https://github.com/llvm/llvm-project/pull/115086 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[llvm-branch-commits] [libcxx] [libc++] Implement std::move_only_function (P0288R9) (PR #94670)

https://github.com/ldionne commented: I think the most effective way of settling on the bit-stealing issue would be to benchmark something like this: 1. Set up ~100 functions that do random stuff (e.g. they all return numbers from 1 to 100) 2. Set up a `std::vector>` with some large number of

[llvm-branch-commits] [libc++abi] Stop copying headers to the build directory (PR #115086)

https://github.com/ldionne commented: Can't we do the same for libc++ as well? https://github.com/llvm/llvm-project/pull/115086 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm

[llvm-branch-commits] [libcxx] [llvm] [libc++][C++03] Use `__cxx03/` headers in C++03 mode (PR #109002)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/109002 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [llvm] [libc++][C++03] Use `__cxx03/` headers in C++03 mode (PR #109002)

@@ -14,6 +14,7 @@ #include <__configuration/abi.h> #include <__configuration/availability.h> #include <__configuration/compiler.h> +#include <__configuration/cxx03.h> ldionne wrote: Could we move `_LIBCPP_CXX03_LANG` into `language.h` instead? And it might be

[llvm-branch-commits] [libcxx] [llvm] [libc++][C++03] Use `__cxx03/` headers in C++03 mode (PR #109002)

https://github.com/ldionne commented: I think this makes sense, however I would like you to post this PR to the RFC, since we mentioned back then that the decision of Driver vs conditional includes would be best taken based on actual proposed changes. This will give this patch a bit more visib

[llvm-branch-commits] [libcxx] [llvm] [libc++][C++03] Use `__cxx03/` headers in C++03 mode (PR #109002)

@@ -0,0 +1,2 @@ +set(LIBCXX_TEST_PARAMS "std=c++03;test-cxx03-headers=True" CACHE STRING "") ldionne wrote: I would probably name this new param `use-frozen-cxx03-headers`. That tells what the setting does a bit more explicitly. https://github.com/llvm/llvm-pro

[llvm-branch-commits] [libcxx] [llvm] [libc++][C++03] Use `__cxx03/` headers in C++03 mode (PR #109002)

@@ -587,42 +587,48 @@ template */ -#include <__config> - -#include <__atomic/aliases.h> -#include <__atomic/atomic.h> -#include <__atomic/atomic_base.h> -#include <__atomic/atomic_flag.h> -#include <__atomic/atomic_init.h> -#include <__atomic/atomic_lock_free.h> -#include <_

[llvm-branch-commits] [libcxx] [llvm] [libc++][C++03] Use `__cxx03/` headers in C++03 mode (PR #109002)

@@ -1827,232 +1827,147 @@ template */ -#include <__config> - -#include <__algorithm/adjacent_find.h> -#include <__algorithm/all_of.h> -#include <__algorithm/any_of.h> -#include <__algorithm/binary_search.h> -#include <__algorithm/copy.h> -#include <__algorithm/copy_backward.

[llvm-branch-commits] [libcxx] [llvm] [libc++][C++03] Use `__cxx03/` headers in C++03 mode (PR #109002)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/109002 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][C++03] Update include guards (PR #109001)

@@ -29,18 +29,18 @@ _LIBCPP_PUSH_MACROS // TODO: Find out how altivec changes things and allow vectorizations there too. #if _LIBCPP_STD_VER >= 14 && defined(_LIBCPP_CLANG_VER) && !defined(__ALTIVEC__) -# define _LIBCPP_HAS_ALGORITHM_VECTOR_UTILS 1 +# define _LIBCPP___CXX0

[llvm-branch-commits] [libcxx] [libc++][C++03] Update include guards (PR #109001)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/109001 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][C++03] Update include guards (PR #109001)

@@ -41,7 +41,7 @@ template , int> = 0> [[nodiscard]] _LIBCPP_HIDE_FROM_ABI bool any_of(_ExecutionPolicy&& __policy, _ForwardIterator __first, _ForwardIterator __last, _Predicate __pred) { - _LIBCPP_REQUIRE_CPP17_FORWARD_ITERATOR(_ForwardIterator, "any_of requires a ForwardIte

[llvm-branch-commits] [libcxx] [libc++][C++03] Update include guards (PR #109001)

https://github.com/ldionne commented: This looks good to me in principle, however the patch itself has a few incorrect renamings. One thing you could do is use `git diff --stat` to confirm that all the changed files have exactly 3 lines changed in them. A few headers like the C compat headers

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=FortranRuntime (PR #110217)

@@ -0,0 +1,165 @@ +#===-- CMakeLists.txt --===# +# +# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +# See https://llvm.org/LICENSE.txt for license information. +# SPDX-License-Identifier: Apache-

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=FortranRuntime (PR #110217)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/110217 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=FortranRuntime (PR #110217)

@@ -0,0 +1,165 @@ +#===-- CMakeLists.txt --===# +# +# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +# See https://llvm.org/LICENSE.txt for license information. +# SPDX-License-Identifier: Apache-

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=FortranRuntime (PR #110217)

https://github.com/ldionne commented: I think the global setting of flags is the last comment I have from the perspective of "integration with the runtimes build". I haven't reviewed anything else inside `flang-rt/` though. https://github.com/llvm/llvm-project/pull/110217 _

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=FortranRuntime (PR #110217)

@@ -24,7 +24,7 @@ list(INSERT CMAKE_MODULE_PATH 0 # We order libraries to mirror roughly how they are layered, except that compiler-rt can depend # on libc++, so we put it after. set(LLVM_DEFAULT_RUNTIMES "libc;libunwind;libcxxabi;pstl;libcxx;compiler-rt;openmp;offload") -set

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=FortranRuntime (PR #110217)

@@ -261,6 +263,7 @@ function(runtime_default_target) llvm_ExternalProject_Add(runtimes ${CMAKE_CURRENT_SOURCE_DIR}/../../runtimes DEPENDS ${ARG_DEPENDS} + ${enable_fortran} ldionn

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=FortranRuntime (PR #110217)

@@ -34,6 +34,8 @@ endfunction() # llvm_ExternalProject_Add(name source_dir ... +# ENABLE_FORTRAN +# External project requires the Flang compiler ldionne wrote: Ah, I see now, `clang` is being added implicitly if you don't specify any required toolchai

[llvm-branch-commits] [libcxx] [libcxxabi] release/19.x: [libc++] Avoid re-exporting a few specific symbols from libc++abi (#109054) (PR #110677)

ldionne wrote: > Can someone post this as a breaking change to the discourse so that I can > link it from the release notes? https://discourse.llvm.org/t/libc-llvm-19-1-2-removal-of-some-libc-abi-re-exported-symbols-on-apple-platforms/82551 (Still being moderated) https://github.com/llvm/llvm

[llvm-branch-commits] [libcxx] [release/19.x][libc++] Adjust the version of __cpp_lib_ranges in C++20 mode (PR #109324)

https://github.com/ldionne commented: LGTM thanks! https://github.com/llvm/llvm-project/pull/109324 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libcxxabi] release/19.x: [libc++] Avoid re-exporting a few specific symbols from libc++abi (#109054) (PR #110677)

ldionne wrote: I'm not seeing any CI failure anymore, I think this can be merged? https://github.com/llvm/llvm-project/pull/110677 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=FortranRuntime (PR #110217)

https://github.com/ldionne requested changes to this pull request. https://github.com/llvm/llvm-project/pull/110217 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-comm

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=FortranRuntime (PR #110217)

@@ -34,6 +34,8 @@ endfunction() # llvm_ExternalProject_Add(name source_dir ... +# ENABLE_FORTRAN +# External project requires the Flang compiler ldionne wrote: I don't fully understand why you need that, but the fact that we don't need `ENABLE_CPLUSPL

  1   2   3   4   5   6   >