https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/125067
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
ldionne wrote:
Approved per discussion in https://github.com/llvm/llvm-project/pull/90292.
@vitalybuka It would be amazing if you could run this PR through the same tests
that made you find the bug that you fixed with
https://github.com/llvm/llvm-project/pull/90292
https://github.com/llvm/llv
ldionne wrote:
The patch has since then been reverted, but I guess this is something that
@philnik777 should have a look into before it is re-landed.
https://github.com/llvm/llvm-project/pull/110783
___
llvm-branch-commits mailing list
llvm-branch-com
ldionne wrote:
@tickerguy Thanks for the heads up.
@tstellar I read the thread in the linked FreeBSD tracker up to `2024-07-02
18:59:18 UTC`, and based on what I am seeing they are still investigating the
cause of the issue. I don't think we have grounds to do anything at this point:
we know
ldionne wrote:
> Could someone write a release note for this?
https://github.com/llvm/llvm-project/pull/96116
https://github.com/llvm/llvm-project/pull/95264
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.or
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/95264
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/112277
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -1285,7 +1285,7 @@ elseif(LLVM_ENABLE_LTO)
endif()
endif()
-if(LLVM_ENABLE_FATLTO AND UNIX AND NOT APPLE)
+if(LLVM_ENABLE_FATLTO AND ((UNIX AND NOT APPLE) OR FUCHSIA))
ldionne wrote:
Sorry, I think I initially read `if (LLVM_ENABLE_FATLTO OR ((UNIX AND N
@@ -79,42 +79,46 @@ namespace std {
} // namespace std
*/
-
-#include <__config>
-#include <__memory/allocator.h>
-#include <__memory/allocator_destructor.h>
-#include <__memory/allocator_traits.h>
-#include <__memory/unique_ptr.h>
-#include <__type_traits/add_cv_quals.h>
-#in
@@ -11,10 +11,6 @@
#include <__config>
-#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
ldionne wrote:
Merge conflict?
https://github.com/llvm/llvm-project/pull/109002
___
llvm-branch-commits mailing list
llvm-b
@@ -152,11 +152,6 @@ _LIBCPP_HARDENING_MODE_DEBUG
# define _LIBCPP_TOSTRING2(x) #x
# define _LIBCPP_TOSTRING(x) _LIBCPP_TOSTRING2(x)
-// NOLINTNEXTLINE(libcpp-cpp-version-check)
-# if __cplusplus < 201103L
-#define _LIBCPP_CXX03_LANG
-# endif
ldionne w
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/109002
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ldionne commented:
Let's write down the order for landing this in smaller pieces:
1. Land the `#if 0` change which addresses the formatting issues.
2. Land the CMake changes that start installing the C++03 headers.
3. Switch to `#if __cplusplus < C++11 && USE_FROZEN_HEADERS` (
@@ -1285,7 +1285,7 @@ elseif(LLVM_ENABLE_LTO)
endif()
endif()
-if(LLVM_ENABLE_FATLTO AND UNIX AND NOT APPLE)
+if(LLVM_ENABLE_FATLTO AND ((UNIX AND NOT APPLE) OR FUCHSIA))
ldionne wrote:
I don't understand why that diff is required since you're setting it pr
https://github.com/ldionne requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/112277
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-comm
https://github.com/ldionne dismissed
https://github.com/llvm/llvm-project/pull/110217
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ldionne approved this pull request.
I think this is reasonable to cherry-pick. It's fixing a somewhat more niche
use case, but if that's useful to @mgorny I think it makes sense to backport.
https://github.com/llvm/llvm-project/pull/115892
@@ -1021,17 +1021,8 @@ set(files
configure_file("__config_site.in"
"${LIBCXX_GENERATED_INCLUDE_TARGET_DIR}/__config_site" @ONLY)
ldionne wrote:
@philnik777 Should be be modifying the C++03 `CMakeLists.txt` at all?
https://github.com/llvm/llvm-project/pull/1153
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/115380
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ldionne approved this pull request.
This looks great, this is a really nice cleanup. Thank you!
Let's just wait until we know what to do with the C++03 CMakeLists but I'm OK
with merging this once that's settled, if CI is green.
https://github.com/llvm/llvm-project/pull/1153
@@ -1043,17 +1043,8 @@ set(files
configure_file("__config_site.in"
"${LIBCXX_GENERATED_INCLUDE_TARGET_DIR}/__config_site" @ONLY)
configure_file("${LIBCXX_ASSERTION_HANDLER_FILE}"
"${LIBCXX_GENERATED_INCLUDE_DIR}/__assertion_handler" COPYONLY)
-set(_all_includes "${LIBCXX_GEN
https://github.com/ldionne approved this pull request.
LGTM, thanks for the cleanup!
https://github.com/llvm/llvm-project/pull/115086
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
https://github.com/ldionne commented:
I think the most effective way of settling on the bit-stealing issue would be
to benchmark something like this:
1. Set up ~100 functions that do random stuff (e.g. they all return numbers
from 1 to 100)
2. Set up a `std::vector>` with some large
number of
https://github.com/ldionne commented:
Can't we do the same for libc++ as well?
https://github.com/llvm/llvm-project/pull/115086
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/109002
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -14,6 +14,7 @@
#include <__configuration/abi.h>
#include <__configuration/availability.h>
#include <__configuration/compiler.h>
+#include <__configuration/cxx03.h>
ldionne wrote:
Could we move `_LIBCPP_CXX03_LANG` into `language.h` instead? And it might be
https://github.com/ldionne commented:
I think this makes sense, however I would like you to post this PR to the RFC,
since we mentioned back then that the decision of Driver vs conditional
includes would be best taken based on actual proposed changes. This will give
this patch a bit more visib
@@ -0,0 +1,2 @@
+set(LIBCXX_TEST_PARAMS "std=c++03;test-cxx03-headers=True" CACHE STRING "")
ldionne wrote:
I would probably name this new param `use-frozen-cxx03-headers`. That tells
what the setting does a bit more explicitly.
https://github.com/llvm/llvm-pro
@@ -587,42 +587,48 @@ template
*/
-#include <__config>
-
-#include <__atomic/aliases.h>
-#include <__atomic/atomic.h>
-#include <__atomic/atomic_base.h>
-#include <__atomic/atomic_flag.h>
-#include <__atomic/atomic_init.h>
-#include <__atomic/atomic_lock_free.h>
-#include <_
@@ -1827,232 +1827,147 @@ template
*/
-#include <__config>
-
-#include <__algorithm/adjacent_find.h>
-#include <__algorithm/all_of.h>
-#include <__algorithm/any_of.h>
-#include <__algorithm/binary_search.h>
-#include <__algorithm/copy.h>
-#include <__algorithm/copy_backward.
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/109002
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -29,18 +29,18 @@ _LIBCPP_PUSH_MACROS
// TODO: Find out how altivec changes things and allow vectorizations there
too.
#if _LIBCPP_STD_VER >= 14 && defined(_LIBCPP_CLANG_VER) &&
!defined(__ALTIVEC__)
-# define _LIBCPP_HAS_ALGORITHM_VECTOR_UTILS 1
+# define _LIBCPP___CXX0
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/109001
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -41,7 +41,7 @@ template , int> = 0>
[[nodiscard]] _LIBCPP_HIDE_FROM_ABI bool
any_of(_ExecutionPolicy&& __policy, _ForwardIterator __first, _ForwardIterator
__last, _Predicate __pred) {
- _LIBCPP_REQUIRE_CPP17_FORWARD_ITERATOR(_ForwardIterator, "any_of requires a
ForwardIte
https://github.com/ldionne commented:
This looks good to me in principle, however the patch itself has a few
incorrect renamings. One thing you could do is use `git diff --stat` to confirm
that all the changed files have exactly 3 lines changed in them. A few headers
like the C compat headers
@@ -0,0 +1,165 @@
+#===-- CMakeLists.txt
--===#
+#
+# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+# See https://llvm.org/LICENSE.txt for license information.
+# SPDX-License-Identifier: Apache-
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/110217
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -0,0 +1,165 @@
+#===-- CMakeLists.txt
--===#
+#
+# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+# See https://llvm.org/LICENSE.txt for license information.
+# SPDX-License-Identifier: Apache-
https://github.com/ldionne commented:
I think the global setting of flags is the last comment I have from the
perspective of "integration with the runtimes build". I haven't reviewed
anything else inside `flang-rt/` though.
https://github.com/llvm/llvm-project/pull/110217
_
@@ -24,7 +24,7 @@ list(INSERT CMAKE_MODULE_PATH 0
# We order libraries to mirror roughly how they are layered, except that
compiler-rt can depend
# on libc++, so we put it after.
set(LLVM_DEFAULT_RUNTIMES
"libc;libunwind;libcxxabi;pstl;libcxx;compiler-rt;openmp;offload")
-set
@@ -261,6 +263,7 @@ function(runtime_default_target)
llvm_ExternalProject_Add(runtimes
${CMAKE_CURRENT_SOURCE_DIR}/../../runtimes
DEPENDS ${ARG_DEPENDS}
+ ${enable_fortran}
ldionn
@@ -34,6 +34,8 @@ endfunction()
# llvm_ExternalProject_Add(name source_dir ...
+# ENABLE_FORTRAN
+# External project requires the Flang compiler
ldionne wrote:
Ah, I see now, `clang` is being added implicitly if you don't specify any
required toolchai
ldionne wrote:
> Can someone post this as a breaking change to the discourse so that I can
> link it from the release notes?
https://discourse.llvm.org/t/libc-llvm-19-1-2-removal-of-some-libc-abi-re-exported-symbols-on-apple-platforms/82551
(Still being moderated)
https://github.com/llvm/llvm
https://github.com/ldionne commented:
LGTM thanks!
https://github.com/llvm/llvm-project/pull/109324
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
ldionne wrote:
I'm not seeing any CI failure anymore, I think this can be merged?
https://github.com/llvm/llvm-project/pull/110677
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
https://github.com/ldionne requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/110217
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-comm
@@ -34,6 +34,8 @@ endfunction()
# llvm_ExternalProject_Add(name source_dir ...
+# ENABLE_FORTRAN
+# External project requires the Flang compiler
ldionne wrote:
I don't fully understand why you need that, but the fact that we don't need
`ENABLE_CPLUSPL
@@ -503,17 +513,9 @@ if(build_runtimes)
endif()
if("openmp" IN_LIST LLVM_ENABLE_RUNTIMES)
-if (${LLVM_TOOL_FLANG_BUILD})
- message(STATUS "Configuring build of omp_lib.mod and omp_lib_kinds.mod
via flang-new")
- set(LIBOMP_FORTRAN_MODULES_COMPILER "${CMAKE_B
@@ -0,0 +1,161 @@
+#===-- CMakeLists.txt
--===#
ldionne wrote:
[not attached to this line]
I don't think we have an official policy for naming top-level subdirectories,
but we have consistently been using low
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/109291
>From 094cc808ded9b00a50e26b91898323e17cc4840f Mon Sep 17 00:00:00 2001
From: Jakub Mazurkiewicz
Date: Wed, 10 Apr 2024 23:12:22 +0200
Subject: [PATCH 1/2] [libc++] Follow-up to "Poison Pills are Too Toxic"
* U
ldionne wrote:
Impact: basically none, this adds test coverage we should always have had.
https://github.com/llvm/llvm-project/pull/110838
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/110838
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
ldionne wrote:
I think this is good to go, the CI is as green as it'll get without rebasing
onto `release/19.x` again.
https://github.com/llvm/llvm-project/pull/109291
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lis
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/109324
>From 2978a0a4e42368e49163102e5a6eb9a032605a61 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Thu, 19 Sep 2024 15:40:47 -0400
Subject: [PATCH] [libc++] Adjust the version of __cpp_lib_ranges in C++20 mode
Th
ldionne wrote:
As I explained in the original PR, I think this is a fairly important fix since
that was an unintentional change in LLVM 19, but this can also potentially
break people who compiled with LLVM 19.1. Since we're making the fix on `main`,
it will land in LLVM 20 anyway and I think i
Author: Louis Dionne
Date: 2024-09-26T16:00:43-04:00
New Revision: 8a25c601eb64bcdb7c6c74bee52655468dfdd91b
URL:
https://github.com/llvm/llvm-project/commit/8a25c601eb64bcdb7c6c74bee52655468dfdd91b
DIFF:
https://github.com/llvm/llvm-project/commit/8a25c601eb64bcdb7c6c74bee52655468dfdd91b.diff
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/109324
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/109291
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
ldionne wrote:
> I guess
> [6f6422f](https://github.com/llvm/llvm-project/commit/6f6422f4a2b8647a59936c131e50a79906d89510)
> and
> [cdd608b](https://github.com/llvm/llvm-project/commit/cdd608b8f0ce090b3568238387df368751bdbb5d)
> should also be cherry-picked. @tru @ldionne
This is now https:/
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/110162
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/110263
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/110259
None
>From 3be5c6921fbc46a3a4a6957b7b58c2398c8a8ce8 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Thu, 15 Aug 2024 08:14:13 +
Subject: [PATCH 1/2] [lldb][test] Mark sys_info zdump test unsupported on
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/110263
We should have been checking against 1700, not 17000, which was a typo.
(cherry picked from commit 1eba87904b0cbaaee82cfdb835528b85d99320ef)
>From b1affedd7d2e4f2e13c3a2cbd8e3645fb5b9af0e Mon Sep 17 00:00:00 20
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/110263
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ldionne milestoned
https://github.com/llvm/llvm-project/pull/110263
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ldionne milestoned
https://github.com/llvm/llvm-project/pull/110259
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
ldionne wrote:
@tru At this point, the important CI has passed. Please consider merging this
so I can rebase the other libc++ PRs on top of it, get the CI to run and clear
the backlog for the 19 milestone PRs.
https://github.com/llvm/llvm-project/pull/110162
___
https://github.com/ldionne milestoned
https://github.com/llvm/llvm-project/pull/110162
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
ldionne wrote:
@tru This patch should make the libc++ CI pass again. Unfortunately, it looks
like we're going to have to let the clang-tidy checks go for now.
Once this passes CI (🤞), we can merge this, and then I can rebase #110161,
#109324, #109291, #109054 and #106077 which should all pass.
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/110162
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/110162
The CI has been a complete mess for the past week, and the only thing
preventing it from being back is the Clang tidy checks. Disable them (as a
total hack) to get CI back.
(cherry picked from commit 78c650654
https://github.com/ldionne approved this pull request.
This LGTM once the comments have been addressed. In particular, we shouldn't
need to change the transitive includes.
https://github.com/llvm/llvm-project/pull/108990
___
llvm-branch-commits mailin
@@ -53,24 +56,150 @@ _LIBCPP_BEGIN_NAMESPACE_STD
namespace __format {
+// A helper to limit the total size of code units written.
+class _LIBCPP_HIDE_FROM_ABI __max_output_size {
+public:
+ [[nodiscard]] _LIBCPP_HIDE_FROM_ABI explicit __max_output_size(size_t
__max_size) :
@@ -319,188 +353,222 @@ struct _LIBCPP_TEMPLATE_VIS
__back_insert_iterator_container
-class _LIBCPP_TEMPLATE_VIS __writer_container {
+// A dynamically growing buffer.
+template <__fmt_char_type _CharT>
+class _LIBCPP_TEMPLATE_VIS __allocating_buffer : public
__output_buffer<_Ch
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/108990
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
ldionne wrote:
@tru Our CI is currently super unstable, that's the failures. We've been
without CI for roughly the past week. We're working on it.
https://github.com/llvm/llvm-project/pull/109324
___
llvm-branch-commits mailing list
llvm-branch-commit
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/109291
>From 9558a97c93be4fb957a82476f5fc1861aff1ed5d Mon Sep 17 00:00:00 2001
From: Jakub Mazurkiewicz
Date: Wed, 10 Apr 2024 23:12:22 +0200
Subject: [PATCH 1/2] [libc++] Follow-up to "Poison Pills are Too Toxic"
* U
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/109291
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ldionne milestoned
https://github.com/llvm/llvm-project/pull/109324
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/109324
This is a (very partial) cherry-pick of #101715 to fix this oversight in the
LLVM 19 release.
>From f94aed192c413fc174d353c9f8f27766497a8c56 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Thu, 19 Sep 2024 1
@@ -992,6 +992,7 @@ def add_version_header(tc):
"name": "__cpp_lib_ranges",
"values": {
"c++20": 202207,
+"c++23": 202211, # P2602R2 Poison Pills are Too Toxic
ldionne wrote:
Ack, we can fix that in a fo
https://github.com/ldionne milestoned
https://github.com/llvm/llvm-project/pull/109291
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
ldionne wrote:
CC @JMazurkiewicz @frederick-vs-ja
@frederick-vs-ja Does the FTM change seem correct to you? IIUC this should have
been done before the LLVM 19 branch but it slipped through the cracks, so this
ought to be correct?
https://github.com/llvm/llvm-project/pull/109291
_
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/109291
* Update release notes and `Cxx23.html`
* Update `__cpp_lib_ranges` feature test macro
Cherry-pick of #88383 for LLVM 19.
>From 9558a97c93be4fb957a82476f5fc1861aff1ed5d Mon Sep 17 00:00:00 2001
From: Jakub Mazu
@@ -319,188 +353,222 @@ struct _LIBCPP_TEMPLATE_VIS
__back_insert_iterator_container
-class _LIBCPP_TEMPLATE_VIS __writer_container {
+// A dynamically growing buffer.
+template <__fmt_char_type _CharT>
+class _LIBCPP_TEMPLATE_VIS __allocating_buffer : public
__output_buffer<_Ch
@@ -53,24 +56,150 @@ _LIBCPP_BEGIN_NAMESPACE_STD
namespace __format {
+// A helper to limit the total size of code units written.
+class _LIBCPP_HIDE_FROM_ABI __max_output_size {
+public:
+ [[nodiscard]] _LIBCPP_HIDE_FROM_ABI explicit __max_output_size(size_t
__max_size) :
@@ -319,188 +353,222 @@ struct _LIBCPP_TEMPLATE_VIS
__back_insert_iterator_container
-class _LIBCPP_TEMPLATE_VIS __writer_container {
+// A dynamically growing buffer.
+template <__fmt_char_type _CharT>
+class _LIBCPP_TEMPLATE_VIS __allocating_buffer : public
__output_buffer<_Ch
@@ -245,21 +245,11 @@ experimental/simd limits
experimental/utility utility
filesystem compare
filesystem concepts
-filesystem cstddef
ldionne wrote:
These transitive includes should probably not need to change. If they do
change, we should add includes to th
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/108990
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -53,24 +56,150 @@ _LIBCPP_BEGIN_NAMESPACE_STD
namespace __format {
+// A helper to limit the total size of code units written.
+class _LIBCPP_HIDE_FROM_ABI __max_output_size {
+public:
+ [[nodiscard]] _LIBCPP_HIDE_FROM_ABI explicit __max_output_size(size_t
__max_size) :
@@ -53,24 +56,150 @@ _LIBCPP_BEGIN_NAMESPACE_STD
namespace __format {
+// A helper to limit the total size of code units written.
+class _LIBCPP_HIDE_FROM_ABI __max_output_size {
+public:
+ [[nodiscard]] _LIBCPP_HIDE_FROM_ABI explicit __max_output_size(size_t
__max_size) :
@@ -53,24 +56,150 @@ _LIBCPP_BEGIN_NAMESPACE_STD
namespace __format {
+// A helper to limit the total size of code units written.
+class _LIBCPP_HIDE_FROM_ABI __max_output_size {
+public:
+ [[nodiscard]] _LIBCPP_HIDE_FROM_ABI explicit __max_output_size(size_t
__max_size) :
https://github.com/ldionne commented:
I have some minor comments but this looks really good!
https://github.com/llvm/llvm-project/pull/108990
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
@@ -53,24 +56,150 @@ _LIBCPP_BEGIN_NAMESPACE_STD
namespace __format {
+// A helper to limit the total size of code units written.
+class _LIBCPP_HIDE_FROM_ABI __max_output_size {
+public:
+ [[nodiscard]] _LIBCPP_HIDE_FROM_ABI explicit __max_output_size(size_t
__max_size) :
@@ -319,188 +353,222 @@ struct _LIBCPP_TEMPLATE_VIS
__back_insert_iterator_container
-class _LIBCPP_TEMPLATE_VIS __writer_container {
+// A dynamically growing buffer.
+template <__fmt_char_type _CharT>
+class _LIBCPP_TEMPLATE_VIS __allocating_buffer : public
__output_buffer<_Ch
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/108990
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/108515
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/101835
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/101831
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -56,6 +57,30 @@ _LIBCPP_BEGIN_NAMESPACE_STD
namespace __format {
+// A helper to limit the total size of code units written.
+class _LIBCPP_HIDE_FROM_ABI __max_output_size {
+public:
+ [[nodiscard]] _LIBCPP_HIDE_FROM_ABI explicit __max_output_size(size_t
__max_size) : __
1 - 100 of 453 matches
Mail list logo
