https://github.com/kyulee-com approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/142584
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
kyulee-com wrote:
Can we add a LIT test case using this flag? I think you could set it with a
smaller number to create a test case.
https://github.com/llvm/llvm-project/pull/142584
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.or
kyulee-com wrote:
Adding this threshold check within `isTrellis()` feels somewhat unnatural. If
compile time is a concern, could we simply check the size of functions (in
terms of the number of blocks, as opposed to predecessor only) early in this
pass and either skip it or switch to a faster,
kyulee-com wrote:
> I can confirm that the performance have been improved significantly from my
> testing on no-LTO projects that the slowdown is acceptable now. Before
> applying the PR it was about 50% slowdown, now it is ~5%.
That's great to hear!
Since these PRs appear to be functioning, i
kyulee-com wrote:
@nocchijiang The new approach seems to be functioning well and is similar in
size to the previous method.
I suspect that the no-LTO case might still encounter some slowdown, as each CU
needs to read the entire CGData regardless. Currently, the CGData used for this
merging pr
kyulee-com wrote:
@nocchijiang The new approach seems to be functioning well and is similar in
size to the previous method.
I suspect that the no-LTO case might still encounter some slowdown, as each CU
needs to read the entire CGData regardless. Currently, the CGData used for this
merging pr
kyulee-com wrote:
> Do we know why `OpIdx` is 4 here? This is confusing to me because it looks
> like there is only one argument, `%5`.
The `ignoreOp` function was initially designed for use with
`llvm::StructuralHashWithDifferences`, where it iterates over operands within
the same instructio
https://github.com/kyulee-com edited
https://github.com/llvm/llvm-project/pull/115750
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
kyulee-com wrote:
> Hit an assertion in `ignoreOp` when testing the refactored code.
>
> ```
> Assertion failed: (OpIdx < I->getNumOperands() && "Invalid operand index"),
> function ignoreOp, file GlobalMergeFunctions.cpp, line 129.
> Stop reason: hit program assert
> expr I->dump()
> %6 = ta
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/115750
>From 70dcb2ccba98b392c3539f349ccf7fec284a674c Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Mon, 11 Nov 2024 10:06:56 -0800
Subject: [PATCH 1/3] [CGData] Refactor Global Merge Functions
---
llvm/lib/Co
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/115750
>From 70dcb2ccba98b392c3539f349ccf7fec284a674c Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Mon, 11 Nov 2024 10:06:56 -0800
Subject: [PATCH 1/2] [CGData] Refactor Global Merge Functions
---
llvm/lib/Co
@@ -420,101 +412,79 @@ static ParamLocsVecTy computeParamInfo(
bool GlobalMergeFunc::merge(Module &M, const StableFunctionMap *FunctionMap) {
bool Changed = false;
- // Build a map from stable function name to function.
- StringMap StableNameToFuncMap;
- for (auto &F : M)
https://github.com/kyulee-com ready_for_review
https://github.com/llvm/llvm-project/pull/115750
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/kyulee-com edited
https://github.com/llvm/llvm-project/pull/115750
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/115750
>From 70dcb2ccba98b392c3539f349ccf7fec284a674c Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Mon, 11 Nov 2024 10:06:56 -0800
Subject: [PATCH 1/2] [CGData] Refactor Global Merge Functions
---
llvm/lib/Co
https://github.com/kyulee-com edited
https://github.com/llvm/llvm-project/pull/115750
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/kyulee-com created
https://github.com/llvm/llvm-project/pull/115750
None
>From 70dcb2ccba98b392c3539f349ccf7fec284a674c Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Mon, 11 Nov 2024 10:06:56 -0800
Subject: [PATCH] [CGData] Refactor Global Merge Functions
---
llvm/lib/
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/112664
>From c7913f9fff736da4cc6a78a17e41dc539bc75e8a Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Mon, 9 Sep 2024 19:38:05 -0700
Subject: [PATCH 1/2] [CGData][llvm-cgdata] Support for stable function map
This
https://github.com/kyulee-com ready_for_review
https://github.com/llvm/llvm-project/pull/112664
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
kyulee-com wrote:
cc. @nocchijiang
https://github.com/llvm/llvm-project/pull/112664
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/kyulee-com edited
https://github.com/llvm/llvm-project/pull/112664
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/112664
>From c7913f9fff736da4cc6a78a17e41dc539bc75e8a Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Mon, 9 Sep 2024 19:38:05 -0700
Subject: [PATCH] [CGData][llvm-cgdata] Support for stable function map
This int
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/112638
>From 6225d74229d41068c57109a24b063f6fcba13985 Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Wed, 16 Oct 2024 17:09:07 -0700
Subject: [PATCH 1/4] [StructuralHash] Support Differences
This comutes a struc
kyulee-com wrote:
The test failure `TableGen/x86-fold-tables.td` seems unrelated.
https://github.com/llvm/llvm-project/pull/112638
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
@@ -100,8 +233,20 @@ class StructuralHashImpl {
if (const auto *ComparisonInstruction = dyn_cast(&Inst))
Hashes.emplace_back(ComparisonInstruction->getPredicate());
-for (const auto &Op : Inst.operands())
- Hashes.emplace_back(hashOperand(Op));
+unsigned
@@ -47,24 +60,140 @@ class StructuralHashImpl {
public:
StructuralHashImpl() = delete;
- explicit StructuralHashImpl(bool DetailedHash) : DetailedHash(DetailedHash)
{}
+ explicit StructuralHashImpl(bool DetailedHash,
+ IgnoreOperandFunc Ignore
kyulee-com wrote:
> IIRC we have several lit tests that cover structural hash, shouldn't we have
> a new test there that uses the new functionality?
Extended the existing `StructuralHashPrinterPass` with `Options`, and updated
the corresponding lit test accordingly.
https://github.com/llvm/ll
@@ -47,24 +60,140 @@ class StructuralHashImpl {
public:
StructuralHashImpl() = delete;
- explicit StructuralHashImpl(bool DetailedHash) : DetailedHash(DetailedHash)
{}
+ explicit StructuralHashImpl(bool DetailedHash,
+ IgnoreOperandFunc Ignore
@@ -47,24 +60,140 @@ class StructuralHashImpl {
public:
StructuralHashImpl() = delete;
- explicit StructuralHashImpl(bool DetailedHash) : DetailedHash(DetailedHash)
{}
+ explicit StructuralHashImpl(bool DetailedHash,
+ IgnoreOperandFunc Ignore
@@ -47,24 +60,140 @@ class StructuralHashImpl {
public:
StructuralHashImpl() = delete;
- explicit StructuralHashImpl(bool DetailedHash) : DetailedHash(DetailedHash)
{}
+ explicit StructuralHashImpl(bool DetailedHash,
+ IgnoreOperandFunc Ignore
@@ -47,24 +60,140 @@ class StructuralHashImpl {
public:
StructuralHashImpl() = delete;
- explicit StructuralHashImpl(bool DetailedHash) : DetailedHash(DetailedHash)
{}
+ explicit StructuralHashImpl(bool DetailedHash,
+ IgnoreOperandFunc Ignore
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/112638
>From 6225d74229d41068c57109a24b063f6fcba13985 Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Wed, 16 Oct 2024 17:09:07 -0700
Subject: [PATCH 1/3] [StructuralHash] Support Differences
This comutes a struc
https://github.com/kyulee-com edited
https://github.com/llvm/llvm-project/pull/112638
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/kyulee-com ready_for_review
https://github.com/llvm/llvm-project/pull/112638
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/112671
>From ded5771bb4ff7c8fd5401b4efe0af988539a8162 Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Fri, 30 Aug 2024 00:09:09 -0700
Subject: [PATCH 1/2] [CGData] Global Merge Functions
---
llvm/include/llvm/CG
https://github.com/kyulee-com edited
https://github.com/llvm/llvm-project/pull/112671
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/kyulee-com edited
https://github.com/llvm/llvm-project/pull/112664
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/kyulee-com edited
https://github.com/llvm/llvm-project/pull/112674
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/kyulee-com edited
https://github.com/llvm/llvm-project/pull/112662
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/kyulee-com edited
https://github.com/llvm/llvm-project/pull/112638
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/kyulee-com edited
https://github.com/llvm/llvm-project/pull/112638
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/112674
>From ead1aee8eeb4046ec0641c09652cea726becd48a Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Wed, 16 Oct 2024 22:56:38 -0700
Subject: [PATCH] [CGData][lld-macho] Add Global Merge Func Pass
---
lld/MachO
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/112671
>From ded5771bb4ff7c8fd5401b4efe0af988539a8162 Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Fri, 30 Aug 2024 00:09:09 -0700
Subject: [PATCH] [CGData] Global Merge Functions
---
llvm/include/llvm/CGData
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/112664
>From 09f1ec7730868a53cb566b0913e7952dfc15fa16 Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Mon, 9 Sep 2024 19:38:05 -0700
Subject: [PATCH] [CGData][llvm-cgdata] Support for stable function map
This int
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/112674
>From 549cf5d3880450641c720a6bc1f3bddae272f902 Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Wed, 16 Oct 2024 22:56:38 -0700
Subject: [PATCH] [CGData][lld-macho] Add Global Merge Func Pass
---
lld/MachO
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/112671
>From 1601086634428b95d1a195e5ecb8f5b9d1f1709c Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Fri, 30 Aug 2024 00:09:09 -0700
Subject: [PATCH] [CGData] Global Merge Functions
---
llvm/include/llvm/CGData
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/112674
>From 6b0b6194a02209036e032a8941f8e5817b402318 Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Wed, 16 Oct 2024 22:56:38 -0700
Subject: [PATCH] [CGData][lld-macho] Add Global Merge Func Pass
---
lld/MachO
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/112671
>From 584a2d7fdadf91838b7b305a1b09056fcb0e805f Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Fri, 30 Aug 2024 00:09:09 -0700
Subject: [PATCH] [CGData] Global Merge Functions
---
llvm/include/llvm/CGData
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/112664
>From 09f1ec7730868a53cb566b0913e7952dfc15fa16 Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Mon, 9 Sep 2024 19:38:05 -0700
Subject: [PATCH] [CGData][llvm-cgdata] Support for stable function map
This int
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/112662
>From 060a23e39a68729859bb7b74e38586b0356e2ba6 Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Sat, 7 Sep 2024 22:48:17 -0700
Subject: [PATCH] [CGData] Stable Function Map
These define the main data struct
https://github.com/kyulee-com created
https://github.com/llvm/llvm-project/pull/112674
None
>From 36978c1da750496941705b284b3c34495b6f7386 Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Wed, 16 Oct 2024 22:56:38 -0700
Subject: [PATCH] [CGData][lld-macho] Add Global Merge Func Pass
---
lld
https://github.com/kyulee-com created
https://github.com/llvm/llvm-project/pull/112671
None
>From 2a690c75924de5feadb4a582d76822b4d4d1d2cf Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Fri, 30 Aug 2024 00:09:09 -0700
Subject: [PATCH] [CGData] Global Merge Functions
---
llvm/include/llvm/
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/112664
>From f6fc25953b8f5109abb968c43ebc7d53f2e475db Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Mon, 9 Sep 2024 19:38:05 -0700
Subject: [PATCH] [CGData][llvm-cgdata] Support for stable function map
This int
https://github.com/kyulee-com updated
https://github.com/llvm/llvm-project/pull/112664
>From 3b73ee558d57434ee1f8447ac2509db371d95d8f Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Mon, 9 Sep 2024 19:38:05 -0700
Subject: [PATCH] [CGData][llvm-cgdata] Support for stable function map
This int
https://github.com/kyulee-com created
https://github.com/llvm/llvm-project/pull/112664
This introduces a new cgdata format for stable function maps. The raw data is
embedded in the __llvm_merge section during compile time. This data can be read
and merged using the llvm-cgdata tool, into an in
https://github.com/kyulee-com created
https://github.com/llvm/llvm-project/pull/112662
These define the main data structures to represent stable functions and group
similar functions in a function map.
Serialization is supported in a binary or yaml form.
>From e7272c3a0293a0b2972e893335d652cc1
https://github.com/kyulee-com created
https://github.com/llvm/llvm-project/pull/112638
This comutes a structural hash while allowing for selective ignoring of certain
operands based on a custom function that is provided. Instead of a single hash
value, it now returns FunctionHashInfo which inc
https://github.com/kyulee-com created
https://github.com/llvm/llvm-project/pull/111464
None
>From 1249f0411388fb0832b49e80e7b6a0985822b026 Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Fri, 13 Sep 2024 08:51:00 -0700
Subject: [PATCH 1/4] [CGData][ThinLTO] Global Outlining with Two-CodeGen
https://github.com/kyulee-com created
https://github.com/llvm/llvm-project/pull/109137
None
>From 32ae0b07276f7ccbdc5dd6675e0c46b507625449 Mon Sep 17 00:00:00 2001
From: Kyungwoo Lee
Date: Wed, 18 Sep 2024 06:05:41 -0700
Subject: [PATCH] test2
---
llvm/lib/LTO/LTO.cpp | 1 +
1 file changed,
https://github.com/kyulee-com approved this pull request.
https://github.com/llvm/llvm-project/pull/103886
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
kyulee-com wrote:
> > So we should remove this tool from the 19.x release? Can someone confirm?
>
> @kyulee-com @thevinster Are you two able to help confirm this?
Yeah. I think we should remove this from the release as it was reverted.
We plan to re-land it via https://github.com/llvm/llvm-proj
61 matches
Mail list logo
