[llvm-branch-commits] [clang-tools-extra] [clang-tidy] fix false positive in lambda expr for return-const-ref-from-parameter (PR #118990)

https://github.com/5chmidti approved this pull request. Nice catch, LGTM https://github.com/llvm/llvm-project/pull/118990 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branc

[llvm-branch-commits] [clang] [clang][test] remove unused `run` overload in `BoundNodesCallback` (PR #105935)

https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/105935 >From 2072160d9b7763c58edd14083a4523fd94e6040f Mon Sep 17 00:00:00 2001 From: Julian Schmidt Date: Sat, 1 Jun 2024 17:49:13 +0200 Subject: [PATCH] [clang][test] remove unused `run` overload in `BoundNodesCallb

[llvm-branch-commits] [clang] [clang][test] add testing for the AST matcher reference (PR #94248)

https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/94248 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang][test] remove unused `run` overload in `BoundNodesCallback` (PR #94244)

5chmidti wrote: Thanks for noticing this pr, I've had a deadline to uphold and wasn't that active. This pr was actually part of a stack, and unluckily not the bottom pr that merges into `main`, so I've recreated the pr. I didn't want to ping Aaron for the last approval needed during the branch

[llvm-branch-commits] [clang] [clang][test] remove unused `run` overload in `BoundNodesCallback` (PR #105935)

5chmidti wrote: Recreated after accidental merge in #94244 because this is part of a stack. Previous approval is in the linked pr. https://github.com/llvm/llvm-project/pull/105935 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [clang] [clang][test] remove unused `run` overload in `BoundNodesCallback` (PR #105935)

https://github.com/5chmidti created https://github.com/llvm/llvm-project/pull/105935 The overload that did not take the additional `ASTContext *` argument is unnecessary when the context could simply be commented out, as it is always passed to `run` from `VerifyMatcher::run`. This patch remove

[llvm-branch-commits] [clang-tidy] Add FixIts for libc namespace macros (PR #99681)

@@ -41,8 +50,26 @@ void ImplementationInNamespaceCheck::check( // Enforce that the namespace is the result of macro expansion if (Result.SourceManager->isMacroBodyExpansion(NS->getLocation()) == false) { -diag(NS->getLocation(), "the outermost namespace should be the '

[llvm-branch-commits] [clang-tidy] Add FixIts for libc namespace macros (PR #99681)

@@ -41,8 +50,26 @@ void ImplementationInNamespaceCheck::check( // Enforce that the namespace is the result of macro expansion if (Result.SourceManager->isMacroBodyExpansion(NS->getLocation()) == false) { -diag(NS->getLocation(), "the outermost namespace should be the '

[llvm-branch-commits] [clang-tidy] Add FixIts for libc namespace macros (PR #99681)

5chmidti wrote: Please add a test with an outer namespace that needs to be changed, but which already has the hidden visibility attribute. That way, we'll be sure that the replacement will replace the namespace name instead of breaking the attribute into piec

[llvm-branch-commits] [clang-tidy] Add FixIts for libc namespace macros (PR #99681)

@@ -41,8 +50,26 @@ void ImplementationInNamespaceCheck::check( // Enforce that the namespace is the result of macro expansion if (Result.SourceManager->isMacroBodyExpansion(NS->getLocation()) == false) { -diag(NS->getLocation(), "the outermost namespace should be the '

[llvm-branch-commits] [clang-tidy] Add FixIts for libc namespace macros (PR #99681)

https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/99681 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang-tidy] Add FixIts for libc namespace macros (PR #99681)

@@ -51,7 +78,9 @@ void ImplementationInNamespaceCheck::check( // instead. if (NS->getVisibility() != Visibility::HiddenVisibility) { diag(NS->getLocation(), "the '%0' macro should start with '%1'") -<< RequiredNamespaceDeclMacroName << RequiredNamespaceDeclStart

[llvm-branch-commits] [clang-tidy] Add FixIts for libc namespace macros (PR #99681)

https://github.com/5chmidti commented: (not familiar with libc development) One question may be if the outer namespace should be replaced with the libc macro, or if the libc macro should be added around the other namespace. But given that this check is for libc development, then the libc peopl

[llvm-branch-commits] [clang-tidy] Add FixIts for libc namespace macros (PR #99681)

@@ -1,4 +1,6 @@ -// RUN: %check_clang_tidy %s llvmlibc-implementation-in-namespace %t +// RUN: %check_clang_tidy %s llvmlibc-implementation-in-namespace %t -fix 5chmidti wrote: No need to specify `-fix`, fixes are done automatically, e.g., https://github.com/llv

[llvm-branch-commits] [clang] [clang][test] remove unused `run` overload in `BoundNodesCallback` (PR #94244)

https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/94244 >From 26d5b0377af3df4c551ae16d053684bb8c75e233 Mon Sep 17 00:00:00 2001 From: Julian Schmidt Date: Sat, 1 Jun 2024 17:49:13 +0200 Subject: [PATCH] [clang][test] remove unused `run` overload in `BoundNodesCallba

[llvm-branch-commits] [clang] [clang][test] add testing for the AST matcher reference (PR #94248)

5chmidti wrote: rebase on trunk + rebased stack https://github.com/llvm/llvm-project/pull/94248 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang][test] remove unused `run` overload in `BoundNodesCallback` (PR #94244)

5chmidti wrote: rebase on trunk + rebased stack https://github.com/llvm/llvm-project/pull/94244 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang][test] remove unused `run` overload in `BoundNodesCallback` (PR #94244)

https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/94244 >From 51de6278688635cdcd5a8dd73a2ef0ede2a31b37 Mon Sep 17 00:00:00 2001 From: Julian Schmidt Date: Sat, 1 Jun 2024 17:49:13 +0200 Subject: [PATCH] [clang][test] remove unused `run` overload in `BoundNodesCallba

[llvm-branch-commits] [clang] [clang][test] add testing for the AST matcher reference (PR #94248)

5chmidti wrote: > Do you need me to land the changes on your behalf? No need, I can do that. However, this PR is in a stack and depends on two small PRs: #94244 and #94243 that need to be reviewed before this PR can be merged https://github.com/llvm/llvm-project/pull/94248

[llvm-branch-commits] [clang] [clang][test] add testing for the AST matcher reference (PR #94248)

5chmidti wrote: Thanks. > ... how this impacts build times for Clang itself? I'm assuming that if > ASTMatchers.h isn't modified, CMake won't re-run > generate_ast_matcher_doc_tests.py and so the compile time performance hit is > only on full rebuilds or when changing the header? The 'state'

[llvm-branch-commits] [clang] [clang][test] add testing for the AST matcher reference (PR #94248)

5chmidti wrote: - added a file-level comment in the ASTMatcher.h file on how the syntax works (basically the pr description) - replaced some `type=name` matches with explicit code matches where applicable, to be more expressive - added comments to `count=` matches when they didn't explain why o

[llvm-branch-commits] [clang] [clang][test] add testing for the AST matcher reference (PR #94248)

@@ -330,35 +377,46 @@ AST_POLYMORPHIC_MATCHER_P(isExpandedFromMacro, /// Matches declarations. /// -/// Examples matches \c X, \c C, and the friend declaration inside \c C; +/// Given /// \code /// void X(); /// class C { -/// friend X; +/// friend void X(); //

[llvm-branch-commits] [clang] [clang][test] add testing for the AST matcher reference (PR #94248)

https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/94248 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang][test] add testing for the AST matcher reference (PR #94248)

@@ -176,11 +176,13 @@ inline internal::TrueMatcher anything() { return internal::TrueMatcher(); } /// \code /// int X; /// namespace NS { -/// int Y; +/// int Y; /// } // namespace NS /// \endcode -/// decl(hasDeclContext(translationUnitDecl())) -/// matches "

[llvm-branch-commits] [clang] [clang][test] add testing for the AST matcher reference (PR #94248)

https://github.com/5chmidti commented: > I wonder if we should add some documentation to ASTMatchers.h I'll add one in a day or so. I updated the description with some more information, and I'll probably take parts of that as a basis for the comment in the header (and update the script comment

[llvm-branch-commits] [clang] [clang][test] add testing for the AST matcher reference (PR #94248)

https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/94248 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang][test] add testing for the AST matcher reference (PR #94248)

https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/94248 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang][test] remove unused `run` overload in `BoundNodesCallback` (PR #94244)

https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/94244 >From 615f30ba7db2bb13d20b4c2a8c0d405a8419ecae Mon Sep 17 00:00:00 2001 From: Julian Schmidt Date: Sat, 1 Jun 2024 17:49:13 +0200 Subject: [PATCH] [clang][test] remove unused `run` overload in `BoundNodesCallba

[llvm-branch-commits] [clang] [clang][test] add testing for the AST matcher reference (PR #94248)

https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/94248 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang][test] add testing for the AST matcher reference (PR #94248)

https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/94248 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang][test] add testing for the AST matcher reference (PR #94248)

https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/94248 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang][test] add testing for the AST matcher reference (PR #94248)

5chmidti wrote: CC @llvm/pr-subscribers-clang-tidy as stake-holders in matchers https://github.com/llvm/llvm-project/pull/94248 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm

[llvm-branch-commits] [clang] [clang][test] remove unused `run` overload in `BoundNodesCallback` (PR #94244)

https://github.com/5chmidti created https://github.com/llvm/llvm-project/pull/94244 The overload that did not take the additional `ASTContext *` argument is unnecessary when the context could simply be commented out, as it is always passed to `run` from `VerifyMatcher::run`. This patch removes