jdoerfert wrote:
FWIW, nvptx backend unfortunately works by "fixing stuff up" late. It
shouldn't, but it does. I'd prefer to not to fix stuff up at all and maybe the
best way is to have proper assertions in the creation of allocas/globals/...
and/or the verifier.
https://github.com/llvm/llvm
https://github.com/jdoerfert commented:
Looks reasonable to me. I left one comment and I believe you can verify what is
best yourself.
https://github.com/llvm/llvm-project/pull/118878
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.ll
https://github.com/jdoerfert edited
https://github.com/llvm/llvm-project/pull/118878
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -9406,6 +9406,14 @@ StmtResult
TreeTransform::TransformOMPInformationalDirective(
D->getBeginLoc(), D->getEndLoc());
}
+template
+StmtResult TreeTransform::TransformOMPCompoundRootDirective(
+OMPCompoundRootDirective *D) {
+ // This function should never be fou
@@ -6758,6 +6793,27 @@ static Expected createOutlinedFunction(
auto Func =
Function::Create(FuncType, GlobalValue::InternalLinkage, FuncName, M);
+ // Forward target-cpu and target-features function attributes from the
+ // original function to the new outlined funct
@@ -6758,6 +6793,27 @@ static Expected createOutlinedFunction(
auto Func =
Function::Create(FuncType, GlobalValue::InternalLinkage, FuncName, M);
+ // Forward target-cpu and target-features function attributes from the
+ // original function to the new outlined funct
@@ -6122,8 +6122,10 @@ TEST_F(OpenMPIRBuilderTest, TargetRegion) {
OpenMPIRBuilderConfig Config(false, false, false, false, false, false,
false);
OMPBuilder.setConfig(Config);
F->setName("func");
+ F->addFnAttr("target-cpu", "x86-64");
+ F->addFnAttr("target-features",
@@ -6727,8 +6727,43 @@ FunctionCallee
OpenMPIRBuilder::createDispatchDeinitFunction() {
return getOrCreateRuntimeFunction(M, omp::OMPRTL___kmpc_dispatch_deinit);
}
+static void emitUsed(StringRef Name, std::vector &List,
+ Module &M) {
+ if (List.empty(
@@ -6378,6 +6439,204 @@ TEST_F(OpenMPIRBuilderTest, TargetRegionDevice) {
auto *ExitBlock = EntryBlockBranch->getSuccessor(1);
EXPECT_EQ(ExitBlock->getName(), "worker.exit");
EXPECT_TRUE(isa(ExitBlock->getFirstNonPHI()));
+
+ // Check global exec_mode.
+ GlobalVariable
@@ -7427,13 +7521,17 @@ emitTargetCall(OpenMPIRBuilder &OMPBuilder,
IRBuilderBase &Builder,
}
OpenMPIRBuilder::InsertPointOrErrorTy OpenMPIRBuilder::createTarget(
-const LocationDescription &Loc, bool IsOffloadEntry, InsertPointTy
AllocaIP,
-InsertPointTy CodeGenIP,
https://github.com/jdoerfert approved this pull request.
LG
https://github.com/llvm/llvm-project/pull/102812
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/jdoerfert approved this pull request.
Looks simple and good to me.
https://github.com/llvm/llvm-project/pull/101407
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
jdoerfert wrote:
I thought I tried this myself. Does it really work, as in, is the mode set
properly for full and thin lto? I think I had problems for one of them.
https://github.com/llvm/llvm-project/pull/100953
___
llvm-branch-commits mailing list
l
jdoerfert wrote:
If we make being declare variant elide on a user defined compile time
condition, we could use the change in the `EF_AMDGPU_MACH_AMDGCN_LAST` value to
determine a minimum version:
```
EF_AMDGPU_MACH_AMDGCN_LAST <= EF_AMDGPU_MACH_AMDGCN_GFX1013,
```
It's not possible right now bu
Author: Johannes Doerfert
Date: 2023-11-27T16:02:34-08:00
New Revision: e1f911e40ce6ad4a7f393ea1b33e65b24940eb84
URL:
https://github.com/llvm/llvm-project/commit/e1f911e40ce6ad4a7f393ea1b33e65b24940eb84
DIFF:
https://github.com/llvm/llvm-project/commit/e1f911e40ce6ad4a7f393ea1b33e65b24940eb84.d
Author: Johannes Doerfert
Date: 2023-11-27T16:02:34-08:00
New Revision: d2636dc39043f6adda3a6797fc5b7966bd4cb2f0
URL:
https://github.com/llvm/llvm-project/commit/d2636dc39043f6adda3a6797fc5b7966bd4cb2f0
DIFF:
https://github.com/llvm/llvm-project/commit/d2636dc39043f6adda3a6797fc5b7966bd4cb2f0.d
Author: Johannes Doerfert
Date: 2023-11-27T16:02:33-08:00
New Revision: 30fbe73ba9c726acbe0658e4ea98f328724482e5
URL:
https://github.com/llvm/llvm-project/commit/30fbe73ba9c726acbe0658e4ea98f328724482e5
DIFF:
https://github.com/llvm/llvm-project/commit/30fbe73ba9c726acbe0658e4ea98f328724482e5.d
Author: Johannes Doerfert
Date: 2023-11-27T16:02:33-08:00
New Revision: 77aa79d4fb646b9fd28176d3845117a6a2da6745
URL:
https://github.com/llvm/llvm-project/commit/77aa79d4fb646b9fd28176d3845117a6a2da6745
DIFF:
https://github.com/llvm/llvm-project/commit/77aa79d4fb646b9fd28176d3845117a6a2da6745.d
Author: Johannes Doerfert
Date: 2023-11-27T16:02:33-08:00
New Revision: 755e1088258b030cdd00cfa1b184c58fe41b4287
URL:
https://github.com/llvm/llvm-project/commit/755e1088258b030cdd00cfa1b184c58fe41b4287
DIFF:
https://github.com/llvm/llvm-project/commit/755e1088258b030cdd00cfa1b184c58fe41b4287.d
Author: Johannes Doerfert
Date: 2021-01-07T14:53:20-06:00
New Revision: 0b0f2e6ee0c3e52398a0d0c4a5131d4a23d8b1ee
URL:
https://github.com/llvm/llvm-project/commit/0b0f2e6ee0c3e52398a0d0c4a5131d4a23d8b1ee
DIFF:
https://github.com/llvm/llvm-project/commit/0b0f2e6ee0c3e52398a0d0c4a5131d4a23d8b1ee.d
Author: Johannes Doerfert
Date: 2021-01-07T14:39:18-06:00
New Revision: 6e7101530dae78efd7b5cdffc1338790ed3e5705
URL:
https://github.com/llvm/llvm-project/commit/6e7101530dae78efd7b5cdffc1338790ed3e5705
DIFF:
https://github.com/llvm/llvm-project/commit/6e7101530dae78efd7b5cdffc1338790ed3e5705.d
Author: Johannes Doerfert
Date: 2021-01-07T14:31:20-06:00
New Revision: 36c4dc9b42fe2e6af4ab488b7c4013d5082b67f6
URL:
https://github.com/llvm/llvm-project/commit/36c4dc9b42fe2e6af4ab488b7c4013d5082b67f6
DIFF:
https://github.com/llvm/llvm-project/commit/36c4dc9b42fe2e6af4ab488b7c4013d5082b67f6.d
Author: Johannes Doerfert
Date: 2021-01-07T14:31:18-06:00
New Revision: d970a285b8567b93aea39e7e4d10965fe8b7340c
URL:
https://github.com/llvm/llvm-project/commit/d970a285b8567b93aea39e7e4d10965fe8b7340c
DIFF:
https://github.com/llvm/llvm-project/commit/d970a285b8567b93aea39e7e4d10965fe8b7340c.d
Author: Johannes Doerfert
Date: 2021-01-07T14:31:17-06:00
New Revision: 9ae171bcd38cdefa64c9dd5d763d16007eebcd0d
URL:
https://github.com/llvm/llvm-project/commit/9ae171bcd38cdefa64c9dd5d763d16007eebcd0d
DIFF:
https://github.com/llvm/llvm-project/commit/9ae171bcd38cdefa64c9dd5d763d16007eebcd0d.d
Author: Johannes Doerfert
Date: 2020-12-22T13:06:23-06:00
New Revision: 7b0f9dd79a3c1799866a7b08e172598df90c649f
URL:
https://github.com/llvm/llvm-project/commit/7b0f9dd79a3c1799866a7b08e172598df90c649f
DIFF:
https://github.com/llvm/llvm-project/commit/7b0f9dd79a3c1799866a7b08e172598df90c649f.d
Author: Johannes Doerfert
Date: 2020-12-22T13:05:04-06:00
New Revision: 9cb748724ef5d7d0f7d662d849423404267d532a
URL:
https://github.com/llvm/llvm-project/commit/9cb748724ef5d7d0f7d662d849423404267d532a
DIFF:
https://github.com/llvm/llvm-project/commit/9cb748724ef5d7d0f7d662d849423404267d532a.d
Author: Johannes Doerfert
Date: 2020-12-17T14:38:26-06:00
New Revision: 994bb6eb7d01db1d9461e54d17a63af2ba1af2c9
URL:
https://github.com/llvm/llvm-project/commit/994bb6eb7d01db1d9461e54d17a63af2ba1af2c9
DIFF:
https://github.com/llvm/llvm-project/commit/994bb6eb7d01db1d9461e54d17a63af2ba1af2c9.d
Author: Johannes Doerfert
Date: 2020-12-16T20:02:49-06:00
New Revision: 2e6e4e6aeef71dd8fba038177a34a82b574d2126
URL:
https://github.com/llvm/llvm-project/commit/2e6e4e6aeef71dd8fba038177a34a82b574d2126
DIFF:
https://github.com/llvm/llvm-project/commit/2e6e4e6aeef71dd8fba038177a34a82b574d2126.d
Author: Johannes Doerfert
Date: 2020-12-15T18:03:10-06:00
New Revision: 1efd7a73acdf1e3f61bbcf82d3c30be41771ce6b
URL:
https://github.com/llvm/llvm-project/commit/1efd7a73acdf1e3f61bbcf82d3c30be41771ce6b
DIFF:
https://github.com/llvm/llvm-project/commit/1efd7a73acdf1e3f61bbcf82d3c30be41771ce6b.d
Author: Johannes Doerfert
Date: 2020-12-15T17:24:53-06:00
New Revision: bc7126b2bc542fdb28347c73a9cb193f5790d93b
URL:
https://github.com/llvm/llvm-project/commit/bc7126b2bc542fdb28347c73a9cb193f5790d93b
DIFF:
https://github.com/llvm/llvm-project/commit/bc7126b2bc542fdb28347c73a9cb193f5790d93b.d
Author: Johannes Doerfert
Date: 2020-12-15T16:51:34-06:00
New Revision: a5a14cbe7f87e01882ecaa14df5d596cbf38823a
URL:
https://github.com/llvm/llvm-project/commit/a5a14cbe7f87e01882ecaa14df5d596cbf38823a
DIFF:
https://github.com/llvm/llvm-project/commit/a5a14cbe7f87e01882ecaa14df5d596cbf38823a.d
Author: Johannes Doerfert
Date: 2020-12-15T16:51:34-06:00
New Revision: dcaec81211be973364cf7830a3db63781e15a474
URL:
https://github.com/llvm/llvm-project/commit/dcaec81211be973364cf7830a3db63781e15a474
DIFF:
https://github.com/llvm/llvm-project/commit/dcaec81211be973364cf7830a3db63781e15a474.d
Author: Johannes Doerfert
Date: 2020-12-15T16:51:34-06:00
New Revision: b9c77542e23756967e77dc42412effc41257a850
URL:
https://github.com/llvm/llvm-project/commit/b9c77542e23756967e77dc42412effc41257a850
DIFF:
https://github.com/llvm/llvm-project/commit/b9c77542e23756967e77dc42412effc41257a850.d
Author: Johannes Doerfert
Date: 2020-12-15T16:51:34-06:00
New Revision: d08d490a4cb93d05d728b6661f8c34d0064a53c6
URL:
https://github.com/llvm/llvm-project/commit/d08d490a4cb93d05d728b6661f8c34d0064a53c6
DIFF:
https://github.com/llvm/llvm-project/commit/d08d490a4cb93d05d728b6661f8c34d0064a53c6.d
Author: Johannes Doerfert
Date: 2020-11-25T11:52:35-06:00
New Revision: 227c8ff189c3861c11f6e80c31274c5fa28a2ee9
URL:
https://github.com/llvm/llvm-project/commit/227c8ff189c3861c11f6e80c31274c5fa28a2ee9
DIFF:
https://github.com/llvm/llvm-project/commit/227c8ff189c3861c11f6e80c31274c5fa28a2ee9.d
Author: Johannes Doerfert
Date: 2020-11-25T11:52:35-06:00
New Revision: c557f549ba049131e444dd17dc326988158677ef
URL:
https://github.com/llvm/llvm-project/commit/c557f549ba049131e444dd17dc326988158677ef
DIFF:
https://github.com/llvm/llvm-project/commit/c557f549ba049131e444dd17dc326988158677ef.d
Author: Johannes Doerfert
Date: 2020-04-04T01:56:18-05:00
New Revision: d1fe2040b09288e1fc582fe87911ee5d4edc7aa0
URL:
https://github.com/llvm/llvm-project/commit/d1fe2040b09288e1fc582fe87911ee5d4edc7aa0
DIFF:
https://github.com/llvm/llvm-project/commit/d1fe2040b09288e1fc582fe87911ee5d4edc7aa0.d
Author: Johannes Doerfert
Date: 2020-04-04T00:27:07-05:00
New Revision: 2a636ffac1a7d92754cd323b5ba43e7b3a14a5d5
URL:
https://github.com/llvm/llvm-project/commit/2a636ffac1a7d92754cd323b5ba43e7b3a14a5d5
DIFF:
https://github.com/llvm/llvm-project/commit/2a636ffac1a7d92754cd323b5ba43e7b3a14a5d5.d
Author: Johannes Doerfert
Date: 2020-04-03T21:26:26-05:00
New Revision: 7f46c38128e7d80df1a0d43d3bbcb390ab70068a
URL:
https://github.com/llvm/llvm-project/commit/7f46c38128e7d80df1a0d43d3bbcb390ab70068a
DIFF:
https://github.com/llvm/llvm-project/commit/7f46c38128e7d80df1a0d43d3bbcb390ab70068a.d
Author: Johannes Doerfert
Date: 2020-04-04T01:56:18-05:00
New Revision: 544ffda5ec21371d3fdace2c11378993e56f6b5b
URL:
https://github.com/llvm/llvm-project/commit/544ffda5ec21371d3fdace2c11378993e56f6b5b
DIFF:
https://github.com/llvm/llvm-project/commit/544ffda5ec21371d3fdace2c11378993e56f6b5b.d
Author: Johannes Doerfert
Date: 2020-04-04T01:56:19-05:00
New Revision: 06aecc71870f2c65d35614d74e4b8701fac2919e
URL:
https://github.com/llvm/llvm-project/commit/06aecc71870f2c65d35614d74e4b8701fac2919e
DIFF:
https://github.com/llvm/llvm-project/commit/06aecc71870f2c65d35614d74e4b8701fac2919e.d
Author: Johannes Doerfert
Date: 2020-04-04T01:56:19-05:00
New Revision: ddd878365b31d31264cb46fdd4e2f0f708ab8548
URL:
https://github.com/llvm/llvm-project/commit/ddd878365b31d31264cb46fdd4e2f0f708ab8548
DIFF:
https://github.com/llvm/llvm-project/commit/ddd878365b31d31264cb46fdd4e2f0f708ab8548.d
42 matches
Mail list logo