https://github.com/j2kun approved this pull request.
https://github.com/llvm/llvm-project/pull/145319
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -2131,6 +2150,15 @@ OperationLegalizer::legalize(Operation *op,
return failure();
}
+/// Helper function that moves and returns the given object. Also resets the
+/// original object, so that it is in a valid, empty state again.
j2kun wrote:
I am no C++
https://github.com/j2kun approved this pull request.
https://github.com/llvm/llvm-project/pull/145171
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -1434,12 +1439,15 @@ Block
*ConversionPatternRewriterImpl::applySignatureConversion(
if (!inputMap) {
// This block argument was dropped and no replacement value was provided.
// Materialize a replacement value "out of thin air".
- buildUnresolvedMateri
https://github.com/j2kun approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/145030
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits