[llvm-branch-commits] [libcxxabi] [flang] [libcxx] [llvm] [clang] [mlir] [clang-tools-extra] [lldb] [lld] [compiler-rt] Refactor ModuleToObject to offer more flexibility to subclass (NFC) (PR #71165)

https://github.com/fabianmcg approved this pull request. https://github.com/llvm/llvm-project/pull/71165 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [mlir] [clang] Refactor ModuleToObject to offer more flexibility to subclass (NFC) (PR #71165)

@@ -39,32 +39,32 @@ ModuleToObject::ModuleToObject(Operation &module, StringRef triple, : module(module), triple(triple), chip(chip), features(features), optLevel(optLevel) {} +ModuleToObject::~ModuleToObject() = default; + Operation &ModuleToObject::getOperation()

[llvm-branch-commits] [llvm] [mlir] [clang] Refactor ModuleToObject to offer more flexibility to subclass (NFC) (PR #71165)

https://github.com/fabianmcg edited https://github.com/llvm/llvm-project/pull/71165 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [clang] [llvm] Refactor ModuleToObject to offer more flexibility to subclass (NFC) (PR #71165)

https://github.com/fabianmcg commented: Overall LGTM, see the only comment. https://github.com/llvm/llvm-project/pull/71165 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bra