https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/146661
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/146662
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/146663
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/146045
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/139579
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/erichkeane commented:
This seems to be reasonable as far as I can tell.
I DO wonder if `getOpenMPDirectiveName` should lose non-version overload
though, so we make sure we get this right everywhere.
https://github.com/llvm/llvm-project/pull/139115
_
erichkeane wrote:
Yes, I think this would be ok. We haven't seen any regressions on it, so I'm
much more comfortable now.
https://github.com/llvm/llvm-project/pull/134194
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https:/
https://github.com/erichkeane approved this pull request.
LGTM here too.
https://github.com/llvm/llvm-project/pull/135798
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branc
@@ -1724,6 +1724,8 @@ void
JSONNodeDumper::VisitTemplateExpansionTemplateArgument(
void JSONNodeDumper::VisitExpressionTemplateArgument(
const TemplateArgument &TA) {
JOS.attribute("isExpr", true);
+ if (TA.isCanonicalExpr())
+JOS.attribute("isCanon", true);
---
@@ -1305,9 +1305,13 @@ void StmtPrinter::VisitDeclRefExpr(DeclRefExpr *Node) {
Qualifier->print(OS, Policy);
if (Node->hasTemplateKeyword())
OS << "template ";
+
+ bool ForceAnonymous =
+ Policy.PrintAsCanonical && VD->getKind() == Decl::NonTypeTemplateParm;
---
@@ -1357,6 +1357,8 @@ void
TextNodeDumper::VisitTemplateExpansionTemplateArgument(
void TextNodeDumper::VisitExpressionTemplateArgument(
const TemplateArgument &TA) {
OS << " expr";
+ if (TA.isCanonicalExpr())
+OS << " canon";
erichkeane wrote:
Sam
erichkeane wrote:
> @erichkeane What do you think about merging this PR to the release branch?
I'm on the fence. It IS a regression that we should fix, and the new version
is significantly better of an implementation than we already have, but the risk
of further regression is non-zero (and on
@@ -7379,8 +7378,11 @@ bool ASTContext::isSameEntity(const NamedDecl *X, const
NamedDecl *Y) const {
return false;
}
-if (!isSameConstraintExpr(FuncX->getTrailingRequiresClause(),
erichkeane wrote:
Ah, hrmph. This is really unergonomic, and I
@@ -78,6 +78,22 @@ class UnresolvedSetImpl;
class VarTemplateDecl;
enum class ImplicitParamKind;
+// Holds a constraint expression along with a pack expansion index, if
+// expanded.
+struct AssociatedConstraint {
+ const Expr *ConstraintExpr = nullptr;
+ int ArgumentPackSub
https://github.com/erichkeane approved this pull request.
I don't really have any comments, quite a few improvements here that are
valuable.
https://github.com/llvm/llvm-project/pull/132441
___
llvm-branch-commits mailing list
llvm-branch-commits@list
erichkeane wrote:
> Done, in order to expedite review, I have split-off three patches from this:
>
> * [[clang] ASTContext: flesh out implementation of getCommonNNS
> #131964](https://github.com/llvm/llvm-project/pull/131964)
>
> * [[clang] NFC: Clear some uses of MemberPointerType::ge
@@ -1355,7 +1355,7 @@ class BlockPointerTypeLoc : public
PointerLikeTypeLochttps://github.com/llvm/llvm-project/pull/130537
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/130537
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/erichkeane approved this pull request.
just want for 1 FIXME comment, else I've reviewed as well as I can and found
nothing concerning.
https://github.com/llvm/llvm-project/pull/130537
___
llvm-branch-commits mailing list
llvm-branc
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/131966
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/erichkeane approved this pull request.
Just did a spot-check, but the uses I saw all seemed reasonable.
There ARE a few cases I saw where it did a `cast` to `RecordType` then a
`getDecl`, so this loses the assert, but I think that is still reasonable.
https://github.com/llvm
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/131474
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
erichkeane wrote:
FWIW: I'm in favor of this. This is quite low risk/a pretty trivial change
that has an incredibly big impact on the memory pressure of our compiler in
certain situations. I think this is a good candidate to back port.
https://github.com/llvm/llvm-project/pull/131209
__
https://github.com/erichkeane approved this pull request.
This is an unfortunate and pretty nasty regression that I think we ought to
fix. I am pretty confident that this is low risk as well, so I'm in favor of
backporting this.
https://github.com/llvm/llvm-project/pull/130950
___
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/127831
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/12
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/erichkeane approved this pull request.
A few quick comments, else the source changes LGTM. Note that @endill's
suggestion to use 'bookmarks' for notes (or something like that) are good ones
that I agree with.
https://github.com/llvm/llvm-project/pull/126088
@@ -11802,9 +11817,10 @@ class Sema final : public SemaBase {
bool PartialOrdering,
bool *StrictPackMatch);
+ SmallString<128> toTerseString(const NamedDecl &D) const;
erichkeane wrote:
@@ -1909,7 +1909,22 @@ class Sema final : public SemaBase {
/// '\#pragma clang attribute push' directives to the given declaration.
void AddPragmaAttributes(Scope *S, Decl *D);
- void PrintPragmaAttributeInstantiationPoint();
+ using DiagFuncRef =
+ llvm::function_
@@ -1251,12 +1261,18 @@ void Sema::PrintInstantiationStack(DiagFuncRef
DiagFunc) {
case CodeSynthesisContext::PartialOrderingTTP:
DiagFunc(Active->PointOfInstantiation,
PDiag(diag::note_template_arg_template_params_mismatch));
- if (SourceLocation
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/126088
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/125275
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/erichkeane approved this pull request.
It still doesn't completely solve my concerns, but it is a strict improvement,
so LGTM.
https://github.com/llvm/llvm-project/pull/124668
___
llvm-branch-commits mailing list
llvm-branch-commits
@@ -11650,6 +11650,33 @@ class Sema final : public SemaBase {
CTAK_DeducedFromArrayBound
};
+ struct CheckTemplateArgumentInfo {
+explicit CheckTemplateArgumentInfo(bool PartialOrdering = false,
erichkeane wrote:
This constructor doesn't make it co
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/124668
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/124498
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/erichkeane commented:
LGTM pending @cor3ntin 's leak concerns.
https://github.com/llvm/llvm-project/pull/124386
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
@@ -6630,7 +6631,8 @@ CodeGenModule::GetAddrOfConstantStringFromLiteral(const
StringLiteral *S,
if (Entry)
*Entry = GV;
- SanitizerMD->reportGlobal(GV, S->getStrTokenLoc(0), "");
+ SanitizerMD->reportGlobalToASan(GV, S->getStrTokenLoc(0), "");
+ // FIXME: Should we a
@@ -5740,7 +5740,8 @@ void CodeGenModule::EmitGlobalVarDefinition(const VarDecl
*D,
if (NeedsGlobalCtor || NeedsGlobalDtor)
EmitCXXGlobalVarDeclInitFunc(D, GV, NeedsGlobalCtor);
- SanitizerMD->reportGlobal(GV, *D, NeedsGlobalCtor);
+ SanitizerMD->reportGlobalToASan(GV
https://github.com/erichkeane commented:
A pair of minor changes requested, else this looks about right? Not sure who
the right person to approve this is though
https://github.com/llvm/llvm-project/pull/76260
___
llvm-branch-commits mailing list
llv
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/76260
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
erichkeane wrote:
Note that the NVCC thing here is that NVCC has an interesting programming model
for its offload.
My understanding is that:
-Uses the (in this case) Clang Preprocessor to process the code.
-Does some messing around with that preprocessed output, generating the device
code, pl
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/115386
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/114951
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/erichkeane approved this pull request.
Should be small enough, and I think it fixes a couple of nice pain points.
https://github.com/llvm/llvm-project/pull/112293
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.or
https://github.com/erichkeane commented:
Did a look through, and have no comments. While we could clean up the
`TemplateDeductionResult` enum, I'm hopeful we're getting 'near the end' on it,
and I can't think of a nicer way to break it down, none of the cases are really
well associated with e
https://github.com/erichkeane approved this pull request.
Fine other than the release note not being clear enough
https://github.com/llvm/llvm-project/pull/93266
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm
@@ -784,6 +784,7 @@ Miscellaneous Bug Fixes
- Fixed an infinite recursion in ASTImporter, on return type declared inside
body of C++11 lambda without trailing return (#GH68775).
- Fixed declaration name source location of instantiated function definitions
(GH71161).
+- Missi
https://github.com/erichkeane approved this pull request.
I don't quite get the justification for this, but also don't see any downside
for it, so I think this is acceptable.
https://github.com/llvm/llvm-project/pull/92854
___
llvm-branch-commits mail
https://github.com/erichkeane approved this pull request.
Seems reasonable, lgtm.
https://github.com/llvm/llvm-project/pull/92855
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
https://github.com/erichkeane approved this pull request.
This seems useful enough with little enough impact to add to the release
branch. If we've got another one coming, I see no reason not to.
https://github.com/llvm/llvm-project/pull/91890
___
ll
https://github.com/erichkeane approved this pull request.
I think this makes sense, 2 nits, else LGTM.
https://github.com/llvm/llvm-project/pull/90961
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
@@ -2744,31 +2744,155 @@ bool hasDeclaredDeductionGuides(DeclarationName Name,
DeclContext *DC) {
return false;
}
+unsigned getTemplateDepth(NamedDecl *TemplateParam) {
+ if (auto *TTP = dyn_cast(TemplateParam))
+return TTP->getDepth();
+ if (auto *TTP = dyn_cast(Temp
@@ -2744,31 +2744,155 @@ bool hasDeclaredDeductionGuides(DeclarationName Name,
DeclContext *DC) {
return false;
}
+unsigned getTemplateDepth(NamedDecl *TemplateParam) {
erichkeane wrote:
are we in an anonymous namespace? Else this should be 'static'.
htt
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/90961
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/89030
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -2876,6 +2876,15 @@ def flax_vector_conversions : Flag<["-"],
"flax-vector-conversions">, Group, Group,
HelpText<"Force linking the clang builtins runtime library">;
+
+/// ClangIR-specific options - BEGIN
+def fclangir_enable : Flag<["-"], "fclangir-enable">, Visibility<[C
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/86080
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
erichkeane wrote:
I see this is irrelevant now, but noticed I had a pair of pending comments and
wanted the other one.
https://github.com/llvm/llvm-project/pull/86080
___
llvm-branch-commits mailing list
llvm-branch-
@@ -0,0 +1,11 @@
+//===- CIRDialect.cpp - MLIR CIR ops implementation
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
erichkeane wrote:
we should probably still create this file with the comment header and include
guards at this point.
https://github.com/llvm/llvm-project/pull/86080
___
llvm-branch-commits mailing list
llvm-branch-c
@@ -590,7 +596,7 @@ class FrontendOptions {
EmitSymbolGraph(false), EmitExtensionSymbolGraphs(false),
EmitSymbolGraphSymbolLabelsForTesting(false),
EmitPrettySymbolGraphs(false), GenReducedBMI(false),
-TimeTraceGranularity(500) {}
+UseCla
@@ -2876,6 +2876,15 @@ def flax_vector_conversions : Flag<["-"],
"flax-vector-conversions">, Group, Group,
HelpText<"Force linking the clang builtins runtime library">;
+
+/// ClangIR-specific options - BEGIN
+def fclangir_enable : Flag<["-"], "fclangir-enable">, Visibility<[C
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/88453
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
erichkeane wrote:
Just got back from WG21, so sorry for the delay. While we don't USUALLY do
backports like this that fix something that was present in the last release, I
think this ends up being reasonably low risk, we haven't seen any bugs
regarding this SINCE, and worst-case it breaks `-W
erichkeane wrote:
As far as I can tell, this isn't fixing a regression in Clang17, and thus isn't
really a candidate for inclusion into the 18.x branches.
https://github.com/llvm/llvm-project/pull/84912
___
llvm-branch-commits mailing list
llvm-branch
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/80120
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
erichkeane wrote:
Does this fix a regression against 17? I didn't think it did?
https://github.com/llvm/llvm-project/pull/80120
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llv
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/79997
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
erichkeane wrote:
> @erichkeane What do you think about merging this PR to the release branch?
We absolutely should! Please do.
https://github.com/llvm/llvm-project/pull/79997
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
ht
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/79400
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
erichkeane wrote:
Author seems to have disappeared, so approving.
https://github.com/llvm/llvm-project/pull/79400
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commit
erichkeane wrote:
I'd like us to give the author a chance to fix the original so that this
feature can get into 18, but this being here will be helpful in case he is
unable to.
https://github.com/llvm/llvm-project/pull/79400
___
llvm-branch-commits m
https://github.com/erichkeane commented:
The clang changes are ok, but this needs some level of documentation/release
notes, which I don't see in the clang release. As this is a part of a larger
feature, do we intend to push that later?
Also, the clang-format suggestion makes sense.
https://
Author: Erich Keane
Date: 2023-03-10T06:04:27-08:00
New Revision: a9e129ed8806cc313fcda5017f25206cf73c42ea
URL:
https://github.com/llvm/llvm-project/commit/a9e129ed8806cc313fcda5017f25206cf73c42ea
DIFF:
https://github.com/llvm/llvm-project/commit/a9e129ed8806cc313fcda5017f25206cf73c42ea.diff
L
Author: Erich Keane
Date: 2021-01-20T11:35:52-08:00
New Revision: 8776e3f289c19ee2e85c593792806e6503408d59
URL:
https://github.com/llvm/llvm-project/commit/8776e3f289c19ee2e85c593792806e6503408d59
DIFF:
https://github.com/llvm/llvm-project/commit/8776e3f289c19ee2e85c593792806e6503408d59.diff
L
Author: Erich Keane
Date: 2021-01-14T11:24:06-08:00
New Revision: 9e53c94d8dd737fcedb543d6ac687ea9696db8a6
URL:
https://github.com/llvm/llvm-project/commit/9e53c94d8dd737fcedb543d6ac687ea9696db8a6
DIFF:
https://github.com/llvm/llvm-project/commit/9e53c94d8dd737fcedb543d6ac687ea9696db8a6.diff
L
Author: Erich Keane
Date: 2021-01-07T09:14:36-08:00
New Revision: 43043adcfbc60945646b791d7162e5a1307a5318
URL:
https://github.com/llvm/llvm-project/commit/43043adcfbc60945646b791d7162e5a1307a5318
DIFF:
https://github.com/llvm/llvm-project/commit/43043adcfbc60945646b791d7162e5a1307a5318.diff
L
Author: Erich Keane
Date: 2021-01-06T07:17:12-08:00
New Revision: 3fa6cedb6be809092f8a8b27e63bd4f6dc526a08
URL:
https://github.com/llvm/llvm-project/commit/3fa6cedb6be809092f8a8b27e63bd4f6dc526a08
DIFF:
https://github.com/llvm/llvm-project/commit/3fa6cedb6be809092f8a8b27e63bd4f6dc526a08.diff
L
Author: Erich Keane
Date: 2020-12-07T11:29:57-08:00
New Revision: 1c98f984105e552daa83ed8e92c61fba0e401410
URL:
https://github.com/llvm/llvm-project/commit/1c98f984105e552daa83ed8e92c61fba0e401410
DIFF:
https://github.com/llvm/llvm-project/commit/1c98f984105e552daa83ed8e92c61fba0e401410.diff
L
80 matches
Mail list logo
