[llvm-branch-commits] [clang] [analyzer] Workaround for slowdown spikes (unintended scope increase) (#136720) (PR #139597)

2025-05-13 Thread Donát Nagy via llvm-branch-commits
@@ -0,0 +1,200 @@ +// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection -verify=expected,default %s +// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection -analyzer-config inline-functions-with-ambiguous-loops=true -verify=expected,enabled %s

[llvm-branch-commits] [clang] [analyzer] Workaround for slowdown spikes (unintended scope increase) (#136720) (PR #139597)

2025-05-12 Thread Donát Nagy via llvm-branch-commits
@@ -0,0 +1,200 @@ +// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection -verify=expected,default %s +// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection -analyzer-config inline-functions-with-ambiguous-loops=true -verify=expected,enabled %s

[llvm-branch-commits] [clang] [analyzer] Workaround for slowdown spikes (unintended scope increase) (#136720) (PR #139597)

2025-05-12 Thread Donát Nagy via llvm-branch-commits
https://github.com/NagyDonat commented: I read this rebased code and IMO it should work -- however I found a whitespace error that originated in my commit :sweat_smile: https://github.com/llvm/llvm-project/pull/139597 ___ llvm-branch-commits mailing

[llvm-branch-commits] [clang] [analyzer] Workaround for slowdown spikes (unintended scope increase) (#136720) (PR #139597)

2025-05-12 Thread Donát Nagy via llvm-branch-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/139597 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang-tools-extra] [clang-tidy] treat unsigned char and signed char as char type by default in bugprone-unintended-char-ostream-output (PR #134870)

2025-04-09 Thread Donát Nagy via llvm-branch-commits
@@ -42,6 +42,14 @@ Or cast to char to explicitly indicate that output should be a character. Options --- +.. option:: AllowedTypes + + A semicolon-separated list of type names that will be treated as ``char`` + type. It only contains the non canonical type names without

[llvm-branch-commits] [clang-tools-extra] [clang-tidy] treat unsigned char and signed char as char type by default in bugprone-unintended-char-ostream-output (PR #134870)

2025-04-09 Thread Donát Nagy via llvm-branch-commits
https://github.com/NagyDonat approved this pull request. Overall looks good to me, I have one suggestion about the documentation. https://github.com/llvm/llvm-project/pull/134870 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org h

[llvm-branch-commits] [clang-tools-extra] [clang-tidy] treat unsigned char and signed char as char type by default in bugprone-unintended-char-ostream-output (PR #134870)

2025-04-09 Thread Donát Nagy via llvm-branch-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/134870 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [analyzer][docs] CSA release notes for clang-20 (PR #124798)

2025-01-29 Thread Donát Nagy via llvm-branch-commits
@@ -1356,30 +1356,62 @@ Static Analyzer New features -- Now CSA models `__builtin_*_overflow` functions. (#GH102602) +- The ``__builtin_*_overflow`` functions are now properly modeled. (#GH102602) -- MallocChecker now checks for ``ownership_returns(class, idx)``

[llvm-branch-commits] [clang] [analyzer][docs] CSA release notes for clang-20 (PR #124798)

2025-01-29 Thread Donát Nagy via llvm-branch-commits
https://github.com/NagyDonat commented: LGTM with one inline suggestion. https://github.com/llvm/llvm-project/pull/124798 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branc

[llvm-branch-commits] [clang] [analyzer][docs] CSA release notes for clang-20 (PR #124798)

2025-01-29 Thread Donát Nagy via llvm-branch-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/124798 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [analyzer][NFC] Migrate nonloc::ConcreteInt to use APSIntPtr (2/4) (PR #120436)

2024-12-19 Thread Donát Nagy via llvm-branch-commits
@@ -241,26 +242,25 @@ computeOffset(ProgramStateRef State, SValBuilder &SVB, SVal Location) { static std::pair getSimplifiedOffsets(NonLoc offset, nonloc::ConcreteInt extent, SValBuilder &svalBuilder) { + const llvm::APSInt &extentVal = extent.getValue();

[llvm-branch-commits] [clang] Backport "[clang][analyzer] Fix #embed crash (#107764)" (PR #107841)

2024-09-10 Thread Donát Nagy via llvm-branch-commits
NagyDonat wrote: > Is this PR a fix for a regression or a critical issue? `#embed` support is a new feature introduced in Clang 19, so this is not a regression. However, without this PR Clang Static Analyzer (and clang-tidy which calls Clang Static Analyzer) will crash on any project that cont

[llvm-branch-commits] [clang] Backport "[clang][analyzer] Fix #embed crash (#107764)" (PR #107841)

2024-09-09 Thread Donát Nagy via llvm-branch-commits
https://github.com/NagyDonat approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/107841 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [analyzer] Harden safeguards for Z3 query times (PR #95129)

2024-06-17 Thread Donát Nagy via llvm-branch-commits
@@ -17,43 +18,126 @@ using Z3Decision = Z3CrosscheckOracle::Z3Decision; static constexpr Z3Decision AcceptReport = Z3Decision::AcceptReport; static constexpr Z3Decision RejectReport = Z3Decision::RejectReport; +static constexpr Z3Decision RejectEQClass = Z3Decision::RejectEQCl

[llvm-branch-commits] [analyzer] Harden safeguards for Z3 query times (PR #95129)

2024-06-17 Thread Donát Nagy via llvm-branch-commits
@@ -101,18 +123,37 @@ void Z3CrosscheckVisitor::Profile(llvm::FoldingSetNodeID &ID) const { Z3CrosscheckOracle::Z3Decision Z3CrosscheckOracle::interpretQueryResult( const Z3CrosscheckVisitor::Z3Result &Query) { ++NumZ3QueriesDone; + ++NumZ3QueriesDoneInEqClass; + Accum

[llvm-branch-commits] [analyzer] Harden safeguards for Z3 query times (PR #95129)

2024-06-17 Thread Donát Nagy via llvm-branch-commits
@@ -101,18 +123,37 @@ void Z3CrosscheckVisitor::Profile(llvm::FoldingSetNodeID &ID) const { Z3CrosscheckOracle::Z3Decision Z3CrosscheckOracle::interpretQueryResult( const Z3CrosscheckVisitor::Z3Result &Query) { ++NumZ3QueriesDone; + ++NumZ3QueriesDoneInEqClass; + Accum

[llvm-branch-commits] [analyzer] Harden safeguards for Z3 query times (PR #95129)

2024-06-17 Thread Donát Nagy via llvm-branch-commits
@@ -101,18 +123,37 @@ void Z3CrosscheckVisitor::Profile(llvm::FoldingSetNodeID &ID) const { Z3CrosscheckOracle::Z3Decision Z3CrosscheckOracle::interpretQueryResult( const Z3CrosscheckVisitor::Z3Result &Query) { ++NumZ3QueriesDone; + ++NumZ3QueriesDoneInEqClass; + Accum

[llvm-branch-commits] [analyzer] Harden safeguards for Z3 query times (PR #95129)

2024-06-17 Thread Donát Nagy via llvm-branch-commits
https://github.com/NagyDonat approved this pull request. Oops, I vaguely recalled that I already reviewed this, but it turns out I didn't. Anyway, the change LGTM, I only added a few minor remarks. (We already discussed a high-level overview of this on Discourse.) https://github.com/llvm/llvm-

[llvm-branch-commits] [analyzer] Harden safeguards for Z3 query times (PR #95129)

2024-06-17 Thread Donát Nagy via llvm-branch-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/95129 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits