https://github.com/dwblaikie approved this pull request.
https://github.com/llvm/llvm-project/pull/120555
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
dwblaikie wrote:
Unit test coverage?
https://github.com/llvm/llvm-project/pull/120555
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/dwblaikie approved this pull request.
LGTM - thanks!
https://github.com/llvm/llvm-project/pull/116617
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch
dwblaikie wrote:
Oh, and please add unit test coverage for the new move functionality.
https://github.com/llvm/llvm-project/pull/116617
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
@@ -205,7 +209,7 @@ class SparseSet {
assert(Idx < Universe && "Key out of range");
assert(Sparse != nullptr && "Invalid sparse type");
const unsigned Stride = std::numeric_limits::max() + 1u;
-for (unsigned i = Sparse[Idx], e = size(); i < e; i += Stride) {
+
dwblaikie wrote:
please separate out the APInt changes and include unit tests in a change just
to llvm separate from/before the mlir side of this
https://github.com/llvm/llvm-project/pull/116176
___
llvm-branch-commits mailing list
llvm-branch-commits
@@ -234,19 +225,12 @@ class SmallSet {
/// Check if the SmallSet contains the given element.
bool contains(const T &V) const {
if (isSmall())
- return vfind(V) != Vector.end();
-return Set.find(V) != Set.end();
+ return llvm::is_contained(Vector, V);
+
https://github.com/dwblaikie edited
https://github.com/llvm/llvm-project/pull/108585
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -234,19 +225,12 @@ class SmallSet {
/// Check if the SmallSet contains the given element.
bool contains(const T &V) const {
if (isSmall())
- return vfind(V) != Vector.end();
-return Set.find(V) != Set.end();
+ return llvm::is_contained(Vector, V);
+
https://github.com/dwblaikie approved this pull request.
https://github.com/llvm/llvm-project/pull/105846
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
dwblaikie wrote:
> @dwblaikie What do you think about merging this PR to the release branch?
Seems pretty harmless/OK to me.
https://github.com/llvm/llvm-project/pull/105846
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https
https://github.com/dwblaikie commented:
Not that the patch is especially long/complicated, but could be split into the
refactor/move of the MC function, then the new usage, if you like (usual
reasons - smaller patches are easier to root cause, functionality can be
reverted without thrashing th
@@ -424,19 +439,13 @@ static void convertFunctionLineTable(OutputAggregator
&Out, CUInfo &CUI,
auto LastLE = FI.OptLineTable->last();
if (LastLE && LastLE->File == FileIdx && LastLE->Line == Row.Line)
continue;
+
// Only push a row if it isn't an end seque
dwblaikie wrote:
Oh, sorry, right - that API should/might be used by `llvm-symbolizer` and the
change might be visible through its behavior?
https://github.com/llvm/llvm-project/pull/89703
___
llvm-branch-commits mailing list
llvm-branch-commits@lists
dwblaikie wrote:
> I'd like to know how this affects the output of llvm-dwarfdump. Intuitively
> it feels like something around the display of end_sequence rows should have
> changed, but I'm willing to be corrected.
+1 - given the change to DWARFDebugLine, I'd expect this to be observable
th
https://github.com/dwblaikie approved this pull request.
https://github.com/llvm/llvm-project/pull/83702
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
Author: David Blaikie
Date: 2021-01-24T18:39:06-08:00
New Revision: 78d41a1295d9d40c37758230d0218c61eaffad88
URL:
https://github.com/llvm/llvm-project/commit/78d41a1295d9d40c37758230d0218c61eaffad88
DIFF:
https://github.com/llvm/llvm-project/commit/78d41a1295d9d40c37758230d0218c61eaffad88.diff
Author: David Blaikie
Date: 2021-01-24T18:38:16-08:00
New Revision: b3fcc72eb07c43ca08dade818018c82275081ec3
URL:
https://github.com/llvm/llvm-project/commit/b3fcc72eb07c43ca08dade818018c82275081ec3
DIFF:
https://github.com/llvm/llvm-project/commit/b3fcc72eb07c43ca08dade818018c82275081ec3.diff
Author: Vladislav Vinogradov
Date: 2021-01-15T14:34:14-08:00
New Revision: 76f5c5a7b059929f0e0352ad4ff5ec1b78511868
URL:
https://github.com/llvm/llvm-project/commit/76f5c5a7b059929f0e0352ad4ff5ec1b78511868
DIFF:
https://github.com/llvm/llvm-project/commit/76f5c5a7b059929f0e0352ad4ff5ec1b7851186
Author: James Player
Date: 2021-01-13T15:23:48-08:00
New Revision: 854f0984f0b7ab9a9a541a4bcda7ea173e4113d3
URL:
https://github.com/llvm/llvm-project/commit/854f0984f0b7ab9a9a541a4bcda7ea173e4113d3
DIFF:
https://github.com/llvm/llvm-project/commit/854f0984f0b7ab9a9a541a4bcda7ea173e4113d3.diff
Author: David Blaikie
Date: 2021-01-12T15:29:44-08:00
New Revision: 0d88d7d82bc44b211a8187650a06c6cd3492186a
URL:
https://github.com/llvm/llvm-project/commit/0d88d7d82bc44b211a8187650a06c6cd3492186a
DIFF:
https://github.com/llvm/llvm-project/commit/0d88d7d82bc44b211a8187650a06c6cd3492186a.diff
Author: Umesh Kalappa
Date: 2021-01-08T22:11:16-08:00
New Revision: 33c8e16f660de9bbe177c1bf821063c146278d8e
URL:
https://github.com/llvm/llvm-project/commit/33c8e16f660de9bbe177c1bf821063c146278d8e
DIFF:
https://github.com/llvm/llvm-project/commit/33c8e16f660de9bbe177c1bf821063c146278d8e.diff
Author: David Blaikie
Date: 2021-01-07T20:04:22-08:00
New Revision: 2ff36e79291486b489ae26418daa1b123473b405
URL:
https://github.com/llvm/llvm-project/commit/2ff36e79291486b489ae26418daa1b123473b405
DIFF:
https://github.com/llvm/llvm-project/commit/2ff36e79291486b489ae26418daa1b123473b405.diff
Author: David Blaikie
Date: 2021-01-07T19:57:14-08:00
New Revision: 4a3c2ba890460a209b289dca525e9de6f8ad0af3
URL:
https://github.com/llvm/llvm-project/commit/4a3c2ba890460a209b289dca525e9de6f8ad0af3
DIFF:
https://github.com/llvm/llvm-project/commit/4a3c2ba890460a209b289dca525e9de6f8ad0af3.diff
Author: David Blaikie
Date: 2021-01-07T19:53:17-08:00
New Revision: 696775d96ecd20aacb7935541995a5554bb32ba8
URL:
https://github.com/llvm/llvm-project/commit/696775d96ecd20aacb7935541995a5554bb32ba8
DIFF:
https://github.com/llvm/llvm-project/commit/696775d96ecd20aacb7935541995a5554bb32ba8.diff
Author: David Blaikie
Date: 2021-01-07T18:18:23-08:00
New Revision: b12f26733a4259c90e5f387aceb9f23c35e003b8
URL:
https://github.com/llvm/llvm-project/commit/b12f26733a4259c90e5f387aceb9f23c35e003b8
DIFF:
https://github.com/llvm/llvm-project/commit/b12f26733a4259c90e5f387aceb9f23c35e003b8.diff
Author: David Blaikie
Date: 2021-01-07T14:28:03-08:00
New Revision: 274afac9a17f43e5396a0d6c7a0741702596a7bd
URL:
https://github.com/llvm/llvm-project/commit/274afac9a17f43e5396a0d6c7a0741702596a7bd
DIFF:
https://github.com/llvm/llvm-project/commit/274afac9a17f43e5396a0d6c7a0741702596a7bd.diff
Author: David Blaikie
Date: 2021-01-07T14:18:19-08:00
New Revision: 3503c856819efc01ce210fa56e597ddfb7a4c1a1
URL:
https://github.com/llvm/llvm-project/commit/3503c856819efc01ce210fa56e597ddfb7a4c1a1
DIFF:
https://github.com/llvm/llvm-project/commit/3503c856819efc01ce210fa56e597ddfb7a4c1a1.diff
Author: David Blaikie
Date: 2021-01-05T16:36:22-08:00
New Revision: ad18b075fd63935148b460f9c6b4dce130c56b15
URL:
https://github.com/llvm/llvm-project/commit/ad18b075fd63935148b460f9c6b4dce130c56b15
DIFF:
https://github.com/llvm/llvm-project/commit/ad18b075fd63935148b460f9c6b4dce130c56b15.diff
Author: David Blaikie
Date: 2020-12-08T00:23:33-08:00
New Revision: 4415678718ad471c84f024e20ce864ae1e79348a
URL:
https://github.com/llvm/llvm-project/commit/4415678718ad471c84f024e20ce864ae1e79348a
DIFF:
https://github.com/llvm/llvm-project/commit/4415678718ad471c84f024e20ce864ae1e79348a.diff
Author: David Blaikie
Date: 2020-12-03T20:41:06-08:00
New Revision: c4af1c8d939b21ac7deb631887fc26db7451c592
URL:
https://github.com/llvm/llvm-project/commit/c4af1c8d939b21ac7deb631887fc26db7451c592
DIFF:
https://github.com/llvm/llvm-project/commit/c4af1c8d939b21ac7deb631887fc26db7451c592.diff
Author: David Blaikie
Date: 2020-12-03T18:43:01-08:00
New Revision: c98a7ab1b1d647492554872e395b2ae5763fd23e
URL:
https://github.com/llvm/llvm-project/commit/c98a7ab1b1d647492554872e395b2ae5763fd23e
DIFF:
https://github.com/llvm/llvm-project/commit/c98a7ab1b1d647492554872e395b2ae5763fd23e.diff
Author: David Blaikie
Date: 2020-12-03T17:42:32-08:00
New Revision: 2e83ccc2ee89110659f3cb313968a0c970d4
URL:
https://github.com/llvm/llvm-project/commit/2e83ccc2ee89110659f3cb313968a0c970d4
DIFF:
https://github.com/llvm/llvm-project/commit/2e83ccc2ee89110659f3cb313968a0c970d4.diff
Author: David Blaikie
Date: 2020-12-03T13:09:36-08:00
New Revision: 0fd0f885eb990feecd67749eff79a5a821767d84
URL:
https://github.com/llvm/llvm-project/commit/0fd0f885eb990feecd67749eff79a5a821767d84
DIFF:
https://github.com/llvm/llvm-project/commit/0fd0f885eb990feecd67749eff79a5a821767d84.diff
Author: David Blaikie
Date: 2020-12-03T13:09:36-08:00
New Revision: 30b1ae591657a14292f2134b426559c3aa6a289d
URL:
https://github.com/llvm/llvm-project/commit/30b1ae591657a14292f2134b426559c3aa6a289d
DIFF:
https://github.com/llvm/llvm-project/commit/30b1ae591657a14292f2134b426559c3aa6a289d.diff
Author: James Park
Date: 2020-12-01T14:43:16-08:00
New Revision: 78b0ec3d1c5cc198093bb03ecb86bca25fe570ca
URL:
https://github.com/llvm/llvm-project/commit/78b0ec3d1c5cc198093bb03ecb86bca25fe570ca
DIFF:
https://github.com/llvm/llvm-project/commit/78b0ec3d1c5cc198093bb03ecb86bca25fe570ca.diff
LO
Author: David Blaikie
Date: 2020-11-25T13:34:15-08:00
New Revision: 175ebad958a0ebaf6c56c20ab30b9d4347742c29
URL:
https://github.com/llvm/llvm-project/commit/175ebad958a0ebaf6c56c20ab30b9d4347742c29
DIFF:
https://github.com/llvm/llvm-project/commit/175ebad958a0ebaf6c56c20ab30b9d4347742c29.diff
Author: David Blaikie
Date: 2020-11-24T17:48:11-08:00
New Revision: 01cee921abe924ae98027ce599d3c76ca5780a38
URL:
https://github.com/llvm/llvm-project/commit/01cee921abe924ae98027ce599d3c76ca5780a38
DIFF:
https://github.com/llvm/llvm-project/commit/01cee921abe924ae98027ce599d3c76ca5780a38.diff
Author: David Blaikie
Date: 2020-11-24T17:35:00-08:00
New Revision: cbd754163934a64e65b87a0f1b2c6741af8d24db
URL:
https://github.com/llvm/llvm-project/commit/cbd754163934a64e65b87a0f1b2c6741af8d24db
DIFF:
https://github.com/llvm/llvm-project/commit/cbd754163934a64e65b87a0f1b2c6741af8d24db.diff
Author: dblaikie
Date: Wed Aug 19 20:58:23 2015
New Revision: 245534
URL: http://llvm.org/viewvc/llvm-project?rev=245534&view=rev
Log:
Add release notes for the typeless pointer work.
Modified:
llvm/branches/release_37/docs/ReleaseNotes.rst
Modified: llvm/branches/release_37/docs/ReleaseNote
40 matches
Mail list logo