[llvm-branch-commits] [llvm] release/19.x: [llvm][aarch64] Fix Arm64EC name mangling algorithm (#115567) (PR #116273)

dpaoliello wrote: > @dpaoliello (or anyone else). If you would like to add a note about this fix > in the release notes (completely optional). Please reply to this comment with > a one or two sentence description of the fix. When you are done, please add > the release:note label to this PR. F

[llvm-branch-commits] [llvm] release/19.x: [llvm][aarch64] Fix Arm64EC name mangling algorithm (#115567) (PR #116273)

https://github.com/dpaoliello edited https://github.com/llvm/llvm-project/pull/116273 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [llvm][aarch64] Fix Arm64EC name mangling algorithm (#115567) (PR #116273)

https://github.com/dpaoliello edited https://github.com/llvm/llvm-project/pull/116273 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [llvm][aarch64] Fix Arm64EC name mangling algorithm (#115567) (PR #116273)

https://github.com/dpaoliello milestoned https://github.com/llvm/llvm-project/pull/116273 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [llvm][aarch64] Fix Arm64EC name mangling algorithm (#115567) (PR #116273)

https://github.com/dpaoliello created https://github.com/llvm/llvm-project/pull/116273 Arm64EC uses a special name mangling mode that adds `$$h` between the symbol name and its type. In MSVC's name mangling `@` is used to separate the name and type BUT it is also used for other purposes, such

[llvm-branch-commits] [llvm] CodeGen: Move current call site out of MachineModuleInfo (PR #100369)

https://github.com/dpaoliello approved this pull request. https://github.com/llvm/llvm-project/pull/100369 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] CodeGen: Move current call site out of MachineModuleInfo (PR #100369)

@@ -183,11 +183,28 @@ class FunctionLoweringInfo { std::vector > PHINodesToUpdate; unsigned OrigNumPHINodesToUpdate; + /// \name Exception Handling dpaoliello wrote: I don't think we need to keep this https://github.com/llvm/llvm-project/pull/100369 ___

[llvm-branch-commits] [llvm] CodeGen: Move current call site out of MachineModuleInfo (PR #100369)

@@ -183,11 +183,28 @@ class FunctionLoweringInfo { std::vector > PHINodesToUpdate; unsigned OrigNumPHINodesToUpdate; + /// \name Exception Handling + /// \{ + /// If the current MBB is a landing pad, the exception pointer and exception /// selector registers are co

[llvm-branch-commits] [llvm] CodeGen: Move current call site out of MachineModuleInfo (PR #100369)

https://github.com/dpaoliello requested changes to this pull request. https://github.com/llvm/llvm-project/pull/100369 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-c

[llvm-branch-commits] [llvm] [release/18.x] Backport fixes for ARM64EC thunk generation (PR #92580)

dpaoliello wrote: > @dpaoliello (or anyone else). If you would like to add a note about this fix > in the release notes (completely optional). Please reply to this comment with > a one or two sentence description of the fix. When you are done, please add > the release:note label to this PR. F

[llvm-branch-commits] [llvm] [release/18.x] Backport fixes for ARM64EC thunk generation (PR #92580)

https://github.com/dpaoliello created https://github.com/llvm/llvm-project/pull/92580 Backports !90115 and !92326 Release notes: Fixes issues where LLVM is either generating the incorrect thunk for a function with aligned parameters or didn't correctly pass through the return value when `Stru

[llvm-branch-commits] [llvm] [release/18.x] Backport fixes for ARM64EC thunk generation (PR #92580)

https://github.com/dpaoliello milestoned https://github.com/llvm/llvm-project/pull/92580 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/18.x: Prepend all library intrinsics with `#` when building for Arm64EC (PR #88016)

dpaoliello wrote: > Hi @dpaoliello I'm seeing some "Illegal Instruction" errors when running the > bolt tests on aarch64. Do you think there is any chance this commit could be > the cause? It's the only one between 18.1.3 and 18.1.4 that touches the > aarch64 code gen. Here is the full log: >

[llvm-branch-commits] [clang] [release/18.x][COFF][Aarch64] Add _InterlockedAdd64 intrinsic (#81849) (PR #89951)

https://github.com/dpaoliello closed https://github.com/llvm/llvm-project/pull/89951 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [release/18.x][COFF][Aarch64] Add _InterlockedAdd64 intrinsic (#81849) (PR #89951)

dpaoliello wrote: Closing this since it would be an ABI break https://github.com/llvm/llvm-project/pull/89951 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [release/18.x][COFF][Aarch64] Add _InterlockedAdd64 intrinsic (#81849) (PR #89951)

dpaoliello wrote: > I think BuiltinsAArch64.def is part of clang's ABI, so changing it violates > the backport rules. > > Otherwise, I'd be inclined to accept; it's kind of late to request, but it's > low risk. @tstellar can you please advise if this change is ok to backport? https://github.

[llvm-branch-commits] [clang] [release/18.x][COFF][Aarch64] Add _InterlockedAdd64 intrinsic (#81849) (PR #89951)

https://github.com/dpaoliello updated https://github.com/llvm/llvm-project/pull/89951 >From d1a4febc0974cb76bce1692be9d62aaa9a5dcefb Mon Sep 17 00:00:00 2001 From: Pierrick Bouvier Date: Fri, 16 Feb 2024 15:20:08 +0400 Subject: [PATCH] [COFF][Aarch64] Add _InterlockedAdd64 intrinsic (#81849) F

[llvm-branch-commits] [clang] [release/18.x][COFF][Aarch64] Add _InterlockedAdd64 intrinsic (#81849) (PR #89951)

https://github.com/dpaoliello edited https://github.com/llvm/llvm-project/pull/89951 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [release/18.x][COFF][Aarch64] Add _InterlockedAdd64 intrinsic (#81849) (PR #89951)

https://github.com/dpaoliello edited https://github.com/llvm/llvm-project/pull/89951 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [COFF][Aarch64] Add _InterlockedAdd64 intrinsic (#81849) (PR #89951)

https://github.com/dpaoliello milestoned https://github.com/llvm/llvm-project/pull/89951 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [COFF][Aarch64] Add _InterlockedAdd64 intrinsic (#81849) (PR #89951)

https://github.com/dpaoliello created https://github.com/llvm/llvm-project/pull/89951 Found when compiling openssl master branch using clang-cl. This commit introduces usage of InterlockedAdd64: https://github.com/openssl/openssl/commit/d0e1a0ae701cfaca7f3dd3bf28a3f934a6408813 https://learn.

[llvm-branch-commits] [llvm] release/18.x: Prepend all library intrinsics with `#` when building for Arm64EC (PR #88016)

dpaoliello wrote: > Hi @dpaoliello (or anyone else). If you would like to add a note about this > fix in the release notes (completely optional). Please reply to this comment > with a one or two sentence description of the fix. Fixes an issue with Arm64EC code generation where calls to some in

[llvm-branch-commits] [llvm] release/18.x: Prepend all library intrinsics with `#` when building for Arm64EC (PR #88016)

dpaoliello wrote: @tstellar this is ready to land for 18 https://github.com/llvm/llvm-project/pull/88016 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/18.x: Prepend all library intrinsics with `#` when building for Arm64EC (PR #88016)

https://github.com/dpaoliello edited https://github.com/llvm/llvm-project/pull/88016 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] Backport: Prepend all library intrinsics with `#` when building for Arm64EC (PR #88016)

https://github.com/dpaoliello updated https://github.com/llvm/llvm-project/pull/88016 >From 83514c75b37e1e02b7f7aca0225072d1068eaffb Mon Sep 17 00:00:00 2001 From: Daniel Paoliello Date: Fri, 5 Apr 2024 12:06:47 -0700 Subject: [PATCH] Prepend all library intrinsics with `#` when building for A

[llvm-branch-commits] [llvm] Backport: Prepend all library intrinsics with `#` when building for Arm64EC (PR #88016)

https://github.com/dpaoliello milestoned https://github.com/llvm/llvm-project/pull/88016 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] Backport: Prepend all library intrinsics with `#` when building for Arm64EC (PR #88016)

https://github.com/dpaoliello created https://github.com/llvm/llvm-project/pull/88016 Backports #87542 to v18 While attempting to build some Rust code, I was getting linker errors due to missing functions that are implemented in `compiler-rt`. Turns out that when `compiler-rt` is built for Ar

[llvm-branch-commits] [lld] [llvm] Backport fixes for ARM64EC import libraries (PR #84590)

https://github.com/dpaoliello updated https://github.com/llvm/llvm-project/pull/84590 >From 1a9bb5ccfd8f93be51d22fb00f38e86a01e82587 Mon Sep 17 00:00:00 2001 From: Jacek Caban Date: Tue, 6 Feb 2024 13:47:58 +0100 Subject: [PATCH 1/5] [llvm-readobj][Object][COFF] Print COFF import library symbo

[llvm-branch-commits] [lld] [llvm] Backport fixes for ARM64EC import libraries (PR #84590)

dpaoliello wrote: @tstellar change made as requested, this is now ready to merge https://github.com/llvm/llvm-project/pull/84590 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llv

[llvm-branch-commits] [lld] [llvm] Backport fixes for ARM64EC import libraries (PR #84590)

https://github.com/dpaoliello edited https://github.com/llvm/llvm-project/pull/84590 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [lld] [llvm] Backport fixes for ARM64EC import libraries (PR #84590)

@@ -91,6 +120,10 @@ struct COFFShortExport { /// file, this is "baz" in "EXPORTS\nfoo = bar == baz". std::string AliasTarget; + /// Specifies EXPORTAS name. In a .def file, this is "bar" in + /// "EXPORTS\nfoo EXPORTAS bar". + std::string ExportAs; dpao

[llvm-branch-commits] [lld] [llvm] Backport fixes for ARM64EC import libraries (PR #84590)

https://github.com/dpaoliello updated https://github.com/llvm/llvm-project/pull/84590 >From 37bee8feb128de231ed278fa2ca95dc46581c014 Mon Sep 17 00:00:00 2001 From: Jacek Caban Date: Tue, 6 Feb 2024 13:47:58 +0100 Subject: [PATCH 1/5] [llvm-readobj][Object][COFF] Print COFF import library symbo

[llvm-branch-commits] [lld] [llvm] Backport fixes for ARM64EC import libraries (PR #84590)

dpaoliello wrote: @tstellar I'd like to get this merged into the v18 release branch, but there's some discussion of whether we should trim the changes down to just what is needed or leave them as they were merged into master. Can you please let me know what your preference is? https://github.

[llvm-branch-commits] [lld] [llvm] Backport fixes for ARM64EC import libraries (PR #84590)

@@ -91,6 +120,10 @@ struct COFFShortExport { /// file, this is "baz" in "EXPORTS\nfoo = bar == baz". std::string AliasTarget; + /// Specifies EXPORTAS name. In a .def file, this is "bar" in + /// "EXPORTS\nfoo EXPORTAS bar". + std::string ExportAs; dpao

[llvm-branch-commits] [lld] [llvm] Backport fixes for ARM64EC import libraries (PR #84590)

https://github.com/dpaoliello edited https://github.com/llvm/llvm-project/pull/84590 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [lld] [llvm] Backport fixes for ARM64EC import libraries (PR #84590)

dpaoliello wrote: @cjacek if you really want me to revert the def parser portion, then I can do that. Otherwise, can you please sign off? https://github.com/llvm/llvm-project/pull/84590 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.ll

[llvm-branch-commits] [lld] [llvm] Backport fixes for ARM64EC import libraries (PR #84590)

https://github.com/dpaoliello updated https://github.com/llvm/llvm-project/pull/84590 >From e96d29f7e80a89204ba541a8af516bf47698d93f Mon Sep 17 00:00:00 2001 From: Jacek Caban Date: Tue, 6 Feb 2024 13:47:58 +0100 Subject: [PATCH 1/4] [llvm-readobj][Object][COFF] Print COFF import library symbo

[llvm-branch-commits] [llvm] 89d5432 - [AArch64] Skip over shadow space for ARM64EC entry thunk variadic calls (#80994)

Author: Billy Laws Date: 2024-03-11T14:29:51-07:00 New Revision: 89d543227a324d9925c68caf5d75c8c1e46c02a4 URL: https://github.com/llvm/llvm-project/commit/89d543227a324d9925c68caf5d75c8c1e46c02a4 DIFF: https://github.com/llvm/llvm-project/commit/89d543227a324d9925c68caf5d75c8c1e46c02a4.diff LO

[llvm-branch-commits] [llvm] 42c599a - [AArch64] Fix generated types for ARM64EC variadic entry thunk targets (#80595)

Author: Billy Laws Date: 2024-03-11T14:29:51-07:00 New Revision: 42c599ab365b6d413d7e35a40f6e4ab98f523b67 URL: https://github.com/llvm/llvm-project/commit/42c599ab365b6d413d7e35a40f6e4ab98f523b67 DIFF: https://github.com/llvm/llvm-project/commit/42c599ab365b6d413d7e35a40f6e4ab98f523b67.diff LO

[llvm-branch-commits] [llvm] d7a9810 - [AArch64] Fix variadic tail-calls on ARM64EC (#79774)

Author: Billy Laws Date: 2024-03-11T14:29:51-07:00 New Revision: d7a9810f9c14e6598265ab41519be9b861228450 URL: https://github.com/llvm/llvm-project/commit/d7a9810f9c14e6598265ab41519be9b861228450 DIFF: https://github.com/llvm/llvm-project/commit/d7a9810f9c14e6598265ab41519be9b861228450.diff LO

[llvm-branch-commits] [lld] [llvm] Backport fixes for ARM64EC import libraries (PR #84590)

dpaoliello wrote: has been merged into master and cherry-picked here, so this is ready to land. > One thing we could consider is to skip .def file parser part of it. I'd rather not modify commits since they've already been tested in master and

[llvm-branch-commits] [lld] [llvm] Backport fixes for ARM64EC import libraries (PR #84590)

https://github.com/dpaoliello updated https://github.com/llvm/llvm-project/pull/84590 >From e84cbe53501ae106c25ca7233e48ad3c5daf539a Mon Sep 17 00:00:00 2001 From: Jacek Caban Date: Tue, 6 Feb 2024 13:47:58 +0100 Subject: [PATCH 1/4] [llvm-readobj][Object][COFF] Print COFF import library symbo

[llvm-branch-commits] [llvm] Backport ARM64EC variadic args fixes to LLVM 18 (PR #81800)

dpaoliello wrote: @tstellar can we please get this merged into the v18 release branch? https://github.com/llvm/llvm-project/pull/81800 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[llvm-branch-commits] [lld] [llvm] Backport fixes for ARM64EC import libraries (PR #84590)

dpaoliello wrote: > So your use-case is basically equivalent to using llvm-dlltool, except not > using the text parser? Yep. > If this is actually enough to make Rust targets usable, then I guess we could > consider it, but the fixes aren't structured in a way to make it obvious this > won't

[llvm-branch-commits] [llvm] Backport ARM64EC variadic args fixes to LLVM 18 (PR #81800)

https://github.com/dpaoliello updated https://github.com/llvm/llvm-project/pull/81800 >From d7a9810f9c14e6598265ab41519be9b861228450 Mon Sep 17 00:00:00 2001 From: Billy Laws Date: Wed, 31 Jan 2024 02:32:15 + Subject: [PATCH 1/3] [AArch64] Fix variadic tail-calls on ARM64EC (#79774) ARM64E

[llvm-branch-commits] [lld] [llvm] Backport fixes for ARM64EC import libraries (PR #84590)

dpaoliello wrote: Sorry, I've got to disagree with this: this is blocking Rust's use of Arm64EC since it can generate import libraries on-the-fly using this functionality (rather than requiring that users install the Windows SDK). I've tested Arm64EC with Rust, and this is the only blocking is

[llvm-branch-commits] [llvm] Backport ARM64EC variadic args fixes to LLVM 18 (PR #81800)

https://github.com/dpaoliello updated https://github.com/llvm/llvm-project/pull/81800 >From a276993409f867760dbc1993acb54063fd8a0fbb Mon Sep 17 00:00:00 2001 From: Billy Laws Date: Wed, 31 Jan 2024 02:32:15 + Subject: [PATCH 1/3] [AArch64] Fix variadic tail-calls on ARM64EC (#79774) ARM64E

[llvm-branch-commits] [lld] [llvm] Backport fixes for ARM64EC import libraries (PR #84590)

dpaoliello wrote: Blocking to wait for https://github.com/llvm/llvm-project/pull/84590 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[llvm-branch-commits] [lld] [llvm] Backport fixes for ARM64EC import libraries (PR #84590)

https://github.com/dpaoliello created https://github.com/llvm/llvm-project/pull/84590 Backports fixes to be able to generate import libraries for ARM64EC: * * *

[llvm-branch-commits] [llvm] Backport ARM64EC variadic args fixes to LLVM 18 (PR #81800)

https://github.com/dpaoliello updated https://github.com/llvm/llvm-project/pull/81800 >From 064dd621c19b3738af5db29afd5b986a6d739ab1 Mon Sep 17 00:00:00 2001 From: Billy Laws Date: Wed, 31 Jan 2024 02:32:15 + Subject: [PATCH 1/3] [AArch64] Fix variadic tail-calls on ARM64EC (#79774) ARM64E

[llvm-branch-commits] [llvm] Backport ARM64EC variadic args fixes to LLVM 18 (PR #81800)

dpaoliello wrote: @efriedma-quic I think this is ready to land, the MacOS test failure is a known issue. https://github.com/llvm/llvm-project/pull/81800 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi

[llvm-branch-commits] [llvm] Backport ARM64EC variadic args fixes to LLVM 18 (PR #81800)

https://github.com/dpaoliello edited https://github.com/llvm/llvm-project/pull/81800 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] Backport ARM64EC variadic args fixes to LLVM 18 (PR #81800)

https://github.com/dpaoliello updated https://github.com/llvm/llvm-project/pull/81800 >From 10ed6a8e268c296901093f90bae4018faf90d27d Mon Sep 17 00:00:00 2001 From: Billy Laws Date: Wed, 31 Jan 2024 02:32:15 + Subject: [PATCH 1/3] [AArch64] Fix variadic tail-calls on ARM64EC (#79774) ARM64E

[llvm-branch-commits] [llvm] Backport ARM64EC variadic args fixes to LLVM 18 (PR #81800)

dpaoliello wrote: > I was sort of waiting until the discussion on #80994 resolves... we might end > up reverting parts of #80595 . > > I guess it won't do any harm to land as-is, though. I'll wait - I'd rather not drop something into the release branch if we know it may cause issues. https:/

[llvm-branch-commits] [llvm] PR for llvm/llvm-project#80752 (PR #80754)

dpaoliello wrote: Superseded by https://github.com/llvm/llvm-project/pull/81800 https://github.com/llvm/llvm-project/pull/80754 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm

[llvm-branch-commits] [llvm] PR for llvm/llvm-project#80752 (PR #80754)

https://github.com/dpaoliello closed https://github.com/llvm/llvm-project/pull/80754 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] Backport ARM64EC variadic args fixes to LLVM 18 (PR #81800)

https://github.com/dpaoliello created https://github.com/llvm/llvm-project/pull/81800 Backports two fixes for ARM64EC variadic args: * * >From 45fbf96034992f7e5e1e6678bfb2988c58a9c0ae Mon Sep 17