[llvm-branch-commits] [clang] [Serialization] Code cleanups and polish 83233 (PR #83237)

2024-10-23 Thread Alexander Kornienko via llvm-branch-commits
alexfh wrote: BTW, if you wonder about the callers of `LoadExternalSpecializations`: ``` - 90.30% 0.00% clang clang [.] clang::Sema::CheckVarTemplateId(clang::VarTemplateDecl*, clang::SourceLocation, clang::SourceLocation, clang::TemplateArgumentListInfo const&)

[llvm-branch-commits] [clang] [Serialization] Code cleanups and polish 83233 (PR #83237)

2024-10-23 Thread Alexander Kornienko via llvm-branch-commits
alexfh wrote: Compiling Clang with more debug information and without FDO+ThinLTO indeed shows `clang::serialization::MultiOnDiskHashTable::findAll()` as the main time sink: ``` + 96.99% 0.00% clangclang [.] clang::Sema::runWithSufficientStackSpace(clang::SourceLocati

[llvm-branch-commits] [clang] [Serialization] Code cleanups and polish 83233 (PR #83237)

2024-10-22 Thread Alexander Kornienko via llvm-branch-commits
alexfh wrote: @usx95 may be able to help with the reproducer. In the meantime, I'm trying to collect some information on the compile times. So far it looks like we have a ~10-15x compile time regression on some translation units. Without this patch `-ftime-report` shows: ``` ===---

[llvm-branch-commits] [clang] [Serialization] Code cleanups and polish 83233 (PR #83237)

2024-08-01 Thread Alexander Kornienko via llvm-branch-commits
alexfh wrote: > bool operator==(const LazySpecializationInfo &Other) Making this `operator==` `const` helps with the warning in C++20. And it's the right thing to do anyway. https://github.com/llvm/llvm-project/pull/83237 ___ llvm-branch-commits mail

[llvm-branch-commits] [clang] [Serialization] Code cleanups and polish 83233 (PR #83237)

2024-07-31 Thread Alexander Kornienko via llvm-branch-commits
alexfh wrote: I'm getting this error when trying to bootstrap Clang: ``` In file included from clang/lib/Serialization/ASTReaderDecl.cpp:15: clang/lib/Serialization/ASTReaderInternals.h:160:19: error: ISO C++20 considers use of overloaded operator '==' (with operand types 'clang::serialization:

[llvm-branch-commits] [clang] [Serialization] Code cleanups and polish 83233 (PR #83237)

2024-07-31 Thread Alexander Kornienko via llvm-branch-commits
alexfh wrote: > > @ilya-biryukov, could we have another try of this PR on your end? > > Sorry for missing this, we will rerun the testing and get back to you. In the meantime, could you rebase the patch on top of current ToT? https://github.com/llvm/llvm-project/pull/83237

[llvm-branch-commits] [llvm] 0f8745b - Revert "[SimplifyCFG] When only one case value is missing, replace default with that case (#76669)"

2024-01-17 Thread Alexander Kornienko via llvm-branch-commits
Author: Alexander Kornienko Date: 2024-01-17T17:49:25+01:00 New Revision: 0f8745b4b77d1c1fd0699adb024ed08bcb1233d3 URL: https://github.com/llvm/llvm-project/commit/0f8745b4b77d1c1fd0699adb024ed08bcb1233d3 DIFF: https://github.com/llvm/llvm-project/commit/0f8745b4b77d1c1fd0699adb024ed08bcb1233d3

[llvm-branch-commits] [llvm] af7a145 - Revert "[SLP][NFC]Make collectValuesToDemote member of BoUpSLP to avoid using"

2023-11-23 Thread Alexander Kornienko via llvm-branch-commits
Author: Alexander Kornienko Date: 2023-11-24T01:18:46+01:00 New Revision: af7a1453526a88a0e242baf156244aa4ae42ae4b URL: https://github.com/llvm/llvm-project/commit/af7a1453526a88a0e242baf156244aa4ae42ae4b DIFF: https://github.com/llvm/llvm-project/commit/af7a1453526a88a0e242baf156244aa4ae42ae4b

Re: [llvm-branch-commits] [clang] c3a21e5 - [ASTMatchers] Ensure that we can match inside lambdas

2021-01-28 Thread Alexander Kornienko via llvm-branch-commits
Thanks for the prompt response! On Thu, Jan 28, 2021 at 12:52 AM Stephen Kelly wrote: > > Thanks for reporting. Please try https://reviews.llvm.org/D95573 > > Thanks, > > Stephen. > On 27/01/2021 22:58, Alexander Kornienko wrote: > > This patch causes practically infinite traversal times on code

Re: [llvm-branch-commits] [clang] c3a21e5 - [ASTMatchers] Ensure that we can match inside lambdas

2021-01-27 Thread Alexander Kornienko via llvm-branch-commits
This patch causes practically infinite traversal times on code that contains deeply nested lambdas. Please fix or revert the commit. There's a very simple test case (add more nesting, if it's still fast ;): void f() { [] { [] { [] { [] { [] { [] { [] { [] { [] { [] { [] {

[llvm-branch-commits] [clang] 9c49b0b - Remove the ast_type_traits namespace.

2020-12-14 Thread Alexander Kornienko via llvm-branch-commits
Author: Alexander Kornienko Date: 2020-12-15T02:16:12+01:00 New Revision: 9c49b0bba0fcbe8b10c0f44ce60a8d26e6f30479 URL: https://github.com/llvm/llvm-project/commit/9c49b0bba0fcbe8b10c0f44ce60a8d26e6f30479 DIFF: https://github.com/llvm/llvm-project/commit/9c49b0bba0fcbe8b10c0f44ce60a8d26e6f30479

[llvm-branch-commits] [clang-tools-extra] 4c5e0c7 - Remove references to the ast_type_traits namespace

2020-12-11 Thread Alexander Kornienko via llvm-branch-commits
Author: Alexander Kornienko Date: 2020-12-11T12:39:33+01:00 New Revision: 4c5e0c7fd801ccc52d3b137fa685d4215a6c57ed URL: https://github.com/llvm/llvm-project/commit/4c5e0c7fd801ccc52d3b137fa685d4215a6c57ed DIFF: https://github.com/llvm/llvm-project/commit/4c5e0c7fd801ccc52d3b137fa685d4215a6c57ed

[llvm-branch-commits] [cfe-branch] r263715 - Add clang-tidy release notes.

2016-03-19 Thread Alexander Kornienko via llvm-branch-commits
Author: alexfh Date: Thu Mar 17 09:58:32 2016 New Revision: 263715 URL: http://llvm.org/viewvc/llvm-project?rev=263715&view=rev Log: Add clang-tidy release notes. Modified: cfe/branches/release_38/docs/ReleaseNotes.rst Modified: cfe/branches/release_38/docs/ReleaseNotes.rst URL: http://llvm