https://github.com/boomanaiden154 approved this pull request.
Overall LGTM.
https://github.com/llvm/llvm-project/pull/147842
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-br
https://github.com/boomanaiden154 edited
https://github.com/llvm/llvm-project/pull/147842
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -0,0 +1,150 @@
+//===- llvm-ir2vec.cpp - IR2Vec Embedding Generation Tool
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -81,6 +136,68 @@ class IR2VecTool {
OS << LocalOutput;
}
+ /// Generate embeddings for the entire module
+ void generateEmbeddings(raw_ostream &OS) const {
+if (!Vocab->isValid()) {
+ OS << "Error: Vocabulary is not valid. IR2VecTool not initialized.\n";
+
@@ -34,7 +42,7 @@
#include "llvm/Support/raw_ostream.h"
using namespace llvm;
-using namespace ir2vec;
+using namespace llvm::ir2vec;
boomanaiden154 wrote:
Instead of `using` statements, it might be better to wrap everything outside of
`main` in an anonymous
https://github.com/boomanaiden154 edited
https://github.com/llvm/llvm-project/pull/147844
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 approved this pull request.
Minor style nits, otherwise LGTM.
https://github.com/llvm/llvm-project/pull/147844
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/148319
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/148319
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/148319
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/148319
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 edited
https://github.com/llvm/llvm-project/pull/148643
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 created
https://github.com/llvm/llvm-project/pull/148643
Manual backport of df7927626bc2e6473691ce59067797c60acc2627 to release/20.x
Part of fixing #132738.
>From 3e619a933d8d86ab4745e86b38573518530c531d Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Mon
@@ -447,21 +453,18 @@ void IR2VecVocabAnalysis::generateNumMappedVocab() {
// Handle Opcodes
std::vector NumericOpcodeEmbeddings(Vocabulary::MaxOpcodes,
Embedding(Dim, 0));
-#define HANDLE_INST(NUM, OPCODE, CLASS)
@@ -297,9 +309,9 @@ StringRef
Vocabulary::getVocabKeyForOperandKind(Vocabulary::OperandKind Kind) {
OPERAND_KINDS
#undef OPERAND_KIND
case Vocabulary::OperandKind::MaxOperandKind:
-llvm_unreachable("Invalid OperandKind");
+return "UnknownOperand";
}
- llvm_un
@@ -0,0 +1,73 @@
+; RUN: llvm-ir2vec --mode=embeddings
--ir2vec-vocab-path=%S/../../Analysis/IR2Vec/Inputs/dummy_3D_nonzero_opc_vocab.json
%s | FileCheck %s -check-prefix=CHECK-DEFAULT
boomanaiden154 wrote:
Given you access `%S../../Analysis/IR2Vec/Inputs` so o
@@ -81,6 +136,70 @@ class IR2VecTool {
OS << LocalOutput;
}
+ /// Generate embeddings for the entire module
+ void generateEmbeddings(raw_ostream &OS) const {
+if (!Vocab->isValid()) {
+ OS << "Error: Vocabulary is not valid. IR2VecTool not initialized.\n";
+
@@ -117,11 +270,21 @@ int main(int argc, char **argv) {
cl::HideUnrelatedOptions(IR2VecToolCategory);
cl::ParseCommandLineOptions(
argc, argv,
- "IR2Vec - Triplet Generation Tool\n"
- "Generates triplets for vocabulary training from LLVM IR.\n"
- "Futur
@@ -50,16 +58,63 @@ static cl::opt OutputFilename("o",
cl::desc("Output filename"),
cl::init("-"),
cl::cat(IR2VecToolCategory));
+enum ToolMode {
+ TripletMode, // Generate triplets for vo
https://github.com/boomanaiden154 edited
https://github.com/llvm/llvm-project/pull/147844
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 commented:
Premerge failures here also look relevant.
https://github.com/llvm/llvm-project/pull/147844
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/147871
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/147871
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/147871
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/147871
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/147791
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/147791
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 created
https://github.com/llvm/llvm-project/pull/147871
This patch makes it so that generate_test_report_github.py generates a
test report even when we don't get any test results. This otherwise
created a pretty confusing user experience on the Github side if t
https://github.com/boomanaiden154 created
https://github.com/llvm/llvm-project/pull/147791
This is another Buildkite relic that we can get rid of now to simplify
things a bit.
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
h
https://github.com/boomanaiden154 approved this pull request.
LGTM barring removing the test trigger from `llvm/README.txt`. Given that we're
now planning on using this in the release branch too, do you want all changes
going into `premerge.yaml` to also be backported?
https://github.com/llvm/
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/147437
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/147437
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -52,8 +52,17 @@
"clang": {"clang-tools-extra", "cross-project-tests"},
"mlir": {"flang"},
# Test everything if ci scripts are changed.
-# FIXME: Figure out what is missing and add here.
-".ci": {"llvm", "clang", "lld", "lldb"},
+".ci": {
-
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/143481
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/143481
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/143480
>From 4a2932807356182b03566460492a2dc17c023a85 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Mon, 9 Jun 2025 22:45:18 -0700
Subject: [PATCH] update
Created using spr 1.3.6
---
.ci/generate-buildki
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/143481
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/143481
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/143481
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/143480
>From 4a2932807356182b03566460492a2dc17c023a85 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Mon, 9 Jun 2025 22:45:18 -0700
Subject: [PATCH] update
Created using spr 1.3.6
---
.ci/generate-buildki
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/143480
>From 4a2932807356182b03566460492a2dc17c023a85 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Mon, 9 Jun 2025 22:45:18 -0700
Subject: [PATCH] update
Created using spr 1.3.6
---
.ci/generate-buildki
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/143481
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/143478
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/143478
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/144034
>From 37c9533ee710afa6276a512fd8e60676f317cfe4 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Sun, 22 Jun 2025 07:57:54 -0700
Subject: [PATCH] feedback
Created using spr 1.3.6
---
.ci/compute_proje
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/144034
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/144034
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 created
https://github.com/llvm/llvm-project/pull/144034
This patch resolves a fixme in the compute_projects script to actually
test all the projects we can when touching something in the .ci
directory. This ensures we test things like compiler-rt before landing
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/143478
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/143481
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/143481
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/143478
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/143480
>From 4a2932807356182b03566460492a2dc17c023a85 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Mon, 9 Jun 2025 22:45:18 -0700
Subject: [PATCH] update
Created using spr 1.3.6
---
.ci/generate-buildki
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/143481
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/143480
>From 4a2932807356182b03566460492a2dc17c023a85 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Mon, 9 Jun 2025 22:45:18 -0700
Subject: [PATCH] update
Created using spr 1.3.6
---
.ci/generate-buildki
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/143478
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/143481
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/143480
>From 4a2932807356182b03566460492a2dc17c023a85 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Mon, 9 Jun 2025 22:45:18 -0700
Subject: [PATCH] update
Created using spr 1.3.6
---
.ci/generate-buildki
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/143480
>From 4a2932807356182b03566460492a2dc17c023a85 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Mon, 9 Jun 2025 22:45:18 -0700
Subject: [PATCH] update
Created using spr 1.3.6
---
.ci/generate-buildki
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/143478
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 created
https://github.com/llvm/llvm-project/pull/143481
This patch updates monolithic-linux.sh and monolithic-windows.sh to emit
expandable groups in the Github logs. The syntax this replaces
originally worked to produce the same functionality on Buildkite, but
https://github.com/boomanaiden154 edited
https://github.com/llvm/llvm-project/pull/143480
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/143480
>From 4a2932807356182b03566460492a2dc17c023a85 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Mon, 9 Jun 2025 22:45:18 -0700
Subject: [PATCH] update
Created using spr 1.3.6
---
.ci/generate-buildki
https://github.com/boomanaiden154 created
https://github.com/llvm/llvm-project/pull/143480
This patch removes the generate_test_report_buildkite script entrypoint
as we no longer need it now that buildkite has been sunsetted. Also
remove the calls in the monolithic-* scripts given they are addin
https://github.com/boomanaiden154 created
https://github.com/llvm/llvm-project/pull/143478
I have a habit of using early exits given it is in the LLVM coding
standards, but most of the early exits used within this script were
trivial and actually adding complexity. These are all instances where
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142696
>From 360e723b51ee201603f72b56859cd7c6d6faec24 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Thu, 5 Jun 2025 06:51:37 +
Subject: [PATCH 1/2] feedback
Created using spr 1.3.4
---
.ci/compute_pr
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142696
>From 360e723b51ee201603f72b56859cd7c6d6faec24 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Thu, 5 Jun 2025 06:51:37 +
Subject: [PATCH 1/2] feedback
Created using spr 1.3.4
---
.ci/compute_pr
@@ -53,7 +56,12 @@ class raw_ostream;
enum class IR2VecKind { Symbolic };
namespace ir2vec {
-/// Embedding is a datavtype that wraps std::vector. It provides
+
+LLVM_ABI extern cl::opt OpcWeight;
boomanaiden154 wrote:
Why do these need an `LLVM_ABI` tag?
If
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142696
>From 360e723b51ee201603f72b56859cd7c6d6faec24 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Thu, 5 Jun 2025 06:51:37 +
Subject: [PATCH 1/2] feedback
Created using spr 1.3.4
---
.ci/compute_pr
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142696
>From 360e723b51ee201603f72b56859cd7c6d6faec24 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Thu, 5 Jun 2025 06:51:37 +
Subject: [PATCH 1/2] feedback
Created using spr 1.3.4
---
.ci/compute_pr
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142695
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142695
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142696
>From 360e723b51ee201603f72b56859cd7c6d6faec24 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Thu, 5 Jun 2025 06:51:37 +
Subject: [PATCH 1/2] feedback
Created using spr 1.3.4
---
.ci/compute_pr
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142696
>From 360e723b51ee201603f72b56859cd7c6d6faec24 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Thu, 5 Jun 2025 06:51:37 +
Subject: [PATCH 1/2] feedback
Created using spr 1.3.4
---
.ci/compute_pr
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142695
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142695
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142694
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142694
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -102,51 +102,25 @@ if [[ "${runtimes}" != "" ]]; then
exit 1
fi
- echo "--- ninja install-clang"
-
- ninja -C ${BUILD_DIR} install-clang install-clang-resource-headers
-
- RUNTIMES_BUILD_DIR="${MONOREPO_ROOT}/build-runtimes"
- INSTALL_DIR="${BUILD_DIR}/install"
-
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142925
>From 357a155d005c20fc10206d046c9b7c010626d9e3 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Thu, 5 Jun 2025 08:42:55 +
Subject: [PATCH 1/2] formatting
Created using spr 1.3.4
---
libcxx/inclu
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142695
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142694
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -451,6 +451,7 @@ namespace std {
# if _LIBCPP_STD_VER >= 23
#include <__fwd/mdspan.h>
+#include <__fwd/span.h>
boomanaiden154 wrote:
Filed the LWG issue (4275) and added a comment.
https://github.com/llvm/llvm-project/pull/142925
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142696
>From 360e723b51ee201603f72b56859cd7c6d6faec24 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Thu, 5 Jun 2025 06:51:37 +
Subject: [PATCH 1/2] feedback
Created using spr 1.3.4
---
.ci/compute_pr
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142696
>From 360e723b51ee201603f72b56859cd7c6d6faec24 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Thu, 5 Jun 2025 06:51:37 +
Subject: [PATCH 1/2] feedback
Created using spr 1.3.4
---
.ci/compute_pr
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142695
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142694
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142694
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142694
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142696
>From 360e723b51ee201603f72b56859cd7c6d6faec24 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Thu, 5 Jun 2025 06:51:37 +
Subject: [PATCH 1/2] feedback
Created using spr 1.3.4
---
.ci/compute_pr
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142696
>From 360e723b51ee201603f72b56859cd7c6d6faec24 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Thu, 5 Jun 2025 06:51:37 +
Subject: [PATCH 1/2] feedback
Created using spr 1.3.4
---
.ci/compute_pr
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142695
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142925
>From 357a155d005c20fc10206d046c9b7c010626d9e3 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Thu, 5 Jun 2025 08:42:55 +
Subject: [PATCH] formatting
Created using spr 1.3.4
---
libcxx/include/m
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142695
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142925
>From 357a155d005c20fc10206d046c9b7c010626d9e3 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Thu, 5 Jun 2025 08:42:55 +
Subject: [PATCH] formatting
Created using spr 1.3.4
---
libcxx/include/m
boomanaiden154 wrote:
Branch seems to be cleaned up now.
https://github.com/llvm/llvm-project/pull/142694
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
boomanaiden154 wrote:
> Multiconfig in this context has some strong associations with CMake's Ninja
> Multi-Config generator for me. My suggestion is needs_reconfig.
> Agree with needs_reconfig.
Updated. Thanks for the suggestion!
https://github.com/llvm/llvm-project/pull/142696
_
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142696
>From 360e723b51ee201603f72b56859cd7c6d6faec24 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Thu, 5 Jun 2025 06:51:37 +
Subject: [PATCH 1/2] feedback
Created using spr 1.3.4
---
.ci/compute_pr
boomanaiden154 wrote:
> There's still an outstanding question of unrelated changes to libc++ tests
> that are included in this PR.
I'm still not sure how they're ending up in here. I haven't seen this before
with `spr`. This will definitely be fixed before I end up landing the patch and
I'm g
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/142696
>From 360e723b51ee201603f72b56859cd7c6d6faec24 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Thu, 5 Jun 2025 06:51:37 +
Subject: [PATCH] feedback
Created using spr 1.3.4
---
.ci/compute_projec
1 - 100 of 300 matches
Mail list logo