[llvm-branch-commits] [llvm] [GOFF] Add writing of section symbols (PR #133799)

2025-04-09 Thread Ulrich Weigand via llvm-branch-commits
@@ -230,10 +230,11 @@ class MCObjectFileInfo { MCSection *GLJMPSection = nullptr; // GOFF specific sections. - MCSection *PPA1Section = nullptr; - MCSection *PPA2Section = nullptr; - MCSection *PPA2ListSection = nullptr; - MCSection *ADASection = nullptr; + MCSection

[llvm-branch-commits] [clang] [clang] implement printing of canonical template arguments of expression kind (PR #135133)

2025-04-09 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Matheus Izvekov (mizvekov) Changes This patch extends the canonicalization printing policy to cover expressions and template names, and wires that up to the template argument printer, covering expressions. This is helpful for debugging,

[llvm-branch-commits] [lld] ELF: Only rewrite non-preemptible IFUNCs to IPLT functions if a non-IRELATIVE relocation is needed. (PR #133531)

2025-04-09 Thread Peter Collingbourne via llvm-branch-commits
pcc wrote: > I’m worried about the added complexity of ifunc and the extra parameter in > isStaticLinkTimeConstant, a key component of relocation scanning where > performance is critical. (Our scanning process is already noticeably slower > than mold’s, and these factors are contributing to th

[llvm-branch-commits] [clang] [clang] implement printing of canonical template arguments of expression kind (PR #135133)

2025-04-09 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Matheus Izvekov (mizvekov) Changes This patch extends the canonicalization printing policy to cover expressions and template names, and wires that up to the template argument printer, covering expressions. This is helpful for deb

[llvm-branch-commits] [clang] [clang] implement printing of canonical template arguments of expression kind (PR #135133)

2025-04-09 Thread Matheus Izvekov via llvm-branch-commits
https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/135133 This patch extends the canonicalization printing policy to cover expressions and template names, and wires that up to the template argument printer, covering expressions. This is helpful for debugging, or if

[llvm-branch-commits] ELF: Only rewrite non-preemptible IFUNCs to IPLT functions if a non-IRELATIVE relocation is needed. (PR #133531)

2025-04-09 Thread Peter Collingbourne via llvm-branch-commits
https://github.com/pcc edited https://github.com/llvm/llvm-project/pull/133531 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/20.x: [clang-format] Keep the space between `not` and a unary operator (#135035) (PR #135118)

2025-04-09 Thread via llvm-branch-commits
https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/135118 Backport f34483838937b1a01ee11ee22bdd6e13c81e9fff Requested by: @owenca >From 352ee2311f041ca08c1ff7bc4a68dd5094398951 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Wed, 9 Apr 2025 17:52:12 -0700 Subject: [PAT

[llvm-branch-commits] [clang] 346c905 - Revert "[Clang][CodeGen][UBSan] Add more precise attributes to recoverable ub…"

2025-04-09 Thread via llvm-branch-commits
Author: Yingwei Zheng Date: 2025-04-10T13:09:28+08:00 New Revision: 346c905e8ab7cb81c537eb5be1d57cc63a41daea URL: https://github.com/llvm/llvm-project/commit/346c905e8ab7cb81c537eb5be1d57cc63a41daea DIFF: https://github.com/llvm/llvm-project/commit/346c905e8ab7cb81c537eb5be1d57cc63a41daea.diff

[llvm-branch-commits] ELF: Remove lock from MTE global relocation handling code. (PR #135123)

2025-04-09 Thread Peter Collingbourne via llvm-branch-commits
https://github.com/pcc created https://github.com/llvm/llvm-project/pull/135123 This lock is unnecessary because we can add the relocations to shards and let them be sorted later. ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.or

[llvm-branch-commits] [BOLT] Jump table trampoline insertion pass (PR #135103)

2025-04-09 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/135103 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] 3e7df27 - Revert "Fix ambiguous reversed operator error in sanitizer_mac.h (#135068)"

2025-04-09 Thread via llvm-branch-commits
Author: Jonas Devlieghere Date: 2025-04-09T21:08:00-07:00 New Revision: 3e7df27c1d3a9c1a430b2cf471517f8f059d59ed URL: https://github.com/llvm/llvm-project/commit/3e7df27c1d3a9c1a430b2cf471517f8f059d59ed DIFF: https://github.com/llvm/llvm-project/commit/3e7df27c1d3a9c1a430b2cf471517f8f059d59ed.d

[llvm-branch-commits] ELF: Only rewrite non-preemptible IFUNCs to IPLT functions if a non-IRELATIVE relocation is needed. (PR #133531)

2025-04-09 Thread Peter Collingbourne via llvm-branch-commits
https://github.com/pcc updated https://github.com/llvm/llvm-project/pull/133531 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] llvm-reduce: Add new pass to inline call sites (PR #134223)

2025-04-09 Thread Arthur Eubanks via llvm-branch-commits
https://github.com/aeubanks commented: perhaps a heuristic of reducing the total number of inlinable calls, i.e. the function being inlined cannot have any inlinable calls, would be good for not letting this run too much https://github.com/llvm/llvm-project/pull/134223

[llvm-branch-commits] [lld] ELF: Only rewrite non-preemptible IFUNCs to IPLT functions if a non-IRELATIVE relocation is needed. (PR #133531)

2025-04-09 Thread Peter Collingbourne via llvm-branch-commits
https://github.com/pcc updated https://github.com/llvm/llvm-project/pull/133531 >From 96e7da9a083888683c2ba00d97f886fd748ea10b Mon Sep 17 00:00:00 2001 From: Peter Collingbourne Date: Wed, 9 Apr 2025 20:30:57 -0700 Subject: [PATCH] Undo unnecessary change Created using spr 1.3.6-beta.1 --- lld

[llvm-branch-commits] [llvm] [BOLT][NFC] Define AArch64 jump table types (PR #132109)

2025-04-09 Thread Maksim Panchenko via llvm-branch-commits
https://github.com/maksfb commented: I expect that eventually we will get RISC-V support for jump tables. In this context, I would prefer to keep the format of the jump table itself separate from the underlying architecture. I.e. we can use JTs with an absolute 64-bit addressing on any platfor

[llvm-branch-commits] AArch64: Relax x16/x17 constraint on AUT in certain cases. (PR #132857)

2025-04-09 Thread Peter Collingbourne via llvm-branch-commits
https://github.com/pcc updated https://github.com/llvm/llvm-project/pull/132857 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] ELF: Only rewrite non-preemptible IFUNCs to IPLT functions if a non-IRELATIVE relocation is needed. (PR #133531)

2025-04-09 Thread Peter Collingbourne via llvm-branch-commits
pcc wrote: > This patch has a few problems > > * The check in `processAux` was moved to the wrong place (it will never get > hit because this is after we deal with all symbols not defined locally). This > patch moves it to approximately the right place but will need some logic > changes to `i

[llvm-branch-commits] ELF: Remove lock from MTE global relocation handling code. (PR #135123)

2025-04-09 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-lld Author: Peter Collingbourne (pcc) Changes This lock is unnecessary because we can add the relocations to shards and let them be sorted later. --- Full diff: https://github.com/llvm/llvm-project/pull/135123.diff 1 Files Affected: - (modified) lld

[llvm-branch-commits] ELF: Only rewrite non-preemptible IFUNCs to IPLT functions if a non-IRELATIVE relocation is needed. (PR #133531)

2025-04-09 Thread Peter Collingbourne via llvm-branch-commits
https://github.com/pcc updated https://github.com/llvm/llvm-project/pull/133531 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] compiler-rt: Introduce runtime functions for emulated PAC. (PR #133530)

2025-04-09 Thread Peter Collingbourne via llvm-branch-commits
https://github.com/pcc updated https://github.com/llvm/llvm-project/pull/133530 >From b37a44fff650b06eda249060277d0c007226cad2 Mon Sep 17 00:00:00 2001 From: Peter Collingbourne Date: Thu, 3 Apr 2025 21:51:44 -0700 Subject: [PATCH] Fix CMake build Created using spr 1.3.6-beta.1 --- compiler-rt

[llvm-branch-commits] Extract SipHash implementation into a header. (PR #134197)

2025-04-09 Thread Peter Collingbourne via llvm-branch-commits
https://github.com/pcc updated https://github.com/llvm/llvm-project/pull/134197 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] Extract SipHash implementation into a header. (PR #134197)

2025-04-09 Thread Peter Collingbourne via llvm-branch-commits
https://github.com/pcc updated https://github.com/llvm/llvm-project/pull/134197 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] libcxx: In gdb test detect execute_mi with feature check instead of version check. (PR #132291)

2025-04-09 Thread Peter Collingbourne via llvm-branch-commits
https://github.com/pcc updated https://github.com/llvm/llvm-project/pull/132291 >From 89ce369ab9b49b8c23a87ad0a888002dd85c094c Mon Sep 17 00:00:00 2001 From: Peter Collingbourne Date: Thu, 20 Mar 2025 15:12:39 -0700 Subject: [PATCH 1/2] Format Created using spr 1.3.6-beta.1 --- libcxx/test/lib

[llvm-branch-commits] AArch64: Relax x16/x17 constraint on AUT in certain cases. (PR #132857)

2025-04-09 Thread Peter Collingbourne via llvm-branch-commits
https://github.com/pcc updated https://github.com/llvm/llvm-project/pull/132857 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/20.x: [clang-format] Keep the space between `not` and a unary operator (#135035) (PR #135118)

2025-04-09 Thread via llvm-branch-commits
https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/135118 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/20.x: [clang-format] Keep the space between `not` and a unary operator (#135035) (PR #135118)

2025-04-09 Thread via llvm-branch-commits
llvmbot wrote: @mydeveloperday What do you think about merging this PR to the release branch? https://github.com/llvm/llvm-project/pull/135118 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[llvm-branch-commits] [llvm] 76c510a - Revert "Reland "Symbolize line zero as if no source info is available (#12484…"

2025-04-09 Thread via llvm-branch-commits
Author: Zequan Wu Date: 2025-04-09T21:02:29-04:00 New Revision: 76c510a2a1b7b7f708ea7b891ef5f7da5c703ca6 URL: https://github.com/llvm/llvm-project/commit/76c510a2a1b7b7f708ea7b891ef5f7da5c703ca6 DIFF: https://github.com/llvm/llvm-project/commit/76c510a2a1b7b7f708ea7b891ef5f7da5c703ca6.diff LOG

[llvm-branch-commits] [llvm] 989bc69 - llvm-reduce: Trim includes in ReduceInstructions (#135022)

2025-04-09 Thread via llvm-branch-commits
Author: Matt Arsenault Date: 2025-04-09T21:14:42+02:00 New Revision: 989bc69ceb47e27f402d14166eb2e2ea53e00c84 URL: https://github.com/llvm/llvm-project/commit/989bc69ceb47e27f402d14166eb2e2ea53e00c84 DIFF: https://github.com/llvm/llvm-project/commit/989bc69ceb47e27f402d14166eb2e2ea53e00c84.diff

[llvm-branch-commits] [clang] 2ab2276 - [HLSL] Implement the `lit` intrinsic (#134171)

2025-04-09 Thread via llvm-branch-commits
Author: Kaitlin Peng Date: 2025-04-09T12:12:26-07:00 New Revision: 2ab2276ee079478b7ba9dd42c62b796d3dab1759 URL: https://github.com/llvm/llvm-project/commit/2ab2276ee079478b7ba9dd42c62b796d3dab1759 DIFF: https://github.com/llvm/llvm-project/commit/2ab2276ee079478b7ba9dd42c62b796d3dab1759.diff

[llvm-branch-commits] [llvm] [GOFF] Add writing of section symbols (PR #133799)

2025-04-09 Thread via llvm-branch-commits
@@ -2759,6 +2762,29 @@ MCSection *TargetLoweringObjectFileXCOFF::getSectionForLSDA( //===--===// TargetLoweringObjectFileGOFF::TargetLoweringObjectFileGOFF() = default; +void TargetLoweringObjectFileGOFF::ge

[llvm-branch-commits] [compiler-rt] release/20.x: [Sanitizers][Darwin][Test] XFAIL malloc_zone.cpp (PR #133832)

2025-04-09 Thread Mariusz Borsa via llvm-branch-commits
wrotki wrote: Not sure if I'm perhaps missing some step to have this merged, is there any automated process?II don't have permissions to merge this to the release branch (Github shows me 'Cannot update this protected ref' status). @tstellar , could you merge this on my behalf? https://githu

[llvm-branch-commits] [llvm] [GOFF] Add writing of section symbols (PR #133799)

2025-04-09 Thread Kai Nacke via llvm-branch-commits
@@ -239,6 +298,63 @@ class GOFFWriter { GOFFWriter::GOFFWriter(raw_pwrite_stream &OS, MCAssembler &Asm) : OS(OS), Asm(Asm) {} +void GOFFWriter::defineSectionSymbols(const MCSectionGOFF &Section) { + if (Section.isSD()) { +GOFFSymbol SD(Section.getName(), Section.getId

[llvm-branch-commits] [BOLT] Jump table trampoline insertion pass (PR #135103)

2025-04-09 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov created https://github.com/llvm/llvm-project/pull/135103 Test Plan: TBD ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] SCEVExpander: Don't look at uses of constants (PR #134691)

2025-04-09 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-transforms Author: Matt Arsenault (arsenm) Changes This could be more relaxed, and look for uses of globals in the same function but no tests apparently depend on that. --- Full diff: https://github.com/llvm/llvm-project/pull/134691.diff 1 Files

[llvm-branch-commits] [llvm] [HLSL] Adding support for Root Constants in LLVM Metadata (PR #135085)

2025-04-09 Thread via llvm-branch-commits
https://github.com/joaosaffran created https://github.com/llvm/llvm-project/pull/135085 - Closes [#126637](https://github.com/llvm/llvm-project/issues/126637) >From 9b59d0108f6b23c039e2c417247216862073cd4b Mon Sep 17 00:00:00 2001 From: joaosaffran Date: Wed, 9 Apr 2025 21:05:58 + Subject:

[llvm-branch-commits] [mlir] [mlir][LLVM] Delete `getFixedVectorType` and `getScalableVectorType` (PR #135051)

2025-04-09 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-mlir-llvm Author: Matthias Springer (matthias-springer) Changes The LLVM dialect no longer has its own vector types. It uses `mlir::VectorType` everywhere. Remove `LLVM::getFixedVectorType/getScalableVectorType` and use `VectorType::get` instead. This

[llvm-branch-commits] [clang] [llvm] [X86] Backport new intrinsic and instruction changes in AVX10.2 (PR #133219)

2025-04-09 Thread Phoebe Wang via llvm-branch-commits
phoebewang wrote: > > Doesn't this break ABI by changing intrinsic / builtin numbers? > > So the headers could still be updated but must use the existing builtins in > the backport? Sounds good, I can try with it. Thanks! https://github.com/llvm/llvm-project/pull/133219 __

[llvm-branch-commits] [llvm] CodeGen: Trim redundant template argument from defusechain_iterator (PR #135024)

2025-04-09 Thread Matt Arsenault via llvm-branch-commits
https://github.com/arsenm ready_for_review https://github.com/llvm/llvm-project/pull/135024 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [BOLT] Gadget scanner: analyze functions without CFG information (PR #133461)

2025-04-09 Thread Anatoly Trosinenko via llvm-branch-commits
@@ -265,21 +286,24 @@ void PacStatePrinter::print(raw_ostream &OS, const State &S) const { OS << ">"; } -class PacRetAnalysis -: public DataflowAnalysis { - using Parent = - DataflowAnalysis; - friend Parent; - +class PacRetAnalysis { atrosinenko

[llvm-branch-commits] [llvm] [BOLT] Gadget scanner: analyze functions without CFG information (PR #133461)

2025-04-09 Thread Anatoly Trosinenko via llvm-branch-commits
https://github.com/atrosinenko updated https://github.com/llvm/llvm-project/pull/133461 >From 15823152747e1885f71407eee27601b84a58bc60 Mon Sep 17 00:00:00 2001 From: Anatoly Trosinenko Date: Wed, 19 Mar 2025 18:58:32 +0300 Subject: [PATCH] [BOLT] Gadget scanner: analyze functions without CFG i

[llvm-branch-commits] [llvm] [BOLT] Gadget scanner: analyze functions without CFG information (PR #133461)

2025-04-09 Thread Anatoly Trosinenko via llvm-branch-commits
https://github.com/atrosinenko updated https://github.com/llvm/llvm-project/pull/133461 >From 15823152747e1885f71407eee27601b84a58bc60 Mon Sep 17 00:00:00 2001 From: Anatoly Trosinenko Date: Wed, 19 Mar 2025 18:58:32 +0300 Subject: [PATCH] [BOLT] Gadget scanner: analyze functions without CFG i

[llvm-branch-commits] [llvm] [BOLT] Gadget scanner: analyze functions without CFG information (PR #133461)

2025-04-09 Thread Anatoly Trosinenko via llvm-branch-commits
https://github.com/atrosinenko edited https://github.com/llvm/llvm-project/pull/133461 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [KeyInstr][Inline] Don't propagate atoms to inlined nodebug instructions (PR #133485)

2025-04-09 Thread Stephen Tozer via llvm-branch-commits
https://github.com/SLTozer edited https://github.com/llvm/llvm-project/pull/133485 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] 69a55b8 - Revert "[llc] Add -M for InstPrinter options"

2025-04-09 Thread via llvm-branch-commits
Author: Thurston Dang Date: 2025-04-09T12:07:54-07:00 New Revision: 69a55b8cab98a8f07a9d84e9704fe79ed9d2fbea URL: https://github.com/llvm/llvm-project/commit/69a55b8cab98a8f07a9d84e9704fe79ed9d2fbea DIFF: https://github.com/llvm/llvm-project/commit/69a55b8cab98a8f07a9d84e9704fe79ed9d2fbea.diff

[llvm-branch-commits] [clang] [llvm] release/20.x: [fatlto] Add coroutine passes when using FatLTO with ThinLTO (#134434) (PR #134711)

2025-04-09 Thread Yuxuan Chen via llvm-branch-commits
yuxuanchen1997 wrote: cc @apolloww https://github.com/llvm/llvm-project/pull/134711 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] Add pointer field protection feature. (PR #133538)

2025-04-09 Thread Mark de Wever via llvm-branch-commits
mordante wrote: > > in libc++ we have a pre-commit CI so this feature should be tested in our > > CI, if you need help with that, best reach out to us on Discord. However I > > think we first need to look at how we can properly integrate this in libc++. > > Sure, I will get in touch once this

[llvm-branch-commits] Add pointer field protection feature. (PR #133538)

2025-04-09 Thread Peter Collingbourne via llvm-branch-commits
@@ -84,7 +84,7 @@ _LIBCPP_PUSH_MACROS _LIBCPP_BEGIN_NAMESPACE_STD template */> -class _LIBCPP_TEMPLATE_VIS vector { +class _LIBCPP_TEMPLATE_VIS vector _LIBCPP_MAYBE_FORCE_NONSTANDARD_LAYOUT { pcc wrote: The intent would be that the user builds libc++.a with

[llvm-branch-commits] Add pointer field protection feature. (PR #133538)

2025-04-09 Thread Peter Collingbourne via llvm-branch-commits
@@ -1215,6 +1215,29 @@ typedef __char32_t char32_t; #define _LIBCPP_HAS_EXPLICIT_THIS_PARAMETER 0 # endif +# if __has_feature(pointer_field_protection) +// Force a class to be non-standard layout by giving it two bases with the same +// type. This is useful when structur

[llvm-branch-commits] Add pointer field protection feature. (PR #133538)

2025-04-09 Thread Peter Collingbourne via llvm-branch-commits
@@ -1215,6 +1215,29 @@ typedef __char32_t char32_t; #define _LIBCPP_HAS_EXPLICIT_THIS_PARAMETER 0 # endif +# if __has_feature(pointer_field_protection) pcc wrote: Makes sense, will do. https://github.com/llvm/llvm-project/pull/133538 __

[llvm-branch-commits] Add pointer field protection feature. (PR #133538)

2025-04-09 Thread Peter Collingbourne via llvm-branch-commits
https://github.com/pcc commented: > in libc++ we have a pre-commit CI so this feature should be tested in our CI, > if you need help with that, best reach out to us on Discord. However I think > we first need to look at how we can properly integrate this in libc++. Sure, I will get in touch on

[llvm-branch-commits] Add pointer field protection feature. (PR #133538)

2025-04-09 Thread Peter Collingbourne via llvm-branch-commits
https://github.com/pcc edited https://github.com/llvm/llvm-project/pull/133538 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] clang/AMDGPU: Stop looking for oclc_daz_opt_* control libraries (PR #134805)

2025-04-09 Thread Matt Arsenault via llvm-branch-commits
arsenm wrote: > LGTM. > > > > Does this mean device library have no code depending on option > `-cl-denorms-are-zero`? It still has a little but it's implementable as a runtime check with dynamic denormal mode. I think it would still be better to find a way to avoid it (I think we need one

[llvm-branch-commits] [llvm] 2b8e723 - Revert "[SelectionDAG] Introducing a new ISD::POISON SDNode to represent the …"

2025-04-09 Thread via llvm-branch-commits
Author: Jakub Kuderski Date: 2025-04-09T13:51:26-04:00 New Revision: 2b8e7230c9fbe55527f6036d40df0c030a0f4ac6 URL: https://github.com/llvm/llvm-project/commit/2b8e7230c9fbe55527f6036d40df0c030a0f4ac6 DIFF: https://github.com/llvm/llvm-project/commit/2b8e7230c9fbe55527f6036d40df0c030a0f4ac6.diff

[llvm-branch-commits] [llvm] CodeGen: Trim redundant template argument from defusechain_iterator (PR #135024)

2025-04-09 Thread Matt Arsenault via llvm-branch-commits
https://github.com/arsenm created https://github.com/llvm/llvm-project/pull/135024 Only one of ByOperand, ByInstr, or ByBundle should be true. Replace ByBundle with !ByInstr, and assert that both are not used. >From 751b2ad5ef572948a57cc0162a4dafc56f9f7d72 Mon Sep 17 00:00:00 2001 From: Matt Ar

[llvm-branch-commits] Add pointer field protection feature. (PR #133538)

2025-04-09 Thread Mark de Wever via llvm-branch-commits
@@ -1215,6 +1215,29 @@ typedef __char32_t char32_t; #define _LIBCPP_HAS_EXPLICIT_THIS_PARAMETER 0 # endif +# if __has_feature(pointer_field_protection) mordante wrote: Since this feature is an ABI break, it will cause ODR violations to these structs. I

[llvm-branch-commits] Add pointer field protection feature. (PR #133538)

2025-04-09 Thread Mark de Wever via llvm-branch-commits
https://github.com/mordante requested changes to this pull request. Some comments from libc++'s perspective: - As you mentioned you need more tests. - I think the current approach with a header only libc++ change approach will not work due to ABI changes. See review comment for `std::vector`. -

[llvm-branch-commits] Add pointer field protection feature. (PR #133538)

2025-04-09 Thread Mark de Wever via llvm-branch-commits
https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/133538 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] Add pointer field protection feature. (PR #133538)

2025-04-09 Thread Mark de Wever via llvm-branch-commits
@@ -1215,6 +1215,29 @@ typedef __char32_t char32_t; #define _LIBCPP_HAS_EXPLICIT_THIS_PARAMETER 0 # endif +# if __has_feature(pointer_field_protection) +// Force a class to be non-standard layout by giving it two bases with the same +// type. This is useful when structur

[llvm-branch-commits] Add pointer field protection feature. (PR #133538)

2025-04-09 Thread Mark de Wever via llvm-branch-commits
@@ -84,7 +84,7 @@ _LIBCPP_PUSH_MACROS _LIBCPP_BEGIN_NAMESPACE_STD template */> -class _LIBCPP_TEMPLATE_VIS vector { +class _LIBCPP_TEMPLATE_VIS vector _LIBCPP_MAYBE_FORCE_NONSTANDARD_LAYOUT { mordante wrote: `std::vector` is used in the libc++ dylib across t

[llvm-branch-commits] [mlir] [mlir][LLVM] Delete `getFixedVectorType` and `getScalableVectorType` (PR #135051)

2025-04-09 Thread via llvm-branch-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- mlir/include/mlir/Dialect/LLVMIR/LLVMTypes.h mlir/

[llvm-branch-commits] [mlir] [mlir][LLVM] Delete `getFixedVectorType` and `getScalableVectorType` (PR #135051)

2025-04-09 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-mlir-gpu @llvm/pr-subscribers-mlir-nvgpu Author: Matthias Springer (matthias-springer) Changes The LLVM dialect no longer has its own vector types. It uses `mlir::VectorType` everywhere. Remove `LLVM::getFixedVectorType/getScalableVectorType` and use `

[llvm-branch-commits] [mlir] [mlir][LLVM] Delete `getFixedVectorType` and `getScalableVectorType` (PR #135051)

2025-04-09 Thread Matthias Springer via llvm-branch-commits
https://github.com/matthias-springer updated https://github.com/llvm/llvm-project/pull/135051 >From 120778f6eff8af147add819a4a9f3f31d495f6d8 Mon Sep 17 00:00:00 2001 From: Matthias Springer Date: Wed, 9 Apr 2025 19:05:11 +0200 Subject: [PATCH] [mlir][LLVM] Delete `getFixedVectorType` and `getS

[llvm-branch-commits] [libcxx] libcxx: In gdb test detect execute_mi with feature check instead of version check. (PR #132291)

2025-04-09 Thread Mark de Wever via llvm-branch-commits
mordante wrote: @philnik777 FWIW I also see a normal diff in the webui. https://github.com/llvm/llvm-project/pull/132291 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch

[llvm-branch-commits] [flang] e256292 - Revert "[flang][nfc] Support volatility in Fir ops (#134858)"

2025-04-09 Thread via llvm-branch-commits
Author: David Spickett Date: 2025-04-09T15:41:07+01:00 New Revision: e256292805f7e8bc168a3f207c83c784f307bd55 URL: https://github.com/llvm/llvm-project/commit/e256292805f7e8bc168a3f207c83c784f307bd55 DIFF: https://github.com/llvm/llvm-project/commit/e256292805f7e8bc168a3f207c83c784f307bd55.diff

[llvm-branch-commits] [clang] clang/AMDGPU: Stop looking for oclc_daz_opt_* control libraries (PR #134805)

2025-04-09 Thread Yaxun Liu via llvm-branch-commits
https://github.com/yxsamliu approved this pull request. LGTM. Does this mean device library have no code depending on option `-cl-denorms-are-zero`? https://github.com/llvm/llvm-project/pull/134805 ___ llvm-branch-commits mailing list llvm-branch-com

[llvm-branch-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [libcxx] [lldb] [llvm] [LV] Reduce register usage for scaled reductions (PR #133090)

2025-04-09 Thread Sam Tebbs via llvm-branch-commits
Valentin Clement =?utf-8?b?KOODkOODrOODsw==?=,zcfh <1412805...@qq.com>,Alexey Bataev ,Florian Hahn ,Alexey Bataev ,Hristo Hristov ,Mircea Trofin ,Florian Hahn ,Jonas Devlieghere ,Henry Jiang ,Alexander Yermolovich <43973793+ayerm...@users.noreply.github.com>,Andy Kaylor ,Andy Kaylor ,Florian

[llvm-branch-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [libcxx] [lldb] [llvm] [LV] Reduce register usage for scaled reductions (PR #133090)

2025-04-09 Thread Sam Tebbs via llvm-branch-commits
Valentin Clement =?utf-8?b?KOODkOODrOODsw==?=,zcfh <1412805...@qq.com>,Alexey Bataev ,Florian Hahn ,Alexey Bataev ,Hristo Hristov ,Mircea Trofin ,Florian Hahn ,Jonas Devlieghere ,Henry Jiang ,Alexander Yermolovich <43973793+ayerm...@users.noreply.github.com>,Andy Kaylor ,Andy Kaylor ,Florian

[llvm-branch-commits] [llvm] IROutliner: Do not look at use lists of constant phi inputs (PR #135019)

2025-04-09 Thread Matt Arsenault via llvm-branch-commits
https://github.com/arsenm created https://github.com/llvm/llvm-project/pull/135019 Theoretically this does a worse job with globals but this is not covered by existing tests >From 6e92bcd3daf17aad7e2a3a3ccc166845aa1b317c Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Wed, 9 Apr 2025 13:28

[llvm-branch-commits] [llvm] CodeGen: Trim redundant template argument from defusechain_iterator (PR #135024)

2025-04-09 Thread Matt Arsenault via llvm-branch-commits
arsenm wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/135024?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [llvm] IROutliner: Do not look at use lists of constant phi inputs (PR #135019)

2025-04-09 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-transforms Author: Matt Arsenault (arsenm) Changes Theoretically this does a worse job with globals but this is not covered by existing tests --- Full diff: https://github.com/llvm/llvm-project/pull/135019.diff 1 Files Affected: - (modified) llv

[llvm-branch-commits] [llvm] IROutliner: Do not look at use lists of constant phi inputs (PR #135019)

2025-04-09 Thread Matt Arsenault via llvm-branch-commits
https://github.com/arsenm ready_for_review https://github.com/llvm/llvm-project/pull/135019 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang-tools-extra] [clang-tidy] treat unsigned char and signed char as char type by default in bugprone-unintended-char-ostream-output (PR #134870)

2025-04-09 Thread Congcong Cai via llvm-branch-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/134870 >From 9d29fd3792be9ae10eb58cecaaba313a0eaf85f1 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Tue, 8 Apr 2025 15:27:54 + Subject: [PATCH 1/2] [clang-tidy] treat unsigned char and signed char as char

[llvm-branch-commits] [llvm] [KeyInstr][Inline] Don't propagate atoms to inlined nodebug instructions (PR #133485)

2025-04-09 Thread Stephen Tozer via llvm-branch-commits
https://github.com/SLTozer approved this pull request. I think conceptually there is some space for copying atom group/rank to the inlined instructions, giving the instruction(s) that produce the return value (if any) the highest precedence. This would be a separate feature however, and this b

[llvm-branch-commits] [llvm] [KeyInstr][Inline] Don't propagate atoms to inlined nodebug instructions (PR #133485)

2025-04-09 Thread Stephen Tozer via llvm-branch-commits
@@ -2145,6 +2145,13 @@ class DILocation : public MDNode { return 0; } + const DILocation *getOrCloneWithoutAtom() const { SLTozer wrote: I think this could just be "getWithoutAtom", it's already implied with DIMetadata that "get" means "find me an exi

[llvm-branch-commits] [llvm] d77b786 - Revert "[AArch64][SVE] Pair SVE fill/spill into LDP/STP with -msve-vector-bit…"

2025-04-09 Thread via llvm-branch-commits
Author: David Spickett Date: 2025-04-09T13:29:42+01:00 New Revision: d77b786ac57008f734cd5552d59c6be34fd05c77 URL: https://github.com/llvm/llvm-project/commit/d77b786ac57008f734cd5552d59c6be34fd05c77 DIFF: https://github.com/llvm/llvm-project/commit/d77b786ac57008f734cd5552d59c6be34fd05c77.diff

[llvm-branch-commits] [llvm] [KeyInstr][SimplifyCFG] Remap atoms after duplication for threading (PR #133484)

2025-04-09 Thread Stephen Tozer via llvm-branch-commits
https://github.com/SLTozer edited https://github.com/llvm/llvm-project/pull/133484 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [KeyInstr][SimplifyCFG] Remap atoms after duplication for threading (PR #133484)

2025-04-09 Thread Stephen Tozer via llvm-branch-commits
@@ -3609,11 +3609,11 @@ foldCondBranchOnValueKnownInPredecessorImpl(BranchInst *BI, DomTreeUpdater *DTU, N->setName(BBI->getName() + ".c"); // Update operands due to translation. - for (Use &Op : N->operands()) { -DenseMap::iterator PI = TranslateMa

[llvm-branch-commits] [lldb] 0451084 - Revert "[LLDB] Refactored CPlusPlusLanguage::MethodName to break lldb-server …"

2025-04-09 Thread via llvm-branch-commits
Author: David Spickett Date: 2025-04-09T13:15:33+01:00 New Revision: 0451084e2e64fc5262f480eae8150c9a191eb7dc URL: https://github.com/llvm/llvm-project/commit/0451084e2e64fc5262f480eae8150c9a191eb7dc DIFF: https://github.com/llvm/llvm-project/commit/0451084e2e64fc5262f480eae8150c9a191eb7dc.diff

[llvm-branch-commits] [llvm] [KeyInstr][SimplifyCFG] Remap atoms when folding br to common succ into pred (PR #133482)

2025-04-09 Thread Stephen Tozer via llvm-branch-commits
@@ -1182,6 +1187,19 @@ static void cloneInstructionsIntoPredecessorBlockAndUpdateSSAUses( U.set(NewBonusInst); } } + + // Key Instructions: We may have propagated atom info into the pred. If the + // pred's terminator already has atom info do nothing as merging w

[llvm-branch-commits] [clang-tools-extra] [clang-tidy] treat unsigned char and signed char as char type by default in bugprone-unintended-char-ostream-output (PR #134870)

2025-04-09 Thread Donát Nagy via llvm-branch-commits
@@ -42,6 +42,14 @@ Or cast to char to explicitly indicate that output should be a character. Options --- +.. option:: AllowedTypes + + A semicolon-separated list of type names that will be treated as ``char`` + type. It only contains the non canonical type names without

[llvm-branch-commits] [clang-tools-extra] [clang-tidy] treat unsigned char and signed char as char type by default in bugprone-unintended-char-ostream-output (PR #134870)

2025-04-09 Thread Donát Nagy via llvm-branch-commits
https://github.com/NagyDonat approved this pull request. Overall looks good to me, I have one suggestion about the documentation. https://github.com/llvm/llvm-project/pull/134870 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org h

[llvm-branch-commits] [clang-tools-extra] [clang-tidy] treat unsigned char and signed char as char type by default in bugprone-unintended-char-ostream-output (PR #134870)

2025-04-09 Thread Donát Nagy via llvm-branch-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/134870 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [KeyInstr][SimplifyCFG] Remap atoms when folding br to common succ into pred (PR #133482)

2025-04-09 Thread Stephen Tozer via llvm-branch-commits
@@ -1182,6 +1187,19 @@ static void cloneInstructionsIntoPredecessorBlockAndUpdateSSAUses( U.set(NewBonusInst); } } + + // Key Instructions: We may have propagated atom info into the pred. If the + // pred's terminator already has atom info do nothing as merging w

[llvm-branch-commits] [llvm] [KeyInstr][SimplifyCFG] Remap atoms when folding br to common succ into pred (PR #133482)

2025-04-09 Thread Stephen Tozer via llvm-branch-commits
https://github.com/SLTozer edited https://github.com/llvm/llvm-project/pull/133482 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [KeyInstr][SimplifyCFG] Remap atoms when folding br to common succ into pred (PR #133482)

2025-04-09 Thread Stephen Tozer via llvm-branch-commits
https://github.com/SLTozer approved this pull request. Some minor nits, but this update looks correct. https://github.com/llvm/llvm-project/pull/133482 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[llvm-branch-commits] [llvm] [KeyInstr][debugify] Add --debugify-atoms to add key instructions metadata (PR #133483)

2025-04-09 Thread Stephen Tozer via llvm-branch-commits
https://github.com/SLTozer approved this pull request. https://github.com/llvm/llvm-project/pull/133483 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] SCEVExpander: Don't look at uses of constants (PR #134691)

2025-04-09 Thread Matt Arsenault via llvm-branch-commits
arsenm wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/134691?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [polly] [Polly] Introduce PhaseManager and remove LPM support (PR #125442)

2025-04-09 Thread Karthika Devi C via llvm-branch-commits
https://github.com/kartcq edited https://github.com/llvm/llvm-project/pull/125442 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] libcxx: In gdb test detect execute_mi with feature check instead of version check. (PR #132291)

2025-04-09 Thread Peter Collingbourne via llvm-branch-commits
pcc wrote: Odd, if I go to https://github.com/llvm/llvm-project/pull/132291/files in an incognito tab it just looks like this to me and that's what would be applied. On Wed, Apr 9, 2025, 00:03 Nikolas Klauser ***@***.***> wrote: > Could you not use spr in that case? I can't see the diff as it w

[llvm-branch-commits] [libcxx] libcxx: In gdb test detect execute_mi with feature check instead of version check. (PR #132291)

2025-04-09 Thread Nikolas Klauser via llvm-branch-commits
philnik777 wrote: Could you not use spr in that case? I can't see the diff as it would be merged AFAICT. https://github.com/llvm/llvm-project/pull/132291 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cg