arsenm wrote:
> Is it legal and defined behavior to target private memory with an atomic?
In the IR it would have to be, and this is the expected behavior in OpenMP and
C++. It's UB in OpenCL, and UB in CUDA/HIP for old style atomics, but defined
for new std::atomic style cases
https://gith
https://github.com/dtcxzyw approved this pull request.
https://github.com/llvm/llvm-project/pull/109502
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
github-actions[bot] wrote:
⚠️ We detected that you are using a GitHub private e-mail address to contribute
to the repo. Please turn off [Keep my email addresses
private](https://github.com/settings/emails) setting in your account. See
[LLVM
Discourse](https://discourse.llvm.org/t/hidden-email
https://github.com/goldsteinn milestoned
https://github.com/llvm/llvm-project/pull/109502
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@llvm/pr-subscribers-llvm-transforms
Author: None (goldsteinn)
Changes
- **[Inliner] Add tests for incorrect propagation of return attrs; NFC**
- **[Inliner] Fix bug where attributes are propagated incorrectly**
The bug stems from the fact that we assume the new (inlined) c
https://github.com/goldsteinn edited
https://github.com/llvm/llvm-project/pull/109502
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/goldsteinn created
https://github.com/llvm/llvm-project/pull/109502
- **[Inliner] Add tests for incorrect propagation of return attrs; NFC**
- **[Inliner] Fix bug where attributes are propagated incorrectly**
The bug stems from the fact that we assume the new (inlined) callsi
https://github.com/willghatch edited
https://github.com/llvm/llvm-project/pull/109495
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff c8fbd5830e63d9f6defed936c769ba27ea8cf261
4d3a3f660e3fbe9b843e85fef6a686c67a9cb11f --e
llvmbot wrote:
@llvm/pr-subscribers-debuginfo
Author: William G Hatch (willghatch)
Changes
This patch adds support for encoding PTX registers for DWARF, using the
encoding supported by nvcc and cuda-gcc.
There are some other features still needed for proper register debugging that
this
https://github.com/fmayer updated
https://github.com/llvm/llvm-project/pull/109489
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/fmayer updated
https://github.com/llvm/llvm-project/pull/109489
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/fmayer converted_to_draft
https://github.com/llvm/llvm-project/pull/109489
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@llvm/pr-subscribers-llvm-transforms
Author: Florian Mayer (fmayer)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/109489.diff
1 Files Affected:
- (modified) llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp (+9-4)
``diff
diff --git
https://github.com/fmayer created
https://github.com/llvm/llvm-project/pull/109489
None
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
github-actions[bot] wrote:
⚠️ We detected that you are using a GitHub private e-mail address to contribute
to the repo. Please turn off [Keep my email addresses
private](https://github.com/settings/emails) setting in your account. See
[LLVM
Discourse](https://discourse.llvm.org/t/hidden-email
llvmbot wrote:
@llvm/pr-subscribers-llvm-analysis
Author: None (llvmbot)
Changes
Backport 76bc1eddb2cf8b6cc073649ade21b59bbed438a2
Requested by: @nikic
---
Full diff: https://github.com/llvm/llvm-project/pull/109476.diff
2 Files Affected:
- (modified) llvm/include/llvm/Analysis/AliasA
llvmbot wrote:
@nikic What do you think about merging this PR to the release branch?
https://github.com/llvm/llvm-project/pull/109476
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
https://github.com/llvmbot created
https://github.com/llvm/llvm-project/pull/109476
Backport 76bc1eddb2cf8b6cc073649ade21b59bbed438a2
Requested by: @nikic
>From d28a483434e3404d2136558a95ec201c3b327925 Mon Sep 17 00:00:00 2001
From: Jonathan Tanner <10051116+adifferen...@users.noreply.github.c
https://github.com/llvmbot milestoned
https://github.com/llvm/llvm-project/pull/109476
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/rampitec approved this pull request.
https://github.com/llvm/llvm-project/pull/109408
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
rampitec wrote:
Is it legal and defined behavior to target private memory with an atomic?
https://github.com/llvm/llvm-project/pull/109407
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
@@ -0,0 +1,6911 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=amdgcn -mcpu=bonaire < %s | FileCheck -check-prefix=GCN1 %s
arsenm wrote:
Copied from the other test
https://github.com/llvm/llvm-project/pull/
@@ -0,0 +1,6911 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=amdgcn -mcpu=bonaire < %s | FileCheck -check-prefix=GCN1 %s
rampitec wrote:
Why GCN1 and GCN2? GFX7 and GFX8 are easier to understand.
https://
https://github.com/aaupov edited
https://github.com/llvm/llvm-project/pull/109351
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/aaupov edited
https://github.com/llvm/llvm-project/pull/109351
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/aaupov updated
https://github.com/llvm/llvm-project/pull/109351
>From 9d29e36c4aaafebec930455c1c0a7ac4aa505aea Mon Sep 17 00:00:00 2001
From: Amir Ayupov
Date: Fri, 20 Sep 2024 08:04:49 -0700
Subject: [PATCH] Preserve clang++.prebolt, drop ICF, use cdsort and cdsplit
Created
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Amir Ayupov (aaupov)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/109351.diff
1 Files Affected:
- (modified) clang/CMakeLists.txt (+5-2)
``diff
diff --git a/clang/CMakeLists.txt b/clang/CMakeLists.txt
ind
https://github.com/aaupov ready_for_review
https://github.com/llvm/llvm-project/pull/109351
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/109291
>From 9558a97c93be4fb957a82476f5fc1861aff1ed5d Mon Sep 17 00:00:00 2001
From: Jakub Mazurkiewicz
Date: Wed, 10 Apr 2024 23:12:22 +0200
Subject: [PATCH 1/2] [libc++] Follow-up to "Poison Pills are Too Toxic"
* U
https://github.com/vhscampos updated
https://github.com/llvm/llvm-project/pull/108601
>From d05069198321f3bab9de7db65f48f3c2b15b34bc Mon Sep 17 00:00:00 2001
From: Victor Campos
Date: Fri, 9 Aug 2024 14:00:32 +0100
Subject: [PATCH 1/2] [ADT] Add more useful methods to SmallSet API
This patch a
vhscampos wrote:
New PR: https://github.com/llvm/llvm-project/pull/109412
https://github.com/llvm/llvm-project/pull/108585
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bran
https://github.com/vhscampos updated
https://github.com/llvm/llvm-project/pull/108590
>From a2438ce9a61d8e80aa32fa58ca5368a64deacd52 Mon Sep 17 00:00:00 2001
From: Victor Campos
Date: Fri, 9 Aug 2024 13:56:31 +0100
Subject: [PATCH 1/4] [ADT] Use range-based helper functions in SmallSet
Replace
https://github.com/vhscampos edited
https://github.com/llvm/llvm-project/pull/108590
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@llvm/pr-subscribers-llvm-adt
Author: Victor Campos (vhscampos)
Changes
- Remove dependence on `STLExtras.h`.
- Remove unused header inclusions.
- Make `count` use `contains` for deduplication.
- Replace hand-written linear scans on Vector by `std::find`.
---
Full diff: htt
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Victor Campos (vhscampos)
Changes
- Remove dependence on `STLExtras.h`.
- Remove unused header inclusions.
- Make `count` use `contains` for deduplication.
- Replace hand-written linear scans on Vector by `std::find`.
---
Full diff: https:
https://github.com/vhscampos created
https://github.com/llvm/llvm-project/pull/109412
- Remove dependence on `STLExtras.h`.
- Remove unused header inclusions.
- Make `count` use `contains` for deduplication.
- Replace hand-written linear scans on Vector by `std::find`.
>From 3d83c5456c35f891aef
https://github.com/arsenm updated
https://github.com/llvm/llvm-project/pull/102462
>From a9840f72f158d93e538fb47a5f6d2c63e18aa813 Mon Sep 17 00:00:00 2001
From: Matt Arsenault
Date: Thu, 8 Aug 2024 15:48:52 +0400
Subject: [PATCH] clang/AMDGPU: Set noalias.addrspace metadata on atomicrmw
---
c
https://github.com/arsenm ready_for_review
https://github.com/llvm/llvm-project/pull/109410
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/arsenm updated
https://github.com/llvm/llvm-project/pull/103939
>From a9627b23a368349efaaad158a5e2189894cd63cc Mon Sep 17 00:00:00 2001
From: Matt Arsenault
Date: Wed, 14 Aug 2024 16:51:08 +0400
Subject: [PATCH] Local: Handle noalias.addrspace in copyMetadataForLoad
---
llv
https://github.com/arsenm updated
https://github.com/llvm/llvm-project/pull/103938
>From 0f1cd91266f2665a75fba619f97b770a42676509 Mon Sep 17 00:00:00 2001
From: Matt Arsenault
Date: Wed, 14 Aug 2024 16:19:30 +0400
Subject: [PATCH] Local: Handle noalias_addrspace in combineMetadata
This should
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
Author: Matt Arsenault (arsenm)
Changes
64-bit flat cmpxchg instructions do not work correctly for scratch
addresses, and need to be expanded as non-atomic.
Allow custom expansion of cmpxchg in AtomicExpand, as is
already the case for ato
llvmbot wrote:
@llvm/pr-subscribers-llvm-transforms
@llvm/pr-subscribers-backend-amdgpu
Author: Matt Arsenault (arsenm)
Changes
When expanding an atomicrmw with a cmpxchg, preserve any metadata
attached to it. This will avoid unwanted double expansions
in a future commit.
The initial load
https://github.com/arsenm ready_for_review
https://github.com/llvm/llvm-project/pull/109409
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/arsenm ready_for_review
https://github.com/llvm/llvm-project/pull/109408
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
Author: Matt Arsenault (arsenm)
Changes
We need a non-atomic path if flat may access private.
---
Patch is 34.44 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/109408.diff
5 Files Affected:
https://github.com/arsenm ready_for_review
https://github.com/llvm/llvm-project/pull/109407
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
Author: Matt Arsenault (arsenm)
Changes
If the runtime flat address resolves to a scratch address,
64-bit atomics do not work correctly. Insert a runtime address
space check (which is quite likely to be uniform) and select between
the non-
https://github.com/arsenm ready_for_review
https://github.com/llvm/llvm-project/pull/109406
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
Author: Matt Arsenault (arsenm)
Changes
---
Patch is 759.08 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/109406.diff
4 Files Affected:
- (modified) llvm/test/CodeGen/AMDGPU/flat-atomic-f
arsenm wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/109410?utm_source=stack-comment-downstack-mergeability-warning";
arsenm wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/109409?utm_source=stack-comment-downstack-mergeability-warning";
https://github.com/arsenm created
https://github.com/llvm/llvm-project/pull/109410
64-bit flat cmpxchg instructions do not work correctly for scratch
addresses, and need to be expanded as non-atomic.
Allow custom expansion of cmpxchg in AtomicExpand, as is
already the case for atomicrmw.
>From
arsenm wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/109407?utm_source=stack-comment-downstack-mergeability-warning";
arsenm wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/109408?utm_source=stack-comment-downstack-mergeability-warning";
https://github.com/arsenm created
https://github.com/llvm/llvm-project/pull/109408
We need a non-atomic path if flat may access private.
>From edf2464809da0ac2fa88283840133cc6b189e168 Mon Sep 17 00:00:00 2001
From: Matt Arsenault
Date: Thu, 12 Sep 2024 12:44:04 +0400
Subject: [PATCH] AMDGPU: A
arsenm wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/109406?utm_source=stack-comment-downstack-mergeability-warning";
https://github.com/arsenm updated
https://github.com/llvm/llvm-project/pull/102599
>From 2c97d43e4054f2a863284fccadc99fb267f5911b Mon Sep 17 00:00:00 2001
From: Matt Arsenault
Date: Fri, 9 Aug 2024 14:51:41 +0400
Subject: [PATCH] AMDGPU: Add noalias.addrspace metadata when autoupgrading
atomic
@@ -12571,17 +12571,59 @@ struct AAAddressSpaceImpl : public AAAddressSpace {
void initialize(Attributor &A) override {
assert(getAssociatedType()->isPtrOrPtrVectorTy() &&
"Associated value is not a pointer");
-if (getAssociatedType()->getPointerAddressSpac
mydeveloperday wrote:
> @mydeveloperday What do you think about merging this PR to the release branch?
I would say go for it.
https://github.com/llvm/llvm-project/pull/109170
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
http
https://github.com/mydeveloperday approved this pull request.
https://github.com/llvm/llvm-project/pull/109170
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ritter-x2a updated
https://github.com/llvm/llvm-project/pull/106965
>From edc0f26d69946271727c9a5e9bc51a7205ce7eac Mon Sep 17 00:00:00 2001
From: Fabian Ritter
Date: Mon, 2 Sep 2024 05:37:33 -0400
Subject: [PATCH] [X86] Avoid generating nested CALLSEQ for TLS pointer
functio
@@ -77,6 +77,7 @@ Implemented Papers
- P2602R2 - Poison Pills are Too Toxic
- P1981R0 - Rename ``leap`` to ``leap_second``
- P1982R0 - Rename ``link`` to ``time_zone_link``
+- P2602R2 - Poison Pills are Too Toxic (as DR against C++20)
frederick-vs-ja wrote:
Th
https://github.com/maksfb approved this pull request.
Thanks!
PS. Let's drop ICF from the flags.
https://github.com/llvm/llvm-project/pull/109351
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
64 matches
Mail list logo