https://github.com/ssahasra edited
https://github.com/llvm/llvm-project/pull/103013
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@llvm/pr-subscribers-llvm-transforms
Author: Sameer Sahasrabuddhe (ssahasra)
Changes
CreateControlFlowHub is a method that redirects control flow edges from a set
of incoming blocks to a set of outgoing blocks through a new set of "guard"
blocks. This is now refactored int
https://github.com/ssahasra created
https://github.com/llvm/llvm-project/pull/103013
CreateControlFlowHub is a method that redirects control flow edges from a set
of incoming blocks to a set of outgoing blocks through a new set of "guard"
blocks. This is now refactored into a separate file wit
llvmbot wrote:
@llvm/pr-subscribers-libcxx
Author: None (llvmbot)
Changes
Backport 7951673d408ee64744d0b924a49db78e8243d876
Requested by: @androm3da
---
Full diff: https://github.com/llvm/llvm-project/pull/103003.diff
3 Files Affected:
- (modified) libcxx/include/__memory/inout_ptr.h
llvmbot wrote:
@mordante What do you think about merging this PR to the release branch?
https://github.com/llvm/llvm-project/pull/103003
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
https://github.com/llvmbot milestoned
https://github.com/llvm/llvm-project/pull/103003
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/llvmbot created
https://github.com/llvm/llvm-project/pull/103003
Backport 7951673d408ee64744d0b924a49db78e8243d876
Requested by: @androm3da
>From 2a1c18b4d278bf981162b7c592ae4384fdfbdfb3 Mon Sep 17 00:00:00 2001
From: Brian Cain
Date: Mon, 12 Aug 2024 20:07:08 -0500
Subject
kaiyan96 wrote:
@tru
https://github.com/llvm/llvm-project/pull/102881
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/kaiyan96 edited
https://github.com/llvm/llvm-project/pull/102881
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/aaupov updated
https://github.com/llvm/llvm-project/pull/101094
>From f598510001859a29f6f1ff6362fb9950ab6340cd Mon Sep 17 00:00:00 2001
From: Amir Ayupov
Date: Mon, 29 Jul 2024 16:14:08 -0700
Subject: [PATCH 1/4] Update test to check the option with llvm-bolt with
fdata, YAM
https://github.com/aaupov updated
https://github.com/llvm/llvm-project/pull/102905
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/aaupov updated
https://github.com/llvm/llvm-project/pull/102905
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/aaupov updated
https://github.com/llvm/llvm-project/pull/102904
>From 3ffb03f8e4bcb2fa235ae989320c466af4a3cda8 Mon Sep 17 00:00:00 2001
From: Amir Ayupov
Date: Mon, 12 Aug 2024 14:40:57 -0700
Subject: [PATCH] stable_sort
Created using spr 1.3.4
---
llvm/lib/MC/MCPseudoProbe
ldionne wrote:
The CI failures are not related to this patch and are being fixed separately.
This looks good to me for merging.
https://github.com/llvm/llvm-project/pull/102052
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
ht
https://github.com/MaskRay updated
https://github.com/llvm/llvm-project/pull/102764
>From 6ec669e2206a29bce0c28213e82c2694f03bfad9 Mon Sep 17 00:00:00 2001
From: Fangrui Song
Date: Sun, 11 Aug 2024 13:27:34 -0700
Subject: [PATCH] remove GetCurrentThread check for NsanAllocate
Created using spr
https://github.com/MaskRay updated
https://github.com/llvm/llvm-project/pull/102764
>From 6ec669e2206a29bce0c28213e82c2694f03bfad9 Mon Sep 17 00:00:00 2001
From: Fangrui Song
Date: Sun, 11 Aug 2024 13:27:34 -0700
Subject: [PATCH] remove GetCurrentThread check for NsanAllocate
Created using spr
https://github.com/alexander-shaposhnikov approved this pull request.
https://github.com/llvm/llvm-project/pull/102764
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-c
@@ -106,3 +135,12 @@ Error
AMDGPUCodeGenPassBuilder::addInstSelector(AddMachinePass &addPass) const {
addPass(SILowerI1CopiesPass());
return Error::success();
}
+
+bool AMDGPUCodeGenPassBuilder::isPassEnabled(const cl::opt &Opt,
aeubanks wrote:
I'd prefer
@@ -106,3 +135,12 @@ Error
AMDGPUCodeGenPassBuilder::addInstSelector(AddMachinePass &addPass) const {
addPass(SILowerI1CopiesPass());
return Error::success();
}
+
+bool AMDGPUCodeGenPassBuilder::isPassEnabled(const cl::opt &Opt,
arsenm wrote:
I guess most
github-actions[bot] wrote:
⚠️ We detected that you are using a GitHub private e-mail address to contribute
to the repo. Please turn off [Keep my email addresses
private](https://github.com/settings/emails) setting in your account. See
[LLVM
Discourse](https://discourse.llvm.org/t/hidden-email
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: None (llvmbot)
Changes
Backport 123b6fc
Requested by: @qiongsiwu
---
Full diff: https://github.com/llvm/llvm-project/pull/102968.diff
7 Files Affected:
- (modified) clang/include/clang/Basic/DiagnosticParseKinds.td (-3)
- (modi
llvmbot wrote:
@llvm/pr-subscribers-backend-powerpc
@llvm/pr-subscribers-clang
Author: None (llvmbot)
Changes
Backport 123b6fc
Requested by: @qiongsiwu
---
Full diff: https://github.com/llvm/llvm-project/pull/102968.diff
7 Files Affected:
- (modified) clang/include/clang/Basic/Diagnos
llvmbot wrote:
@AaronBallman What do you think about merging this PR to the release branch?
https://github.com/llvm/llvm-project/pull/102968
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
https://github.com/llvmbot milestoned
https://github.com/llvm/llvm-project/pull/102968
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/llvmbot created
https://github.com/llvm/llvm-project/pull/102968
Backport 123b6fc
Requested by: @qiongsiwu
>From 5a047c493f47cbb38eb2e2fa24d55e7d9383dbb2 Mon Sep 17 00:00:00 2001
From: Qiongsi Wu <274595+qiongs...@users.noreply.github.com>
Date: Mon, 12 Aug 2024 16:00:25 -04
@@ -106,3 +135,12 @@ Error
AMDGPUCodeGenPassBuilder::addInstSelector(AddMachinePass &addPass) const {
addPass(SILowerI1CopiesPass());
return Error::success();
}
+
+bool AMDGPUCodeGenPassBuilder::isPassEnabled(const cl::opt &Opt,
aeubanks wrote:
is this pa
https://github.com/rampitec approved this pull request.
https://github.com/llvm/llvm-project/pull/102884
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/tobias-stadler updated
https://github.com/llvm/llvm-project/pull/102163
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/tobias-stadler updated
https://github.com/llvm/llvm-project/pull/102163
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/rampitec approved this pull request.
https://github.com/llvm/llvm-project/pull/102867
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
rampitec wrote:
> I don't really like needing to expose these globally like this; maybe it
> would be better to just move TargetPassConfig and the CodeGenPassBuilder into
> one common file?
Yep, I also do not like extern cl::opt.
https://github.com/llvm/llvm-project/pull/102865
__
https://github.com/rampitec approved this pull request.
https://github.com/llvm/llvm-project/pull/102816
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/rampitec approved this pull request.
https://github.com/llvm/llvm-project/pull/102815
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/HazardyKnusperkeks approved this pull request.
https://github.com/llvm/llvm-project/pull/102770
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commi
Author: Florian Mayer
Date: 2024-08-12T11:39:31-07:00
New Revision: cbee41197dc222648dea7a40ec982b69139d29c6
URL:
https://github.com/llvm/llvm-project/commit/cbee41197dc222648dea7a40ec982b69139d29c6
DIFF:
https://github.com/llvm/llvm-project/commit/cbee41197dc222648dea7a40ec982b69139d29c6.diff
mordante wrote:
> @ldionne this has some suspect CI failures, can you double check and approve
> if this is ready to go?
I just restarted the bootstrap build.
AIX's `std/re/re.traits/transform.pass.cpp` seems now to magically pass. I
recently fixed this by removing XFAIL in main.
https://gith
https://github.com/asl approved this pull request.
This is the second change similar to
https://github.com/llvm/llvm-project/pull/102670
It is a small frontend change require to close the chain of changes required
for end-to-end support of pointer authentication in LLVM 19.
The change does no
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: None (llvmbot)
Changes
Backport d179acd0484bac30c5ebbbed4d29a4734d92ac93
Requested by: @asl
---
Full diff: https://github.com/llvm/llvm-project/pull/102938.diff
4 Files Affected:
- (modified) clang/include/clang/Basic/PointerAu
https://github.com/llvmbot created
https://github.com/llvm/llvm-project/pull/102938
Backport d179acd0484bac30c5ebbbed4d29a4734d92ac93
Requested by: @asl
>From 147ee4adc3e5ff491bf61126478dfce0914c30ce Mon Sep 17 00:00:00 2001
From: Ahmed Bougacha
Date: Fri, 9 Aug 2024 12:32:01 -0700
Subject: [
llvmbot wrote:
@kovdan01 What do you think about merging this PR to the release branch?
https://github.com/llvm/llvm-project/pull/102938
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
https://github.com/llvmbot milestoned
https://github.com/llvm/llvm-project/pull/102938
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/coopp approved this pull request.
Looks good.
https://github.com/llvm/llvm-project/pull/100700
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commit
Author: Teresa Johnson
Date: 2024-08-12T09:40:56-07:00
New Revision: a79d1b9501ad436f025e10b390e8858780163ab1
URL:
https://github.com/llvm/llvm-project/commit/a79d1b9501ad436f025e10b390e8858780163ab1
DIFF:
https://github.com/llvm/llvm-project/commit/a79d1b9501ad436f025e10b390e8858780163ab1.diff
Author: Valentin Clement (バレンタイン クレメン)
Date: 2024-08-12T09:35:08-07:00
New Revision: 94a1b9e30a4f7c96474a3e201dcc0f653046d493
URL:
https://github.com/llvm/llvm-project/commit/94a1b9e30a4f7c96474a3e201dcc0f653046d493
DIFF:
https://github.com/llvm/llvm-project/commit/94a1b9e30a4f7c96474a3e201dcc0
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (llvmbot)
Changes
Backport d469794d0cdfd2fea50a6ce0c0e33abb242d744c
Requested by: @llvmbot
---
Full diff: https://github.com/llvm/llvm-project/pull/102924.diff
2 Files Affected:
- (modified) clang/lib/Sema/SemaDeclCXX.cpp (+28-1)
https://github.com/llvmbot updated
https://github.com/llvm/llvm-project/pull/102924
>From ee828c387981e06204e29effa41032062ddc6cf4 Mon Sep 17 00:00:00 2001
From: Mariya Podchishchaeva
Date: Mon, 12 Aug 2024 09:08:46 +0200
Subject: [PATCH] [clang] Avoid triggering vtable instantiation for C++23
llvmbot wrote:
@cor3ntin What do you think about merging this PR to the release branch?
https://github.com/llvm/llvm-project/pull/102924
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
https://github.com/llvmbot milestoned
https://github.com/llvm/llvm-project/pull/102924
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/llvmbot created
https://github.com/llvm/llvm-project/pull/102924
Backport d469794d0cdfd2fea50a6ce0c0e33abb242d744c
Requested by: @llvmbot
>From d6beb484536981c00754e94c99d666f895b56fcd Mon Sep 17 00:00:00 2001
From: Mariya Podchishchaeva
Date: Mon, 12 Aug 2024 09:08:46 +020
@@ -85,67 +135,227 @@ class OMPMapInfoFinalizationPass
descriptor = alloca;
}
+return descriptor;
+ }
+
+ /// Simple function that will generate a FIR operation accessing
+ /// the descriptors base address (BoxOffsetOp) and then generate a
+ /// MapInfoOp for
@@ -85,67 +138,187 @@ class OMPMapInfoFinalizationPass
descriptor = alloca;
}
+return descriptor;
+ }
+
+ /// Simple function that will generate a FIR operation accessing
+ /// the descriptors base address (BoxOffsetOp) and then generate a
+ /// MapInfoOp for
@@ -85,67 +138,187 @@ class OMPMapInfoFinalizationPass
descriptor = alloca;
}
+return descriptor;
+ }
+
+ /// Simple function that will generate a FIR operation accessing
+ /// the descriptors base address (BoxOffsetOp) and then generate a
+ /// MapInfoOp for
@@ -85,67 +138,187 @@ class OMPMapInfoFinalizationPass
descriptor = alloca;
}
+return descriptor;
+ }
+
+ /// Simple function that will generate a FIR operation accessing
+ /// the descriptors base address (BoxOffsetOp) and then generate a
+ /// MapInfoOp for
@@ -216,31 +215,50 @@ bool
ClauseProcessor::processMotionClauses(lower::StatementContext &stmtCtx,
if (origSymbol && fir::isTypeWithDescriptor(origSymbol.getType()))
symAddr = origSymbol;
+ if (object.sym()->owner().IsDerivedType()) {
+
https://github.com/skatrak commented:
Thanks Andrew for the updates to this patch. I gave it a fresh look and I've
got another set of comments, but they should be easy to address.
https://github.com/llvm/llvm-project/pull/96266
___
llvm-branch-commits
@@ -85,67 +138,187 @@ class OMPMapInfoFinalizationPass
descriptor = alloca;
}
+return descriptor;
+ }
+
+ /// Simple function that will generate a FIR operation accessing
+ /// the descriptors base address (BoxOffsetOp) and then generate a
+ /// MapInfoOp for
@@ -85,67 +138,187 @@ class OMPMapInfoFinalizationPass
descriptor = alloca;
}
+return descriptor;
+ }
+
+ /// Simple function that will generate a FIR operation accessing
+ /// the descriptors base address (BoxOffsetOp) and then generate a
+ /// MapInfoOp for
@@ -237,26 +436,34 @@ class OMPMapInfoFinalizationPass
getOperation()->walk([&](mlir::omp::MapInfoOp op) {
// TODO: Currently only supports a single user for the MapInfoOp, this
- // is fine for the moment as the Fortran Frontend will generate a
- // new Ma
@@ -267,6 +267,24 @@ mlir::Block *fir::FirOpBuilder::getAllocaBlock() {
return getEntryBlock();
}
+static mlir::ArrayAttr makeI64ArrayAttr(llvm::ArrayRef values,
+mlir::MLIRContext *context) {
+ llvm::SmallVector attrs;
+ for (auto &
@@ -280,75 +340,60 @@ void insertChildMapInfoIntoParent(
// precedes the children. An alternative, may be to do
// delayed generation of map info operations from the clauses and
// organize them first before generation.
- mapOp->moveAfter(indices.second.b
@@ -85,67 +138,187 @@ class OMPMapInfoFinalizationPass
descriptor = alloca;
}
+return descriptor;
+ }
+
+ /// Simple function that will generate a FIR operation accessing
+ /// the descriptors base address (BoxOffsetOp) and then generate a
+ /// MapInfoOp for
@@ -267,6 +267,24 @@ mlir::Block *fir::FirOpBuilder::getAllocaBlock() {
return getEntryBlock();
}
+static mlir::ArrayAttr makeI64ArrayAttr(llvm::ArrayRef values,
+mlir::MLIRContext *context) {
+ llvm::SmallVector attrs;
+ for (auto &
@@ -175,99 +271,63 @@ getComponentObject(std::optional object,
return getComponentObject(baseObj.value(), semaCtx);
}
-static void
-generateMemberPlacementIndices(const Object &object,
- llvm::SmallVectorImpl &indices,
-
@@ -267,6 +267,24 @@ mlir::Block *fir::FirOpBuilder::getAllocaBlock() {
return getEntryBlock();
}
+static mlir::ArrayAttr makeI64ArrayAttr(llvm::ArrayRef values,
+mlir::MLIRContext *context) {
+ llvm::SmallVector attrs;
--
@@ -175,99 +271,63 @@ getComponentObject(std::optional object,
return getComponentObject(baseObj.value(), semaCtx);
}
-static void
-generateMemberPlacementIndices(const Object &object,
- llvm::SmallVectorImpl &indices,
-
https://github.com/skatrak edited
https://github.com/llvm/llvm-project/pull/96266
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -344,6 +345,7 @@ inline void createHLFIRToFIRPassPipeline(
pm.addPass(hlfir::createLowerHLFIRIntrinsics());
pm.addPass(hlfir::createBufferizeHLFIR());
pm.addPass(hlfir::createConvertHLFIRtoFIR());
+ pm.addPass(flangomp::createLowerWorkshare());
agozil
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/102341
>From ba8cf358a98cfcce6b1239ac88391bc25bcc7197 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Wed, 7 Aug 2024 18:31:08 +0100
Subject: [PATCH 1/3] [OpenMP][MLIR] Set omp.composite attr for composite loop
wr
llvmbot wrote:
@llvm/pr-subscribers-mc
@llvm/pr-subscribers-bolt
Author: Amir Ayupov (aaupov)
Changes
Replace unordered_map with a vector. Pre-parse the section to statically
allocate storage. Use BumpPtrAllocator for FuncName strings, keep
StringRef in FuncDesc.
Reduces peak RSS of pseud
https://github.com/aaupov created
https://github.com/llvm/llvm-project/pull/102905
Replace unordered_map with a vector. Pre-parse the section to statically
allocate storage. Use BumpPtrAllocator for FuncName strings, keep
StringRef in FuncDesc.
Reduces peak RSS of pseudo probe parsing from 9.08
llvmbot wrote:
@llvm/pr-subscribers-bolt
@llvm/pr-subscribers-pgo
Author: Amir Ayupov (aaupov)
Changes
Replace the map from addresses to list of probes with a flat vector
containing probe references sorted by their addresses.
Reduces pseudo probe parsing time from 9.56s to 8.59s and peak
https://github.com/aaupov created
https://github.com/llvm/llvm-project/pull/102904
Replace the map from addresses to list of probes with a flat vector
containing probe references sorted by their addresses.
Reduces pseudo probe parsing time from 9.56s to 8.59s and peak RSS from
9.66 GiB to 9.08
https://github.com/aaupov updated
https://github.com/llvm/llvm-project/pull/102789
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/aaupov updated
https://github.com/llvm/llvm-project/pull/102789
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/aaupov edited
https://github.com/llvm/llvm-project/pull/102789
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
arsenm wrote:
> +1 for this if backend developers want to test something, although I'm still
> trying to improve the pass builder in #89708 after investigating asm printer
> and register allocator.
I'm currently blocked by assorted -enable-new-pm tests failing in future
patches because of mis
https://github.com/Michael137 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/102895
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (llvmbot)
Changes
Backport 57cd100
Requested by: @labath
---
Full diff: https://github.com/llvm/llvm-project/pull/102895.diff
2 Files Affected:
- (modified) lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
(+9-2)
- (a
llvmbot wrote:
@Michael137 What do you think about merging this PR to the release branch?
https://github.com/llvm/llvm-project/pull/102895
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
https://github.com/llvmbot milestoned
https://github.com/llvm/llvm-project/pull/102895
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/llvmbot created
https://github.com/llvm/llvm-project/pull/102895
Backport 57cd100
Requested by: @labath
>From 5cb7662e5e808dd733e623294c4376f57611723b Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Thu, 8 Aug 2024 10:53:15 +0200
Subject: [PATCH] [lldb] Fix crash when add
paperchalice wrote:
+1 for this if backend developers want to test something, although I'm still
trying to improve the pass builder in #89708 after investigating asm printer
and register allocator.
https://github.com/llvm/llvm-project/pull/102884
___
@@ -2261,47 +2261,47 @@ static int getMapDataMemberIdx(MapInfoData &mapData,
static mlir::omp::MapInfoOp
getFirstOrLastMappedMemberPtr(mlir::omp::MapInfoOp mapInfo, bool first) {
- mlir::DenseIntElementsAttr indexAttr = mapInfo.getMembersIndexAttr();
-
+ mlir::ArrayAttr inde
@@ -2541,6 +2541,31 @@ static void processMapMembersWithParent(
assert(memberDataIdx >= 0 && "could not find mapped member of structure");
+// If we're currently mapping a pointer to a block of data, we must
+// initially map the pointer, and then attatch/bind the
@@ -1087,50 +1086,31 @@ static ParseResult parseMembersIndex(OpAsmParser
&parser,
if (failed(parser.parseRSquare()))
return failure();
-// Only set once, if any indices are not the same size
-// we error out in the next check as that's unsupported
-if (s
https://github.com/skatrak approved this pull request.
Thank you Andrew for working on my previous comments. I have a couple of
suggestions to hopefully help simplify things a bit further, but it LGTM. No
need to wait for another look by me before merging.
https://github.com/llvm/llvm-project/
@@ -1064,16 +1064,15 @@ static void printMapClause(OpAsmPrinter &p, Operation
*op,
}
static ParseResult parseMembersIndex(OpAsmParser &parser,
- DenseIntElementsAttr &membersIdx) {
- SmallVector values;
+
https://github.com/skatrak edited
https://github.com/llvm/llvm-project/pull/96265
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -2541,6 +2541,31 @@ static void processMapMembersWithParent(
assert(memberDataIdx >= 0 && "could not find mapped member of structure");
+// If we're currently mapping a pointer to a block of data, we must
+// initially map the pointer, and then attatch/bind the
@@ -2383,3 +2383,165 @@ func.func @masked_arg_count_mismatch(%arg0: i32, %arg1:
i32) {
}) : (i32, i32) -> ()
return
}
+
+// -
+func.func @omp_parallel_missing_composite(%lb: index, %ub: index, %step:
index) -> () {
+ omp.distribute {
+ // expected-error@+1 {{'omp.
@@ -1748,11 +1754,27 @@ LogicalResult WsloopOp::verify() {
if (!isWrapper())
return emitOpError() << "must be a loop wrapper";
+ auto wrapper =
+ llvm::dyn_cast_if_present((*this)->getParentOp());
+ bool isCompositeWrapper = wrapper && wrapper.isWrapper() &&
+
@@ -1748,11 +1754,27 @@ LogicalResult WsloopOp::verify() {
if (!isWrapper())
return emitOpError() << "must be a loop wrapper";
+ auto wrapper =
+ llvm::dyn_cast_if_present((*this)->getParentOp());
+ bool isCompositeWrapper = wrapper && wrapper.isWrapper() &&
-
@@ -210,7 +210,7 @@ func.func @invalid_nested_wrapper(%lb : index, %ub : index,
%step : index) {
omp.terminator
}
skatrak wrote:
Nit: Add attribute to `omp.distribute` too.
https://github.com/llvm/llvm-project/pull/102341
___
@@ -36,9 +36,9 @@ func.func @invalid_nested_wrapper(%lb : index, %ub : index,
%step : index) {
omp.terminator
}
skatrak wrote:
Nit: I suppose it doesn't matter because the parent op's verifier fails before
checking this one, but I think it makes
@@ -2173,7 +2173,7 @@ func.func @omp_distribute_nested_wrapper(%lb: index, %ub:
index, %step: index) -
"omp.terminator"() : () -> ()
}) : () -> ()
skatrak wrote:
Nit: Add attribute to `omp.wsloop` too.
https://github.com/llvm/llvm-project/pull/10234
@@ -1965,7 +1965,7 @@ func.func @taskloop(%lb: i32, %ub: i32, %step: i32) {
omp.terminator
}
skatrak wrote:
Nit: Add attribute to `omp.distribute` too.
https://github.com/llvm/llvm-project/pull/102341
___
l
https://github.com/skatrak approved this pull request.
Thank you again Akash, this LGTM. I have a couple of minor nits left, but
there's no need for another review by me after addressing them. Can you add to
ops.mlir an instance of `distribute parallel do/for simd` after line 117?
https://gith
https://github.com/skatrak edited
https://github.com/llvm/llvm-project/pull/102341
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@llvm/pr-subscribers-llvm-transforms
Author: Matt Arsenault (arsenm)
Changes
This is not complete, but gets AtomicExpand running. I was able
to get further than I expected; we're quite close to having all
the IR codegen passes ported.
---
Full diff: https://github.com/llvm/
arsenm wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/102884?utm_source=stack-comment-downstack-mergeability-warning";
1 - 100 of 140 matches
Mail list logo
