https://github.com/mydeveloperday approved this pull request.
https://github.com/llvm/llvm-project/pull/89492
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/89415
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/89412
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@llvm/pr-subscribers-debuginfo
Author: Andres Villegas (avillega)
Changes
Work around for https://github.com/llvm/llvm-project/issues/46494.
Before this change end_sequence rows in debug_line were not included
in `DWARFDebugLine::LineTable::lookupAddressRangeImpl`, this was
https://github.com/avillega created
https://github.com/llvm/llvm-project/pull/89703
Work around for https://github.com/llvm/llvm-project/issues/46494.
Before this change end_sequence rows in debug_line were not included
in `DWARFDebugLine::LineTable::lookupAddressRangeImpl`, this was problematic
fhahn wrote:
Added compiler-rt tests for various strict-aliasing violations from the bug
tracker I found.
https://github.com/llvm/llvm-project/pull/76261
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cg
https://github.com/Mogball edited
https://github.com/llvm/llvm-project/pull/89628
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/Mogball edited
https://github.com/llvm/llvm-project/pull/89664
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
Mogball wrote:
> Before I forget: we should add documentation for this, including the how to
> structure the dialect to support it.
Added in https://github.com/llvm/llvm-project/pull/89664
https://github.com/llvm/llvm-project/pull/89423
___
llvm-bran
llvmbot wrote:
@llvm/pr-subscribers-mlir
Author: Jeff Niu (Mogball)
Changes
Stacked PRs:
* __->__#89664
* #89628
* #89423
* #89424
--- --- ---
### [mlir][ods] Add documentation on how to use sharded op definitions (NFC)
This adds explanations and instructions on how to set up a di
https://github.com/Mogball edited
https://github.com/llvm/llvm-project/pull/89423
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/Mogball edited
https://github.com/llvm/llvm-project/pull/89628
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/Mogball updated
https://github.com/llvm/llvm-project/pull/89664
>From f8c449c81fb62dc063eaf9be3dc0cc81407afd1d Mon Sep 17 00:00:00 2001
From: Mogball
Date: Mon, 22 Apr 2024 20:40:10 +
Subject: [PATCH] [mlir][ods] Add documentation on how to use sharded op
definitions (NF
https://github.com/Mogball created
https://github.com/llvm/llvm-project/pull/89664
[mlir][ods] Add documentation on how to use sharded op definitions (NFC)
This adds explanations and instructions on how to set up a dialect for
sharded op definitions to the MLIR documentation.
>From 8991d4f3521
Mogball wrote:
> LG, but please make sure to remove all spurious headers from the commit
> description (seems like it should start at "This PR massively ...")
Yep. The tool removes it before landing the commit
https://github.com/llvm/llvm-project/pull/89424
https://github.com/philnik777 closed
https://github.com/llvm/llvm-project/pull/89181
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/joker-eph approved this pull request.
https://github.com/llvm/llvm-project/pull/89424
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
joker-eph wrote:
LG, but please make sure to remove all spurious headers from the commit
description (seems like it should start at "This PR massively ...")
https://github.com/llvm/llvm-project/pull/89424
___
llvm-branch-commits mailing list
llvm-bran
https://github.com/Prabhuk updated
https://github.com/llvm/llvm-project/pull/87573
>From a8a5848885e12c771f12cfa33b4dbc6a0272e925 Mon Sep 17 00:00:00 2001
From: Prabhuk
Date: Mon, 22 Apr 2024 11:34:04 -0700
Subject: [PATCH 1/2] Update clang/lib/CodeGen/CodeGenModule.cpp
Cleaner if checks.
Co-
https://github.com/Prabhuk updated
https://github.com/llvm/llvm-project/pull/87573
>From a8a5848885e12c771f12cfa33b4dbc6a0272e925 Mon Sep 17 00:00:00 2001
From: Prabhuk
Date: Mon, 22 Apr 2024 11:34:04 -0700
Subject: [PATCH] Update clang/lib/CodeGen/CodeGenModule.cpp
Cleaner if checks.
Co-auth
https://github.com/Prabhuk updated
https://github.com/llvm/llvm-project/pull/87576
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/Prabhuk updated
https://github.com/llvm/llvm-project/pull/87576
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/Mogball updated
https://github.com/llvm/llvm-project/pull/89628
>From 478b4e8e9523ab80e65f115274b2f2ae4423faf4 Mon Sep 17 00:00:00 2001
From: Mogball
Date: Mon, 22 Apr 2024 16:39:58 +
Subject: [PATCH] [mlir][test] Shard the Test Dialect (NFC)
This PR uses the new op shar
https://github.com/Mogball updated
https://github.com/llvm/llvm-project/pull/89628
>From 478b4e8e9523ab80e65f115274b2f2ae4423faf4 Mon Sep 17 00:00:00 2001
From: Mogball
Date: Mon, 22 Apr 2024 16:39:58 +
Subject: [PATCH] [mlir][test] Shard the Test Dialect (NFC)
This PR uses the new op shar
llvmbot wrote:
@llvm/pr-subscribers-mlir
Author: Jeff Niu (Mogball)
Changes
Stacked PRs:
* __->__#89628
* #89424
* #89423
--- --- ---
### [mlir][test] Shard the Test Dialect (NFC)
This PR uses the new op sharding mechanism in tablegen to shard the test
dialect's op definitions. Thi
https://github.com/Mogball updated
https://github.com/llvm/llvm-project/pull/89628
>From 478b4e8e9523ab80e65f115274b2f2ae4423faf4 Mon Sep 17 00:00:00 2001
From: Mogball
Date: Mon, 22 Apr 2024 16:39:58 +
Subject: [PATCH] [mlir][test] Shard the Test Dialect (NFC)
This PR uses the new op shar
https://github.com/Mogball edited
https://github.com/llvm/llvm-project/pull/89424
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/Mogball edited
https://github.com/llvm/llvm-project/pull/89424
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/Mogball created
https://github.com/llvm/llvm-project/pull/89628
[mlir][test] Shard the Test Dialect (NFC)
This PR uses the new op sharding mechanism in tablegen to shard the test
dialect's op definitions. This breaks the definition of ops into
multiple source files, speeding
Author: Mircea Trofin
Date: 2024-04-22T09:33:53-07:00
New Revision: c10f8e22ad731488726ecfecb58073127063ca26
URL:
https://github.com/llvm/llvm-project/commit/c10f8e22ad731488726ecfecb58073127063ca26
DIFF:
https://github.com/llvm/llvm-project/commit/c10f8e22ad731488726ecfecb58073127063ca26.diff
ilovepi wrote:
@MatzeB Thanks for all the good suggestions. I'm just getting back form
EuroLLVM + a vacation, but I'll try to set aside some time this afternoon to
update the PR.
https://github.com/llvm/llvm-project/pull/86609
___
llvm-branch-commits
@@ -5196,7 +5198,11 @@ void SwitchInstProfUpdateWrapper::init() {
if (!ProfileData)
return;
- if (ProfileData->getNumOperands() != SI.getNumSuccessors() + 1) {
+ // FIXME: This check belongs in ProfDataUtils. Its almost equivalent to
+ // getValidBranchWeightMDNode(),
@@ -228,6 +332,7 @@ void TestDialect::initialize() {
>();
registerOpsSyntax();
addOperations();
+ registerTestDialectOperations(this);
Mogball wrote:
As you noted, this isn't needed. I think this got lost in the merge resolution.
I'll delete it.
h
@@ -1210,12 +1210,22 @@ Instruction *Instruction::cloneImpl() const {
void Instruction::swapProfMetadata() {
MDNode *ProfileData = getBranchWeightMDNode(*this);
- if (!ProfileData || ProfileData->getNumOperands() != 3)
+ if (!isBranchWeightMD(ProfileData))
return;
-
@@ -55,6 +55,20 @@ MDNode *getBranchWeightMDNode(const Instruction &I);
/// Nullptr otherwise.
MDNode *getValidBranchWeightMDNode(const Instruction &I);
+/// Check if Branch Weight Metadata has an "expected" field from an
llvm.expect*
+/// intrinsic
+bool hasExpectedProvenanc
@@ -55,6 +55,20 @@ MDNode *getBranchWeightMDNode(const Instruction &I);
/// Nullptr otherwise.
MDNode *getValidBranchWeightMDNode(const Instruction &I);
+/// Check if Branch Weight Metadata has an "expected" field from an
llvm.expect*
+/// intrinsic
+bool hasExpectedProvenanc
https://github.com/kparzysz edited
https://github.com/llvm/llvm-project/pull/89104
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
kparzysz wrote:
Push review updates for another PR here by mistake...
https://github.com/llvm/llvm-project/pull/89104
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-co
https://github.com/kparzysz updated
https://github.com/llvm/llvm-project/pull/89104
>From 4593582b2a480dfffd2dceb4611cc0dec9cd7de5 Mon Sep 17 00:00:00 2001
From: Krzysztof Parzyszek
Date: Thu, 11 Apr 2024 10:33:44 -0500
Subject: [PATCH 1/3] [LLVM][OpenMP] Implement getLeafOrCompositeConstructs
https://github.com/kparzysz updated
https://github.com/llvm/llvm-project/pull/89104
>From 4593582b2a480dfffd2dceb4611cc0dec9cd7de5 Mon Sep 17 00:00:00 2001
From: Krzysztof Parzyszek
Date: Thu, 11 Apr 2024 10:33:44 -0500
Subject: [PATCH 1/2] [LLVM][OpenMP] Implement getLeafOrCompositeConstructs
@@ -25,6 +25,43 @@ using namespace llvm::omp;
#define GEN_DIRECTIVES_IMPL
#include "llvm/Frontend/OpenMP/OMP.inc"
+static iterator_range::iterator>
+getFirstCompositeRange(iterator_range::iterator> Leafs) {
kparzysz wrote:
This is intended to be a general uti
https://github.com/skatrak edited
https://github.com/llvm/llvm-project/pull/82851
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -1452,10 +1454,14 @@ def MapInfoOp : OpenMP_Op<"map.info",
[AttrSizedOperandSegments]> {
- `var_type`: The type of the variable to copy.
- `var_ptr_ptr`: Used when the variable copied is a member of a class,
structure
or derived type and refers to the origina
@@ -1466,6 +1472,8 @@ def MapInfoOp : OpenMP_Op<"map.info",
[AttrSizedOperandSegments]> {
- 'map_capture_type': Capture type for the variable e.g. this, byref,
byvalue, byvla
this can affect how the variable is lowered.
- `name`: Holds the name of variable as s
https://github.com/skatrak approved this pull request.
This LGTM, I just have some small nits. Thanks Andrew!
https://github.com/llvm/llvm-project/pull/82851
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org
@@ -990,6 +990,77 @@ static void printMapClause(OpAsmPrinter &p, Operation *op,
}
}
+static ParseResult parseMembersIndex(OpAsmParser &parser,
+ DenseIntElementsAttr &membersIdx) {
+ SmallVector values;
+ int64_t value;
+ int64_t shape[
https://github.com/skatrak edited
https://github.com/llvm/llvm-project/pull/82851
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -1452,10 +1454,14 @@ def MapInfoOp : OpenMP_Op<"map.info",
[AttrSizedOperandSegments]> {
- `var_type`: The type of the variable to copy.
- `var_ptr_ptr`: Used when the variable copied is a member of a class,
structure
or derived type and refers to the origina
https://github.com/fhahn reopened
https://github.com/llvm/llvm-project/pull/88039
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/fhahn closed https://github.com/llvm/llvm-project/pull/88039
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -2028,41 +2029,61 @@ MemoryDepChecker::Dependence::DepType
MemoryDepChecker::isDependent(
if (std::holds_alternative(Res))
return std::get(Res);
- const auto &[Dist, Stride, TypeByteSize, AIsWrite, BIsWrite] =
+ const auto &[Dist, StrideA, StrideB, TypeByteSize, AI
@@ -2071,34 +2092,51 @@ MemoryDepChecker::Dependence::DepType
MemoryDepChecker::isDependent(
// NOTE: There is no need to update MaxSafeVectorWidthInBits after call to
// couldPreventStoreLoadForward, even if it changed MinDepDistBytes, since
a
// forward dependen
@@ -2028,41 +2029,61 @@ MemoryDepChecker::Dependence::DepType
MemoryDepChecker::isDependent(
if (std::holds_alternative(Res))
return std::get(Res);
- const auto &[Dist, Stride, TypeByteSize, AIsWrite, BIsWrite] =
+ const auto &[Dist, StrideA, StrideB, TypeByteSize, AI
@@ -25,6 +25,43 @@ using namespace llvm::omp;
#define GEN_DIRECTIVES_IMPL
#include "llvm/Frontend/OpenMP/OMP.inc"
+static iterator_range::iterator>
+getFirstCompositeRange(iterator_range::iterator> Leafs) {
skatrak wrote:
My understanding is that there can on
https://github.com/skatrak edited
https://github.com/llvm/llvm-project/pull/89104
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/skatrak commented:
Thank you Krzysztof for working on this. I have a suggestion to simplify the
implementation quite a bit, but let me know if you have issues with it.
https://github.com/llvm/llvm-project/pull/89104
___
llvm-branch-
https://github.com/skatrak approved this pull request.
LGTM, just small comments. Thanks!
https://github.com/llvm/llvm-project/pull/87258
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
@@ -37,3 +37,29 @@ TEST(Composition, GetCompoundConstruct) {
Directive C6 = getCompoundConstruct({OMPD_parallel_for, OMPD_simd});
ASSERT_EQ(C6, OMPD_parallel_for_simd);
}
+
+TEST(Composition, IsLeafConstruct) {
+ ASSERT_TRUE(isLeafConstruct(OMPD_loop));
+ ASSERT_TRUE(isLe
@@ -37,3 +37,29 @@ TEST(Composition, GetCompoundConstruct) {
Directive C6 = getCompoundConstruct({OMPD_parallel_for, OMPD_simd});
ASSERT_EQ(C6, OMPD_parallel_for_simd);
}
+
+TEST(Composition, IsLeafConstruct) {
+ ASSERT_TRUE(isLeafConstruct(OMPD_loop));
+ ASSERT_TRUE(isLe
https://github.com/skatrak edited
https://github.com/llvm/llvm-project/pull/87258
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/Meinersbur approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/89214
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/arsenm milestoned
https://github.com/llvm/llvm-project/pull/89240
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
Author: martinboehme
Date: 2024-04-22T09:35:06+02:00
New Revision: b0456501b10a3a83e6e6818a050f3fd691972d79
URL:
https://github.com/llvm/llvm-project/commit/b0456501b10a3a83e6e6818a050f3fd691972d79
DIFF:
https://github.com/llvm/llvm-project/commit/b0456501b10a3a83e6e6818a050f3fd691972d79.diff
63 matches
Mail list logo
