[lldb-dev] "devirtualizing" files in the VFS

2018-11-15 Thread Sam McCall via lldb-dev
I'd like to get some more perspectives on the role of the VirtualFileSystem abstraction in llvm/Support. (The VFS layer has recently moved from Clang to LLVM, so crossposting to both lists) https://reviews.llvm.org/D54277 proposed adding a function to VirtualFileSystem to get the underlying "real

Re: [lldb-dev] "devirtualizing" files in the VFS

2018-11-15 Thread Jonas Devlieghere via lldb-dev
HI Sam, Thanks again for taking the time to discuss this. > On Nov 15, 2018, at 3:02 AM, Sam McCall wrote: > > I'd like to get some more perspectives on the role of the VirtualFileSystem > abstraction in llvm/Support. > (The VFS layer has recently moved from Clang to LLVM, so crossposting to

Re: [lldb-dev] [cfe-dev] "devirtualizing" files in the VFS

2018-11-15 Thread Jonas Devlieghere via lldb-dev
> On Nov 15, 2018, at 3:34 AM, Whisperity wrote: > > I am really not sure if adding real file system functionality strictly into > the VFS is a good approach. This "ExternalFileSystem" thing sounds weird to > me. The `ExternalFileSystem` was an attempt to provide a more limited interface wh

Re: [lldb-dev] [CMake] LLDB framework / shared library

2018-11-15 Thread Stefan Gränitz via lldb-dev
Hi Alex, hi Pavel Thanks for your feedback and sorry for the late reply, I was a little busy on the other sites. Ok, so making the LLDB_FRAMEWORK_INSTALL_DIR vs. LLDB_FRAMEWORK_BUILD_DIR distinction and changing the approach for tools from symlink to copy sound like good tasks to start with.