Re: [lldb-dev] SB API questions

2021-05-30 Thread Raphael “Teemperor” Isemann via lldb-dev
Thanks! In the spirit of not letting users fix our bugs, I just made a draft patch for the logging enable/disable: https://reviews.llvm.org/D103376 I don't think landing code is much of a burden, but I think you can just re-request commit access if you had it before. Cheers, - Raphael > On 30

Re: [lldb-dev] SB API questions

2021-05-30 Thread Bruce Mitchener via lldb-dev
\On Sat, May 29, 2021 at 10:57 PM Raphael Isemann wrote: > And I think the best way to propose a new API is maybe just making a > dummy patch that adds the API + documentation (doesn't need an actual > implementation or tests). And if everyone agrees the new API is fine > you can add the tests an

Re: [lldb-dev] SB API questions

2021-05-29 Thread Raphael Isemann via lldb-dev
I think patches are always welcome and I don't see any problems with the proposed new API (haven't really checked though if they are all unavailable* through the SB API). The only downside to extending the SB API is that we have to maintain it forever. So if we add an API then it should be abstract