I think it's a nice improvement.
Passing the options around via the argparse results (as I do in many
programs) makes it easier to unit test, but having configuration variables
all in a module makes it really simple to find and use everywhere without
having them as globals.
Thanks for cleaning th
Sounds good, looks good then.
> On Dec 8, 2015, at 11:09 AM, Zachary Turner wrote:
>
> One advantage of this approach is that it makes the options available to the
> entire test suite. Even if we have no transferring going on, and we get
> argparse to return us a perfectly organized structure
One advantage of this approach is that it makes the options available to
the entire test suite. Even if we have no transferring going on, and we
get argparse to return us a perfectly organized structure with everything
in the right format, in order to make all the options accessible to the
rest of
There's no way to avoid doing a transfer out of the options dictionary at
some level, because it's not a straight transfer. There's a ton of
post-processing that gets done on the options dictionary in order to
convert the raw options into a useful format.
That might be solvable with more advanced
Do we not want to have an "options" global variable in this module that
contains everything instead of having separate global variables in this file?
The idea would be that you could assign directly when parsing arguments:
(configuration.options, args) = parser.parse_args(sys.argv[1:])
Its OK i
Hi Greg,
Take a look at dotest.py next time you get some free time and let me know
what you think. There should be no more globals. Everything that used to
be a global is now stored in its own module `configuration.py`, and
everything in `configuration.py` can be referenced from everywhere in th
I have updated the list of command line options with a proposed action. It
looks like exactly half of the command line options can be deleted, which
is going to be a huge win for being able to understand what the test suite
does and how to use it effectively. Please take a look at the updated
spr
Yeah that would be awesome, and also would be a lot of work. Good luck!
On Fri, Nov 20, 2015 at 10:37 AM, Zachary Turner via lldb-dev <
lldb-dev@lists.llvm.org> wrote:
> Seems reasonable. I will make a best effort to get as many of them as I
> can.
>
> On Fri, Nov 20, 2015 at 10:34 AM Greg Cla
Seems reasonable. I will make a best effort to get as many of them as I
can.
On Fri, Nov 20, 2015 at 10:34 AM Greg Clayton wrote:
> Zach, I would also like to get rid of all global variables in the process
> of this change. The history goes like this: a long time ago someone wrote
> the initial
Zach, I would also like to get rid of all global variables in the process of
this change. The history goes like this: a long time ago someone wrote the
initial dotest.py and parsed the options manually and stored results in global
variables. Later, someone converted the options over to use a pyt
We're reviewing these. I've added the ones that I use or need for
infrastructure. I've pinged everyone else internally and we'll be sure to
update any others over today and tomorrow.
-Todd
On Wed, Nov 18, 2015 at 2:32 PM, Zachary Turner via lldb-dev <
lldb-dev@lists.llvm.org> wrote:
> I would
11 matches
Mail list logo
