Re: [lldb-dev] small Editline wrapper cleanup req for feedback

2021-05-05 Thread Neal Sidhwaney via lldb-dev
Sounds great. It’ll be useful to combine the function to describe EditLine commands, help text, and their callbacks with the logic to register keyboard commands for them, as well, so I’ll do both. However, I couldn’t make the member function pointer a function argument, because then the lamb

Re: [lldb-dev] small Editline wrapper cleanup req for feedback

2021-05-04 Thread Greg Clayton via lldb-dev
As long as the solution matches "EditLine *" (C struct type from edit line library) to back to the C++ instance of "Editline" (lower case ell in "line" from LLDB). It should be easy to do with a template. I am fine with any new solution that makes it easier to add new commands. I would rather h

[lldb-dev] small Editline wrapper cleanup req for feedback

2021-04-30 Thread Neal Sidhwaney via lldb-dev
Some comments in https://reviews.llvm.org/rGfd89af6880f33ead708abe2f7d88ecb687d4e0d2 prompted me to look more into potential simplifications of our EditLine wrapper and I wanted to run this by anyone who is interested before