Re: [lldb-dev] Ubuntu version-based fail/skip

2016-01-28 Thread Zachary Turner via lldb-dev
I'd prefer to avoid calling the unittest2 functions. We already do that in a couple places, but if we could centralize on one place where we call unittest2 decorators it would really make it easier to customize our own decorators. For example, I have a short-term goal of adding an option to dotes

Re: [lldb-dev] Ubuntu version-based fail/skip

2016-01-28 Thread Todd Fiala via lldb-dev
That could be a reasonable way to do it. Now that I think about it, unittest2 already gives us a generic skip where we can put the logic in that we want. Not sure why that didn't occur to me earlier as I've done that very thing in the past. (I think I've conditioned myself to use our custom decor

Re: [lldb-dev] Ubuntu version-based fail/skip

2016-01-25 Thread Tamas Berghammer via lldb-dev
I think recently we are trying to reduce the number of decorators we are having so adding a few new Ubuntu specific decorators might not be a good idea. My suggestion would be to move on a little bit to the functional programming style with adding a new option to @expetedFailureAll where we can spe

[lldb-dev] Ubuntu version-based fail/skip

2016-01-22 Thread Todd Fiala via lldb-dev
Hey all, What do you think about having some kind of way of marking the (in this case, specifically) Ubuntu distribution for fail/skip test decorators? I've had a few cases where I've needed to mark tests failing on for Ubuntu where it really was only a particular release of an Ubuntu distribution