On 2017-02-22 18:50, Greg Clayton via lldb-dev wrote:
On Feb 21, 2017, at 5:08 PM, Jim Ingham mailto:jing...@apple.com>> wrote:
On Feb 21, 2017, at 4:49 PM, Jim Ingham via lldb-dev
mailto:lldb-dev@lists.llvm.org>> wrote:
On Feb 21, 2017, at 4:24 PM, Greg Clayton via lldb-dev
mailto:lldb-
> On Feb 21, 2017, at 5:08 PM, Jim Ingham wrote:
>
>>
>> On Feb 21, 2017, at 4:49 PM, Jim Ingham via lldb-dev
>> wrote:
>>
>>
>>> On Feb 21, 2017, at 4:24 PM, Greg Clayton via lldb-dev
>>> wrote:
>>>
- StepOverBreakpointTestCase: Have the test not store the breakpoints
in the t
Thank you for the feedback. I'll look into how to get the expressions
cleared when the breakpoint locations get unresolved. I can also
switch the breakpoints to a weak_ptr if you think that is worthwhile,
but one of the two fixes is enough for me at the moment.
regards,
pavel
On 22 February 2017
> On Feb 21, 2017, at 4:49 PM, Jim Ingham via lldb-dev
> wrote:
>
>
>> On Feb 21, 2017, at 4:24 PM, Greg Clayton via lldb-dev
>> wrote:
>>
>>> - StepOverBreakpointTestCase: Have the test not store the breakpoints
>>> in the test case object. Basically, declare that this is not a bug,
>>> an
> On Feb 21, 2017, at 4:24 PM, Greg Clayton via lldb-dev
> wrote:
>
>> - StepOverBreakpointTestCase: Have the test not store the breakpoints
>> in the test case object. Basically, declare that this is not a bug,
>> and it's the users responsibility to clean up necessary objects.
>
> It would b
> On Feb 21, 2017, at 4:26 PM, Greg Clayton wrote:
>
>>
>> On Feb 21, 2017, at 9:36 AM, Jim Ingham via lldb-dev
>> wrote:
>>
>> Thanks for digging into this.
>>
>> Maybe a better option would be to have IRExecutionUnit hold a
>> SymbolContextScope, rather than a SymbolContext. We started
On Tue, Feb 21, 2017 at 4:24 PM Greg Clayton via lldb-dev <
lldb-dev@lists.llvm.org> wrote:
> On Feb 21, 2017, at 9:10 AM, Zachary Turner via lldb-dev <
> lldb-dev@lists.llvm.org> wrote:
>
> No comments on this specifically, but +1 to reducing shared_ptr usage in
> general. We use way too many, an
> On Feb 21, 2017, at 9:36 AM, Jim Ingham via lldb-dev
> wrote:
>
> Thanks for digging into this.
>
> Maybe a better option would be to have IRExecutionUnit hold a
> SymbolContextScope, rather than a SymbolContext. We started out with
> SymbolContext's because they were convenient but they
> On Feb 21, 2017, at 9:10 AM, Zachary Turner via lldb-dev
> wrote:
>
> No comments on this specifically, but +1 to reducing shared_ptr usage in
> general. We use way too many, and often it feels like shared_ptr is used as a
> way to avoid having to think about ownership, which leads to more
Thanks for digging into this.
Maybe a better option would be to have IRExecutionUnit hold a
SymbolContextScope, rather than a SymbolContext. We started out with
SymbolContext's because they were convenient but they hold too many things
alive so when we run into SymbolContext's we've been conve
No comments on this specifically, but +1 to reducing shared_ptr usage in
general. We use way too many, and often it feels like shared_ptr is used as
a way to avoid having to think about ownership, which leads to more
problems than it solves imo
On Tue, Feb 21, 2017 at 9:03 AM Pavel Labath via lldb-
Hello all,
I've been debugging the newly added TestStepOverBreakpoint.py, which
has been failing on windows, for a very prosaic reason: after the test
completes, we are unable to run "make clean" because lldb still holds
the file open.
After some debugging, I've found that this happens because th
12 matches
Mail list logo