Re: [lldb-dev] RFC: Processor Trace Support in LLDB

2020-10-02 Thread Greg Clayton via lldb-dev
> On Oct 2, 2020, at 3:51 AM, Pavel Labath wrote: > > On 01/10/2020 22:32, Walter wrote: >> After a chat with Greg, we agreed on this set of commands >> >> >> trace load /path/to/json process trace start/stop process trace save >> /path/to/json thread trace start/stop thread trace dump [instr

Re: [lldb-dev] RFC: Processor Trace Support in LLDB

2020-10-02 Thread Pavel Labath via lldb-dev
On 01/10/2020 22:32, Walter wrote: > After a chat with Greg, we agreed on this set of commands > > > trace load /path/to/json process trace start/stop process trace save > /path/to/json thread trace start/stop thread trace dump [instructions | > functions] > Thanks. The new commands look good t

Re: [lldb-dev] RFC: Processor Trace Support in LLDB

2020-10-01 Thread Greg Clayton via lldb-dev
I had accepted the patch https://reviews.llvm.org/D86670 , but then marked as "Request Changes" while we discuss the commands in this RFC after new comments came in. > On Oct 1, 2020, at 1:42 PM, Greg Clayton wrote: > > We spoke a bit after Panel's comments wh

Re: [lldb-dev] RFC: Processor Trace Support in LLDB

2020-10-01 Thread Greg Clayton via lldb-dev
We spoke a bit after Panel's comments which made sense and we propose the commands Walter sent below. Let us know what everyone thinks of this organization of the command structure! > On Oct 1, 2020, at 1:32 PM, Walter wrote: > > After a chat with Greg, we agreed on this set of commands > >

Re: [lldb-dev] RFC: Processor Trace Support in LLDB

2020-10-01 Thread Walter via lldb-dev
After a chat with Greg, we agreed on this set of commands trace load /path/to/json process trace start/stop process trace save /path/to/json thread trace start/stop thread trace dump [instructions | functions] Il giorno gio 1 ott 2020 alle ore 13:21 Greg Clayton ha scritto: > > > > On Oct 1, 2

Re: [lldb-dev] RFC: Processor Trace Support in LLDB

2020-10-01 Thread Greg Clayton via lldb-dev
> On Oct 1, 2020, at 7:08 AM, Pavel Labath via lldb-dev > wrote: > > Thank you for writing this Walter. I think this document will be a > useful reference both now and in the future. > > The part that's not clear to me is what is the story with multi-process > traces. The file format enables

Re: [lldb-dev] RFC: Processor Trace Support in LLDB

2020-10-01 Thread Walter via lldb-dev
Hi Pavel, thanks for the comments. I'll reply inline > The part that's not clear to me is what is the story with multi-process traces. The file format enables those, but it's not clear how are they going be created or used. Can you elaborate more on what you intend to use those for? Something we

Re: [lldb-dev] RFC: Processor Trace Support in LLDB

2020-10-01 Thread Pavel Labath via lldb-dev
Thank you for writing this Walter. I think this document will be a useful reference both now and in the future. The part that's not clear to me is what is the story with multi-process traces. The file format enables those, but it's not clear how are they going be created or used. Can you elaborate

Re: [lldb-dev] RFC: Processor Trace Support in LLDB

2020-09-21 Thread Walter via lldb-dev
Thanks for your feedback Fangrui, I've just been checking Capn' Proto and it looks really good. I'll keep it in mind in the design and see how it can optimize the overall data transfer. - Walter Il giorno dom 20 set 2020 alle ore 11:24 Fangrui Song ha scritto: > On 2020-09-18, Eric Christopher

Re: [lldb-dev] RFC: Processor Trace Support in LLDB

2020-09-21 Thread Walter via lldb-dev
Hi Eric, thanks for the feedback > Something I think would be good would be to compare/contrast against rr as an "exploring alternatives" section of the document. I'll include that. I've done some comparative research on rr and I think I can provide valuable input. > I think the document should a

Re: [lldb-dev] RFC: Processor Trace Support in LLDB

2020-09-20 Thread Fangrui Song via lldb-dev
On 2020-09-18, Eric Christopher via lldb-dev wrote: Hi Walter, I've only done a brief scan of the document but, in general, I'm favorable of the goals, aim, and approach. Something I think would be good would be to compare/contrast against rr as an "exploring alternatives" section of the documen

Re: [lldb-dev] RFC: Processor Trace Support in LLDB

2020-09-18 Thread Eric Christopher via lldb-dev
Hi Walter, I've only done a brief scan of the document but, in general, I'm favorable of the goals, aim, and approach. Something I think would be good would be to compare/contrast against rr as an "exploring alternatives" section of the document. I think the document should also be made available/

Re: [lldb-dev] RFC: Processor Trace Support in LLDB

2020-09-18 Thread Walter via lldb-dev
Thanks for your comments, I'll reply here: > Is it possible to decode a small portion of an Intel PT trace file quickly, say, in a few milliseconds? This would be useful if tracing were done in ringbuffer mode, or if the event the user is interested in debugging (along with its relevant execution

Re: [lldb-dev] RFC: Processor Trace Support in LLDB

2020-09-18 Thread Vedant Kumar via lldb-dev
Hi Walter & Greg, Thanks for sharing this RFC, and for your work in this area. > On Sep 17, 2020, at 5:28 PM, Walter via lldb-dev > wrote: > > Hi all, > > Here I propose, along with Greg Clayton, Processor Trace support for LLDB. > I’m attaching a link to the document that contains this pro

[lldb-dev] RFC: Processor Trace Support in LLDB

2020-09-17 Thread Walter via lldb-dev
Hi all, Here I propose, along with Greg Clayton, Processor Trace support for LLDB. I’m attaching a link to the document that contains this proposal if that’s easier to read for you: https://docs.google.com/document/d/1cOVTGp1sL_HBXjP9eB7qjVtDNr5xnuZvUUtv43G5eVI/edit#heading=h.t5mblb9ugv8f