Re: [lldb-dev] Psuedo terminal on Windows

2016-09-12 Thread Carlo Kok via lldb-dev
On 2016-09-12 16:39, Zachary Turner wrote: Ahh that explains why I didn't notice it. Is the fix straightforward? Sort of. it works if i (locally) do return 0, but that's doesn't seem to be the right thing to do. The common thing to do on Windows is to let the program create a new window (

Re: [lldb-dev] Psuedo terminal on Windows

2016-09-12 Thread Zachary Turner via lldb-dev
Ahh that explains why I didn't notice it. Is the fix straightforward? On Mon, Sep 12, 2016 at 1:31 AM Carlo Kok via lldb-dev < lldb-dev@lists.llvm.org> wrote: > > > On 2016-09-12 10:06, Carlo Kok via lldb-dev wrote: > > Hi, > > > > ProcessLaunchInfo seems to, unconditionally create a pseudo termin

Re: [lldb-dev] Psuedo terminal on Windows

2016-09-12 Thread Carlo Kok via lldb-dev
On 2016-09-12 10:06, Carlo Kok via lldb-dev wrote: Hi, ProcessLaunchInfo seems to, unconditionally create a pseudo terminal if there's nothing attached to the stdout/stderr. This seems to end up calling posix_openpt, which is defined as: inline int posix_openpt(int flag) { LLVM_BUILTIN_UNREAC

[lldb-dev] Psuedo terminal on Windows

2016-09-12 Thread Carlo Kok via lldb-dev
Hi, ProcessLaunchInfo seems to, unconditionally create a pseudo terminal if there's nothing attached to the stdout/stderr. This seems to end up calling posix_openpt, which is defined as: inline int posix_openpt(int flag) { LLVM_BUILTIN_UNREACHABLE; } for Windows. This was fine a while ago s