Re: [lldb-dev] LLDB REFORMATTING IN PROGRESS

On Thu, Sep 8, 2016, at 11:14 AM, Pavel Labath via lldb-dev wrote: > The clang format webpage > recommends the following (I haven't tried it, but it sounds like it > should work): > svn diff --diff-cmd=diff -x -U0 | clang-format-diff.py -i > > I also e

Re: [lldb-dev] LLDB REFORMATTING IN PROGRESS

The clang format webpage recommends the following (I haven't tried it, but it sounds like it should work): svn diff --diff-cmd=diff -x -U0 | clang-format-diff.py -i I also expected that running clang-format on the current tree would be a no-op, but act

Re: [lldb-dev] LLDB REFORMATTING IN PROGRESS

But what about SVN users? :) Okay, I know format can be applied for modified fragments only. But why did we leave some places unformatted? I thought "clang-format -i `find include source tools -name '*.[cpp|h]'`" ends with empty diff. On Thu, Sep 8, 2016 at 10:19 AM, Zachary Turner wrote: > In o

Re: [lldb-dev] LLDB REFORMATTING IN PROGRESS

In order to clang-format only the diff, you should use the "git clang-format" extension command. Search for git-clang-format (yes, that one has an extra dash), and there should be instructions inside On Thu, Sep 8, 2016 at 12:16 AM Ilia K wrote: > Hi! > > clang-formatting of my patch changed the

Re: [lldb-dev] LLDB REFORMATTING IN PROGRESS

Hi! clang-formatting of my patch changed the style outside the patch (diff: https://reviews.llvm.org/D24331?vs=70653&id=70654). Am I doing something wrong? On Wed, Sep 7, 2016 at 1:06 PM, Pavel Labath via lldb-dev < lldb-dev@lists.llvm.org> wrote: > Windows unit tests passing now. All clear. > >

Re: [lldb-dev] LLDB REFORMATTING IN PROGRESS

Windows unit tests passing now. All clear. On 7 September 2016 at 09:54, Pavel Labath wrote: > I am still seeing errors when building windows unittests. I'll have a > change for fixing that soon. Apart from that everything else looks > good on our side. I'll send an all clear once the unit tests

Re: [lldb-dev] LLDB REFORMATTING IN PROGRESS

On 6 September 2016 at 22:21, Zachary Turner via lldb-dev wrote: > I think it goes without saying, but henceforth, no changes should be landed > without first passing them through clang-format. Personally, I will be > reverting any I see that don't conform. But I can't promise to catch all of >

Re: [lldb-dev] LLDB REFORMATTING IN PROGRESS

I am still seeing errors when building windows unittests. I'll have a change for fixing that soon. Apart from that everything else looks good on our side. I'll send an all clear once the unit tests get green on windows. pl On 6 September 2016 at 23:26, Zachary Turner via lldb-dev wrote: > I thin

Re: [lldb-dev] LLDB REFORMATTING IN PROGRESS

I think Windows is good. On Tue, Sep 6, 2016 at 3:10 PM Zachary Turner wrote: > Everything compiles on Windows now but all the tests are failing with > ERROR. I'm looking into this now. > > On Tue, Sep 6, 2016 at 2:26 PM Ed Maste via lldb-dev < > lldb-dev@lists.llvm.org> wrote: > > On 6 Septemb

Re: [lldb-dev] LLDB REFORMATTING IN PROGRESS

Everything compiles on Windows now but all the tests are failing with ERROR. I'm looking into this now. On Tue, Sep 6, 2016 at 2:26 PM Ed Maste via lldb-dev < lldb-dev@lists.llvm.org> wrote: > On 6 September 2016 at 17:17, Kate Stone via lldb-dev > wrote: > > The storm of commit messages might

Re: [lldb-dev] LLDB REFORMATTING IN PROGRESS

On 6 September 2016 at 17:17, Kate Stone via lldb-dev wrote: > The storm of commit messages might be a subtle clue, but here it is > officially: the reformatting is complete and I’ve verified that no tests > regressed locally in our macOS suite. Please begin any validation process > you’ve signed

Re: [lldb-dev] LLDB REFORMATTING IN PROGRESS

I think it goes without saying, but henceforth, no changes should be landed without first passing them through clang-format. Personally, I will be reverting any I see that don't conform. But I can't promise to catch all of them. On Tue, Sep 6, 2016 at 2:17 PM Kate Stone via lldb-dev < lldb-dev@l

Re: [lldb-dev] LLDB REFORMATTING IN PROGRESS

The storm of commit messages might be a subtle clue, but here it is officially: the reformatting is complete and I’ve verified that no tests regressed locally in our macOS suite. Please begin any validation process you’ve signed up for on another platform, and if changes are necessary go ahead

[lldb-dev] LLDB REFORMATTING IN PROGRESS

As has been discussed over the past few weeks the reformatting of the LLDB code base will take place shortly, followed by validation before committing these changes. Please suspend all commit activity. Any intervening commits will be reverted until the all-clear is given. Kate Stone k8st...@a