Re: [lldb-dev] LLDB Evolution: Next Phase

2016-09-06 Thread Kate Stone via lldb-dev
This has been in the works long enough to get plans together. If the current state of a bot suggests that manual validation is required then that’s what I’d recommend. That’s the unfortunate current state of affairs with the Green Dragon bots, for example. Kate Stone k8st...@apple.com

Re: [lldb-dev] LLDB Evolution: Next Phase

2016-09-06 Thread Zachary Turner via lldb-dev
Yea it's only clang bots i think On Tue, Sep 6, 2016 at 6:30 AM Pavel Labath via lldb-dev < lldb-dev@lists.llvm.org> wrote: > Wow, I had no idea things were that bad. LLDB buildbots do not seem to > be affected though, so I think we should proceed. > > pl > > > > On 6 September 2016 at 14:09, Ed M

Re: [lldb-dev] LLDB Evolution: Next Phase

2016-09-06 Thread Pavel Labath via lldb-dev
Wow, I had no idea things were that bad. LLDB buildbots do not seem to be affected though, so I think we should proceed. pl On 6 September 2016 at 14:09, Ed Maste wrote: > On 6 September 2016 at 08:51, Pavel Labath wrote: >> Hi Ed, >> >> which bots are you referring to? Our bots were red over

Re: [lldb-dev] LLDB Evolution: Next Phase

2016-09-06 Thread Ed Maste via lldb-dev
On 6 September 2016 at 08:51, Pavel Labath wrote: > Hi Ed, > > which bots are you referring to? Our bots were red overnight, but > we've been cleaning them up now, and they should get green shortly. As > far as we're concerned, the reformat can go on as planned. The "Buildbot General Failure - Pr

Re: [lldb-dev] LLDB Evolution: Next Phase

2016-09-06 Thread Pavel Labath via lldb-dev
Hi Ed, which bots are you referring to? Our bots were red overnight, but we've been cleaning them up now, and they should get green shortly. As far as we're concerned, the reformat can go on as planned. pl On 6 September 2016 at 13:06, Ed Maste via lldb-dev wrote: > On 3 September 2016 at 00:30

Re: [lldb-dev] LLDB Evolution: Next Phase

2016-09-06 Thread Ed Maste via lldb-dev
On 3 September 2016 at 00:30, Kate Stone via lldb-dev wrote: > As a reminder, any pending commits you might have planned for LLDB this > weekend must not break any of the bots we’re using to validate the health of > the source tree. Given the current non-functional state of the bots, what is the

Re: [lldb-dev] LLDB Evolution: Next Phase

2016-09-02 Thread Kate Stone via lldb-dev
As a reminder, any pending commits you might have planned for LLDB this weekend must not break any of the bots we’re using to validate the health of the source tree. Thanks to everyone who nominated a validation process for the pending reformatting. We’ll assume that each of these validation e

Re: [lldb-dev] LLDB Evolution: Next Phase

2016-08-24 Thread Pavel Labath via lldb-dev
Sounds like a good idea. After the reformat, we can try it out and see if it works well enough (I don't know how smart that thing is, but I can imagine it could end up quite confused by all the line breaking that clang-format will do). If it works, I will definitely use it. pl On 23 August 2016 a

Re: [lldb-dev] LLDB Evolution: Next Phase

2016-08-23 Thread Zachary Turner via lldb-dev
Pretty much, yea. On Tue, Aug 23, 2016 at 12:24 PM Ed Maste wrote: > On 23 August 2016 at 11:55, Zachary Turner wrote: > > > > Should we consider adding git hyper-blame to llvm and recommending its > usage? > > Nifty, I hadn't encountered git hyper-blame before. Thanks Zach. > > If I understand

Re: [lldb-dev] LLDB Evolution: Next Phase

2016-08-23 Thread Ed Maste via lldb-dev
On 23 August 2016 at 11:55, Zachary Turner wrote: > > Should we consider adding git hyper-blame to llvm and recommending its usage? Nifty, I hadn't encountered git hyper-blame before. Thanks Zach. If I understand correctly all we need to do is add a `.git-blame-ignore-revs` file to the lldb root

Re: [lldb-dev] LLDB Evolution: Next Phase

2016-08-23 Thread Zachary Turner via lldb-dev
Should we consider adding git hyper-blame to llvm and recommending its usage? https://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/git-hyper-blame.html On Tue, Aug 23, 2016 at 6:44 AM Ed Maste via lldb-dev < lldb-dev@lists.llvm.org> wrote: > On 19 August 2016 at 1

Re: [lldb-dev] LLDB Evolution: Next Phase

2016-08-23 Thread Ed Maste via lldb-dev
On 19 August 2016 at 17:10, Kate Stone via lldb-dev wrote: > > Sept 5th Trunk closes for commits while reformatting takes place and is > validated before re-opening trunk. This is fine with me. As for validation, from my perspective I want to make sure the FreeBSD build-only buildbot is green: h

Re: [lldb-dev] LLDB Evolution: Next Phase

2016-08-22 Thread Pavel Labath via lldb-dev
On 19 August 2016 at 22:10, Kate Stone via lldb-dev wrote: > Following up from yesterday, everything now builds and runs cleanly with the > configuration described below on macOS. I did have to make one set of minor > changes to preserve #include ordering, but that’s already committed to trunk >

[lldb-dev] LLDB Evolution: Next Phase

2016-08-19 Thread Kate Stone via lldb-dev
Following up from yesterday, everything now builds and runs cleanly with the configuration described below on macOS. I did have to make one set of minor changes to preserve #include ordering, but that’s already committed to trunk so there are no true blockers at this point. To keep pushing for