Re: [lldb-dev] [llvm-dev] [RFC] Deprecate email code reviews in favor of Phabricator

2021-05-04 Thread Krzysztof Parzyszek via lldb-dev
I'm opposed to separating the pre- and post-commit reviews. One of the goals of this proposal is to have the entire review history in one place, and using a combination of email and Phabricator would prevent that. If I want to find out why a commit has been reverted, I have to search the post-

Re: [lldb-dev] [llvm-dev] [RFC] Deprecate email code reviews in favor of Phabricator

2021-05-03 Thread Philip Reames via lldb-dev
In my view, this email is really too different topics.  Given that, my response is split into two parts. First, should we make phabricator our default for code review?  I am not opposed to this.  I don't particular support it either, but I would not spend time arguing against it.  I would sugg