Re: [lldb-dev] Patch to fix REPL for ARMv7 & ARMv6 on linux

2016-01-29 Thread William Dillon via lldb-dev
t; Omair, any thoughts on this? >> >> cheers, >> pl >> >> >> On 25 January 2016 at 18:55, Hans Wennborg wrote: >>> This patch looks reasonable to me, but I don't know enough about LLDB >>> to actually review it. >>> >>> +

Re: [lldb-dev] Patch to fix REPL for ARMv7 & ARMv6 on linux

2016-01-14 Thread William Dillon via lldb-dev
Hi again, everyone I’d like to ping on this patch now that the 3.8 branch is fairly new, and merging it over is fairly straight-forward. Thanks in advance for your comments! - Will > There is a small change that enables correct calculation of arm sub > architectures while using the REPL on a

[lldb-dev] Canonicalize armv6l and armv7l to v6 and v7

2016-01-08 Thread William Dillon via lldb-dev
Hi all, I have a small patch that fixes an issue that prevents use of the Swift REPL on arm-linux. When working with targets that the OS presents as armv7l, for example, there is an inconsistency when the architecture sub-type is parsed. Detecting this condition and removing the ‘l’ fixes it.

[lldb-dev] Patch to fix REPL for ARMv7 & ARMv6 on linux

2016-01-06 Thread William Dillon via lldb-dev
Hi All, There is a small change that enables correct calculation of arm sub architectures while using the REPL on arm-linux. As you may of may or may not know, linux appends ‘l’ to arm architecture versions to denote little endian. This sometimes interferes with the determination of the archi

Re: [lldb-dev] Patch for addressing format warnings on 32-bit

2015-12-28 Thread William Dillon via lldb-dev
ays, aren't they? If they're not but they should be, that seems like the > real underlying problem rather than needing to cast. > > What kind of warning are you seeing if you just replace the % format > specifier? > > Thanks! > > -Todd > > On Sun, Dec 27, 201

Re: [lldb-dev] Patch for addressing format warnings on 32-bit

2015-12-27 Thread William Dillon via lldb-dev
: text/plain; charset=utf-8 > > On Fri, Dec 25, 2015 at 06:34:09PM -0800, William Dillon via lldb-dev wrote: >> There are a handful of -Wformat warnings on 32-bit platforms. >> I addressed all those that I’ve seen while working on Swift. >> Let me know if the git diff format i

[lldb-dev] Patch for addressing format warnings on 32-bit

2015-12-25 Thread William Dillon via lldb-dev
There are a handful of -Wformat warnings on 32-bit platforms. I addressed all those that I’ve seen while working on Swift. Let me know if the git diff format is inappropriate for this. Cheers, - Will diff Description: Binary data ___ lldb-dev mail