Re: [lldb-dev] proposed change to remove conditional WCHAR support in libedit wrapper

l 2021 10:51:34 +0200, Neal Sidhwaney via lldb-dev wrote: >> Anyone else think this could be useful? Or, conversely, does anyone see >> something that I missed that requires the conditional compilation to remain >> in? > > Oldest platform Red Hat builds LLDB on is RHEL-7

[lldb-dev] proposed change to remove conditional WCHAR support in libedit wrapper

Hello, I was thinking of removing the conditional compilation to use libedit’s WCHAR support on non-Windows platforms. The conditional preprocessor logic is definitely the correct way to support both wide & narrow character APIs, but editline has enabled the wide API’s by default for some time

Re: [lldb-dev] small Editline wrapper cleanup req for feedback

gument if > possible. I am thinking of something like: > > createEditLineCommandDescriptor(“Command1", “Command1 help", &Foo::Foo1); > createEditLineCommandDescriptor(“Command2", “Command2 help", &Foo::Bar); > > as I find it more readable. > &

[lldb-dev] small Editline wrapper cleanup req for feedback

Some comments in https://reviews.llvm.org/rGfd89af6880f33ead708abe2f7d88ecb687d4e0d2 prompted me to look more into potential simplifications of our EditLine wrapper and I wanted to run this by anyone who is interested before

[lldb-dev] reviewer requested for D101250

Hello, I put together a small patch for the Editline wrapper in LLDB: https://reviews.llvm.org/D101250 It wraps some of the libedit calls in a helper function to provide type safety and remove casts that shouldn’t be needed, since the libedit functions take v