[lldb-dev] RFC: Break/Watchpoint Callback storage and validation

2016-09-29 Thread Daniel Austin Noland via lldb-dev
As per discussion in another thread (http://lists.llvm.org/pipermail/lldb-dev/2016-September/011397.html) I have started refactoring the private side of Break/Watchpoint. Mostly this involves fairly trivial and obvious changes and I expect the first patch to be ready fairly soon. Still, there a

Re: [lldb-dev] RFC: Break/Watchpoint refactor

2016-09-27 Thread Daniel Austin Noland via lldb-dev
On 09/27/2016 03:37 PM, Enrico Granata wrote: On Sep 27, 2016, at 1:09 PM, Daniel Austin Noland via lldb-dev mailto:lldb-dev@lists.llvm.org>> wrote: * Prefer explicitly deleted copy ctor / assignments over multiline macro DISALLOW_COPY_AND_ASSIGN Why not jus

Re: [lldb-dev] RFC: Break/Watchpoint refactor

2016-09-27 Thread Daniel Austin Noland via lldb-dev
On 09/27/2016 03:30 PM, Jim Ingham wrote: On Sep 27, 2016, at 1:09 PM, Daniel Austin Noland via lldb-dev wrote: I have been giving study to the private and public classes for break/watchpoints and I have some ideas for how to improve them. I am looking for comments from the community on

Re: [lldb-dev] RFC: Break/Watchpoint refactor

2016-09-27 Thread Daniel Austin Noland via lldb-dev
On 09/27/2016 03:23 PM, Zachary Turner wrote: On Tue, Sep 27, 2016 at 1:09 PM Daniel Austin Noland via lldb-dev mailto:lldb-dev@lists.llvm.org>> wrote: 4. All of these classes are "old school" (not necessarily bad, but potentially a problem). For example:

[lldb-dev] RFC: Break/Watchpoint refactor

2016-09-27 Thread Daniel Austin Noland via lldb-dev
I have been giving study to the private and public classes for break/watchpoints and I have some ideas for how to improve them. I am looking for comments from the community on this now to avoid wasted work and invite suggestion for improvements and any objections you may have. Some problems w